From patchwork Mon Jul 20 08:59:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prashant Laddha X-Patchwork-Id: 6825881 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id ADEC4C05AC for ; Mon, 20 Jul 2015 09:00:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DA48020650 for ; Mon, 20 Jul 2015 09:00:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E8232064E for ; Mon, 20 Jul 2015 09:00:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932361AbbGTJAD (ORCPT ); Mon, 20 Jul 2015 05:00:03 -0400 Received: from bgl-iport-2.cisco.com ([72.163.197.26]:17434 "EHLO bgl-iport-2.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932262AbbGTJAB (ORCPT ); Mon, 20 Jul 2015 05:00:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=874; q=dns/txt; s=iport; t=1437382800; x=1438592400; h=from:to:cc:subject:date:message-id; bh=8jnndPQU0xh/fFBTUJ4L83Stamm8mCKKq+ASzQmjPis=; b=CNCZTuS8OZu3i0bvs6Ufq3g/zf6QmsF9MAlwrpRvg0q3kaefDrdc6UJZ anh58FhaPfpyM68i61wXpc2xOiTI2OF+TX2qZFY8hgc7m4jwsDv4UATzo 2WBWfMGswagG3vjTmZhe6Gzc9FqfXYs0RePVDbQpRl71ttaDiiRsGPiGg s=; X-IronPort-AV: E=Sophos;i="5.15,507,1432598400"; d="scan'208";a="53551227" Received: from vla196-nat.cisco.com (HELO bgl-core-1.cisco.com) ([72.163.197.24]) by bgl-iport-2.cisco.com with ESMTP; 20 Jul 2015 08:59:58 +0000 Received: from pla-VB.cisco.com ([10.142.60.201]) by bgl-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id t6K8xwT4029665; Mon, 20 Jul 2015 08:59:58 GMT From: Prashant Laddha To: linux-media@vger.kernel.org Cc: Hans Verkuil , Prashant Laddha Subject: [PATCH] v4l2-ctl-modes: use reduced fps only with reduced blanking v2 Date: Mon, 20 Jul 2015 14:29:58 +0530 Message-Id: <1437382798-16061-1-git-send-email-prladdha@cisco.com> X-Mailer: git-send-email 1.9.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-15.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY, USER_IN_DEF_DKIM_WL autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In the absence of reduced blanking v2, the clock granularity is not sufficient enough to allow pixel clock reduction done by factor of 1000 / 1001 in case of reduced fps. Cc: Hans Verkuil Signed-off-by: Prashant Laddha --- utils/v4l2-ctl/v4l2-ctl-modes.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/v4l2-ctl/v4l2-ctl-modes.cpp b/utils/v4l2-ctl/v4l2-ctl-modes.cpp index e44b229..236f19f 100644 --- a/utils/v4l2-ctl/v4l2-ctl-modes.cpp +++ b/utils/v4l2-ctl/v4l2-ctl-modes.cpp @@ -336,7 +336,7 @@ bool calc_cvt_modeline(int image_width, int image_height, } else { cvt->polarities = V4L2_DV_VSYNC_POS_POL; } - if (reduced_fps && v_refresh % 6 == 0) + if (rb_v2 && reduced_fps && v_refresh % 6 == 0) cvt->flags |= V4L2_DV_FL_REDUCED_FPS; return true;