@@ -1932,11 +1932,15 @@ done:
}
/*
- * isp_create_pads_links - Pads links creation for the subdevices
+ * isp_create_links() - Create links for internal and external ISP entities
* @isp : Pointer to ISP device
- * return negative error code or zero on success
+ *
+ * This function creates all links between ISP internal and external entities.
+ *
+ * Return: A negative error code on failure or zero on success. Possible error
+ * codes are those returned by media_create_pad_link().
*/
-static int isp_create_pads_links(struct isp_device *isp)
+static int isp_create_links(struct isp_device *isp)
{
int ret;
@@ -2527,7 +2531,7 @@ static int isp_probe(struct platform_device *pdev)
if (ret < 0)
goto error_modules;
- ret = isp_create_pads_links(isp);
+ ret = isp_create_links(isp);
if (ret < 0)
goto error_register_entities;
The function that creates the links between ISP internal and external entities is called isp_create_pads_links() but the "pads" prefix is redundant since the driver doesn't handle any other kind of link so it can just be removed. While being there, fix the function's kernel-doc since is not using a proper format. Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- This patch addresses 2 remaining issues Laurent pointed in patch [0]: 1- Rename isp_create_pads_links() to isp_create_links(). 2- Fix kernel-doc for the same function. [0]: https://patchwork.linuxtv.org/patch/31147/ drivers/media/platform/omap3isp/isp.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)