From patchwork Fri Jan 8 22:02:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Baptiste Theou X-Patchwork-Id: 7990661 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 357659F38D for ; Fri, 8 Jan 2016 22:02:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7876E201EC for ; Fri, 8 Jan 2016 22:02:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AFE66201C8 for ; Fri, 8 Jan 2016 22:02:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754952AbcAHWCf (ORCPT ); Fri, 8 Jan 2016 17:02:35 -0500 Received: from vpndallas.adeneo-embedded.us ([162.254.209.190]:29319 "EHLO mxadeneo.adeneo-embedded.us" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752918AbcAHWCe (ORCPT ); Fri, 8 Jan 2016 17:02:34 -0500 Received: from jtheou.adeneo-embedded.us (172.16.20.221) by mxadeneo.adeneo-embedded.us (10.0.4.191) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 8 Jan 2016 14:02:23 -0800 From: Jean-Baptiste Theou To: CC: Jean-Baptiste Theou Subject: [PATCH v2] [media] cx231xx: Fix memory leak Date: Fri, 8 Jan 2016 14:02:03 -0800 Message-ID: <1452290523-28053-1-git-send-email-jtheou@adeneo-embedded.us> X-Mailer: git-send-email 2.6.4 In-Reply-To: <1452287450-17623-1-git-send-email-jtheou@adeneo-embedded.us> References: <1452287450-17623-1-git-send-email-jtheou@adeneo-embedded.us> MIME-Version: 1.0 X-Originating-IP: [172.16.20.221] Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP dma_area needs to be freed when the device is closed. Based on em23xx-audio.c Signed-off-by: Jean-Baptiste Theou --- Changes in v2: - Fix debug trace call --- drivers/media/usb/cx231xx/cx231xx-audio.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-audio.c b/drivers/media/usb/cx231xx/cx231xx-audio.c index de4ae5e..a6a9508 100644 --- a/drivers/media/usb/cx231xx/cx231xx-audio.c +++ b/drivers/media/usb/cx231xx/cx231xx-audio.c @@ -499,6 +499,11 @@ static int snd_cx231xx_pcm_close(struct snd_pcm_substream *substream) } dev->adev.users--; + if (substream->runtime->dma_area) { + dev_dbg(dev->dev, "freeing\n"); + vfree(substream->runtime->dma_area); + substream->runtime->dma_area = NULL; + } mutex_unlock(&dev->lock); if (dev->adev.users == 0 && dev->adev.shutdown == 1) {