Message ID | 1456602156-25011-1-git-send-email-Becher.Jannik@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Sat, 27 Feb 2016 20:42:36 +0100 Jannik Becher <becher.jannik@gmail.com> wrote: > Fixed a coding style issue. > You should be more specific: which style issue? See also my comment below. > Signed-off-by: Jannik Becher <Becher.Jannik@gmail.com> > --- > drivers/media/usb/hackrf/hackrf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c > index 9e700ca..186ef2d 100644 > --- a/drivers/media/usb/hackrf/hackrf.c > +++ b/drivers/media/usb/hackrf/hackrf.c > @@ -249,6 +249,7 @@ static int hackrf_set_params(struct hackrf_dev *dev) > unsigned int uitmp, uitmp1, uitmp2; > const bool rx = test_bit(RX_ON, &dev->flags); > const bool tx = test_bit(TX_ON, &dev->flags); > + > static const struct { > u32 freq; > } bandwidth_lut[] = { If this has been found by scripts/checkpatch.pl as: WARNING: Missing a blank line after declarations #252: FILE: drivers/media/usb/hackrf/hackrf.c:252: + const bool tx = test_bit(TX_ON, &dev->flags); + static const struct { it is a false positive, as the code which follows the blank line is a declaration too. Ciao ciao, Antonio
diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c index 9e700ca..186ef2d 100644 --- a/drivers/media/usb/hackrf/hackrf.c +++ b/drivers/media/usb/hackrf/hackrf.c @@ -249,6 +249,7 @@ static int hackrf_set_params(struct hackrf_dev *dev) unsigned int uitmp, uitmp1, uitmp2; const bool rx = test_bit(RX_ON, &dev->flags); const bool tx = test_bit(TX_ON, &dev->flags); + static const struct { u32 freq; } bandwidth_lut[] = {
Fixed a coding style issue. Signed-off-by: Jannik Becher <Becher.Jannik@gmail.com> --- drivers/media/usb/hackrf/hackrf.c | 1 + 1 file changed, 1 insertion(+)