From patchwork Fri Mar 4 20:20:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 8507421 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 12588C0554 for ; Fri, 4 Mar 2016 20:21:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3C99020225 for ; Fri, 4 Mar 2016 20:21:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52AD22022A for ; Fri, 4 Mar 2016 20:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759678AbcCDUUv (ORCPT ); Fri, 4 Mar 2016 15:20:51 -0500 Received: from lists.s-osg.org ([54.187.51.154]:36319 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759679AbcCDUUt (ORCPT ); Fri, 4 Mar 2016 15:20:49 -0500 Received: from sauron.localdomain (unknown [181.120.163.117]) by lists.s-osg.org (Postfix) with ESMTPSA id 3B46A462D4; Fri, 4 Mar 2016 12:20:42 -0800 (PST) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Kukjin Kim , Mauro Carvalho Chehab , linux-samsung-soc@vger.kernel.org, Kyungmin Park , Krzysztof Kozlowski , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: [PATCH 2/2] [media] exynos4-is: FIMC port parse should fail if there's no endpoint Date: Fri, 4 Mar 2016 17:20:13 -0300 Message-Id: <1457122813-12791-3-git-send-email-javier@osg.samsung.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1457122813-12791-1-git-send-email-javier@osg.samsung.com> References: <1457122813-12791-1-git-send-email-javier@osg.samsung.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The fimc_md_parse_port_node() function return 0 if an endpoint node is not found but according to Documentation/devicetree/bindings/graph.txt, a port must always have at least one enpoint. So return an -EINVAL errno code to the caller instead, so it knows that the port node parse failed due an invalid Device Tree description. Signed-off-by: Javier Martinez Canillas --- drivers/media/platform/exynos4-is/media-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c index feb521f28e14..06f3d75c9a0e 100644 --- a/drivers/media/platform/exynos4-is/media-dev.c +++ b/drivers/media/platform/exynos4-is/media-dev.c @@ -394,7 +394,7 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd, /* Assume here a port node can have only one endpoint node. */ ep = of_get_next_child(port, NULL); if (!ep) - return 0; + return -EINVAL; ret = v4l2_of_parse_endpoint(ep, &endpoint); if (ret) {