From patchwork Wed Mar 9 19:09:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 8548671 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AE1909F38C for ; Wed, 9 Mar 2016 19:09:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 23FF1202BE for ; Wed, 9 Mar 2016 19:09:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35AA62021A for ; Wed, 9 Mar 2016 19:09:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933414AbcCITJy (ORCPT ); Wed, 9 Mar 2016 14:09:54 -0500 Received: from lists.s-osg.org ([54.187.51.154]:40278 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933958AbcCITJw (ORCPT ); Wed, 9 Mar 2016 14:09:52 -0500 Received: from sauron.localdomain (unknown [181.120.163.117]) by lists.s-osg.org (Postfix) with ESMTPSA id A13D0462D4; Wed, 9 Mar 2016 11:09:46 -0800 (PST) From: Javier Martinez Canillas To: linux-media@vger.kernel.org Cc: Mauro Carvalho Chehab , Laurent Pinchart , Sakari Ailus , Hans Verkuil , Shuah Khan , Javier Martinez Canillas Subject: [RFC PATCH 1/3] [media] v4l2-mc.h: Add a S-Video C input PAD to demod enum Date: Wed, 9 Mar 2016 16:09:24 -0300 Message-Id: <1457550566-5465-2-git-send-email-javier@osg.samsung.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1457550566-5465-1-git-send-email-javier@osg.samsung.com> References: <1457550566-5465-1-git-send-email-javier@osg.samsung.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The enum demod_pad_index list the PADs that an analog TV demod has but in some decoders the S-Video Y (luminance) and C (chrominance) signals are carried by different connectors. So a single DEMOD_PAD_IF_INPUT is not enough and an additional PAD is needed in the case of S-Video for the additional C signal. Add a DEMOD_PAD_C_INPUT that can be used for this case and the existing DEMOD_PAD_IF_INPUT can be used for either Composite or the Y signal. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Javier Martinez Canillas --- Hello, This change was suggested by Mauro in [0] although is still not clear if this is the way forward since changing PAD indexes can break the uAPI depending on how the PADs are looked up. Another alternative is to have a PAD type as Mauro mentioned on the same email but since the series are RFC, I'm making this change as an example and hopping that the patches can help with the discussion. [0]: http://www.spinics.net/lists/linux-media/msg98042.html Best regards, Javier include/media/v4l2-mc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/media/v4l2-mc.h b/include/media/v4l2-mc.h index 98a938aabdfb..47c00c288a06 100644 --- a/include/media/v4l2-mc.h +++ b/include/media/v4l2-mc.h @@ -94,7 +94,8 @@ enum if_aud_dec_pad_index { * @DEMOD_NUM_PADS: Maximum number of output pads. */ enum demod_pad_index { - DEMOD_PAD_IF_INPUT, + DEMOD_PAD_IF_INPUT, /* S-Video Y input or Composite */ + DEMOD_PAD_C_INPUT, /* S-Video C input or Composite */ DEMOD_PAD_VID_OUT, DEMOD_PAD_VBI_OUT, DEMOD_PAD_AUDIO_OUT,