From patchwork Wed Mar 16 19:16:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olli Salonen X-Patchwork-Id: 8603491 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A85189F44D for ; Wed, 16 Mar 2016 19:16:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DA7A6202F0 for ; Wed, 16 Mar 2016 19:16:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 088F9201CD for ; Wed, 16 Mar 2016 19:16:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934332AbcCPTQv (ORCPT ); Wed, 16 Mar 2016 15:16:51 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:35043 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752138AbcCPTQu (ORCPT ); Wed, 16 Mar 2016 15:16:50 -0400 Received: by mail-lf0-f44.google.com with SMTP id l202so26683593lfl.2 for ; Wed, 16 Mar 2016 12:16:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PLUTJphSBmLU57eqVwx54YZtLaIVHfuYg4qzMPTeN6I=; b=CKFkmiJdA9DbZ3z2Yltqg0MZjPVYsHo87i1vR6MDHBbTR0xQXLLPFQh6LA8ZkdddZi Omqw7MRaDSPaR2Vj7+PPooqCsHzovWhCUGnz9xtbwb3e1qtA6aUz83HSNMlVxemPz47u GyrEcubWey2mi+EwKGSXPttiwzV4HdiyUoV+T816oQhdt28ejXBYQhOu0Cxx+6Ekbw9F lJq2W+WLkBeU6CEbFgOVoWbHIHhc2vgAComK2gIZuUGss4cXrd+MMUPxBUiKyIS8VXAG cfG/jEeNEX4ERcJHg0W0zHxDS6opvslcanUN5o6ZLkZtuMfC6aXv7N6R+03YA5aT3XRQ 9k1Q== X-Gm-Message-State: AD7BkJLIr+/PjpOXt14RvHxRGmCsDHpKcZjXt+4gvkDecP4IdJGiqpPCoWYiOnJoQoC4Pw== X-Received: by 10.25.206.135 with SMTP id e129mr2150827lfg.46.1458155808515; Wed, 16 Mar 2016 12:16:48 -0700 (PDT) Received: from dl160.lan (178-55-1-76.bb.dnainternet.fi. [178.55.1.76]) by smtp.gmail.com with ESMTPSA id h6sm771742lbv.43.2016.03.16.12.16.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 16 Mar 2016 12:16:47 -0700 (PDT) From: Olli Salonen To: linux-media@vger.kernel.org Cc: Olli Salonen Subject: [PATCH] pctv452e: correct parameters for TechnoTrend TT S2-3600 Date: Wed, 16 Mar 2016 21:16:41 +0200 Message-Id: <1458155801-14534-1-git-send-email-olli.salonen@iki.fi> X-Mailer: git-send-email 1.9.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 2008-02-25 Andre Weidemann added support for TT S2-3600 and noted that he still gets image distortions every now and then. It seems to be common knowledge in many projects that changing the USB parameters seems to help. OpenELEC has included this patch for a few years, for example. Nobody bothered to report the issue upstream though, it seems. References: https://github.com/OpenELEC/OpenELEC.tv/issues/1957 http://www.vdr-portal.de/board60-linux/board14-betriebssystem/board96-yavdr/p1033458-darstellungsproblem-bei-2-tt-3600-usb/#post1033458 (in German) I'd suggest we include the patch below. Any objections? Signed-off-by: Olli Salonen --- drivers/media/usb/dvb-usb/pctv452e.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/dvb-usb/pctv452e.c b/drivers/media/usb/dvb-usb/pctv452e.c index ec397c4..c05de1b 100644 --- a/drivers/media/usb/dvb-usb/pctv452e.c +++ b/drivers/media/usb/dvb-usb/pctv452e.c @@ -995,11 +995,11 @@ static struct dvb_usb_device_properties tt_connect_s2_3600_properties = { /* parameter for the MPEG2-data transfer */ .stream = { .type = USB_ISOC, - .count = 7, + .count = 4, .endpoint = 0x02, .u = { .isoc = { - .framesperurb = 4, + .framesperurb = 64, .framesize = 940, .interval = 1 }