| Message ID | 145855998541.9135.18170484612406448203.stgit@woodpecker.blarg.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Max, Em Mon, 21 Mar 2016 12:33:05 +0100 Max Kellermann <max@duempel.org> escreveu: > CONFIG_DEBUG_KOBJECT_RELEASE found this bug. Please, always send us your Signed-off-by on your patches, as described at: https://linuxtv.org/wiki/index.php/Development:_Submitting_Patches#Developer.27s_Certificate_of_Origin_1.1 > --- > drivers/media/rc/rc-main.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c > index 1042fa3..cb3e8db 100644 > --- a/drivers/media/rc/rc-main.c > +++ b/drivers/media/rc/rc-main.c > @@ -1248,6 +1248,9 @@ unlock: > > static void rc_dev_release(struct device *device) > { > + struct rc_dev *dev = to_rc_dev(device); > + > + kfree(dev); > } > > #define ADD_HOTPLUG_VAR(fmt, val...) \ > @@ -1369,7 +1372,9 @@ void rc_free_device(struct rc_dev *dev) > > put_device(&dev->dev); > > - kfree(dev); > + /* kfree(dev) will be called by the callback function > + rc_dev_release() */ > + > module_put(THIS_MODULE); > } > EXPORT_SYMBOL_GPL(rc_free_device); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2016/03/21 13:24, Mauro Carvalho Chehab <mchehab@osg.samsung.com> wrote: > Please, always send us your Signed-off-by on your patches, as described at: > https://linuxtv.org/wiki/index.php/Development:_Submitting_Patches#Developer.27s_Certificate_of_Origin_1.1 Sorry, I forgot this, and remembered only right after the patches were already sent. I will resend. Max -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 1042fa3..cb3e8db 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -1248,6 +1248,9 @@ unlock: static void rc_dev_release(struct device *device) { + struct rc_dev *dev = to_rc_dev(device); + + kfree(dev); } #define ADD_HOTPLUG_VAR(fmt, val...) \ @@ -1369,7 +1372,9 @@ void rc_free_device(struct rc_dev *dev) put_device(&dev->dev); - kfree(dev); + /* kfree(dev) will be called by the callback function + rc_dev_release() */ + module_put(THIS_MODULE); } EXPORT_SYMBOL_GPL(rc_free_device);