| Message ID | 1465659593-16858-3-git-send-email-ivo.g.dimitrov.75@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: > Add DT bindings description Not exactly the best commit msg. > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > --- > .../bindings/media/i2c/toshiba,et8ek8.txt | 50 ++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > new file mode 100644 > index 0000000..997d268 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > @@ -0,0 +1,50 @@ > +Toshiba et8ek8 5MP sensor > + > +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device > + > +More detailed documentation can be found in > +Documentation/devicetree/bindings/media/video-interfaces.txt . > + > + > +Mandatory properties > +-------------------- > + > +- compatible: "toshiba,et8ek8" > +- reg: I2C address (0x3e, or an alternative address) > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts > +- clocks: External clock to the sensor > +- clock-frequency: Frequency of the external clock to the sensor These should be mutually-exclusive. If you have a clock, then you can get the frequency at runtime. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote: > On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: > > Add DT bindings description > > Not exactly the best commit msg. > > > > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > > --- > > .../bindings/media/i2c/toshiba,et8ek8.txt | 50 ++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > > new file mode 100644 > > index 0000000..997d268 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > > @@ -0,0 +1,50 @@ > > +Toshiba et8ek8 5MP sensor > > + > > +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device > > + > > +More detailed documentation can be found in > > +Documentation/devicetree/bindings/media/video-interfaces.txt . > > + > > + > > +Mandatory properties > > +-------------------- > > + > > +- compatible: "toshiba,et8ek8" > > +- reg: I2C address (0x3e, or an alternative address) > > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts > > > +- clocks: External clock to the sensor > > +- clock-frequency: Frequency of the external clock to the sensor > > These should be mutually-exclusive. If you have a clock, then you can > get the frequency at runtime. Yes, you can. But the intention is to set the frequency: the sensor requires a particular, pre-determined frequency. Typically this is specific to the board.
On Tue, Jun 14, 2016 at 11:31 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote: > Hi Rob, > > On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote: >> On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: >> > Add DT bindings description >> >> Not exactly the best commit msg. >> >> > >> > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> >> > --- >> > .../bindings/media/i2c/toshiba,et8ek8.txt | 50 ++++++++++++++++++++++ >> > 1 file changed, 50 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >> > >> > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >> > new file mode 100644 >> > index 0000000..997d268 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >> > @@ -0,0 +1,50 @@ >> > +Toshiba et8ek8 5MP sensor >> > + >> > +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device >> > + >> > +More detailed documentation can be found in >> > +Documentation/devicetree/bindings/media/video-interfaces.txt . >> > + >> > + >> > +Mandatory properties >> > +-------------------- >> > + >> > +- compatible: "toshiba,et8ek8" >> > +- reg: I2C address (0x3e, or an alternative address) >> > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts >> >> > +- clocks: External clock to the sensor >> > +- clock-frequency: Frequency of the external clock to the sensor >> >> These should be mutually-exclusive. If you have a clock, then you can >> get the frequency at runtime. > > Yes, you can. But the intention is to set the frequency: the sensor requires > a particular, pre-determined frequency. Typically this is specific to the > board. Okay, then state that in the description. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 15.06.2016 21:41, Rob Herring wrote: > On Tue, Jun 14, 2016 at 11:31 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote: >> Hi Rob, >> >> On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote: >>> On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: >>>> Add DT bindings description >>> >>> Not exactly the best commit msg. >>> will elaborate a bit more in the next patch version >>>> >>>> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> >>>> --- >>>> .../bindings/media/i2c/toshiba,et8ek8.txt | 50 ++++++++++++++++++++++ >>>> 1 file changed, 50 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >>>> new file mode 100644 >>>> index 0000000..997d268 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >>>> @@ -0,0 +1,50 @@ >>>> +Toshiba et8ek8 5MP sensor >>>> + >>>> +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device >>>> + >>>> +More detailed documentation can be found in >>>> +Documentation/devicetree/bindings/media/video-interfaces.txt . >>>> + >>>> + >>>> +Mandatory properties >>>> +-------------------- >>>> + >>>> +- compatible: "toshiba,et8ek8" >>>> +- reg: I2C address (0x3e, or an alternative address) >>>> +- vana-supply: Analogue voltage supply (VANA), 2.8 volts >>> >>>> +- clocks: External clock to the sensor >>>> +- clock-frequency: Frequency of the external clock to the sensor >>> >>> These should be mutually-exclusive. If you have a clock, then you can >>> get the frequency at runtime. >> >> Yes, you can. But the intention is to set the frequency: the sensor requires >> a particular, pre-determined frequency. Typically this is specific to the >> board. > > Okay, then state that in the description. > ok, will do in the next patch version Thanks, Ivo -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed 2016-06-15 22:24:40, Ivaylo Dimitrov wrote: > > > On 15.06.2016 21:41, Rob Herring wrote: > >On Tue, Jun 14, 2016 at 11:31 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote: > >>Hi Rob, > >> > >>On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote: > >>>On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: > >>>>Add DT bindings description > >>> > >>>Not exactly the best commit msg. > >>> > > will elaborate a bit more in the next patch version And you can add my Acked-by to the next version :-). Pavel
diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt new file mode 100644 index 0000000..997d268 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt @@ -0,0 +1,50 @@ +Toshiba et8ek8 5MP sensor + +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device + +More detailed documentation can be found in +Documentation/devicetree/bindings/media/video-interfaces.txt . + + +Mandatory properties +-------------------- + +- compatible: "toshiba,et8ek8" +- reg: I2C address (0x3e, or an alternative address) +- vana-supply: Analogue voltage supply (VANA), 2.8 volts +- clocks: External clock to the sensor +- clock-frequency: Frequency of the external clock to the sensor +- reset-gpios: XSHUTDOWN GPIO + + +Endpoint node mandatory properties +---------------------------------- + +- remote-endpoint: A phandle to the bus receiver's endpoint node. + +Endpoint node optional properties +---------------------------------- + +- clock-lanes: <0> +- data-lanes: <1..n> + +Example +------- + +&i2c3 { + clock-frequency = <400000>; + + cam1: camera@3e { + compatible = "toshiba,et8ek8"; + reg = <0x3e>; + vana-supply = <&vaux4>; + clocks = <&isp 0>; + clock-frequency = <9600000>; + reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */ + port { + csi_cam1: endpoint { + remote-endpoint = <&csi_out1>; + }; + }; + }; +};
Add DT bindings description Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> --- .../bindings/media/i2c/toshiba,et8ek8.txt | 50 ++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt