From patchwork Wed Jul 6 09:01:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andi Shyti X-Patchwork-Id: 9215901 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E7D4E60467 for ; Wed, 6 Jul 2016 09:44:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D8B56287D1 for ; Wed, 6 Jul 2016 09:44:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CB941287DB; Wed, 6 Jul 2016 09:44:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D553287D1 for ; Wed, 6 Jul 2016 09:44:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932166AbcGFJoj (ORCPT ); Wed, 6 Jul 2016 05:44:39 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:56504 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753221AbcGFJoG (ORCPT ); Wed, 6 Jul 2016 05:44:06 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O9W022VT0D6A830@mailout2.samsung.com>; Wed, 06 Jul 2016 18:43:54 +0900 (KST) Received: from epcpsbgm2new.samsung.com ( [172.20.52.112]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 3F.69.05161.AD2DC775; Wed, 6 Jul 2016 18:43:54 +0900 (KST) X-AuditID: cbfee68f-f79476d000001429-40-577cd2da1bdb Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id 3E.B5.04429.AD2DC775; Wed, 6 Jul 2016 02:43:54 -0700 (MST) Received: from samsunx.samsung ([10.113.63.54]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O9W003BE0D2J600@mmp2.samsung.com>; Wed, 06 Jul 2016 18:43:53 +0900 (KST) From: Andi Shyti To: Mauro Carvalho Chehab Cc: Joe Perches , Sean Young , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH v3 12/15] [media] lirc_dev: fix error return value Date: Wed, 06 Jul 2016 18:01:24 +0900 Message-id: <1467795687-10737-13-git-send-email-andi.shyti@samsung.com> X-Mailer: git-send-email 2.8.1 In-reply-to: <1467795687-10737-1-git-send-email-andi.shyti@samsung.com> References: <1467795687-10737-1-git-send-email-andi.shyti@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsWyRsSkQPfWpZpwgwtH5S22H3nGarH4x3Mm i1OTnzFZzL7/mMXi8q45bBY9G7ayWqx+VmGx8Ol3FgcOj+tLPjF7LHlj7bGl/y67x5dV15g9 +rasYvT4vEnO49TXz+wB7FFcNimpOZllqUX6dglcGacnORQ85Km4MuE+SwNjC1cXIyeHhICJ xOYdR9ghbDGJC/fWs3UxcnEICaxglPh8qYsdpmhO63MmiMQsRomNyz8xQjgfGSV+LbvJBFLF JqAp0XT7B1A7B4eIgLHEuR/qIDXMAk8ZJfZNnQtWIyzgJDF1+UZmEJtFQFWicdt7FpB6XgF3 ibuPxSGWyUlcnv4AbAwnUPjqciWQsJCAm8T+bTfZQUZKCGxil7i74CAjxBgBiW+TD4GNkRCQ ldh0gBlijKTEwRU3WCYwCi9gZFjFKJpakFxQnJReZKxXnJhbXJqXrpecn7uJERj8p/8969/B ePeA9SFGAQ5GJR7eis014UKsiWXFlbmHGE2BNkxklhJNzgfGWF5JvKGxmZGFqYmpsZG5pZmS OO9CqZ/BQgLpiSWp2ampBalF8UWlOanFhxiZODilGhgj3K1/f5kqUtB+beMdyScl3g5ePhr+ Dc5HJd+ryrz+smy5y/b+ebrT+pfLzRPj2Z87rTT5f2jk2v8/K7v/H7ryRrLBsTFF+kxN+u93 jkENxwz8JNOvJwtuTVD9vKO/v2GaUqHY2Zy9Gv1Vl9Z/SNbglBDpW3zrdoBh946JH0v12S88 ud99IF6JpTgj0VCLuag4EQBE2nfGeQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMIsWRmVeSWpSXmKPExsVy+t9jQd1bl2rCDV5dkLLYfuQZq8XiH8+Z LE5NfsZkMfv+YxaLy7vmsFn0bNjKarH6WYXFwqffWRw4PK4v+cTsseSNtceW/rvsHl9WXWP2 6NuyitHj8yY5j1NfP7MHsEc1MNpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynk Jeam2iq5+AToumXmAB2lpFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcw4 Pcmh4CFPxZUJ91kaGFu4uhg5OSQETCTmtD5ngrDFJC7cW8/WxcjFISQwi1Fi4/JPjBDOR0aJ X8tuglWxCWhKNN3+AVTFwSEiYCxx7oc6SA2zwFNGiX1T54LVCAs4SUxdvpEZxGYRUJVo3Pae BaSeV8Bd4u5jcYhlchKXpz8AG8MJFL66XAkkLCTgJrF/2032CYy8CxgZVjFKpBYkFxQnpeca 5aWW6xUn5haX5qXrJefnbmIER9gz6R2Mh3e5H2IU4GBU4uE9IVETLsSaWFZcmXuIUYKDWUmE 1+YCUIg3JbGyKrUoP76oNCe1+BCjKdBZE5mlRJPzgdGfVxJvaGxiZmRpZG5oYWRsriTO+/j/ ujAhgfTEktTs1NSC1CKYPiYOTqkGxugoz8D9obPnPXmy0PrQ4eUc959Ly/8rXxm37daCqcor /KdcK0u2dZS6FRli1aD2fOfKuIkTfUK2TIx9POP/elbF34u/qB7dcLLlaNbvw3tmFt/9LnRE b3PP5Blif1klwrwzZLdKF7i5VEZmOlybIDuBcdnx0ND8QD13l33P5L60KwnEXxRhvqHEUpyR aKjFXFScCAB8lpQ3xgIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If ioctl is called, it cannot be a case of invalid system call number (ENOSYS), that is a ENOTTY case which means that the device doesn't support that specific ioctl command. Replace ENOSYS with EPERM. Signed-off-by: Andi Shyti --- drivers/media/rc/lirc_dev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c index c2b32e0..ac00433 100644 --- a/drivers/media/rc/lirc_dev.c +++ b/drivers/media/rc/lirc_dev.c @@ -582,7 +582,7 @@ long lirc_dev_fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg) break; case LIRC_GET_REC_MODE: if (!(ir->d.features & LIRC_CAN_REC_MASK)) { - result = -ENOSYS; + result = -ENOTTY; break; } @@ -592,7 +592,7 @@ long lirc_dev_fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg) break; case LIRC_SET_REC_MODE: if (!(ir->d.features & LIRC_CAN_REC_MASK)) { - result = -ENOSYS; + result = -ENOTTY; break; } @@ -610,7 +610,7 @@ long lirc_dev_fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg) case LIRC_GET_MIN_TIMEOUT: if (!(ir->d.features & LIRC_CAN_SET_REC_TIMEOUT) || ir->d.min_timeout == 0) { - result = -ENOSYS; + result = -ENOTTY; break; } @@ -619,7 +619,7 @@ long lirc_dev_fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg) case LIRC_GET_MAX_TIMEOUT: if (!(ir->d.features & LIRC_CAN_SET_REC_TIMEOUT) || ir->d.max_timeout == 0) { - result = -ENOSYS; + result = -ENOTTY; break; }