From patchwork Thu Aug 11 21:03:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 9275969 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C43AF600CB for ; Thu, 11 Aug 2016 21:11:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B41242879E for ; Thu, 11 Aug 2016 21:11:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A913D287A0; Thu, 11 Aug 2016 21:11:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5CE5B2879E for ; Thu, 11 Aug 2016 21:11:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932679AbcHKVL3 (ORCPT ); Thu, 11 Aug 2016 17:11:29 -0400 Received: from www.zeus03.de ([194.117.254.33]:56250 "EHLO mail.zeus03.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932368AbcHKVLZ (ORCPT ); Thu, 11 Aug 2016 17:11:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references; s=k1; bh=Ko4eHU0QpcTfqUsJ+2FxQQX9mFawKbl1j4UTm28BUo8=; b=XddyfjliXUdv 9JPCENXRpBkxWUd5ABLQnVFnokNlMjVo4hcnBh2o5iizTtIrPCIthK5kRyWNPGQc j7aiGSJe4P/gCtfzlgDSkQstirVchR3DPGMUhOWMLcqFJiMrZIFn4h7egJccVj11 TgzvHOgMBK2dLlGQPE7RMRlaZKciXAI= Received: (qmail 3544 invoked from network); 11 Aug 2016 23:04:43 +0200 Received: from dslb-178-008-085-090.178.008.pools.vodafone-ip.de (HELO localhost) (l3s3148p1@178.8.85.90) by mail.zeus03.de with ESMTPSA (ECDHE-RSA-AES256-GCM-SHA384 encrypted, authenticated); 11 Aug 2016 23:04:43 +0200 From: Wolfram Sang To: linux-usb@vger.kernel.org Cc: Wolfram Sang , Hans Verkuil , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 15/28] media: usb: gspca: benq: don't print error when allocating urb fails Date: Thu, 11 Aug 2016 23:03:51 +0200 Message-Id: <1470949451-24823-16-git-send-email-wsa-dev@sang-engineering.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1470949451-24823-1-git-send-email-wsa-dev@sang-engineering.com> References: <1470949451-24823-1-git-send-email-wsa-dev@sang-engineering.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/gspca/benq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/usb/gspca/benq.c b/drivers/media/usb/gspca/benq.c index 790baed339639d..5fa67b78ad49b1 100644 --- a/drivers/media/usb/gspca/benq.c +++ b/drivers/media/usb/gspca/benq.c @@ -95,10 +95,8 @@ static int sd_start(struct gspca_dev *gspca_dev) #define SD_NPKT 32 for (n = 0; n < 4; n++) { urb = usb_alloc_urb(SD_NPKT, GFP_KERNEL); - if (!urb) { - pr_err("usb_alloc_urb failed\n"); + if (!urb) return -ENOMEM; - } gspca_dev->urb[n] = urb; urb->transfer_buffer = usb_alloc_coherent(gspca_dev->dev, SD_PKT_SZ * SD_NPKT,