From patchwork Thu Aug 11 21:03:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 9275995 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D16E1600CB for ; Thu, 11 Aug 2016 21:11:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C14D72879F for ; Thu, 11 Aug 2016 21:11:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B618A287A2; Thu, 11 Aug 2016 21:11:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 713E32879F for ; Thu, 11 Aug 2016 21:11:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932604AbcHKVLu (ORCPT ); Thu, 11 Aug 2016 17:11:50 -0400 Received: from www.zeus03.de ([194.117.254.33]:56270 "EHLO mail.zeus03.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932654AbcHKVL1 (ORCPT ); Thu, 11 Aug 2016 17:11:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references; s=k1; bh=evl2KoJiTAFC/D2hXrc7JaPM89TyO5VwF7bMsoxEs4I=; b=dKOpffiOZGrr oPR7SJnafdxY8UHr6M/qFqvB22eAHowtjAc9NIxVwxGwnRjTZq1pmLsE9mkrzQIR h1J6u6YjjmWEq17X3T5iwZjzhR0EOJbCWlQkAFFkzXIpO8QnVQn9MYVc22yV/opR VY6gcU3WeAMvInJcuXo6/VHe9IhhRNs= Received: (qmail 3636 invoked from network); 11 Aug 2016 23:04:46 +0200 Received: from dslb-178-008-085-090.178.008.pools.vodafone-ip.de (HELO localhost) (l3s3148p1@178.8.85.90) by mail.zeus03.de with ESMTPSA (ECDHE-RSA-AES256-GCM-SHA384 encrypted, authenticated); 11 Aug 2016 23:04:46 +0200 From: Wolfram Sang To: linux-usb@vger.kernel.org Cc: Wolfram Sang , Hans Verkuil , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 19/28] media: usb: hdpvr: hdpvr-video: don't print error when allocating urb fails Date: Thu, 11 Aug 2016 23:03:55 +0200 Message-Id: <1470949451-24823-20-git-send-email-wsa-dev@sang-engineering.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1470949451-24823-1-git-send-email-wsa-dev@sang-engineering.com> References: <1470949451-24823-1-git-send-email-wsa-dev@sang-engineering.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/hdpvr/hdpvr-video.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hdpvr/hdpvr-video.c index 2a3a8b470555b9..6d43d75493ea0e 100644 --- a/drivers/media/usb/hdpvr/hdpvr-video.c +++ b/drivers/media/usb/hdpvr/hdpvr-video.c @@ -155,10 +155,8 @@ int hdpvr_alloc_buffers(struct hdpvr_device *dev, uint count) buf->dev = dev; urb = usb_alloc_urb(0, GFP_KERNEL); - if (!urb) { - v4l2_err(&dev->v4l2_dev, "cannot allocate urb\n"); + if (!urb) goto exit_urb; - } buf->urb = urb; mem = usb_alloc_coherent(dev->udev, dev->bulk_in_size, GFP_KERNEL,