From patchwork Thu Aug 11 21:03:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 9275961 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 27907600CB for ; Thu, 11 Aug 2016 21:11:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 185132879E for ; Thu, 11 Aug 2016 21:11:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0CCD3287A2; Thu, 11 Aug 2016 21:11:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B90F92879E for ; Thu, 11 Aug 2016 21:11:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932613AbcHKVLV (ORCPT ); Thu, 11 Aug 2016 17:11:21 -0400 Received: from www.zeus03.de ([194.117.254.33]:56192 "EHLO mail.zeus03.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932329AbcHKVLP (ORCPT ); Thu, 11 Aug 2016 17:11:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references; s=k1; bh=ppgDHM2WDOP/Oq9OB0O0Tm7jM8cvywh9uVSJ7sl8lNU=; b=0LBfebg5mCzJ QaWKxgSx+jji4VJCTufdQTO7D+7cf3eCCxPSElIqvesjt7UQOaPtV0wlmJloR5DP OmXOreTqDIaS6A85+JjzIji5fjInx6UGA7Ra0RsKF0+32/V61OEuuxK1scVpFBnn Z/nWC9UajFoLXSzrWlKQU3AgVT/fTJM= Received: (qmail 3285 invoked from network); 11 Aug 2016 23:04:34 +0200 Received: from dslb-178-008-085-090.178.008.pools.vodafone-ip.de (HELO localhost) (l3s3148p1@178.8.85.90) by mail.zeus03.de with ESMTPSA (ECDHE-RSA-AES256-GCM-SHA384 encrypted, authenticated); 11 Aug 2016 23:04:34 +0200 From: Wolfram Sang To: linux-usb@vger.kernel.org Cc: Wolfram Sang , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 03/28] media: rc: imon: don't print error when allocating urb fails Date: Thu, 11 Aug 2016 23:03:39 +0200 Message-Id: <1470949451-24823-4-git-send-email-wsa-dev@sang-engineering.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1470949451-24823-1-git-send-email-wsa-dev@sang-engineering.com> References: <1470949451-24823-1-git-send-email-wsa-dev@sang-engineering.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/rc/imon.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c index 65f80b8b9f7ab9..86cc70fe25348f 100644 --- a/drivers/media/rc/imon.c +++ b/drivers/media/rc/imon.c @@ -2211,16 +2211,11 @@ static struct imon_context *imon_init_intf0(struct usb_interface *intf, goto exit; } rx_urb = usb_alloc_urb(0, GFP_KERNEL); - if (!rx_urb) { - dev_err(dev, "%s: usb_alloc_urb failed for IR urb", __func__); + if (!rx_urb) goto rx_urb_alloc_failed; - } tx_urb = usb_alloc_urb(0, GFP_KERNEL); - if (!tx_urb) { - dev_err(dev, "%s: usb_alloc_urb failed for display urb", - __func__); + if (!tx_urb) goto tx_urb_alloc_failed; - } mutex_init(&ictx->lock); spin_lock_init(&ictx->kc_lock); @@ -2305,10 +2300,8 @@ static struct imon_context *imon_init_intf1(struct usb_interface *intf, int ret = -ENOMEM; rx_urb = usb_alloc_urb(0, GFP_KERNEL); - if (!rx_urb) { - pr_err("usb_alloc_urb failed for IR urb\n"); + if (!rx_urb) goto rx_urb_alloc_failed; - } mutex_lock(&ictx->lock);