From patchwork Thu Aug 11 21:03:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 9275955 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6C48E60CDC for ; Thu, 11 Aug 2016 21:11:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5C64D2879E for ; Thu, 11 Aug 2016 21:11:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 517B4287A0; Thu, 11 Aug 2016 21:11:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 091A92879F for ; Thu, 11 Aug 2016 21:11:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932451AbcHKVLR (ORCPT ); Thu, 11 Aug 2016 17:11:17 -0400 Received: from www.zeus03.de ([194.117.254.33]:56191 "EHLO mail.zeus03.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932273AbcHKVLP (ORCPT ); Thu, 11 Aug 2016 17:11:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references; s=k1; bh=68fl7mXyGx4qx6zyamGD+nahOS9JFObvhxqRtGL/sAk=; b=l3LSOPOPaJO4 nMPSI5BtsEmxEQN9Mh7biYSVUQDmof2yxXunonJejekxo0iPS9Jgv0eNGpvvaQ8P kPXSFew49W/iIQ01IaDW00BQ+lvDlPvHF/dTCSEeGtGVDmQDyL6Nt4R17XeTQh0h Yrp0+ol3z1RUPs+4tZlLf7gk3EK9+Vc= Received: (qmail 3306 invoked from network); 11 Aug 2016 23:04:34 +0200 Received: from dslb-178-008-085-090.178.008.pools.vodafone-ip.de (HELO localhost) (l3s3148p1@178.8.85.90) by mail.zeus03.de with ESMTPSA (ECDHE-RSA-AES256-GCM-SHA384 encrypted, authenticated); 11 Aug 2016 23:04:34 +0200 From: Wolfram Sang To: linux-usb@vger.kernel.org Cc: Wolfram Sang , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 04/28] media: rc: redrat3: don't print error when allocating urb fails Date: Thu, 11 Aug 2016 23:03:40 +0200 Message-Id: <1470949451-24823-5-git-send-email-wsa-dev@sang-engineering.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1470949451-24823-1-git-send-email-wsa-dev@sang-engineering.com> References: <1470949451-24823-1-git-send-email-wsa-dev@sang-engineering.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/rc/redrat3.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c index 399f44d89a2986..ec8016d9b00907 100644 --- a/drivers/media/rc/redrat3.c +++ b/drivers/media/rc/redrat3.c @@ -970,10 +970,8 @@ static int redrat3_dev_probe(struct usb_interface *intf, /* set up bulk-in endpoint */ rr3->read_urb = usb_alloc_urb(0, GFP_KERNEL); - if (!rr3->read_urb) { - dev_err(dev, "Read urb allocation failure\n"); + if (!rr3->read_urb) goto error; - } rr3->ep_in = ep_in; rr3->bulk_in_buf = usb_alloc_coherent(udev,