From patchwork Wed Sep 21 13:09:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9343553 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 98455607D4 for ; Wed, 21 Sep 2016 13:09:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8825E2A507 for ; Wed, 21 Sep 2016 13:09:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7C9552A5B1; Wed, 21 Sep 2016 13:09:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BB70D2A507 for ; Wed, 21 Sep 2016 13:09:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932959AbcIUNJs (ORCPT ); Wed, 21 Sep 2016 09:09:48 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:36128 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753056AbcIUNJr (ORCPT ); Wed, 21 Sep 2016 09:09:47 -0400 Received: by mail-pa0-f67.google.com with SMTP id my20so2289624pab.3 for ; Wed, 21 Sep 2016 06:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mPjWAg5kzcLda6BOJNjBd6wQAo3fH429tMiIguV5CNI=; b=M4k/UF8/lWvNs+w/ljMqsJvXD8W3XFeaCcqb53soAlOhJycI5QDhl5CsBv5i5OxmxT ep5091xqc1EvKgeAtKi7TjwyroPuPBZF1me4qpEJkG/cMFnHJHdYhsXPbPKSpP81R2+s 30kLfg05ezABXT4Y3A4tQizFIngRU9hdlre8uVw8854MFEXvvw3b41vfU6x4rN4qU+XP /blqS0gABdOSAZwtRthLFDTW9UXLnU3FVMLWekdPjYE2vNwr7PIcePfexwB1v1hhSscU O5A2+eXfXGSfJJ2xv4FHWosKthJKvEB/5ne+8brw9Zj9cKZtFYUPPoJw9tgiCYh6Mp9s wDuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mPjWAg5kzcLda6BOJNjBd6wQAo3fH429tMiIguV5CNI=; b=cmD83zBKT9CJGAsm5vo04W5ewfpEEKcZF1u9cgNqMbHGw3lBnCzCFipKXWUVcvqECk YDIKVD6U9tD5v3egi9FpJCMNtb9bHAXFm3Fl2P/U7lt9URujf/aMQuO0Pa1mNnV74ioK cSp9OD+n9bVAa/ehYNKn+Yuj2yeFiSQlRhIclHSMiOWQFjLN2YMrcO15rhccHXiwxXw4 crq86mUNIW+QsYWK2cWAW0CWFEZtnL6pcNyWqRR3AumQbLrlJm2SuUp2BxOtCzrzN5Nc DgE3VyeCYpDpRTcGoDQTum1c42O1cTtdkjoZ9aj6AifaNdYn7eq18XKeOjymjHefa8oi Q7UA== X-Gm-Message-State: AE9vXwNZGhjvLp7L0W2nPTuDxYSr9nW+fLPli4UAuf1lpRt74npd/LwMfkECT+myPpqA1Q== X-Received: by 10.66.16.74 with SMTP id e10mr19914947pad.148.1474463387152; Wed, 21 Sep 2016 06:09:47 -0700 (PDT) Received: from 192.168.0.37 (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id gm1sm41036236pac.2.2016.09.21.06.09.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Sep 2016 06:09:46 -0700 (PDT) From: Wei Yongjun To: Charles-Antoine Couret , Mauro Carvalho Chehab Cc: Wei Yongjun , linux-media@vger.kernel.org Subject: [PATCH -next] [media] gs1662: drop kfree for memory allocated with devm_kzalloc Date: Wed, 21 Sep 2016 13:09:39 +0000 Message-Id: <1474463379-1030-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free. Fixes: 7aae6e2df127 ("[media] Add GS1662 driver, a video serializer") Signed-off-by: Wei Yongjun --- drivers/media/spi/gs1662.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/spi/gs1662.c b/drivers/media/spi/gs1662.c index d76f362..5143a90 100644 --- a/drivers/media/spi/gs1662.c +++ b/drivers/media/spi/gs1662.c @@ -453,10 +453,9 @@ static int gs_probe(struct spi_device *spi) static int gs_remove(struct spi_device *spi) { struct v4l2_subdev *sd = spi_get_drvdata(spi); - struct gs *gs = to_gs(sd); v4l2_device_unregister_subdev(sd); - kfree(gs); + return 0; }