From patchwork Wed Sep 21 15:09:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9343707 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DEC726077A for ; Wed, 21 Sep 2016 15:09:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CBFCB294FF for ; Wed, 21 Sep 2016 15:09:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C0D3B2A6F5; Wed, 21 Sep 2016 15:09:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 65FD1294FF for ; Wed, 21 Sep 2016 15:09:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757254AbcIUPJq (ORCPT ); Wed, 21 Sep 2016 11:09:46 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35276 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755814AbcIUPJp (ORCPT ); Wed, 21 Sep 2016 11:09:45 -0400 Received: by mail-pf0-f196.google.com with SMTP id 6so2505874pfl.2 for ; Wed, 21 Sep 2016 08:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pwdLmyiMtXVwn4ujN8mvIFgIK/X56xmoWMhCvyBoQEk=; b=DlSm0GrodfKz+Njoc5cQcqkzT8O4iCK+bGXm/agJm7YNIPPRqryzrgBF4vQk0a92eu QcXBoTYQKRBYUSaJ+LZ9SoO9ftLp0oZwkw9yYOugEexcHrIA6V3wuQnJTfJGdzgKZb7d MRtYwCOyUEjYEy1pXi8E9pX2PUKFDs4a7e1FJG8zvlrNtYqn7TejnFh0vj1a/fhE2pLH nt+Ycg0Ea39dgpbu7whVrBJ8TK6kodHAmRDP9vVX0K2nkX2tjhlWXrZlmpi8lI5IXvci AcFz4T3KotgyPZ/6gmGUa1Zj4errfcMpf014qaI24/xd5i6T4FBg+ZvTjm6pMVMxZ3G3 9T7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pwdLmyiMtXVwn4ujN8mvIFgIK/X56xmoWMhCvyBoQEk=; b=CpQwAHucRyckKTYc5NLEiRZua3NaZO4RjWxFP7AmqupTMXor0uosAuKRSu1W78K215 1zev+Z6rdwXufpEfa0aRhyLUwhbitVVCnZcB6jXfElGyknuEkProuPWzMFDu7veKe0F3 1vZmsAVTuZw9B+xoBDLjDjPPwCNlgDOxf6dMx/3zMO0/4qBXR9TAJtVMi56UfyJWJUc4 OK2eLLN2UTh00yPeR1j4CY/FIuyPQk2lhcDnjCwLNAcJoxDXSPjsRpYffaKvslTikXzM hQlQqTCbMGB/yVPRe2B7K3m8dpTnmpceXV8vYN0O2hX9Mp8zEv79w3UusC4omgCOzDPf nzSQ== X-Gm-Message-State: AE9vXwN2ZiB3fH9qr/nS+e+4/86cFlsO8ZTnmcBVL1S3CkGLIE0JXPTN3WsucYC1VEGOqw== X-Received: by 10.98.200.4 with SMTP id z4mr54188456pff.95.1474470585309; Wed, 21 Sep 2016 08:09:45 -0700 (PDT) Received: from 192.168.0.37 (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id 184sm87495222pfg.20.2016.09.21.08.09.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Sep 2016 08:09:44 -0700 (PDT) From: Wei Yongjun To: Fabien Dessenne , Mauro Carvalho Chehab Cc: Wei Yongjun , linux-media@vger.kernel.org Subject: [PATCH -next] [media] bdisp: fix error return code in bdisp_probe() Date: Wed, 21 Sep 2016 15:09:38 +0000 Message-Id: <1474470578-2870-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun Fix to return error code -EINVAL from the platform_get_resource() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Reviewed-by: Fabien Dessenne --- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c index 45f82b5..8236081 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c @@ -1337,6 +1337,7 @@ static int bdisp_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); if (!res) { dev_err(dev, "failed to get IRQ resource\n"); + ret = -EINVAL; goto err_clk; }