From patchwork Thu Oct 13 13:51:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 9375019 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2016760487 for ; Thu, 13 Oct 2016 13:51:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 124692A0BB for ; Thu, 13 Oct 2016 13:51:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 05F422A0D5; Thu, 13 Oct 2016 13:51:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 885EF2A0BB for ; Thu, 13 Oct 2016 13:51:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932312AbcJMNvm (ORCPT ); Thu, 13 Oct 2016 09:51:42 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:48244 "EHLO baptiste.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932274AbcJMNvl (ORCPT ); Thu, 13 Oct 2016 09:51:41 -0400 Received: from ayla.of.borg ([84.193.137.253]) by baptiste.telenet-ops.be with bizsmtp id v1re1t0025UCtCs011reca; Thu, 13 Oct 2016 15:51:38 +0200 Received: from ramsan.of.borg ([192.168.97.29] helo=ramsan) by ayla.of.borg with esmtp (Exim 4.82) (envelope-from ) id 1bugQ5-0006v6-Bn; Thu, 13 Oct 2016 15:51:37 +0200 Received: from geert by ramsan with local (Exim 4.82) (envelope-from ) id 1bugQ8-0005dA-Pe; Thu, 13 Oct 2016 15:51:40 +0200 From: Geert Uytterhoeven To: Sean Young , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] [media] dib0700: Fix uninitialized protocol for NEC repeat codes Date: Thu, 13 Oct 2016 15:51:39 +0200 Message-Id: <1476366699-21611-1-git-send-email-geert@linux-m68k.org> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP drivers/media/usb/dvb-usb/dib0700_core.c: In function ‘dib0700_rc_urb_completion’: drivers/media/usb/dvb-usb/dib0700_core.c:679: warning: ‘protocol’ may be used uninitialized in this function When receiving an NEC repeat code, protocol is indeed not initialized. Set it to RC_TYPE_NECX to fix this. Fixes: 2ceeca0499d74521 ("[media] rc: split nec protocol into its three variants") Signed-off-by: Geert Uytterhoeven --- Is RC_TYPE_NECX correct, or should it be RC_TYPE_NEC? I used RC_TYPE_NECX based on the checks for {,not_}data and {,not_}system for the other cases. --- drivers/media/usb/dvb-usb/dib0700_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media/usb/dvb-usb/dib0700_core.c index f3196658fb700706..5878ae4d20ad27ed 100644 --- a/drivers/media/usb/dvb-usb/dib0700_core.c +++ b/drivers/media/usb/dvb-usb/dib0700_core.c @@ -718,6 +718,7 @@ static void dib0700_rc_urb_completion(struct urb *purb) poll_reply->nec.data == 0x00 && poll_reply->nec.not_data == 0xff) { poll_reply->data_state = 2; + protocol = RC_TYPE_NECX; break; }