| Message ID | 1477565451-3621-1-git-send-email-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Em Thu, 27 Oct 2016 13:50:51 +0300 Sakari Ailus <sakari.ailus@linux.intel.com> escreveu: > struct timeval and struct timespec are defined in linux/time.h. Explicitly > include the header if __KERNEL__ is defined. The patch below doesn't do what you're mentioned above. It unconditionally include linux/time.h, and, for userspace, it will *also* include sys/time.h... I suspect that this would cause problems on userspace. Btw, you didn't mention on your description what's the bug you're trying to fix. > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > include/uapi/linux/videodev2.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 4364ce6..bbab50c 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -61,6 +61,7 @@ > #endif > #include <linux/compiler.h> > #include <linux/ioctl.h> > +#include <linux/time.h> > #include <linux/types.h> > #include <linux/v4l2-common.h> > #include <linux/v4l2-controls.h> Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mauro, On 11/21/16 15:33, Mauro Carvalho Chehab wrote: > Em Thu, 27 Oct 2016 13:50:51 +0300 > Sakari Ailus <sakari.ailus@linux.intel.com> escreveu: > >> struct timeval and struct timespec are defined in linux/time.h. Explicitly >> include the header if __KERNEL__ is defined. > > The patch below doesn't do what you're mentioned above. It unconditionally > include linux/time.h, and, for userspace, it will *also* include > sys/time.h... My bad... I thought writing a single line patch would be easy. ;-) Will fix. > > I suspect that this would cause problems on userspace. > > Btw, you didn't mention on your description what's the bug you're > trying to fix. The problem is a compiler error due to lacking defition for a struct. I'll add that to v2.
Em Mon, 21 Nov 2016 15:51:56 +0200 Sakari Ailus <sakari.ailus@linux.intel.com> escreveu: > Hi Mauro, > > On 11/21/16 15:33, Mauro Carvalho Chehab wrote: > > Em Thu, 27 Oct 2016 13:50:51 +0300 > > Sakari Ailus <sakari.ailus@linux.intel.com> escreveu: > > > >> struct timeval and struct timespec are defined in linux/time.h. Explicitly > >> include the header if __KERNEL__ is defined. > > > > The patch below doesn't do what you're mentioned above. It unconditionally > > include linux/time.h, and, for userspace, it will *also* include > > sys/time.h... > > My bad... I thought writing a single line patch would be easy. ;-) Will fix. > > > > > I suspect that this would cause problems on userspace. > > > > Btw, you didn't mention on your description what's the bug you're > > trying to fix. > > The problem is a compiler error due to lacking defition for a struct. > I'll add that to v2. On userspace or Kernelspace? Please be clear at version 2, adding the relevant info about how you got it. Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 4364ce6..bbab50c 100644 --- a/include/uapi/linux/videodev2.h +++ b/include/uapi/linux/videodev2.h @@ -61,6 +61,7 @@ #endif #include <linux/compiler.h> #include <linux/ioctl.h> +#include <linux/time.h> #include <linux/types.h> #include <linux/v4l2-common.h> #include <linux/v4l2-controls.h>
struct timeval and struct timespec are defined in linux/time.h. Explicitly include the header if __KERNEL__ is defined. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- include/uapi/linux/videodev2.h | 1 + 1 file changed, 1 insertion(+)