diff mbox

[v3,8/9] media: venus: add Makefiles and Kconfig files

Message ID 1478540043-24558-9-git-send-email-stanimir.varbanov@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Stanimir Varbanov Nov. 7, 2016, 5:34 p.m. UTC
Makefile and Kconfig files to build the Venus video codec driver.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
---
 drivers/media/platform/qcom/Kconfig        |  7 +++++++
 drivers/media/platform/qcom/Makefile       |  1 +
 drivers/media/platform/qcom/venus/Makefile | 15 +++++++++++++++
 3 files changed, 23 insertions(+)
 create mode 100644 drivers/media/platform/qcom/Kconfig
 create mode 100644 drivers/media/platform/qcom/Makefile
 create mode 100644 drivers/media/platform/qcom/venus/Makefile

Comments

Stephen Boyd Nov. 10, 2016, 2:04 a.m. UTC | #1
On 11/07, Stanimir Varbanov wrote:
> diff --git a/drivers/media/platform/qcom/Kconfig b/drivers/media/platform/qcom/Kconfig
> new file mode 100644
> index 000000000000..bf4d2fcce924
> --- /dev/null
> +++ b/drivers/media/platform/qcom/Kconfig
> @@ -0,0 +1,7 @@
> +
> +menuconfig VIDEO_QCOM_VENUS
> +        tristate "Qualcomm Venus V4L2 encoder/decoder driver"
> +        depends on ARCH_QCOM && VIDEO_V4L2
> +        depends on IOMMU_DMA
> +        depends on QCOM_VENUS_PIL
> +        select VIDEOBUF2_DMA_SG

Can this have some help text?
Vivek Gautam Nov. 11, 2016, 6:12 a.m. UTC | #2
On Mon, Nov 7, 2016 at 11:04 PM, Stanimir Varbanov
<stanimir.varbanov@linaro.org> wrote:
> Makefile and Kconfig files to build the Venus video codec driver.
>
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> ---
>  drivers/media/platform/qcom/Kconfig        |  7 +++++++
>  drivers/media/platform/qcom/Makefile       |  1 +
>  drivers/media/platform/qcom/venus/Makefile | 15 +++++++++++++++
>  3 files changed, 23 insertions(+)
>  create mode 100644 drivers/media/platform/qcom/Kconfig
>  create mode 100644 drivers/media/platform/qcom/Makefile
>  create mode 100644 drivers/media/platform/qcom/venus/Makefile
>
> diff --git a/drivers/media/platform/qcom/Kconfig b/drivers/media/platform/qcom/Kconfig
> new file mode 100644
> index 000000000000..bf4d2fcce924
> --- /dev/null
> +++ b/drivers/media/platform/qcom/Kconfig
> @@ -0,0 +1,7 @@
> +
> +menuconfig VIDEO_QCOM_VENUS
> +        tristate "Qualcomm Venus V4L2 encoder/decoder driver"
> +        depends on ARCH_QCOM && VIDEO_V4L2

Let's also enable this for COMPILE_TEST.


Thanks
Vivek
Stanimir Varbanov Nov. 11, 2016, 9:07 a.m. UTC | #3
Hi Vivek,

On 11/11/2016 08:12 AM, Vivek Gautam wrote:
> On Mon, Nov 7, 2016 at 11:04 PM, Stanimir Varbanov
> <stanimir.varbanov@linaro.org> wrote:
>> Makefile and Kconfig files to build the Venus video codec driver.
>>
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>> ---
>>  drivers/media/platform/qcom/Kconfig        |  7 +++++++
>>  drivers/media/platform/qcom/Makefile       |  1 +
>>  drivers/media/platform/qcom/venus/Makefile | 15 +++++++++++++++
>>  3 files changed, 23 insertions(+)
>>  create mode 100644 drivers/media/platform/qcom/Kconfig
>>  create mode 100644 drivers/media/platform/qcom/Makefile
>>  create mode 100644 drivers/media/platform/qcom/venus/Makefile
>>
>> diff --git a/drivers/media/platform/qcom/Kconfig b/drivers/media/platform/qcom/Kconfig
>> new file mode 100644
>> index 000000000000..bf4d2fcce924
>> --- /dev/null
>> +++ b/drivers/media/platform/qcom/Kconfig
>> @@ -0,0 +1,7 @@
>> +
>> +menuconfig VIDEO_QCOM_VENUS
>> +        tristate "Qualcomm Venus V4L2 encoder/decoder driver"
>> +        depends on ARCH_QCOM && VIDEO_V4L2
> 
> Let's also enable this for COMPILE_TEST.

I agree, but it needs changes in other dependency drivers like qcom_scm
one. I will try to come out with something in the next version.
Vivek Gautam Nov. 11, 2016, 9:45 a.m. UTC | #4
Hi Stan,

On Fri, Nov 11, 2016 at 2:37 PM, Stanimir Varbanov
<stanimir.varbanov@linaro.org> wrote:
> Hi Vivek,
>
> On 11/11/2016 08:12 AM, Vivek Gautam wrote:
>> On Mon, Nov 7, 2016 at 11:04 PM, Stanimir Varbanov
>> <stanimir.varbanov@linaro.org> wrote:
>>> Makefile and Kconfig files to build the Venus video codec driver.
>>>
>>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>>> ---
>>>  drivers/media/platform/qcom/Kconfig        |  7 +++++++
>>>  drivers/media/platform/qcom/Makefile       |  1 +
>>>  drivers/media/platform/qcom/venus/Makefile | 15 +++++++++++++++
>>>  3 files changed, 23 insertions(+)
>>>  create mode 100644 drivers/media/platform/qcom/Kconfig
>>>  create mode 100644 drivers/media/platform/qcom/Makefile
>>>  create mode 100644 drivers/media/platform/qcom/venus/Makefile
>>>
>>> diff --git a/drivers/media/platform/qcom/Kconfig b/drivers/media/platform/qcom/Kconfig
>>> new file mode 100644
>>> index 000000000000..bf4d2fcce924
>>> --- /dev/null
>>> +++ b/drivers/media/platform/qcom/Kconfig
>>> @@ -0,0 +1,7 @@
>>> +
>>> +menuconfig VIDEO_QCOM_VENUS
>>> +        tristate "Qualcomm Venus V4L2 encoder/decoder driver"
>>> +        depends on ARCH_QCOM && VIDEO_V4L2
>>
>> Let's also enable this for COMPILE_TEST.
>
> I agree, but it needs changes in other dependency drivers like qcom_scm
> one. I will try to come out with something in the next version.

Sure, let's see if there's a possibility. Else, we may have to revisit
this at a later point.
Thanks.


Regards
Vivek
diff mbox

Patch

diff --git a/drivers/media/platform/qcom/Kconfig b/drivers/media/platform/qcom/Kconfig
new file mode 100644
index 000000000000..bf4d2fcce924
--- /dev/null
+++ b/drivers/media/platform/qcom/Kconfig
@@ -0,0 +1,7 @@ 
+
+menuconfig VIDEO_QCOM_VENUS
+        tristate "Qualcomm Venus V4L2 encoder/decoder driver"
+        depends on ARCH_QCOM && VIDEO_V4L2
+        depends on IOMMU_DMA
+        depends on QCOM_VENUS_PIL
+        select VIDEOBUF2_DMA_SG
diff --git a/drivers/media/platform/qcom/Makefile b/drivers/media/platform/qcom/Makefile
new file mode 100644
index 000000000000..347c6c71c189
--- /dev/null
+++ b/drivers/media/platform/qcom/Makefile
@@ -0,0 +1 @@ 
+obj-$(CONFIG_VIDEO_QCOM_VENUS)     += venus/
diff --git a/drivers/media/platform/qcom/venus/Makefile b/drivers/media/platform/qcom/venus/Makefile
new file mode 100644
index 000000000000..b6c486be386c
--- /dev/null
+++ b/drivers/media/platform/qcom/venus/Makefile
@@ -0,0 +1,15 @@ 
+# Makefile for Qualcomm Venus driver
+
+venus-objs += \
+		core.o \
+		helpers.o \
+		vdec.o \
+		vdec_ctrls.o \
+		venc.o \
+		venc_ctrls.o \
+		hfi_venus.o \
+		hfi_msgs.o \
+		hfi_cmds.o \
+		hfi.o \
+
+obj-$(CONFIG_VIDEO_QCOM_VENUS) += venus.o