From patchwork Mon Dec 12 11:46:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Young X-Patchwork-Id: 9470499 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7EF9D60476 for ; Mon, 12 Dec 2016 11:46:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 733CD2846A for ; Mon, 12 Dec 2016 11:46:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 682DD28477; Mon, 12 Dec 2016 11:46:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E4B9C2846A for ; Mon, 12 Dec 2016 11:46:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752184AbcLLLqt (ORCPT ); Mon, 12 Dec 2016 06:46:49 -0500 Received: from gofer.mess.org ([80.229.237.210]:59811 "EHLO gofer.mess.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752135AbcLLLqs (ORCPT ); Mon, 12 Dec 2016 06:46:48 -0500 Received: by gofer.mess.org (Postfix, from userid 1000) id B79BF6015D; Mon, 12 Dec 2016 11:46:46 +0000 (GMT) From: Sean Young To: linux-media@vger.kernel.org Subject: [PATCH v4l-utils] ir-ctl: rc5 command 6th bit missing Date: Mon, 12 Dec 2016 11:46:46 +0000 Message-Id: <1481543206-8696-1-git-send-email-sean@mess.org> X-Mailer: git-send-email 2.1.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is called extended rc5, not be confused with rc5x_20. Signed-off-by: Sean Young --- utils/ir-ctl/ir-encode.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/utils/ir-ctl/ir-encode.c b/utils/ir-ctl/ir-encode.c index 9cc8c5d..3863779 100644 --- a/utils/ir-ctl/ir-encode.c +++ b/utils/ir-ctl/ir-encode.c @@ -250,7 +250,8 @@ static int rc5_encode(enum rc_proto proto, unsigned scancode, unsigned *buf) default: return 0; case RC_PROTO_RC5: - add_bits(2, 2); + add_bits(!(scancode & 0x40), 1); + add_bits(0, 1); add_bits(scancode >> 8, 5); add_bits(scancode, 6); break; @@ -349,7 +350,7 @@ static const struct { unsigned carrier; int (*encode)(enum rc_proto proto, unsigned scancode, unsigned *buf); } encoders[RC_PROTO_COUNT] = { - [RC_PROTO_RC5] = { "rc5", 0x1f3f, 24, 36000, rc5_encode }, + [RC_PROTO_RC5] = { "rc5", 0x1f7f, 24, 36000, rc5_encode }, [RC_PROTO_RC5X_20] = { "rc5x_20", 0x1f7f3f, 40, 36000, rc5_encode }, [RC_PROTO_RC5_SZ] = { "rc5_sz", 0x2fff, 26, 36000, rc5_encode }, [RC_PROTO_SONY12] = { "sony12", 0x1f007f, 25, 40000, sony_encode },