From patchwork Sat Jan 21 09:37:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhumika Goyal X-Patchwork-Id: 9530197 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D4DEF600CA for ; Sat, 21 Jan 2017 09:37:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CDE522856A for ; Sat, 21 Jan 2017 09:37:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C24632864A; Sat, 21 Jan 2017 09:37:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 668E52856A for ; Sat, 21 Jan 2017 09:37:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751017AbdAUJhh (ORCPT ); Sat, 21 Jan 2017 04:37:37 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34658 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750886AbdAUJhh (ORCPT ); Sat, 21 Jan 2017 04:37:37 -0500 Received: by mail-pg0-f66.google.com with SMTP id t6so8943359pgt.1; Sat, 21 Jan 2017 01:37:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ybXy97laaVXcHO4d2Oma7YxNb0oicC4svBVA3Z57714=; b=MQui1DJO8gamMHjbbeeN0MVtIiiFJaTh4pcfhLrvM2B88dzXtStKnTAC56CdAP+4y5 E5og2C8pLBDWBl8eWazNRBsnHnNnaDqBLuPMiK2Cl52TxjeGR/RouESi5sDodz13qm1L Fo7XY6DFD1/wr9TaPkY1el8HjDE5x8DO0+x8GUr7akc6JMNl2qTAVPi7w/C0f24jJdWH lLiMl+HQtUWj4TnQ++7XVmo9vbNZtdnYwMvEHe7xy5YnO5DrY4tuAkajrlADuJmKVWRW 98wgsB03qgr6y4I0wc3mfH3xS60X/BQGz5xH09EUfcLDOG+uBLMMgXzgLjtK+GaD3rJq CrqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ybXy97laaVXcHO4d2Oma7YxNb0oicC4svBVA3Z57714=; b=YJutKnyrUTLz9kZCXYAjEB8DxR2ECy5bSwN8IdrBOOHgiD0RmRqLLv21//GvbN1GkY 4WOwoUMafV2CpWoqhifo682f4QT3mZDyZzdFzts1IstP/SfUYlR9NjvCU4+7JKo9rVkA lZ6kbxG9nHHD3NQGJJzIHrX+dxUulgYkINBSKXv06IZ+SidTmsWRS7sz9iQllWATGgKV LqBB5PxGyhBWPfgMQw2+gfc7GkmX8/C6HVzsydnKLQuipObUYn1jUXiT5dKCqd/xLC2p 1fgDWYgh5OrDQg9kscOLK5rsP90/iew4DJpfMzVpn1zwj4An3e/uhYlUZ6rEiHhZzoQD WZAQ== X-Gm-Message-State: AIkVDXKcFdQ05HzMIVerAHaAJAl3/+hKh6DK79JsWCK5sASz6Lo1Cn1lqessLdb6R6RJ3A== X-Received: by 10.99.178.89 with SMTP id t25mr21931176pgo.183.1484991456599; Sat, 21 Jan 2017 01:37:36 -0800 (PST) Received: from gmail.com ([2405:204:5003:fc89:8da0:9234:d099:4cc7]) by smtp.gmail.com with ESMTPSA id x16sm22540524pfk.79.2017.01.21.01.37.32 (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 21 Jan 2017 01:37:35 -0800 (PST) Received: by gmail.com (sSMTP sendmail emulation); Sat, 21 Jan 2017 15:07:29 +0530 From: Bhumika Goyal To: julia.lawall@lip6.fr, mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bhumika Goyal Subject: [PATCH] media: pci: constify vb2_ops structure Date: Sat, 21 Jan 2017 15:07:25 +0530 Message-Id: <1484991445-17253-1-git-send-email-bhumirks@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Declare vb2_ops structure as const as it is only stored in the ops field of a vb2_queue structure. This field is of type const, so vb2_ops structures having same properties can be made const too. Done using Coccinelle: @r1 disable optional_qualifier@ identifier i; position p; @@ static struct vb2_ops i@p={...}; @ok1@ identifier r1.i; position p; struct sta2x11_vip vip; struct vb2_queue q; @@ ( vip.vb_vidq.ops=&i@p | q.ops=&i@p ) @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct vb2_ops i; File size before: text data bss dec hex filename 8448 440 0 8888 22b8 media/pci/sta2x11/sta2x11_vip.o File size after: text data bss dec hex filename 8552 352 0 8904 22c8 media/pci/sta2x11/sta2x11_vip.o Signed-off-by: Bhumika Goyal --- drivers/media/pci/sta2x11/sta2x11_vip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/sta2x11/sta2x11_vip.c b/drivers/media/pci/sta2x11/sta2x11_vip.c index aeb2b4e..6343d24 100644 --- a/drivers/media/pci/sta2x11/sta2x11_vip.c +++ b/drivers/media/pci/sta2x11/sta2x11_vip.c @@ -377,7 +377,7 @@ static void stop_streaming(struct vb2_queue *vq) spin_unlock(&vip->lock); } -static struct vb2_ops vip_video_qops = { +static const struct vb2_ops vip_video_qops = { .queue_setup = queue_setup, .buf_init = buffer_init, .buf_prepare = buffer_prepare,