| Message ID | 1490771548-6134-1-git-send-email-haimdaniel@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Mar 29, 2017 at 10:12:28AM +0300, Haim Daniel wrote: > isp_capture_defs.h: What is this line for? > fix checkpatch ERROR: Trailing whitespace? > Macros with complex values should be enclosed in parentheses > > Signed-off-by: Haim Daniel <haimdaniel@gmail.com> > --- > .../pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h > index aa413df..78cbbf6 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h > +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h > @@ -19,7 +19,7 @@ > #define _ISP_CAPTURE_BITS_PER_ELEM 32 /* only for data, not SOP */ > #define _ISP_CAPTURE_BYTES_PER_ELEM (_ISP_CAPTURE_BITS_PER_ELEM/8 ) > #define _ISP_CAPTURE_BYTES_PER_WORD 32 /* 256/8 */ > -#define _ISP_CAPTURE_ELEM_PER_WORD _ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM > +#define _ISP_CAPTURE_ELEM_PER_WORD (_ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM) Does this change really make sense? Why keep the trailing whitespace if you touch the line? thanks, greg k-h
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h index aa413df..78cbbf6 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h @@ -19,7 +19,7 @@ #define _ISP_CAPTURE_BITS_PER_ELEM 32 /* only for data, not SOP */ #define _ISP_CAPTURE_BYTES_PER_ELEM (_ISP_CAPTURE_BITS_PER_ELEM/8 ) #define _ISP_CAPTURE_BYTES_PER_WORD 32 /* 256/8 */ -#define _ISP_CAPTURE_ELEM_PER_WORD _ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM +#define _ISP_CAPTURE_ELEM_PER_WORD (_ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM) //#define CAPT_RCV_ACK 1 //#define CAPT_WRT_ACK 2
isp_capture_defs.h: fix checkpatch ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by: Haim Daniel <haimdaniel@gmail.com> --- .../pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)