From patchwork Mon May 1 16:10:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?RGF2aWQgSMODwqRyZGVtYW4=?= X-Patchwork-Id: 9706701 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B4620602B5 for ; Mon, 1 May 2017 16:10:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A62A3223B2 for ; Mon, 1 May 2017 16:10:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9B17D280FC; Mon, 1 May 2017 16:10:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 39734223B2 for ; Mon, 1 May 2017 16:10:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932715AbdEAQKK (ORCPT ); Mon, 1 May 2017 12:10:10 -0400 Received: from vader.hardeman.nu ([95.142.160.32]:41411 "EHLO hardeman.nu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932069AbdEAQKI (ORCPT ); Mon, 1 May 2017 12:10:08 -0400 Received: from hardeman.nu (zeus.hardeman.nu [IPv6:fd27:2a41:8fcb:2::a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by vader.hardeman.nu (Postfix) with ESMTPSA id 705AC436B; Mon, 1 May 2017 18:10:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hardeman.nu; s=hardeman-201704; t=1493655007; bh=M2YA2++XD7sWOXwNPPJO+yMz/0sBFa8hSCyVtvUmzY0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=UX5zw5Y5kF3JVEwXt160c4q2nhQ/46Dn5mCyW3VKnAY8i8KSbyvZ3YB275j3MxY9m tYyYdvCaW1/6i6ExM1qTpoi6tYkXgZS3azT29mQF1Ej4Pz23s8AFyHwzo/hWB/F8mC 6bApWYCSJ0ntle8HS2ksHo8mlpxC7/Qfmbhi8Olnu/oePu/5fVrVLftyBjJjEHYB+A 7etQQG7qE1wO10jk2SNKn3Po+SHX8XbGd4PhFxoef7dp/VSqlAU1j16aLGMWVn6Gfr 6p5jNNBI1eca13IKUE5RV96P/EnD/1aIlA6lKa/GNUEI9gDz4jqC9Khd0WfvMcASFI uglI3ufUTak1w== Received: (nullmailer pid 13654 invoked by uid 1000); Mon, 01 May 2017 16:10:06 -0000 Subject: [PATCH 3/7] rc-core: img-nec-decoder - leave the internals of rc_dev alone From: David =?utf-8?b?SMOkcmRlbWFu?= To: linux-media@vger.kernel.org Cc: mchehab@s-opensource.com, sean@mess.org Date: Mon, 01 May 2017 18:10:06 +0200 Message-ID: <149365500692.13489.9572857464621441673.stgit@zeus.hardeman.nu> In-Reply-To: <149365487447.13489.15793446874818182829.stgit@zeus.hardeman.nu> References: <149365487447.13489.15793446874818182829.stgit@zeus.hardeman.nu> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Obvious fix, leave repeat handling to rc-core Signed-off-by: David Härdeman --- drivers/media/rc/ir-nec-decoder.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/media/rc/ir-nec-decoder.c b/drivers/media/rc/ir-nec-decoder.c index 3ce850314dca..75b9137f6faf 100644 --- a/drivers/media/rc/ir-nec-decoder.c +++ b/drivers/media/rc/ir-nec-decoder.c @@ -88,13 +88,9 @@ static int ir_nec_decode(struct rc_dev *dev, struct ir_raw_event ev) data->state = STATE_BIT_PULSE; return 0; } else if (eq_margin(ev.duration, NEC_REPEAT_SPACE, NEC_UNIT / 2)) { - if (!dev->keypressed) { - IR_dprintk(1, "Discarding last key repeat: event after key up\n"); - } else { - rc_repeat(dev); - IR_dprintk(1, "Repeat last key\n"); - data->state = STATE_TRAILER_PULSE; - } + rc_repeat(dev); + IR_dprintk(1, "Repeat last key\n"); + data->state = STATE_TRAILER_PULSE; return 0; }