ov5670: Add Omnivision OV5670 5M sensor support

Commit Message

Chiranjeevi Rapolu May 3, 2017, 10:06 p.m. UTC

Provides single source pad with up to 2576x1936 pixels at 10-bit raw
bayer format over MIPI CSI2 two lanes at 640Mbps/lane.
Supports up to 30fps at 5M pixels, up to 60fps at 1080p.

Signed-off-by: Chiranjeevi Rapolu <[e-mail]>
---
 drivers/media/i2c/Kconfig  |   11 +
 drivers/media/i2c/Makefile |    1 +
 drivers/media/i2c/ov5670.c | 3890 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 3902 insertions(+)
 create mode 100644 drivers/media/i2c/ov5670.c

Comments

Sakari Ailus May 4, 2017, 8:48 a.m. UTC | #1

Hi Chiranjeevi,

Thanks for the patch.

On Wed, May 03, 2017 at 03:06:52PM -0700, Chiranjeevi Rapolu wrote:
> Provides single source pad with up to 2576x1936 pixels at 10-bit raw
> bayer format over MIPI CSI2 two lanes at 640Mbps/lane.
> Supports up to 30fps at 5M pixels, up to 60fps at 1080p.
> 
> Signed-off-by: Chiranjeevi Rapolu <[e-mail]>
> ---
>  drivers/media/i2c/Kconfig  |   11 +
>  drivers/media/i2c/Makefile |    1 +
>  drivers/media/i2c/ov5670.c | 3890 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 3902 insertions(+)
>  create mode 100644 drivers/media/i2c/ov5670.c
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index cee1dae..ded8485 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -531,6 +531,17 @@ config VIDEO_OV2659
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called ov2659.
>  
> +config VIDEO_OV5670
> +	tristate "OmniVision OV5670 sensor support"
> +	depends on I2C && VIDEO_V4L2
> +	depends on MEDIA_CAMERA_SUPPORT
> +	---help---
> +	  This is a Video4Linux2 sensor-level driver for the OmniVision
> +	  OV5670 camera.
> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called ov5670.
> +
>  config VIDEO_OV7640
>  	tristate "OmniVision OV7640 sensor support"
>  	depends on I2C && VIDEO_V4L2
> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> index 5bc7bbe..3efc61f 100644
> --- a/drivers/media/i2c/Makefile
> +++ b/drivers/media/i2c/Makefile
> @@ -57,6 +57,7 @@ obj-$(CONFIG_VIDEO_VP27SMPX) += vp27smpx.o
>  obj-$(CONFIG_VIDEO_SONY_BTF_MPX) += sony-btf-mpx.o
>  obj-$(CONFIG_VIDEO_UPD64031A) += upd64031a.o
>  obj-$(CONFIG_VIDEO_UPD64083) += upd64083.o
> +obj-$(CONFIG_VIDEO_OV5670) += ov5670.o

The patch no longer applies cleanly to current media-tree master. Could you
rebase it on top of that?

>  obj-$(CONFIG_VIDEO_OV7640) += ov7640.o
>  obj-$(CONFIG_VIDEO_OV7670) += ov7670.o
>  obj-$(CONFIG_VIDEO_OV9650) += ov9650.o
> diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c
> new file mode 100644
> index 0000000..394f8f2
> --- /dev/null
> +++ b/drivers/media/i2c/ov5670.c
> @@ -0,0 +1,3890 @@
> +/*
> + * Copyright (c) 2017 Intel Corporation.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License version
> + * 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + */
> +
> +#include <linux/acpi.h>
> +#include <linux/delay.h>

Do you need delay.h?

> +#include <linux/i2c.h>
> +#include <linux/module.h>
> +#include <media/v4l2-device.h>
> +#include <media/v4l2-ctrls.h>

Alphabetical order, please.

> +
> +#define OV5670_CHIP_ID			0x005670
> +
> +#define OV5670_REG_VALUE_08BIT		1
> +#define OV5670_REG_VALUE_16BIT		2
> +#define OV5670_REG_VALUE_24BIT		3
> +
> +#define OV5670_REG_MODE_SELECT		0x0100
> +#define OV5670_MODE_STANDBY		0x00
> +#define OV5670_MODE_STREAMING		0x01
> +
> +#define OV5670_REG_SOFTWARE_RST		0x0103
> +#define OV5670_SOFTWARE_RST		0x01
> +
> +#define OV5670_REG_EXPOSURE		0x3500
> +#define OV5670_REG_ANALOG_GAIN		0x3508
> +
> +#define OV5670_REG_CHIPID		0x300a
> +
> +/* Supported link frequencies */
> +#define OV5670_LINK_FREQ_840MBPS		840000000
> +#define OV5670_LINK_FREQ_840MBPS_INDEX		0

It'd be better to define these there you have the related register lists.

> +
> +/* Analog gain controls from sensor */
> +#define	ANALOG_GAIN_MIN		0
> +#define	ANALOG_GAIN_MAX		8191
> +#define	ANALOG_GAIN_STEP	1
> +#define	ANALOG_GAIN_DEFAULT	128
> +
> +/* Exposure controls from sensor */
> +#define	EXPOSURE_MIN		0
> +#define	EXPOSURE_MAX		1048575
> +#define	EXPOSURE_STEP		1
> +#define	EXPOSURE_DEFAULT	47232

Are these values dependent on sensor configuration i.e. in the case of this
driver modes?

> +
> +struct ov5670_reg {
> +	u16 address;
> +	u8 val;
> +};
> +
> +struct ov5670_reg_list {
> +	u32 num_of_regs;
> +	const struct ov5670_reg *regs;
> +};
> +
> +struct ov5670_link_freq_config {
> +	s64 link_freq;
> +	u32 pixel_rate;
> +
> +	const struct ov5670_reg_list reg_list;
> +};
> +
> +struct ov5670_mode {
> +	/* Frame width in pixels */
> +	u32 width;
> +
> +	/* Frame height in pixels */
> +	u32 height;
> +
> +	/* Initial number of frames to skip to avoid garbage in the frames */
> +	u32 skip_frames;
> +
> +	/* Link frequency needed for this resolution */
> +	u32 link_freq_index;
> +
> +	/* Sensor register settings for this resolution */
> +	const struct ov5670_reg_list reg_list;
> +};
> +
> +static const struct ov5670_reg mipi_data_rate_840mbps[] = {
> +	{0x0300, 0x04},
> +	{0x0301, 0x00},
> +	{0x0302, 0x84},
> +	{0x0303, 0x00},
> +	{0x0304, 0x03},
> +	{0x0305, 0x01},
> +	{0x0306, 0x01},
> +	{0x030a, 0x00},
> +	{0x030b, 0x00},
> +	{0x030c, 0x00},
> +	{0x030d, 0x26},
> +	{0x030e, 0x00},
> +	{0x030f, 0x06},
> +	{0x0312, 0x01},
> +	{0x3031, 0x0a},
> +};
> +
> +static const struct ov5670_reg mode_640x480_regs[] = {
> +	{0x3000, 0x00},
> +	{0x3002, 0x61},
> +	{0x3005, 0xf0},
> +	{0x3007, 0x00},
> +	{0x300D, 0x00},
> +	{0x3015, 0x0f},
> +	{0x3018, 0x32},
> +	{0x3010, 0x40},
> +	{0x301a, 0xf0},
> +	{0x301b, 0xf0},
> +	{0x301c, 0xf0},
> +	{0x301d, 0xf0},
> +	{0x301e, 0xf0},
> +	{0x3030, 0x00},
> +	{0x303c, 0xff},
> +	{0x303e, 0xff},
> +	{0x3040, 0xf0},
> +	{0x3041, 0x00},
> +	{0x3042, 0xf0},
> +	{0x3106, 0x11},
> +	{0x3500, 0x00},
> +	{0x3501, 0xb8},
> +	{0x3502, 0x80},
> +	{0x3503, 0x00},
> +	{0x3504, 0x03},
> +	{0x3505, 0x83},
> +	{0x3508, 0x04},
> +	{0x3509, 0x00},
> +	{0x350e, 0x04},
> +	{0x350f, 0x00},
> +	{0x3510, 0x00},
> +	{0x3511, 0x02},
> +	{0x3512, 0x00},
> +	{0x3601, 0xc8},
> +	{0x3610, 0x88},
> +	{0x3612, 0x48},
> +	{0x3614, 0x5b},
> +	{0x3615, 0x96},
> +	{0x3621, 0xd0},
> +	{0x3622, 0x00},
> +	{0x3623, 0x04},
> +	{0x3633, 0x13},
> +	{0x3634, 0x13},
> +	{0x3635, 0x13},
> +	{0x3636, 0x13},
> +	{0x3645, 0x13},
> +	{0x3646, 0x82},
> +	{0x3650, 0x00},
> +	{0x3652, 0xff},
> +	{0x3655, 0x20},
> +	{0x3656, 0xff},
> +	{0x365a, 0xff},
> +	{0x365e, 0xff},
> +	{0x3668, 0x00},
> +	{0x366a, 0x07},
> +	{0x366e, 0x08},
> +	{0x366d, 0x00},
> +	{0x366f, 0x80},
> +	{0x3700, 0x28},
> +	{0x3701, 0x10},
> +	{0x3702, 0x3a},
> +	{0x3703, 0x19},
> +	{0x3704, 0x10},
> +	{0x3705, 0x00},
> +	{0x3706, 0x66},
> +	{0x3707, 0x08},
> +	{0x3708, 0x34},
> +	{0x3709, 0x40},
> +	{0x370a, 0x01},
> +	{0x370b, 0x1b},
> +	{0x3714, 0x24},
> +	{0x371a, 0x3e},
> +	{0x3733, 0x00},
> +	{0x3734, 0x00},
> +	{0x373a, 0x05},
> +	{0x373b, 0x06},
> +	{0x373c, 0x0a},
> +	{0x373f, 0xa0},
> +	{0x3755, 0x00},
> +	{0x3758, 0x00},
> +	{0x375b, 0x0e},
> +	{0x3766, 0x5f},
> +	{0x3768, 0x00},
> +	{0x3769, 0x22},
> +	{0x3773, 0x08},
> +	{0x3774, 0x1f},
> +	{0x3776, 0x06},
> +	{0x37a0, 0x88},
> +	{0x37a1, 0x5c},
> +	{0x37a7, 0x88},
> +	{0x37a8, 0x70},
> +	{0x37aa, 0x88},
> +	{0x37ab, 0x48},
> +	{0x37b3, 0x66},
> +	{0x37c2, 0x04},
> +	{0x37c5, 0x00},
> +	{0x37c8, 0x00},
> +	{0x3800, 0x00},
> +	{0x3801, 0x0c},
> +	{0x3802, 0x00},
> +	{0x3803, 0x04},
> +	{0x3804, 0x0a},
> +	{0x3805, 0x33},
> +	{0x3806, 0x07},
> +	{0x3807, 0xa3},
> +	{0x3808, 0x02},
> +	{0x3809, 0x80},
> +	{0x380a, 0x01},
> +	{0x380b, 0xe0},
> +	{0x380c, 0x06},
> +	{0x380d, 0xa8},
> +	{0x380e, 0x07},
> +	{0x380f, 0xf6},
> +	{0x3811, 0x04},
> +	{0x3813, 0x02},
> +	{0x3814, 0x07},
> +	{0x3815, 0x01},
> +	{0x3816, 0x00},
> +	{0x3817, 0x00},
> +	{0x3818, 0x00},
> +	{0x3819, 0x00},
> +	{0x3820, 0x94},
> +	{0x3821, 0xc0},
> +	{0x3822, 0x48},
> +	{0x3826, 0x00},
> +	{0x3827, 0x08},
> +	{0x382a, 0x07},
> +	{0x382b, 0x01},
> +	{0x3830, 0x08},
> +	{0x3836, 0x02},
> +	{0x3837, 0x00},
> +	{0x3838, 0x10},
> +	{0x3841, 0xff},
> +	{0x3846, 0x48},
> +	{0x3861, 0x00},
> +	{0x3862, 0x04},
> +	{0x3863, 0x06},
> +	{0x3a11, 0x01},
> +	{0x3a12, 0x78},
> +	{0x3b00, 0x00},
> +	{0x3b02, 0x00},
> +	{0x3b03, 0x00},
> +	{0x3b04, 0x00},
> +	{0x3b05, 0x00},
> +	{0x3c00, 0x89},
> +	{0x3c01, 0xab},
> +	{0x3c02, 0x01},
> +	{0x3c03, 0x00},
> +	{0x3c04, 0x00},
> +	{0x3c05, 0x03},
> +	{0x3c06, 0x00},
> +	{0x3c07, 0x05},
> +	{0x3c0c, 0x00},
> +	{0x3c0d, 0x00},
> +	{0x3c0e, 0x00},
> +	{0x3c0f, 0x00},
> +	{0x3c40, 0x00},
> +	{0x3c41, 0xa3},
> +	{0x3c43, 0x7d},
> +	{0x3c45, 0xd7},
> +	{0x3c47, 0xfc},
> +	{0x3c50, 0x05},
> +	{0x3c52, 0xaa},
> +	{0x3c54, 0x71},
> +	{0x3c56, 0x80},
> +	{0x3d85, 0x17},
> +	{0x3f03, 0x00},
> +	{0x3f0a, 0x00},
> +	{0x3f0b, 0x00},
> +	{0x4001, 0x60},
> +	{0x4009, 0x05},
> +	{0x4020, 0x00},
> +	{0x4021, 0x00},
> +	{0x4022, 0x00},
> +	{0x4023, 0x00},
> +	{0x4024, 0x00},
> +	{0x4025, 0x00},
> +	{0x4026, 0x00},
> +	{0x4027, 0x00},
> +	{0x4028, 0x00},
> +	{0x4029, 0x00},
> +	{0x402a, 0x00},
> +	{0x402b, 0x00},
> +	{0x402c, 0x00},
> +	{0x402d, 0x00},
> +	{0x402e, 0x00},
> +	{0x402f, 0x00},
> +	{0x4040, 0x00},
> +	{0x4041, 0x03},
> +	{0x4042, 0x00},
> +	{0x4043, 0x7A},
> +	{0x4044, 0x00},
> +	{0x4045, 0x7A},
> +	{0x4046, 0x00},
> +	{0x4047, 0x7A},
> +	{0x4048, 0x00},
> +	{0x4049, 0x7A},
> +	{0x4303, 0x00},
> +	{0x4307, 0x30},
> +	{0x4500, 0x58},
> +	{0x4501, 0x04},
> +	{0x4502, 0x40},
> +	{0x4503, 0x10},
> +	{0x4508, 0x55},
> +	{0x4509, 0x55},
> +	{0x450a, 0x02},
> +	{0x450b, 0x00},
> +	{0x4600, 0x00},
> +	{0x4601, 0x40},
> +	{0x4700, 0xa4},
> +	{0x4800, 0x4c},
> +	{0x4816, 0x53},
> +	{0x481f, 0x40},
> +	{0x4837, 0x12},
> +	{0x5000, 0x56},
> +	{0x5001, 0x01},
> +	{0x5002, 0x28},
> +	{0x5004, 0x0c},
> +	{0x5006, 0x0c},
> +	{0x5007, 0xe0},
> +	{0x5008, 0x01},
> +	{0x5009, 0xb0},
> +	{0x5045, 0x05},
> +	{0x5048, 0x10},
> +	{0x5901, 0x00},
> +	{0x5a01, 0x00},
> +	{0x5a03, 0x00},
> +	{0x5a04, 0x0c},
> +	{0x5a05, 0xe0},
> +	{0x5a06, 0x09},
> +	{0x5a07, 0xb0},
> +	{0x5a08, 0x06},
> +	{0x5e00, 0x00},
> +	{0x3734, 0x40},
> +	{0x5b00, 0x01},
> +	{0x5b01, 0x10},
> +	{0x5b02, 0x01},
> +	{0x5b03, 0xdb},
> +	{0x3d8c, 0x71},
> +	{0x3d8d, 0xea},
> +	{0x4017, 0x10},
> +	{0x3618, 0x2a},
> +	{0x5780, 0x3e},
> +	{0x5781, 0x0f},
> +	{0x5782, 0x44},
> +	{0x5783, 0x02},
> +	{0x5784, 0x01},
> +	{0x5785, 0x01},
> +	{0x5786, 0x00},
> +	{0x5787, 0x04},
> +	{0x5788, 0x02},
> +	{0x5789, 0x0f},
> +	{0x578a, 0xfd},
> +	{0x578b, 0xf5},
> +	{0x578c, 0xf5},
> +	{0x578d, 0x03},
> +	{0x578e, 0x08},
> +	{0x578f, 0x0c},
> +	{0x5790, 0x08},
> +	{0x5791, 0x06},
> +	{0x5792, 0x00},
> +	{0x5793, 0x52},
> +	{0x5794, 0xa3},
> +};
> +
> +static const struct ov5670_reg mode_656x496_regs[] = {
> +	{0x3000, 0x00},
> +	{0x3002, 0x61},
> +	{0x3005, 0xf0},
> +	{0x3007, 0x00},
> +	{0x300D, 0x00},
> +	{0x3015, 0x0f},
> +	{0x3018, 0x32},
> +	{0x3010, 0x40},
> +	{0x301a, 0xf0},
> +	{0x301b, 0xf0},
> +	{0x301c, 0xf0},
> +	{0x301d, 0xf0},
> +	{0x301e, 0xf0},
> +	{0x3030, 0x00},
> +	{0x303c, 0xff},
> +	{0x303e, 0xff},
> +	{0x3040, 0xf0},
> +	{0x3041, 0x00},
> +	{0x3042, 0xf0},
> +	{0x3106, 0x11},
> +	{0x3500, 0x00},
> +	{0x3501, 0xb8},
> +	{0x3502, 0x80},
> +	{0x3503, 0x00},
> +	{0x3504, 0x03},
> +	{0x3505, 0x83},
> +	{0x3508, 0x04},
> +	{0x3509, 0x00},
> +	{0x350e, 0x04},
> +	{0x350f, 0x00},
> +	{0x3510, 0x00},
> +	{0x3511, 0x02},
> +	{0x3512, 0x00},
> +	{0x3601, 0xc8},
> +	{0x3610, 0x88},
> +	{0x3612, 0x48},
> +	{0x3614, 0x5b},
> +	{0x3615, 0x96},
> +	{0x3621, 0xd0},
> +	{0x3622, 0x00},
> +	{0x3623, 0x04},
> +	{0x3633, 0x13},
> +	{0x3634, 0x13},
> +	{0x3635, 0x13},
> +	{0x3636, 0x13},
> +	{0x3645, 0x13},
> +	{0x3646, 0x82},
> +	{0x3650, 0x00},
> +	{0x3652, 0xff},
> +	{0x3655, 0x20},
> +	{0x3656, 0xff},
> +	{0x365a, 0xff},
> +	{0x365e, 0xff},
> +	{0x3668, 0x00},
> +	{0x366a, 0x07},
> +	{0x366e, 0x08},
> +	{0x366d, 0x00},
> +	{0x366f, 0x80},
> +	{0x3700, 0x28},
> +	{0x3701, 0x10},
> +	{0x3702, 0x3a},
> +	{0x3703, 0x19},
> +	{0x3704, 0x10},
> +	{0x3705, 0x00},
> +	{0x3706, 0x66},
> +	{0x3707, 0x08},
> +	{0x3708, 0x34},
> +	{0x3709, 0x40},
> +	{0x370a, 0x01},
> +	{0x370b, 0x1b},
> +	{0x3714, 0x24},
> +	{0x371a, 0x3e},
> +	{0x3733, 0x00},
> +	{0x3734, 0x00},
> +	{0x373a, 0x05},
> +	{0x373b, 0x06},
> +	{0x373c, 0x0a},
> +	{0x373f, 0xa0},
> +	{0x3755, 0x00},
> +	{0x3758, 0x00},
> +	{0x375b, 0x0e},
> +	{0x3766, 0x5f},
> +	{0x3768, 0x00},
> +	{0x3769, 0x22},
> +	{0x3773, 0x08},
> +	{0x3774, 0x1f},
> +	{0x3776, 0x06},
> +	{0x37a0, 0x88},
> +	{0x37a1, 0x5c},
> +	{0x37a7, 0x88},
> +	{0x37a8, 0x70},
> +	{0x37aa, 0x88},
> +	{0x37ab, 0x48},
> +	{0x37b3, 0x66},
> +	{0x37c2, 0x04},
> +	{0x37c5, 0x00},
> +	{0x37c8, 0x00},
> +	{0x3800, 0x00},
> +	{0x3801, 0x0c},
> +	{0x3802, 0x00},
> +	{0x3803, 0x04},
> +	{0x3804, 0x0a},
> +	{0x3805, 0x33},
> +	{0x3806, 0x07},
> +	{0x3807, 0xa3},
> +	{0x3808, 0x02},
> +	{0x3809, 0x90},
> +	{0x380a, 0x01},
> +	{0x380b, 0xf0},
> +	{0x380c, 0x06},
> +	{0x380d, 0xa8},
> +	{0x380e, 0x07},
> +	{0x380f, 0xf6},
> +	{0x3811, 0x04},
> +	{0x3813, 0x02},
> +	{0x3814, 0x07},
> +	{0x3815, 0x01},
> +	{0x3816, 0x00},
> +	{0x3817, 0x00},
> +	{0x3818, 0x00},
> +	{0x3819, 0x00},
> +	{0x3820, 0x94},
> +	{0x3821, 0xc0},
> +	{0x3822, 0x48},
> +	{0x3826, 0x00},
> +	{0x3827, 0x08},
> +	{0x382a, 0x07},
> +	{0x382b, 0x01},
> +	{0x3830, 0x08},
> +	{0x3836, 0x02},
> +	{0x3837, 0x00},
> +	{0x3838, 0x10},
> +	{0x3841, 0xff},
> +	{0x3846, 0x48},
> +	{0x3861, 0x00},
> +	{0x3862, 0x04},
> +	{0x3863, 0x06},
> +	{0x3a11, 0x01},
> +	{0x3a12, 0x78},
> +	{0x3b00, 0x00},
> +	{0x3b02, 0x00},
> +	{0x3b03, 0x00},
> +	{0x3b04, 0x00},
> +	{0x3b05, 0x00},
> +	{0x3c00, 0x89},
> +	{0x3c01, 0xab},
> +	{0x3c02, 0x01},
> +	{0x3c03, 0x00},
> +	{0x3c04, 0x00},
> +	{0x3c05, 0x03},
> +	{0x3c06, 0x00},
> +	{0x3c07, 0x05},
> +	{0x3c0c, 0x00},
> +	{0x3c0d, 0x00},
> +	{0x3c0e, 0x00},
> +	{0x3c0f, 0x00},
> +	{0x3c40, 0x00},
> +	{0x3c41, 0xa3},
> +	{0x3c43, 0x7d},
> +	{0x3c45, 0xd7},
> +	{0x3c47, 0xfc},
> +	{0x3c50, 0x05},
> +	{0x3c52, 0xaa},
> +	{0x3c54, 0x71},
> +	{0x3c56, 0x80},
> +	{0x3d85, 0x17},
> +	{0x3f03, 0x00},
> +	{0x3f0a, 0x00},
> +	{0x3f0b, 0x00},
> +	{0x4001, 0x60},
> +	{0x4009, 0x05},
> +	{0x4020, 0x00},
> +	{0x4021, 0x00},
> +	{0x4022, 0x00},
> +	{0x4023, 0x00},
> +	{0x4024, 0x00},
> +	{0x4025, 0x00},
> +	{0x4026, 0x00},
> +	{0x4027, 0x00},
> +	{0x4028, 0x00},
> +	{0x4029, 0x00},
> +	{0x402a, 0x00},
> +	{0x402b, 0x00},
> +	{0x402c, 0x00},
> +	{0x402d, 0x00},
> +	{0x402e, 0x00},
> +	{0x402f, 0x00},
> +	{0x4040, 0x00},
> +	{0x4041, 0x03},
> +	{0x4042, 0x00},
> +	{0x4043, 0x7A},
> +	{0x4044, 0x00},
> +	{0x4045, 0x7A},
> +	{0x4046, 0x00},
> +	{0x4047, 0x7A},
> +	{0x4048, 0x00},
> +	{0x4049, 0x7A},
> +	{0x4303, 0x00},
> +	{0x4307, 0x30},
> +	{0x4500, 0x58},
> +	{0x4501, 0x04},
> +	{0x4502, 0x40},
> +	{0x4503, 0x10},
> +	{0x4508, 0x55},
> +	{0x4509, 0x55},
> +	{0x450a, 0x02},
> +	{0x450b, 0x00},
> +	{0x4600, 0x00},
> +	{0x4601, 0x40},
> +	{0x4700, 0xa4},
> +	{0x4800, 0x4c},
> +	{0x4816, 0x53},
> +	{0x481f, 0x40},
> +	{0x4837, 0x12},
> +	{0x5000, 0x56},
> +	{0x5001, 0x01},
> +	{0x5002, 0x28},
> +	{0x5004, 0x0c},
> +	{0x5006, 0x0c},
> +	{0x5007, 0xe0},
> +	{0x5008, 0x01},
> +	{0x5009, 0xb0},
> +	{0x5045, 0x05},
> +	{0x5048, 0x10},
> +	{0x5901, 0x00},
> +	{0x5a01, 0x00},
> +	{0x5a03, 0x00},
> +	{0x5a04, 0x0c},
> +	{0x5a05, 0xe0},
> +	{0x5a06, 0x09},
> +	{0x5a07, 0xb0},
> +	{0x5a08, 0x06},
> +	{0x5e00, 0x00},
> +	{0x3734, 0x40},
> +	{0x5b00, 0x01},
> +	{0x5b01, 0x10},
> +	{0x5b02, 0x01},
> +	{0x5b03, 0xdb},
> +	{0x3d8c, 0x71},
> +	{0x3d8d, 0xea},
> +	{0x4017, 0x10},
> +	{0x3618, 0x2a},
> +	{0x5780, 0x3e},
> +	{0x5781, 0x0f},
> +	{0x5782, 0x44},
> +	{0x5783, 0x02},
> +	{0x5784, 0x01},
> +	{0x5785, 0x01},
> +	{0x5786, 0x00},
> +	{0x5787, 0x04},
> +	{0x5788, 0x02},
> +	{0x5789, 0x0f},
> +	{0x578a, 0xfd},
> +	{0x578b, 0xf5},
> +	{0x578c, 0xf5},
> +	{0x578d, 0x03},
> +	{0x578e, 0x08},
> +	{0x578f, 0x0c},
> +	{0x5790, 0x08},
> +	{0x5791, 0x06},
> +	{0x5792, 0x00},
> +	{0x5793, 0x52},
> +	{0x5794, 0xa3},
> +};
> +
> +static const struct ov5670_reg mode_1280x720_regs[] = {
> +	{0x3000, 0x00},
> +	{0x3002, 0x61},
> +	{0x3005, 0xf0},
> +	{0x3007, 0x00},
> +	{0x300D, 0x00},
> +	{0x3010, 0x40},
> +	{0x3015, 0x0f},
> +	{0x3018, 0x32},
> +	{0x301a, 0xf0},
> +	{0x301b, 0xf0},
> +	{0x301c, 0xf0},
> +	{0x301d, 0xf0},
> +	{0x301e, 0xf0},
> +	{0x3030, 0x00},
> +	{0x303c, 0xff},
> +	{0x303e, 0xff},
> +	{0x3040, 0xf0},
> +	{0x3041, 0x00},
> +	{0x3042, 0xf0},
> +	{0x3106, 0x11},
> +	{0x3500, 0x00},
> +	{0x3501, 0xb8},
> +	{0x3502, 0x80},
> +	{0x3503, 0x00},
> +	{0x3504, 0x03},
> +	{0x3505, 0x83},
> +	{0x3508, 0x04},
> +	{0x3509, 0x00},
> +	{0x350e, 0x04},
> +	{0x350f, 0x00},
> +	{0x3510, 0x00},
> +	{0x3511, 0x02},
> +	{0x3512, 0x00},
> +	{0x3601, 0xc8},
> +	{0x3610, 0x88},
> +	{0x3612, 0x48},
> +	{0x3614, 0x5b},
> +	{0x3615, 0x96},
> +	{0x3621, 0xd0},
> +	{0x3622, 0x00},
> +	{0x3623, 0x00},
> +	{0x3633, 0x13},
> +	{0x3634, 0x13},
> +	{0x3635, 0x13},
> +	{0x3636, 0x13},
> +	{0x3645, 0x13},
> +	{0x3646, 0x82},
> +	{0x3650, 0x00},
> +	{0x3652, 0xff},
> +	{0x3655, 0x20},
> +	{0x3656, 0xff},
> +	{0x365a, 0xff},
> +	{0x365e, 0xff},
> +	{0x3668, 0x00},
> +	{0x366a, 0x07},
> +	{0x366e, 0x08},
> +	{0x366d, 0x00},
> +	{0x366f, 0x80},
> +	{0x3700, 0x28},
> +	{0x3701, 0x10},
> +	{0x3702, 0x3a},
> +	{0x3703, 0x19},
> +	{0x3704, 0x10},
> +	{0x3705, 0x00},
> +	{0x3706, 0x66},
> +	{0x3707, 0x08},
> +	{0x3708, 0x34},
> +	{0x3709, 0x40},
> +	{0x370a, 0x01},
> +	{0x370b, 0x1b},
> +	{0x3714, 0x24},
> +	{0x371a, 0x3e},
> +	{0x3733, 0x00},
> +	{0x3734, 0x00},
> +	{0x373a, 0x05},
> +	{0x373b, 0x06},
> +	{0x373c, 0x0a},
> +	{0x373f, 0xa0},
> +	{0x3755, 0x00},
> +	{0x3758, 0x00},
> +	{0x375b, 0x0e},
> +	{0x3766, 0x5f},
> +	{0x3768, 0x00},
> +	{0x3769, 0x22},
> +	{0x3773, 0x08},
> +	{0x3774, 0x1f},
> +	{0x3776, 0x06},
> +	{0x37a0, 0x88},
> +	{0x37a1, 0x5c},
> +	{0x37a7, 0x88},
> +	{0x37a8, 0x70},
> +	{0x37aa, 0x88},
> +	{0x37ab, 0x48},
> +	{0x37b3, 0x66},
> +	{0x37c2, 0x04},
> +	{0x37c5, 0x00},
> +	{0x37c8, 0x00},
> +	{0x3800, 0x00},
> +	{0x3801, 0x0c},
> +	{0x3802, 0x00},
> +	{0x3803, 0x04},
> +	{0x3804, 0x0a},
> +	{0x3805, 0x33},
> +	{0x3806, 0x07},
> +	{0x3807, 0xa3},
> +	{0x3808, 0x05},
> +	{0x3809, 0x00},
> +	{0x380a, 0x02},
> +	{0x380b, 0xd0},
> +	{0x380c, 0x06},
> +	{0x380d, 0xa8},
> +	{0x380e, 0x07},
> +	{0x380f, 0xf6},
> +	{0x3811, 0x04},
> +	{0x3813, 0x02},
> +	{0x3814, 0x03},
> +	{0x3815, 0x01},
> +	{0x3816, 0x00},
> +	{0x3817, 0x00},
> +	{0x3818, 0x00},
> +	{0x3819, 0x00},
> +	{0x3820, 0x94},
> +	{0x3821, 0x41},
> +	{0x3822, 0x48},
> +	{0x3826, 0x00},
> +	{0x3827, 0x08},
> +	{0x382a, 0x03},
> +	{0x382b, 0x01},
> +	{0x3830, 0x08},
> +	{0x3836, 0x02},
> +	{0x3837, 0x00},
> +	{0x3838, 0x10},
> +	{0x3841, 0xff},
> +	{0x3846, 0x48},
> +	{0x3861, 0x00},
> +	{0x3862, 0x04},
> +	{0x3863, 0x06},
> +	{0x3a11, 0x01},
> +	{0x3a12, 0x78},
> +	{0x3b00, 0x00},
> +	{0x3b02, 0x00},
> +	{0x3b03, 0x00},
> +	{0x3b04, 0x00},
> +	{0x3b05, 0x00},
> +	{0x3c00, 0x89},
> +	{0x3c01, 0xab},
> +	{0x3c02, 0x01},
> +	{0x3c03, 0x00},
> +	{0x3c04, 0x00},
> +	{0x3c05, 0x03},
> +	{0x3c06, 0x00},
> +	{0x3c07, 0x05},
> +	{0x3c0c, 0x00},
> +	{0x3c0d, 0x00},
> +	{0x3c0e, 0x00},
> +	{0x3c0f, 0x00},
> +	{0x3c40, 0x00},
> +	{0x3c41, 0xa3},
> +	{0x3c43, 0x7d},
> +	{0x3c45, 0xd7},
> +	{0x3c47, 0xfc},
> +	{0x3c50, 0x05},
> +	{0x3c52, 0xaa},
> +	{0x3c54, 0x71},
> +	{0x3c56, 0x80},
> +	{0x3d85, 0x17},
> +	{0x3f03, 0x00},
> +	{0x3f0a, 0x00},
> +	{0x3f0b, 0x00},
> +	{0x4001, 0x60},
> +	{0x4009, 0x05},
> +	{0x4020, 0x00},
> +	{0x4021, 0x00},
> +	{0x4022, 0x00},
> +	{0x4023, 0x00},
> +	{0x4024, 0x00},
> +	{0x4025, 0x00},
> +	{0x4026, 0x00},
> +	{0x4027, 0x00},
> +	{0x4028, 0x00},
> +	{0x4029, 0x00},
> +	{0x402a, 0x00},
> +	{0x402b, 0x00},
> +	{0x402c, 0x00},
> +	{0x402d, 0x00},
> +	{0x402e, 0x00},
> +	{0x402f, 0x00},
> +	{0x4040, 0x00},
> +	{0x4041, 0x03},
> +	{0x4042, 0x00},
> +	{0x4043, 0x7A},
> +	{0x4044, 0x00},
> +	{0x4045, 0x7A},
> +	{0x4046, 0x00},
> +	{0x4047, 0x7A},
> +	{0x4048, 0x00},
> +	{0x4049, 0x7A},
> +	{0x4303, 0x00},
> +	{0x4307, 0x30},
> +	{0x4500, 0x58},
> +	{0x4501, 0x04},
> +	{0x4502, 0x48},
> +	{0x4503, 0x10},
> +	{0x4508, 0x55},
> +	{0x4509, 0x55},
> +	{0x450a, 0x00},
> +	{0x450b, 0x00},
> +	{0x4600, 0x00},
> +	{0x4601, 0x80},
> +	{0x4700, 0xa4},
> +	{0x4800, 0x4c},
> +	{0x4816, 0x53},
> +	{0x481f, 0x40},
> +	{0x4837, 0x12},
> +	{0x5000, 0x56},
> +	{0x5001, 0x01},
> +	{0x5002, 0x28},
> +	{0x5004, 0x0c},
> +	{0x5006, 0x0c},
> +	{0x5007, 0xe0},
> +	{0x5008, 0x01},
> +	{0x5009, 0xb0},
> +	{0x5045, 0x05},
> +	{0x5048, 0x10},
> +	{0x5901, 0x00},
> +	{0x5a01, 0x00},
> +	{0x5a03, 0x00},
> +	{0x5a04, 0x0c},
> +	{0x5a05, 0xe0},
> +	{0x5a06, 0x09},
> +	{0x5a07, 0xb0},
> +	{0x5a08, 0x06},
> +	{0x5e00, 0x00},
> +	{0x3734, 0x40},
> +	{0x5b00, 0x01},
> +	{0x5b01, 0x10},
> +	{0x5b02, 0x01},
> +	{0x5b03, 0xdb},
> +	{0x3d8c, 0x71},
> +	{0x3d8d, 0xea},
> +	{0x4017, 0x10},
> +	{0x3618, 0x2a},
> +	{0x5780, 0x3e},
> +	{0x5781, 0x0f},
> +	{0x5782, 0x44},
> +	{0x5783, 0x02},
> +	{0x5784, 0x01},
> +	{0x5785, 0x01},
> +	{0x5786, 0x00},
> +	{0x5787, 0x04},
> +	{0x5788, 0x02},
> +	{0x5789, 0x0f},
> +	{0x578a, 0xfd},
> +	{0x578b, 0xf5},
> +	{0x578c, 0xf5},
> +	{0x578d, 0x03},
> +	{0x578e, 0x08},
> +	{0x578f, 0x0c},
> +	{0x5790, 0x08},
> +	{0x5791, 0x06},
> +	{0x5792, 0x00},
> +	{0x5793, 0x52},
> +	{0x5794, 0xa3},
> +};
> +
> +static const struct ov5670_reg mode_1296x736_regs[] = {
> +	{0x3000, 0x00},
> +	{0x3002, 0x61},
> +	{0x3005, 0xf0},
> +	{0x3007, 0x00},
> +	{0x300D, 0x00},
> +	{0x3010, 0x40},
> +	{0x3015, 0x0f},
> +	{0x3018, 0x32},
> +	{0x301a, 0xf0},
> +	{0x301b, 0xf0},
> +	{0x301c, 0xf0},
> +	{0x301d, 0xf0},
> +	{0x301e, 0xf0},
> +	{0x3030, 0x00},
> +	{0x303c, 0xff},
> +	{0x303e, 0xff},
> +	{0x3040, 0xf0},
> +	{0x3041, 0x00},
> +	{0x3042, 0xf0},
> +	{0x3106, 0x11},
> +	{0x3500, 0x00},
> +	{0x3501, 0xb8},
> +	{0x3502, 0x80},
> +	{0x3503, 0x00},
> +	{0x3504, 0x03},
> +	{0x3505, 0x83},
> +	{0x3508, 0x04},
> +	{0x3509, 0x00},
> +	{0x350e, 0x04},
> +	{0x350f, 0x00},
> +	{0x3510, 0x00},
> +	{0x3511, 0x02},
> +	{0x3512, 0x00},
> +	{0x3601, 0xc8},
> +	{0x3610, 0x88},
> +	{0x3612, 0x48},
> +	{0x3614, 0x5b},
> +	{0x3615, 0x96},
> +	{0x3621, 0xd0},
> +	{0x3622, 0x00},
> +	{0x3623, 0x00},
> +	{0x3633, 0x13},
> +	{0x3634, 0x13},
> +	{0x3635, 0x13},
> +	{0x3636, 0x13},
> +	{0x3645, 0x13},
> +	{0x3646, 0x82},
> +	{0x3650, 0x00},
> +	{0x3652, 0xff},
> +	{0x3655, 0x20},
> +	{0x3656, 0xff},
> +	{0x365a, 0xff},
> +	{0x365e, 0xff},
> +	{0x3668, 0x00},
> +	{0x366a, 0x07},
> +	{0x366e, 0x08},
> +	{0x366d, 0x00},
> +	{0x366f, 0x80},
> +	{0x3700, 0x28},
> +	{0x3701, 0x10},
> +	{0x3702, 0x3a},
> +	{0x3703, 0x19},
> +	{0x3704, 0x10},
> +	{0x3705, 0x00},
> +	{0x3706, 0x66},
> +	{0x3707, 0x08},
> +	{0x3708, 0x34},
> +	{0x3709, 0x40},
> +	{0x370a, 0x01},
> +	{0x370b, 0x1b},
> +	{0x3714, 0x24},
> +	{0x371a, 0x3e},
> +	{0x3733, 0x00},
> +	{0x3734, 0x00},
> +	{0x373a, 0x05},
> +	{0x373b, 0x06},
> +	{0x373c, 0x0a},
> +	{0x373f, 0xa0},
> +	{0x3755, 0x00},
> +	{0x3758, 0x00},
> +	{0x375b, 0x0e},
> +	{0x3766, 0x5f},
> +	{0x3768, 0x00},
> +	{0x3769, 0x22},
> +	{0x3773, 0x08},
> +	{0x3774, 0x1f},
> +	{0x3776, 0x06},
> +	{0x37a0, 0x88},
> +	{0x37a1, 0x5c},
> +	{0x37a7, 0x88},
> +	{0x37a8, 0x70},
> +	{0x37aa, 0x88},
> +	{0x37ab, 0x48},
> +	{0x37b3, 0x66},
> +	{0x37c2, 0x04},
> +	{0x37c5, 0x00},
> +	{0x37c8, 0x00},
> +	{0x3800, 0x00},
> +	{0x3801, 0x0c},
> +	{0x3802, 0x00},
> +	{0x3803, 0x04},
> +	{0x3804, 0x0a},
> +	{0x3805, 0x33},
> +	{0x3806, 0x07},
> +	{0x3807, 0xa3},
> +	{0x3808, 0x05},
> +	{0x3809, 0x10},
> +	{0x380a, 0x02},
> +	{0x380b, 0xe0},
> +	{0x380c, 0x06},
> +	{0x380d, 0xa8},
> +	{0x380e, 0x07},
> +	{0x380f, 0xf6},
> +	{0x3811, 0x04},
> +	{0x3813, 0x02},
> +	{0x3814, 0x03},
> +	{0x3815, 0x01},
> +	{0x3816, 0x00},
> +	{0x3817, 0x00},
> +	{0x3818, 0x00},
> +	{0x3819, 0x00},
> +	{0x3820, 0x94},
> +	{0x3821, 0x41},
> +	{0x3822, 0x48},
> +	{0x3826, 0x00},
> +	{0x3827, 0x08},
> +	{0x382a, 0x03},
> +	{0x382b, 0x01},
> +	{0x3830, 0x08},
> +	{0x3836, 0x02},
> +	{0x3837, 0x00},
> +	{0x3838, 0x10},
> +	{0x3841, 0xff},
> +	{0x3846, 0x48},
> +	{0x3861, 0x00},
> +	{0x3862, 0x04},
> +	{0x3863, 0x06},
> +	{0x3a11, 0x01},
> +	{0x3a12, 0x78},
> +	{0x3b00, 0x00},
> +	{0x3b02, 0x00},
> +	{0x3b03, 0x00},
> +	{0x3b04, 0x00},
> +	{0x3b05, 0x00},
> +	{0x3c00, 0x89},
> +	{0x3c01, 0xab},
> +	{0x3c02, 0x01},
> +	{0x3c03, 0x00},
> +	{0x3c04, 0x00},
> +	{0x3c05, 0x03},
> +	{0x3c06, 0x00},
> +	{0x3c07, 0x05},
> +	{0x3c0c, 0x00},
> +	{0x3c0d, 0x00},
> +	{0x3c0e, 0x00},
> +	{0x3c0f, 0x00},
> +	{0x3c40, 0x00},
> +	{0x3c41, 0xa3},
> +	{0x3c43, 0x7d},
> +	{0x3c45, 0xd7},
> +	{0x3c47, 0xfc},
> +	{0x3c50, 0x05},
> +	{0x3c52, 0xaa},
> +	{0x3c54, 0x71},
> +	{0x3c56, 0x80},
> +	{0x3d85, 0x17},
> +	{0x3f03, 0x00},
> +	{0x3f0a, 0x00},
> +	{0x3f0b, 0x00},
> +	{0x4001, 0x60},
> +	{0x4009, 0x05},
> +	{0x4020, 0x00},
> +	{0x4021, 0x00},
> +	{0x4022, 0x00},
> +	{0x4023, 0x00},
> +	{0x4024, 0x00},
> +	{0x4025, 0x00},
> +	{0x4026, 0x00},
> +	{0x4027, 0x00},
> +	{0x4028, 0x00},
> +	{0x4029, 0x00},
> +	{0x402a, 0x00},
> +	{0x402b, 0x00},
> +	{0x402c, 0x00},
> +	{0x402d, 0x00},
> +	{0x402e, 0x00},
> +	{0x402f, 0x00},
> +	{0x4040, 0x00},
> +	{0x4041, 0x03},
> +	{0x4042, 0x00},
> +	{0x4043, 0x7A},
> +	{0x4044, 0x00},
> +	{0x4045, 0x7A},
> +	{0x4046, 0x00},
> +	{0x4047, 0x7A},
> +	{0x4048, 0x00},
> +	{0x4049, 0x7A},
> +	{0x4303, 0x00},
> +	{0x4307, 0x30},
> +	{0x4500, 0x58},
> +	{0x4501, 0x04},
> +	{0x4502, 0x48},
> +	{0x4503, 0x10},
> +	{0x4508, 0x55},
> +	{0x4509, 0x55},
> +	{0x450a, 0x00},
> +	{0x450b, 0x00},
> +	{0x4600, 0x00},
> +	{0x4601, 0x80},
> +	{0x4700, 0xa4},
> +	{0x4800, 0x4c},
> +	{0x4816, 0x53},
> +	{0x481f, 0x40},
> +	{0x4837, 0x12},
> +	{0x5000, 0x56},
> +	{0x5001, 0x01},
> +	{0x5002, 0x28},
> +	{0x5004, 0x0c},
> +	{0x5006, 0x0c},
> +	{0x5007, 0xe0},
> +	{0x5008, 0x01},
> +	{0x5009, 0xb0},
> +	{0x5045, 0x05},
> +	{0x5048, 0x10},
> +	{0x5901, 0x00},
> +	{0x5a01, 0x00},
> +	{0x5a03, 0x00},
> +	{0x5a04, 0x0c},
> +	{0x5a05, 0xe0},
> +	{0x5a06, 0x09},
> +	{0x5a07, 0xb0},
> +	{0x5a08, 0x06},
> +	{0x5e00, 0x00},
> +	{0x3734, 0x40},
> +	{0x5b00, 0x01},
> +	{0x5b01, 0x10},
> +	{0x5b02, 0x01},
> +	{0x5b03, 0xdb},
> +	{0x3d8c, 0x71},
> +	{0x3d8d, 0xea},
> +	{0x4017, 0x10},
> +	{0x3618, 0x2a},
> +	{0x5780, 0x3e},
> +	{0x5781, 0x0f},
> +	{0x5782, 0x44},
> +	{0x5783, 0x02},
> +	{0x5784, 0x01},
> +	{0x5785, 0x01},
> +	{0x5786, 0x00},
> +	{0x5787, 0x04},
> +	{0x5788, 0x02},
> +	{0x5789, 0x0f},
> +	{0x578a, 0xfd},
> +	{0x578b, 0xf5},
> +	{0x578c, 0xf5},
> +	{0x578d, 0x03},
> +	{0x578e, 0x08},
> +	{0x578f, 0x0c},
> +	{0x5790, 0x08},
> +	{0x5791, 0x06},
> +	{0x5792, 0x00},
> +	{0x5793, 0x52},
> +	{0x5794, 0xa3},
> +};
> +
> +static const struct ov5670_reg mode_960x720_regs[] = {
> +	{0x3000, 0x00},
> +	{0x3002, 0x61},
> +	{0x3005, 0xf0},
> +	{0x3007, 0x00},
> +	{0x300D, 0x00},
> +	{0x3010, 0x40},
> +	{0x3015, 0x0f},
> +	{0x3018, 0x32},
> +	{0x301a, 0xf0},
> +	{0x301b, 0xf0},
> +	{0x301c, 0xf0},
> +	{0x301d, 0xf0},
> +	{0x301e, 0xf0},
> +	{0x3030, 0x00},
> +	{0x303c, 0xff},
> +	{0x303e, 0xff},
> +	{0x3040, 0xf0},
> +	{0x3041, 0x00},
> +	{0x3042, 0xf0},
> +	{0x3106, 0x11},
> +	{0x3500, 0x00},
> +	{0x3501, 0xb8},
> +	{0x3502, 0x80},
> +	{0x3503, 0x00},
> +	{0x3504, 0x03},
> +	{0x3505, 0x83},
> +	{0x3508, 0x04},
> +	{0x3509, 0x00},
> +	{0x350e, 0x04},
> +	{0x350f, 0x00},
> +	{0x3510, 0x00},
> +	{0x3511, 0x02},
> +	{0x3512, 0x00},
> +	{0x3601, 0xc8},
> +	{0x3610, 0x88},
> +	{0x3612, 0x48},
> +	{0x3614, 0x5b},
> +	{0x3615, 0x96},
> +	{0x3621, 0xd0},
> +	{0x3622, 0x00},
> +	{0x3623, 0x00},
> +	{0x3633, 0x13},
> +	{0x3634, 0x13},
> +	{0x3635, 0x13},
> +	{0x3636, 0x13},
> +	{0x3645, 0x13},
> +	{0x3646, 0x82},
> +	{0x3650, 0x00},
> +	{0x3652, 0xff},
> +	{0x3655, 0x20},
> +	{0x3656, 0xff},
> +	{0x365a, 0xff},
> +	{0x365e, 0xff},
> +	{0x3668, 0x00},
> +	{0x366a, 0x07},
> +	{0x366e, 0x08},
> +	{0x366d, 0x00},
> +	{0x366f, 0x80},
> +	{0x3700, 0x28},
> +	{0x3701, 0x10},
> +	{0x3702, 0x3a},
> +	{0x3703, 0x19},
> +	{0x3704, 0x10},
> +	{0x3705, 0x00},
> +	{0x3706, 0x66},
> +	{0x3707, 0x08},
> +	{0x3708, 0x34},
> +	{0x3709, 0x40},
> +	{0x370a, 0x01},
> +	{0x370b, 0x1b},
> +	{0x3714, 0x24},
> +	{0x371a, 0x3e},
> +	{0x3733, 0x00},
> +	{0x3734, 0x00},
> +	{0x373a, 0x05},
> +	{0x373b, 0x06},
> +	{0x373c, 0x0a},
> +	{0x373f, 0xa0},
> +	{0x3755, 0x00},
> +	{0x3758, 0x00},
> +	{0x375b, 0x0e},
> +	{0x3766, 0x5f},
> +	{0x3768, 0x00},
> +	{0x3769, 0x22},
> +	{0x3773, 0x08},
> +	{0x3774, 0x1f},
> +	{0x3776, 0x06},
> +	{0x37a0, 0x88},
> +	{0x37a1, 0x5c},
> +	{0x37a7, 0x88},
> +	{0x37a8, 0x70},
> +	{0x37aa, 0x88},
> +	{0x37ab, 0x48},
> +	{0x37b3, 0x66},
> +	{0x37c2, 0x04},
> +	{0x37c5, 0x00},
> +	{0x37c8, 0x00},
> +	{0x3800, 0x00},
> +	{0x3801, 0x0c},
> +	{0x3802, 0x00},
> +	{0x3803, 0x04},
> +	{0x3804, 0x0a},
> +	{0x3805, 0x33},
> +	{0x3806, 0x07},
> +	{0x3807, 0xa3},
> +	{0x3808, 0x03},
> +	{0x3809, 0xc0},
> +	{0x380a, 0x02},
> +	{0x380b, 0xd0},
> +	{0x380c, 0x06},
> +	{0x380d, 0xa8},
> +	{0x380e, 0x07},
> +	{0x380f, 0xf6},
> +	{0x3811, 0x04},
> +	{0x3813, 0x02},
> +	{0x3814, 0x03},
> +	{0x3815, 0x01},
> +	{0x3816, 0x00},
> +	{0x3817, 0x00},
> +	{0x3818, 0x00},
> +	{0x3819, 0x00},
> +	{0x3820, 0x94},
> +	{0x3821, 0x41},
> +	{0x3822, 0x48},
> +	{0x3826, 0x00},
> +	{0x3827, 0x08},
> +	{0x382a, 0x03},
> +	{0x382b, 0x01},
> +	{0x3830, 0x08},
> +	{0x3836, 0x02},
> +	{0x3837, 0x00},
> +	{0x3838, 0x10},
> +	{0x3841, 0xff},
> +	{0x3846, 0x48},
> +	{0x3861, 0x00},
> +	{0x3862, 0x04},
> +	{0x3863, 0x06},
> +	{0x3a11, 0x01},
> +	{0x3a12, 0x78},
> +	{0x3b00, 0x00},
> +	{0x3b02, 0x00},
> +	{0x3b03, 0x00},
> +	{0x3b04, 0x00},
> +	{0x3b05, 0x00},
> +	{0x3c00, 0x89},
> +	{0x3c01, 0xab},
> +	{0x3c02, 0x01},
> +	{0x3c03, 0x00},
> +	{0x3c04, 0x00},
> +	{0x3c05, 0x03},
> +	{0x3c06, 0x00},
> +	{0x3c07, 0x05},
> +	{0x3c0c, 0x00},
> +	{0x3c0d, 0x00},
> +	{0x3c0e, 0x00},
> +	{0x3c0f, 0x00},
> +	{0x3c40, 0x00},
> +	{0x3c41, 0xa3},
> +	{0x3c43, 0x7d},
> +	{0x3c45, 0xd7},
> +	{0x3c47, 0xfc},
> +	{0x3c50, 0x05},
> +	{0x3c52, 0xaa},
> +	{0x3c54, 0x71},
> +	{0x3c56, 0x80},
> +	{0x3d85, 0x17},
> +	{0x3f03, 0x00},
> +	{0x3f0a, 0x00},
> +	{0x3f0b, 0x00},
> +	{0x4001, 0x60},
> +	{0x4009, 0x05},
> +	{0x4020, 0x00},
> +	{0x4021, 0x00},
> +	{0x4022, 0x00},
> +	{0x4023, 0x00},
> +	{0x4024, 0x00},
> +	{0x4025, 0x00},
> +	{0x4026, 0x00},
> +	{0x4027, 0x00},
> +	{0x4028, 0x00},
> +	{0x4029, 0x00},
> +	{0x402a, 0x00},
> +	{0x402b, 0x00},
> +	{0x402c, 0x00},
> +	{0x402d, 0x00},
> +	{0x402e, 0x00},
> +	{0x402f, 0x00},
> +	{0x4040, 0x00},
> +	{0x4041, 0x03},
> +	{0x4042, 0x00},
> +	{0x4043, 0x7A},
> +	{0x4044, 0x00},
> +	{0x4045, 0x7A},
> +	{0x4046, 0x00},
> +	{0x4047, 0x7A},
> +	{0x4048, 0x00},
> +	{0x4049, 0x7A},
> +	{0x4303, 0x00},
> +	{0x4307, 0x30},
> +	{0x4500, 0x58},
> +	{0x4501, 0x04},
> +	{0x4502, 0x48},
> +	{0x4503, 0x10},
> +	{0x4508, 0x55},
> +	{0x4509, 0x55},
> +	{0x450a, 0x00},
> +	{0x450b, 0x00},
> +	{0x4600, 0x00},
> +	{0x4601, 0x80},
> +	{0x4700, 0xa4},
> +	{0x4800, 0x4c},
> +	{0x4816, 0x53},
> +	{0x481f, 0x40},
> +	{0x4837, 0x12},
> +	{0x5000, 0x56},
> +	{0x5001, 0x01},
> +	{0x5002, 0x28},
> +	{0x5004, 0x0c},
> +	{0x5006, 0x0c},
> +	{0x5007, 0xe0},
> +	{0x5008, 0x01},
> +	{0x5009, 0xb0},
> +	{0x5045, 0x05},
> +	{0x5048, 0x10},
> +	{0x5901, 0x00},
> +	{0x5a01, 0x00},
> +	{0x5a03, 0x00},
> +	{0x5a04, 0x0c},
> +	{0x5a05, 0xe0},
> +	{0x5a06, 0x09},
> +	{0x5a07, 0xb0},
> +	{0x5a08, 0x06},
> +	{0x5e00, 0x00},
> +	{0x3734, 0x40},
> +	{0x5b00, 0x01},
> +	{0x5b01, 0x10},
> +	{0x5b02, 0x01},
> +	{0x5b03, 0xdb},
> +	{0x3d8c, 0x71},
> +	{0x3d8d, 0xea},
> +	{0x4017, 0x10},
> +	{0x3618, 0x2a},
> +	{0x5780, 0x3e},
> +	{0x5781, 0x0f},
> +	{0x5782, 0x44},
> +	{0x5783, 0x02},
> +	{0x5784, 0x01},
> +	{0x5785, 0x01},
> +	{0x5786, 0x00},
> +	{0x5787, 0x04},
> +	{0x5788, 0x02},
> +	{0x5789, 0x0f},
> +	{0x578a, 0xfd},
> +	{0x578b, 0xf5},
> +	{0x578c, 0xf5},
> +	{0x578d, 0x03},
> +	{0x578e, 0x08},
> +	{0x578f, 0x0c},
> +	{0x5790, 0x08},
> +	{0x5791, 0x06},
> +	{0x5792, 0x00},
> +	{0x5793, 0x52},
> +	{0x5794, 0xa3},
> +};
> +
> +static const struct ov5670_reg mode_1920x1080_regs[] = {
> +	{0x3000, 0x00},
> +	{0x3002, 0x61},
> +	{0x3005, 0xf0},
> +	{0x3007, 0x00},
> +	{0x300D, 0x00},
> +	{0x3010, 0x40},
> +	{0x3015, 0x0f},
> +	{0x3018, 0x32},
> +	{0x301a, 0xf0},
> +	{0x301b, 0xf0},
> +	{0x301c, 0xf0},
> +	{0x301d, 0xf0},
> +	{0x301e, 0xf0},
> +	{0x3030, 0x00},
> +	{0x303c, 0xff},
> +	{0x303e, 0xff},
> +	{0x3040, 0xf0},
> +	{0x3041, 0x00},
> +	{0x3042, 0xf0},
> +	{0x3106, 0x11},
> +	{0x3500, 0x00},
> +	{0x3501, 0xb8},
> +	{0x3502, 0x80},
> +	{0x3503, 0x00},
> +	{0x3504, 0x03},
> +	{0x3505, 0x83},
> +	{0x3508, 0x04},
> +	{0x3509, 0x00},
> +	{0x350e, 0x04},
> +	{0x350f, 0x00},
> +	{0x3510, 0x00},
> +	{0x3511, 0x02},
> +	{0x3512, 0x00},
> +	{0x3601, 0xc8},
> +	{0x3610, 0x88},
> +	{0x3612, 0x48},
> +	{0x3614, 0x5b},
> +	{0x3615, 0x96},
> +	{0x3621, 0xd0},
> +	{0x3622, 0x00},
> +	{0x3623, 0x00},
> +	{0x3633, 0x13},
> +	{0x3634, 0x13},
> +	{0x3635, 0x13},
> +	{0x3636, 0x13},
> +	{0x3645, 0x13},
> +	{0x3646, 0x82},
> +	{0x3650, 0x00},
> +	{0x3652, 0xff},
> +	{0x3655, 0x20},
> +	{0x3656, 0xff},
> +	{0x365a, 0xff},
> +	{0x365e, 0xff},
> +	{0x3668, 0x00},
> +	{0x366a, 0x07},
> +	{0x366e, 0x10},
> +	{0x366d, 0x00},
> +	{0x366f, 0x80},
> +	{0x3700, 0x28},
> +	{0x3701, 0x10},
> +	{0x3702, 0x3a},
> +	{0x3703, 0x19},
> +	{0x3704, 0x10},
> +	{0x3705, 0x00},
> +	{0x3706, 0x66},
> +	{0x3707, 0x08},
> +	{0x3708, 0x34},
> +	{0x3709, 0x40},
> +	{0x370a, 0x01},
> +	{0x370b, 0x1b},
> +	{0x3714, 0x24},
> +	{0x371a, 0x3e},
> +	{0x3733, 0x00},
> +	{0x3734, 0x00},
> +	{0x373a, 0x05},
> +	{0x373b, 0x06},
> +	{0x373c, 0x0a},
> +	{0x373f, 0xa0},
> +	{0x3755, 0x00},
> +	{0x3758, 0x00},
> +	{0x375b, 0x0e},
> +	{0x3766, 0x5f},
> +	{0x3768, 0x00},
> +	{0x3769, 0x22},
> +	{0x3773, 0x08},
> +	{0x3774, 0x1f},
> +	{0x3776, 0x06},
> +	{0x37a0, 0x88},
> +	{0x37a1, 0x5c},
> +	{0x37a7, 0x88},
> +	{0x37a8, 0x70},
> +	{0x37aa, 0x88},
> +	{0x37ab, 0x48},
> +	{0x37b3, 0x66},
> +	{0x37c2, 0x04},
> +	{0x37c5, 0x00},
> +	{0x37c8, 0x00},
> +	{0x3800, 0x00},
> +	{0x3801, 0x0c},
> +	{0x3802, 0x00},
> +	{0x3803, 0x04},
> +	{0x3804, 0x0a},
> +	{0x3805, 0x33},
> +	{0x3806, 0x07},
> +	{0x3807, 0xa3},
> +	{0x3808, 0x07},
> +	{0x3809, 0x80},
> +	{0x380a, 0x04},
> +	{0x380b, 0x38},
> +	{0x380c, 0x06},
> +	{0x380d, 0xa8},
> +	{0x380e, 0x07},
> +	{0x380f, 0xf6},
> +	{0x3811, 0x04},
> +	{0x3813, 0x02},
> +	{0x3814, 0x01},
> +	{0x3815, 0x01},
> +	{0x3816, 0x00},
> +	{0x3817, 0x00},
> +	{0x3818, 0x00},
> +	{0x3819, 0x00},
> +	{0x3820, 0x84},
> +	{0x3821, 0x40},
> +	{0x3822, 0x48},
> +	{0x3826, 0x00},
> +	{0x3827, 0x08},
> +	{0x382a, 0x01},
> +	{0x382b, 0x01},
> +	{0x3830, 0x08},
> +	{0x3836, 0x02},
> +	{0x3837, 0x00},
> +	{0x3838, 0x10},
> +	{0x3841, 0xfa},
> +	{0x3846, 0x48},
> +	{0x3861, 0x00},
> +	{0x3862, 0x04},
> +	{0x3863, 0x06},
> +	{0x3a11, 0x01},
> +	{0x3a12, 0x78},
> +	{0x3b00, 0x00},
> +	{0x3b02, 0x00},
> +	{0x3b03, 0x00},
> +	{0x3b04, 0x00},
> +	{0x3b05, 0x00},
> +	{0x3c00, 0x89},
> +	{0x3c01, 0xab},
> +	{0x3c02, 0x01},
> +	{0x3c03, 0x00},
> +	{0x3c04, 0x00},
> +	{0x3c05, 0x03},
> +	{0x3c06, 0x00},
> +	{0x3c07, 0x05},
> +	{0x3c0c, 0x00},
> +	{0x3c0d, 0x00},
> +	{0x3c0e, 0x00},
> +	{0x3c0f, 0x00},
> +	{0x3c40, 0x00},
> +	{0x3c41, 0xa3},
> +	{0x3c43, 0x7d},
> +	{0x3c45, 0xd7},
> +	{0x3c47, 0xfc},
> +	{0x3c50, 0x05},
> +	{0x3c52, 0xaa},
> +	{0x3c54, 0x71},
> +	{0x3c56, 0x80},
> +	{0x3d85, 0x17},
> +	{0x3f03, 0x00},
> +	{0x3f0a, 0x00},
> +	{0x3f0b, 0x00},
> +	{0x4001, 0x60},
> +	{0x4009, 0x0d},
> +	{0x4020, 0x00},
> +	{0x4021, 0x00},
> +	{0x4022, 0x00},
> +	{0x4023, 0x00},
> +	{0x4024, 0x00},
> +	{0x4025, 0x00},
> +	{0x4026, 0x00},
> +	{0x4027, 0x00},
> +	{0x4028, 0x00},
> +	{0x4029, 0x00},
> +	{0x402a, 0x00},
> +	{0x402b, 0x00},
> +	{0x402c, 0x00},
> +	{0x402d, 0x00},
> +	{0x402e, 0x00},
> +	{0x402f, 0x00},
> +	{0x4040, 0x00},
> +	{0x4041, 0x03},
> +	{0x4042, 0x00},
> +	{0x4043, 0x7A},
> +	{0x4044, 0x00},
> +	{0x4045, 0x7A},
> +	{0x4046, 0x00},
> +	{0x4047, 0x7A},
> +	{0x4048, 0x00},
> +	{0x4049, 0x7A},
> +	{0x4303, 0x00},
> +	{0x4307, 0x30},
> +	{0x4500, 0x58},
> +	{0x4501, 0x04},
> +	{0x4502, 0x40},
> +	{0x4503, 0x10},
> +	{0x4508, 0xaa},
> +	{0x4509, 0xaa},
> +	{0x450a, 0x00},
> +	{0x450b, 0x00},
> +	{0x4600, 0x00},
> +	{0x4601, 0xc0},
> +	{0x4700, 0xa4},
> +	{0x4800, 0x4c},
> +	{0x4816, 0x53},
> +	{0x481f, 0x40},
> +	{0x4837, 0x12},
> +	{0x5000, 0x56},
> +	{0x5001, 0x01},
> +	{0x5002, 0x28},
> +	{0x5004, 0x0c},
> +	{0x5006, 0x0c},
> +	{0x5007, 0xe0},
> +	{0x5008, 0x01},
> +	{0x5009, 0xb0},
> +	{0x5045, 0x05},
> +	{0x5048, 0x10},
> +	{0x5901, 0x00},
> +	{0x5a01, 0x00},
> +	{0x5a03, 0x00},
> +	{0x5a04, 0x0c},
> +	{0x5a05, 0xe0},
> +	{0x5a06, 0x09},
> +	{0x5a07, 0xb0},
> +	{0x5a08, 0x06},
> +	{0x5e00, 0x00},
> +	{0x3734, 0x40},
> +	{0x5b00, 0x01},
> +	{0x5b01, 0x10},
> +	{0x5b02, 0x01},
> +	{0x5b03, 0xdb},
> +	{0x3d8c, 0x71},
> +	{0x3d8d, 0xea},
> +	{0x4017, 0x08},
> +	{0x3618, 0x2a},
> +	{0x5780, 0x3e},
> +	{0x5781, 0x0f},
> +	{0x5782, 0x44},
> +	{0x5783, 0x02},
> +	{0x5784, 0x01},
> +	{0x5785, 0x01},
> +	{0x5786, 0x00},
> +	{0x5787, 0x04},
> +	{0x5788, 0x02},
> +	{0x5789, 0x0f},
> +	{0x578a, 0xfd},
> +	{0x578b, 0xf5},
> +	{0x578c, 0xf5},
> +	{0x578d, 0x03},
> +	{0x578e, 0x08},
> +	{0x578f, 0x0c},
> +	{0x5790, 0x08},
> +	{0x5791, 0x06},
> +	{0x5792, 0x00},
> +	{0x5793, 0x52},
> +	{0x5794, 0xa3},
> +};
> +
> +static const struct ov5670_reg mode_1440x1080_regs[] = {
> +	{0x3000, 0x00},
> +	{0x3002, 0x61},
> +	{0x3005, 0xf0},
> +	{0x3007, 0x00},
> +	{0x300D, 0x00},
> +	{0x3010, 0x40},
> +	{0x3015, 0x0f},
> +	{0x3018, 0x32},
> +	{0x301a, 0xf0},
> +	{0x301b, 0xf0},
> +	{0x301c, 0xf0},
> +	{0x301d, 0xf0},
> +	{0x301e, 0xf0},
> +	{0x3030, 0x00},
> +	{0x303c, 0xff},
> +	{0x303e, 0xff},
> +	{0x3040, 0xf0},
> +	{0x3041, 0x00},
> +	{0x3042, 0xf0},
> +	{0x3106, 0x11},
> +	{0x3500, 0x00},
> +	{0x3501, 0xb8},
> +	{0x3502, 0x80},
> +	{0x3503, 0x00},
> +	{0x3504, 0x03},
> +	{0x3505, 0x83},
> +	{0x3508, 0x04},
> +	{0x3509, 0x00},
> +	{0x350e, 0x04},
> +	{0x350f, 0x00},
> +	{0x3510, 0x00},
> +	{0x3511, 0x02},
> +	{0x3512, 0x00},
> +	{0x3601, 0xc8},
> +	{0x3610, 0x88},
> +	{0x3612, 0x48},
> +	{0x3614, 0x5b},
> +	{0x3615, 0x96},
> +	{0x3621, 0xd0},
> +	{0x3622, 0x00},
> +	{0x3623, 0x00},
> +	{0x3633, 0x13},
> +	{0x3634, 0x13},
> +	{0x3635, 0x13},
> +	{0x3636, 0x13},
> +	{0x3645, 0x13},
> +	{0x3646, 0x82},
> +	{0x3650, 0x00},
> +	{0x3652, 0xff},
> +	{0x3655, 0x20},
> +	{0x3656, 0xff},
> +	{0x365a, 0xff},
> +	{0x365e, 0xff},
> +	{0x3668, 0x00},
> +	{0x366a, 0x07},
> +	{0x366e, 0x10},
> +	{0x366d, 0x00},
> +	{0x366f, 0x80},
> +	{0x3700, 0x28},
> +	{0x3701, 0x10},
> +	{0x3702, 0x3a},
> +	{0x3703, 0x19},
> +	{0x3704, 0x10},
> +	{0x3705, 0x00},
> +	{0x3706, 0x66},
> +	{0x3707, 0x08},
> +	{0x3708, 0x34},
> +	{0x3709, 0x40},
> +	{0x370a, 0x01},
> +	{0x370b, 0x1b},
> +	{0x3714, 0x24},
> +	{0x371a, 0x3e},
> +	{0x3733, 0x00},
> +	{0x3734, 0x00},
> +	{0x373a, 0x05},
> +	{0x373b, 0x06},
> +	{0x373c, 0x0a},
> +	{0x373f, 0xa0},
> +	{0x3755, 0x00},
> +	{0x3758, 0x00},
> +	{0x375b, 0x0e},
> +	{0x3766, 0x5f},
> +	{0x3768, 0x00},
> +	{0x3769, 0x22},
> +	{0x3773, 0x08},
> +	{0x3774, 0x1f},
> +	{0x3776, 0x06},
> +	{0x37a0, 0x88},
> +	{0x37a1, 0x5c},
> +	{0x37a7, 0x88},
> +	{0x37a8, 0x70},
> +	{0x37aa, 0x88},
> +	{0x37ab, 0x48},
> +	{0x37b3, 0x66},
> +	{0x37c2, 0x04},
> +	{0x37c5, 0x00},
> +	{0x37c8, 0x00},
> +	{0x3800, 0x00},
> +	{0x3801, 0x0c},
> +	{0x3802, 0x00},
> +	{0x3803, 0x04},
> +	{0x3804, 0x0a},
> +	{0x3805, 0x33},
> +	{0x3806, 0x07},
> +	{0x3807, 0xa3},
> +	{0x3808, 0x05},
> +	{0x3809, 0xa0},
> +	{0x380a, 0x04},
> +	{0x380b, 0x38},
> +	{0x380c, 0x06},
> +	{0x380d, 0xa8},
> +	{0x380e, 0x07},
> +	{0x380f, 0xf6},
> +	{0x3811, 0x04},
> +	{0x3813, 0x02},
> +	{0x3814, 0x01},
> +	{0x3815, 0x01},
> +	{0x3816, 0x00},
> +	{0x3817, 0x00},
> +	{0x3818, 0x00},
> +	{0x3819, 0x00},
> +	{0x3820, 0x84},
> +	{0x3821, 0x40},
> +	{0x3822, 0x48},
> +	{0x3826, 0x00},
> +	{0x3827, 0x08},
> +	{0x382a, 0x01},
> +	{0x382b, 0x01},
> +	{0x3830, 0x08},
> +	{0x3836, 0x02},
> +	{0x3837, 0x00},
> +	{0x3838, 0x10},
> +	{0x3841, 0xff},
> +	{0x3846, 0x48},
> +	{0x3861, 0x00},
> +	{0x3862, 0x04},
> +	{0x3863, 0x06},
> +	{0x3a11, 0x01},
> +	{0x3a12, 0x78},
> +	{0x3b00, 0x00},
> +	{0x3b02, 0x00},
> +	{0x3b03, 0x00},
> +	{0x3b04, 0x00},
> +	{0x3b05, 0x00},
> +	{0x3c00, 0x89},
> +	{0x3c01, 0xab},
> +	{0x3c02, 0x01},
> +	{0x3c03, 0x00},
> +	{0x3c04, 0x00},
> +	{0x3c05, 0x03},
> +	{0x3c06, 0x00},
> +	{0x3c07, 0x05},
> +	{0x3c0c, 0x00},
> +	{0x3c0d, 0x00},
> +	{0x3c0e, 0x00},
> +	{0x3c0f, 0x00},
> +	{0x3c40, 0x00},
> +	{0x3c41, 0xa3},
> +	{0x3c43, 0x7d},
> +	{0x3c45, 0xd7},
> +	{0x3c47, 0xfc},
> +	{0x3c50, 0x05},
> +	{0x3c52, 0xaa},
> +	{0x3c54, 0x71},
> +	{0x3c56, 0x80},
> +	{0x3d85, 0x17},
> +	{0x3f03, 0x00},
> +	{0x3f0a, 0x00},
> +	{0x3f0b, 0x00},
> +	{0x4001, 0x60},
> +	{0x4009, 0x0d},
> +	{0x4020, 0x00},
> +	{0x4021, 0x00},
> +	{0x4022, 0x00},
> +	{0x4023, 0x00},
> +	{0x4024, 0x00},
> +	{0x4025, 0x00},
> +	{0x4026, 0x00},
> +	{0x4027, 0x00},
> +	{0x4028, 0x00},
> +	{0x4029, 0x00},
> +	{0x402a, 0x00},
> +	{0x402b, 0x00},
> +	{0x402c, 0x00},
> +	{0x402d, 0x00},
> +	{0x402e, 0x00},
> +	{0x402f, 0x00},
> +	{0x4040, 0x00},
> +	{0x4041, 0x03},
> +	{0x4042, 0x00},
> +	{0x4043, 0x7A},
> +	{0x4044, 0x00},
> +	{0x4045, 0x7A},
> +	{0x4046, 0x00},
> +	{0x4047, 0x7A},
> +	{0x4048, 0x00},
> +	{0x4049, 0x7A},
> +	{0x4303, 0x00},
> +	{0x4307, 0x30},
> +	{0x4500, 0x58},
> +	{0x4501, 0x04},
> +	{0x4502, 0x40},
> +	{0x4503, 0x10},
> +	{0x4508, 0xaa},
> +	{0x4509, 0xaa},
> +	{0x450a, 0x00},
> +	{0x450b, 0x00},
> +	{0x4600, 0x00},
> +	{0x4601, 0xc0},
> +	{0x4700, 0xa4},
> +	{0x4800, 0x4c},
> +	{0x4816, 0x53},
> +	{0x481f, 0x40},
> +	{0x4837, 0x12},
> +	{0x5000, 0x56},
> +	{0x5001, 0x01},
> +	{0x5002, 0x28},
> +	{0x5004, 0x0c},
> +	{0x5006, 0x0c},
> +	{0x5007, 0xe0},
> +	{0x5008, 0x01},
> +	{0x5009, 0xb0},
> +	{0x5045, 0x05},
> +	{0x5048, 0x10},
> +	{0x5901, 0x00},
> +	{0x5a01, 0x00},
> +	{0x5a03, 0x00},
> +	{0x5a04, 0x0c},
> +	{0x5a05, 0xe0},
> +	{0x5a06, 0x09},
> +	{0x5a07, 0xb0},
> +	{0x5a08, 0x06},
> +	{0x5e00, 0x00},
> +	{0x3734, 0x40},
> +	{0x5b00, 0x01},
> +	{0x5b01, 0x10},
> +	{0x5b02, 0x01},
> +	{0x5b03, 0xdb},
> +	{0x3d8c, 0x71},
> +	{0x3d8d, 0xea},
> +	{0x4017, 0x08},
> +	{0x3618, 0x2a},
> +	{0x5780, 0x3e},
> +	{0x5781, 0x0f},
> +	{0x5782, 0x44},
> +	{0x5783, 0x02},
> +	{0x5784, 0x01},
> +	{0x5785, 0x01},
> +	{0x5786, 0x00},
> +	{0x5787, 0x04},
> +	{0x5788, 0x02},
> +	{0x5789, 0x0f},
> +	{0x578a, 0xfd},
> +	{0x578b, 0xf5},
> +	{0x578c, 0xf5},
> +	{0x578d, 0x03},
> +	{0x578e, 0x08},
> +	{0x578f, 0x0c},
> +	{0x5790, 0x08},
> +	{0x5791, 0x06},
> +	{0x5792, 0x00},
> +	{0x5793, 0x52},
> +	{0x5794, 0xa3},
> +};
> +
> +static const struct ov5670_reg mode_1936x1096_regs[] = {
> +	{0x3000, 0x00},
> +	{0x3002, 0x61},
> +	{0x3005, 0xf0},
> +	{0x3007, 0x00},
> +	{0x300D, 0x00},
> +	{0x3010, 0x40},
> +	{0x3015, 0x0f},
> +	{0x3018, 0x32},
> +	{0x301a, 0xf0},
> +	{0x301b, 0xf0},
> +	{0x301c, 0xf0},
> +	{0x301d, 0xf0},
> +	{0x301e, 0xf0},
> +	{0x3030, 0x00},
> +	{0x303c, 0xff},
> +	{0x303e, 0xff},
> +	{0x3040, 0xf0},
> +	{0x3041, 0x00},
> +	{0x3042, 0xf0},
> +	{0x3106, 0x11},
> +	{0x3500, 0x00},
> +	{0x3501, 0xb8},
> +	{0x3502, 0x80},
> +	{0x3503, 0x00},
> +	{0x3504, 0x03},
> +	{0x3505, 0x83},
> +	{0x3508, 0x04},
> +	{0x3509, 0x00},
> +	{0x350e, 0x04},
> +	{0x350f, 0x00},
> +	{0x3510, 0x00},
> +	{0x3511, 0x02},
> +	{0x3512, 0x00},
> +	{0x3601, 0xc8},
> +	{0x3610, 0x88},
> +	{0x3612, 0x48},
> +	{0x3614, 0x5b},
> +	{0x3615, 0x96},
> +	{0x3621, 0xd0},
> +	{0x3622, 0x00},
> +	{0x3623, 0x00},
> +	{0x3633, 0x13},
> +	{0x3634, 0x13},
> +	{0x3635, 0x13},
> +	{0x3636, 0x13},
> +	{0x3645, 0x13},
> +	{0x3646, 0x82},
> +	{0x3650, 0x00},
> +	{0x3652, 0xff},
> +	{0x3655, 0x20},
> +	{0x3656, 0xff},
> +	{0x365a, 0xff},
> +	{0x365e, 0xff},
> +	{0x3668, 0x00},
> +	{0x366a, 0x07},
> +	{0x366e, 0x10},
> +	{0x366d, 0x00},
> +	{0x366f, 0x80},
> +	{0x3700, 0x28},
> +	{0x3701, 0x10},
> +	{0x3702, 0x3a},
> +	{0x3703, 0x19},
> +	{0x3704, 0x10},
> +	{0x3705, 0x00},
> +	{0x3706, 0x66},
> +	{0x3707, 0x08},
> +	{0x3708, 0x34},
> +	{0x3709, 0x40},
> +	{0x370a, 0x01},
> +	{0x370b, 0x1b},
> +	{0x3714, 0x24},
> +	{0x371a, 0x3e},
> +	{0x3733, 0x00},
> +	{0x3734, 0x00},
> +	{0x373a, 0x05},
> +	{0x373b, 0x06},
> +	{0x373c, 0x0a},
> +	{0x373f, 0xa0},
> +	{0x3755, 0x00},
> +	{0x3758, 0x00},
> +	{0x375b, 0x0e},
> +	{0x3766, 0x5f},
> +	{0x3768, 0x00},
> +	{0x3769, 0x22},
> +	{0x3773, 0x08},
> +	{0x3774, 0x1f},
> +	{0x3776, 0x06},
> +	{0x37a0, 0x88},
> +	{0x37a1, 0x5c},
> +	{0x37a7, 0x88},
> +	{0x37a8, 0x70},
> +	{0x37aa, 0x88},
> +	{0x37ab, 0x48},
> +	{0x37b3, 0x66},
> +	{0x37c2, 0x04},
> +	{0x37c5, 0x00},
> +	{0x37c8, 0x00},
> +	{0x3800, 0x00},
> +	{0x3801, 0x0c},
> +	{0x3802, 0x00},
> +	{0x3803, 0x04},
> +	{0x3804, 0x0a},
> +	{0x3805, 0x33},
> +	{0x3806, 0x07},
> +	{0x3807, 0xa3},
> +	{0x3808, 0x07},
> +	{0x3809, 0x90},
> +	{0x380a, 0x04},
> +	{0x380b, 0x48},
> +	{0x380c, 0x06},
> +	{0x380d, 0xa8},
> +	{0x380e, 0x07},
> +	{0x380f, 0xf6},
> +	{0x3811, 0x04},
> +	{0x3813, 0x02},
> +	{0x3814, 0x01},
> +	{0x3815, 0x01},
> +	{0x3816, 0x00},
> +	{0x3817, 0x00},
> +	{0x3818, 0x00},
> +	{0x3819, 0x00},
> +	{0x3820, 0x84},
> +	{0x3821, 0x40},
> +	{0x3822, 0x48},
> +	{0x3826, 0x00},
> +	{0x3827, 0x08},
> +	{0x382a, 0x01},
> +	{0x382b, 0x01},
> +	{0x3830, 0x08},
> +	{0x3836, 0x02},
> +	{0x3837, 0x00},
> +	{0x3838, 0x10},
> +	{0x3841, 0xff},
> +	{0x3846, 0x48},
> +	{0x3861, 0x00},
> +	{0x3862, 0x04},
> +	{0x3863, 0x06},
> +	{0x3a11, 0x01},
> +	{0x3a12, 0x78},
> +	{0x3b00, 0x00},
> +	{0x3b02, 0x00},
> +	{0x3b03, 0x00},
> +	{0x3b04, 0x00},
> +	{0x3b05, 0x00},
> +	{0x3c00, 0x89},
> +	{0x3c01, 0xab},
> +	{0x3c02, 0x01},
> +	{0x3c03, 0x00},
> +	{0x3c04, 0x00},
> +	{0x3c05, 0x03},
> +	{0x3c06, 0x00},
> +	{0x3c07, 0x05},
> +	{0x3c0c, 0x00},
> +	{0x3c0d, 0x00},
> +	{0x3c0e, 0x00},
> +	{0x3c0f, 0x00},
> +	{0x3c40, 0x00},
> +	{0x3c41, 0xa3},
> +	{0x3c43, 0x7d},
> +	{0x3c45, 0xd7},
> +	{0x3c47, 0xfc},
> +	{0x3c50, 0x05},
> +	{0x3c52, 0xaa},
> +	{0x3c54, 0x71},
> +	{0x3c56, 0x80},
> +	{0x3d85, 0x17},
> +	{0x3f03, 0x00},
> +	{0x3f0a, 0x00},
> +	{0x3f0b, 0x00},
> +	{0x4001, 0x60},
> +	{0x4009, 0x0d},
> +	{0x4020, 0x00},
> +	{0x4021, 0x00},
> +	{0x4022, 0x00},
> +	{0x4023, 0x00},
> +	{0x4024, 0x00},
> +	{0x4025, 0x00},
> +	{0x4026, 0x00},
> +	{0x4027, 0x00},
> +	{0x4028, 0x00},
> +	{0x4029, 0x00},
> +	{0x402a, 0x00},
> +	{0x402b, 0x00},
> +	{0x402c, 0x00},
> +	{0x402d, 0x00},
> +	{0x402e, 0x00},
> +	{0x402f, 0x00},
> +	{0x4040, 0x00},
> +	{0x4041, 0x03},
> +	{0x4042, 0x00},
> +	{0x4043, 0x7A},
> +	{0x4044, 0x00},
> +	{0x4045, 0x7A},
> +	{0x4046, 0x00},
> +	{0x4047, 0x7A},
> +	{0x4048, 0x00},
> +	{0x4049, 0x7A},
> +	{0x4303, 0x00},
> +	{0x4307, 0x30},
> +	{0x4500, 0x58},
> +	{0x4501, 0x04},
> +	{0x4502, 0x40},
> +	{0x4503, 0x10},
> +	{0x4508, 0xaa},
> +	{0x4509, 0xaa},
> +	{0x450a, 0x00},
> +	{0x450b, 0x00},
> +	{0x4600, 0x00},
> +	{0x4601, 0xc0},
> +	{0x4700, 0xa4},
> +	{0x4800, 0x4c},
> +	{0x4816, 0x53},
> +	{0x481f, 0x40},
> +	{0x4837, 0x12},
> +	{0x5000, 0x56},
> +	{0x5001, 0x01},
> +	{0x5002, 0x28},
> +	{0x5004, 0x0c},
> +	{0x5006, 0x0c},
> +	{0x5007, 0xe0},
> +	{0x5008, 0x01},
> +	{0x5009, 0xb0},
> +	{0x5045, 0x05},
> +	{0x5048, 0x10},
> +	{0x5901, 0x00},
> +	{0x5a01, 0x00},
> +	{0x5a03, 0x00},
> +	{0x5a04, 0x0c},
> +	{0x5a05, 0xe0},
> +	{0x5a06, 0x09},
> +	{0x5a07, 0xb0},
> +	{0x5a08, 0x06},
> +	{0x5e00, 0x00},
> +	{0x3734, 0x40},
> +	{0x5b00, 0x01},
> +	{0x5b01, 0x10},
> +	{0x5b02, 0x01},
> +	{0x5b03, 0xdb},
> +	{0x3d8c, 0x71},
> +	{0x3d8d, 0xea},
> +	{0x4017, 0x08},
> +	{0x3618, 0x2a},
> +	{0x5780, 0x3e},
> +	{0x5781, 0x0f},
> +	{0x5782, 0x44},
> +	{0x5783, 0x02},
> +	{0x5784, 0x01},
> +	{0x5785, 0x01},
> +	{0x5786, 0x00},
> +	{0x5787, 0x04},
> +	{0x5788, 0x02},
> +	{0x5789, 0x0f},
> +	{0x578a, 0xfd},
> +	{0x578b, 0xf5},
> +	{0x578c, 0xf5},
> +	{0x578d, 0x03},
> +	{0x578e, 0x08},
> +	{0x578f, 0x0c},
> +	{0x5790, 0x08},
> +	{0x5791, 0x06},
> +	{0x5792, 0x00},
> +	{0x5793, 0x52},
> +	{0x5794, 0xa3},
> +};
> +
> +static const struct ov5670_reg mode_2560x1440_regs[] = {
> +	{0x3000, 0x00},
> +	{0x3002, 0x61},
> +	{0x3005, 0xf0},
> +	{0x3007, 0x00},
> +	{0x300D, 0x00},
> +	{0x3010, 0x40},
> +	{0x3015, 0x0f},
> +	{0x3018, 0x32},
> +	{0x301a, 0xf0},
> +	{0x301b, 0xf0},
> +	{0x301c, 0xf0},
> +	{0x301d, 0xf0},
> +	{0x301e, 0xf0},
> +	{0x3030, 0x00},
> +	{0x303c, 0xff},
> +	{0x303e, 0xff},
> +	{0x3040, 0xf0},
> +	{0x3041, 0x00},
> +	{0x3042, 0xf0},
> +	{0x3106, 0x11},
> +	{0x3500, 0x00},
> +	{0x3501, 0xb8},
> +	{0x3502, 0x80},
> +	{0x3503, 0x00},
> +	{0x3504, 0x03},
> +	{0x3505, 0x83},
> +	{0x3508, 0x04},
> +	{0x3509, 0x00},
> +	{0x350e, 0x04},
> +	{0x350f, 0x00},
> +	{0x3510, 0x00},
> +	{0x3511, 0x02},
> +	{0x3512, 0x00},
> +	{0x3601, 0xc8},
> +	{0x3610, 0xa8},
> +	{0x3612, 0x48},
> +	{0x3614, 0x5b},
> +	{0x3615, 0x96},
> +	{0x3621, 0xd0},
> +	{0x3622, 0x00},
> +	{0x3623, 0x00},
> +	{0x3633, 0x13},
> +	{0x3634, 0x13},
> +	{0x3635, 0x13},
> +	{0x3636, 0x13},
> +	{0x3645, 0x13},
> +	{0x3646, 0x82},
> +	{0x3650, 0x00},
> +	{0x3652, 0xff},
> +	{0x3655, 0x20},
> +	{0x3656, 0xff},
> +	{0x365a, 0xff},
> +	{0x365e, 0xff},
> +	{0x3668, 0x00},
> +	{0x366a, 0x07},
> +	{0x366e, 0x10},
> +	{0x366d, 0x00},
> +	{0x366f, 0x80},
> +	{0x3700, 0x28},
> +	{0x3701, 0x10},
> +	{0x3702, 0x3a},
> +	{0x3703, 0x19},
> +	{0x3704, 0x10},
> +	{0x3705, 0x00},
> +	{0x3706, 0x66},
> +	{0x3707, 0x08},
> +	{0x3708, 0x34},
> +	{0x3709, 0x40},
> +	{0x370a, 0x01},
> +	{0x370b, 0x1b},
> +	{0x3714, 0x24},
> +	{0x371a, 0x3e},
> +	{0x3733, 0x10},
> +	{0x3734, 0x40},
> +	{0x373a, 0x05},
> +	{0x373b, 0x06},
> +	{0x373c, 0x0a},
> +	{0x373f, 0xa0},
> +	{0x3755, 0x00},
> +	{0x3758, 0x00},
> +	{0x375b, 0x0e},
> +	{0x3766, 0x5f},
> +	{0x3768, 0x00},
> +	{0x3769, 0x22},
> +	{0x3773, 0x08},
> +	{0x3774, 0x1f},
> +	{0x3776, 0x06},
> +	{0x37a0, 0x88},
> +	{0x37a1, 0x5c},
> +	{0x37a7, 0x88},
> +	{0x37a8, 0x70},
> +	{0x37aa, 0x88},
> +	{0x37ab, 0x48},
> +	{0x37b3, 0x66},
> +	{0x37c2, 0x04},
> +	{0x37c5, 0x00},
> +	{0x37c8, 0x00},
> +	{0x3800, 0x00},
> +	{0x3801, 0x0c},
> +	{0x3802, 0x00},
> +	{0x3803, 0x04},
> +	{0x3804, 0x0a},
> +	{0x3805, 0x33},
> +	{0x3806, 0x07},
> +	{0x3807, 0xa3},
> +	{0x3808, 0x0a},
> +	{0x3809, 0x00},
> +	{0x380a, 0x05},
> +	{0x380b, 0xa0},
> +	{0x380c, 0x06},
> +	{0x380d, 0x90},
> +	{0x380e, 0x08},
> +	{0x380f, 0x14},
> +	{0x3811, 0x04},
> +	{0x3813, 0x02},
> +	{0x3814, 0x01},
> +	{0x3815, 0x01},
> +	{0x3816, 0x00},
> +	{0x3817, 0x00},
> +	{0x3818, 0x00},
> +	{0x3819, 0x00},
> +	{0x3820, 0x84},
> +	{0x3821, 0x40},
> +	{0x3822, 0x48},
> +	{0x3826, 0x00},
> +	{0x3827, 0x08},
> +	{0x382a, 0x01},
> +	{0x382b, 0x01},
> +	{0x3830, 0x08},
> +	{0x3836, 0x02},
> +	{0x3837, 0x00},
> +	{0x3838, 0x10},
> +	{0x3841, 0xff},
> +	{0x3845, 0x01},
> +	{0x3846, 0x48},
> +	{0x3861, 0x00},
> +	{0x3862, 0x04},
> +	{0x3863, 0x06},
> +	{0x3a11, 0x01},
> +	{0x3a12, 0x78},
> +	{0x3b00, 0x00},
> +	{0x3b02, 0x00},
> +	{0x3b03, 0x00},
> +	{0x3b04, 0x00},
> +	{0x3b05, 0x00},
> +	{0x3c00, 0x89},
> +	{0x3c01, 0xab},
> +	{0x3c02, 0x01},
> +	{0x3c03, 0x00},
> +	{0x3c04, 0x00},
> +	{0x3c05, 0x03},
> +	{0x3c06, 0x00},
> +	{0x3c07, 0x05},
> +	{0x3c0c, 0x00},
> +	{0x3c0d, 0x00},
> +	{0x3c0e, 0x00},
> +	{0x3c0f, 0x00},
> +	{0x3c40, 0x00},
> +	{0x3c41, 0xa3},
> +	{0x3c43, 0x7d},
> +	{0x3c45, 0xd7},
> +	{0x3c47, 0xfc},
> +	{0x3c50, 0x05},
> +	{0x3c52, 0xaa},
> +	{0x3c54, 0x71},
> +	{0x3c56, 0x80},
> +	{0x3d85, 0x17},
> +	{0x3f03, 0x00},
> +	{0x3f0a, 0x00},
> +	{0x3f0b, 0x00},
> +	{0x4001, 0x60},
> +	{0x4009, 0x0d},
> +	{0x4020, 0x00},
> +	{0x4021, 0x00},
> +	{0x4022, 0x00},
> +	{0x4023, 0x00},
> +	{0x4024, 0x00},
> +	{0x4025, 0x00},
> +	{0x4026, 0x00},
> +	{0x4027, 0x00},
> +	{0x4028, 0x00},
> +	{0x4029, 0x00},
> +	{0x402a, 0x00},
> +	{0x402b, 0x00},
> +	{0x402c, 0x00},
> +	{0x402d, 0x00},
> +	{0x402e, 0x00},
> +	{0x402f, 0x00},
> +	{0x4040, 0x00},
> +	{0x4041, 0x03},
> +	{0x4042, 0x00},
> +	{0x4043, 0x7A},
> +	{0x4044, 0x00},
> +	{0x4045, 0x7A},
> +	{0x4046, 0x00},
> +	{0x4047, 0x7A},
> +	{0x4048, 0x00},
> +	{0x4049, 0x7A},
> +	{0x4303, 0x00},
> +	{0x4307, 0x30},
> +	{0x4500, 0x58},
> +	{0x4501, 0x04},
> +	{0x4502, 0x40},
> +	{0x4503, 0x10},
> +	{0x4508, 0xaa},
> +	{0x4509, 0xaa},
> +	{0x450a, 0x00},
> +	{0x450b, 0x00},
> +	{0x4600, 0x01},
> +	{0x4601, 0x00},
> +	{0x4700, 0xa4},
> +	{0x4800, 0x4c},
> +	{0x4816, 0x53},
> +	{0x481f, 0x40},
> +	{0x4837, 0x12},
> +	{0x5000, 0x56},
> +	{0x5001, 0x01},
> +	{0x5002, 0x28},
> +	{0x5004, 0x0c},
> +	{0x5006, 0x0c},
> +	{0x5007, 0xe0},
> +	{0x5008, 0x01},
> +	{0x5009, 0xb0},
> +	{0x5045, 0x05},
> +	{0x5048, 0x10},
> +	{0x5901, 0x00},
> +	{0x5a01, 0x00},
> +	{0x5a03, 0x00},
> +	{0x5a04, 0x0c},
> +	{0x5a05, 0xe0},
> +	{0x5a06, 0x09},
> +	{0x5a07, 0xb0},
> +	{0x5a08, 0x06},
> +	{0x5e00, 0x00},
> +	{0x3734, 0x40},
> +	{0x5b00, 0x01},
> +	{0x5b01, 0x10},
> +	{0x5b02, 0x01},
> +	{0x5b03, 0xdb},
> +	{0x3d8c, 0x71},
> +	{0x3d8d, 0xea},
> +	{0x4017, 0x08},
> +	{0x3618, 0x2a},
> +	{0x5780, 0x3e},
> +	{0x5781, 0x0f},
> +	{0x5782, 0x44},
> +	{0x5783, 0x02},
> +	{0x5784, 0x01},
> +	{0x5785, 0x01},
> +	{0x5786, 0x00},
> +	{0x5787, 0x04},
> +	{0x5788, 0x02},
> +	{0x5789, 0x0f},
> +	{0x578a, 0xfd},
> +	{0x578b, 0xf5},
> +	{0x578c, 0xf5},
> +	{0x578d, 0x03},
> +	{0x578e, 0x08},
> +	{0x578f, 0x0c},
> +	{0x5790, 0x08},
> +	{0x5791, 0x06},
> +	{0x5792, 0x00},
> +	{0x5793, 0x52},
> +	{0x5794, 0xa3},
> +};
> +
> +static const struct ov5670_reg mode_2576x1456_regs[] = {
> +	{0x3000, 0x00},
> +	{0x3002, 0x61},
> +	{0x3005, 0xf0},
> +	{0x3007, 0x00},
> +	{0x300D, 0x00},
> +	{0x3010, 0x40},
> +	{0x3015, 0x0f},
> +	{0x3018, 0x32},
> +	{0x301a, 0xf0},
> +	{0x301b, 0xf0},
> +	{0x301c, 0xf0},
> +	{0x301d, 0xf0},
> +	{0x301e, 0xf0},
> +	{0x3030, 0x00},
> +	{0x303c, 0xff},
> +	{0x303e, 0xff},
> +	{0x3040, 0xf0},
> +	{0x3041, 0x00},
> +	{0x3042, 0xf0},
> +	{0x3106, 0x11},
> +	{0x3500, 0x00},
> +	{0x3501, 0xb8},
> +	{0x3502, 0x80},
> +	{0x3503, 0x00},
> +	{0x3504, 0x03},
> +	{0x3505, 0x83},
> +	{0x3508, 0x04},
> +	{0x3509, 0x00},
> +	{0x350e, 0x04},
> +	{0x350f, 0x00},
> +	{0x3510, 0x00},
> +	{0x3511, 0x02},
> +	{0x3512, 0x00},
> +	{0x3601, 0xc8},
> +	{0x3610, 0xa8},
> +	{0x3612, 0x48},
> +	{0x3614, 0x5b},
> +	{0x3615, 0x96},
> +	{0x3621, 0xd0},
> +	{0x3622, 0x00},
> +	{0x3623, 0x00},
> +	{0x3633, 0x13},
> +	{0x3634, 0x13},
> +	{0x3635, 0x13},
> +	{0x3636, 0x13},
> +	{0x3645, 0x13},
> +	{0x3646, 0x82},
> +	{0x3650, 0x00},
> +	{0x3652, 0xff},
> +	{0x3655, 0x20},
> +	{0x3656, 0xff},
> +	{0x365a, 0xff},
> +	{0x365e, 0xff},
> +	{0x3668, 0x00},
> +	{0x366a, 0x07},
> +	{0x366e, 0x10},
> +	{0x366d, 0x00},
> +	{0x366f, 0x80},
> +	{0x3700, 0x28},
> +	{0x3701, 0x10},
> +	{0x3702, 0x3a},
> +	{0x3703, 0x19},
> +	{0x3704, 0x10},
> +	{0x3705, 0x00},
> +	{0x3706, 0x66},
> +	{0x3707, 0x08},
> +	{0x3708, 0x34},
> +	{0x3709, 0x40},
> +	{0x370a, 0x01},
> +	{0x370b, 0x1b},
> +	{0x3714, 0x24},
> +	{0x371a, 0x3e},
> +	{0x3733, 0x10},
> +	{0x3734, 0x40},
> +	{0x373a, 0x05},
> +	{0x373b, 0x06},
> +	{0x373c, 0x0a},
> +	{0x373f, 0xa0},
> +	{0x3755, 0x00},
> +	{0x3758, 0x00},
> +	{0x375b, 0x0e},
> +	{0x3766, 0x5f},
> +	{0x3768, 0x00},
> +	{0x3769, 0x22},
> +	{0x3773, 0x08},
> +	{0x3774, 0x1f},
> +	{0x3776, 0x06},
> +	{0x37a0, 0x88},
> +	{0x37a1, 0x5c},
> +	{0x37a7, 0x88},
> +	{0x37a8, 0x70},
> +	{0x37aa, 0x88},
> +	{0x37ab, 0x48},
> +	{0x37b3, 0x66},
> +	{0x37c2, 0x04},
> +	{0x37c5, 0x00},
> +	{0x37c8, 0x00},
> +	{0x3800, 0x00},
> +	{0x3801, 0x0c},
> +	{0x3802, 0x00},
> +	{0x3803, 0x04},
> +	{0x3804, 0x0a},
> +	{0x3805, 0x33},
> +	{0x3806, 0x07},
> +	{0x3807, 0xa3},
> +	{0x3808, 0x0a},
> +	{0x3809, 0x10},
> +	{0x380a, 0x05},
> +	{0x380b, 0xb0},
> +	{0x380c, 0x06},
> +	{0x380d, 0x90},
> +	{0x380e, 0x08},
> +	{0x380f, 0x14},
> +	{0x3811, 0x04},
> +	{0x3813, 0x02},
> +	{0x3814, 0x01},
> +	{0x3815, 0x01},
> +	{0x3816, 0x00},
> +	{0x3817, 0x00},
> +	{0x3818, 0x00},
> +	{0x3819, 0x00},
> +	{0x3820, 0x84},
> +	{0x3821, 0x40},
> +	{0x3822, 0x48},
> +	{0x3826, 0x00},
> +	{0x3827, 0x08},
> +	{0x382a, 0x01},
> +	{0x382b, 0x01},
> +	{0x3830, 0x08},
> +	{0x3836, 0x02},
> +	{0x3837, 0x00},
> +	{0x3838, 0x10},
> +	{0x3841, 0xff},
> +	{0x3845, 0x01},
> +	{0x3846, 0x48},
> +	{0x3861, 0x00},
> +	{0x3862, 0x04},
> +	{0x3863, 0x06},
> +	{0x3a11, 0x01},
> +	{0x3a12, 0x78},
> +	{0x3b00, 0x00},
> +	{0x3b02, 0x00},
> +	{0x3b03, 0x00},
> +	{0x3b04, 0x00},
> +	{0x3b05, 0x00},
> +	{0x3c00, 0x89},
> +	{0x3c01, 0xab},
> +	{0x3c02, 0x01},
> +	{0x3c03, 0x00},
> +	{0x3c04, 0x00},
> +	{0x3c05, 0x03},
> +	{0x3c06, 0x00},
> +	{0x3c07, 0x05},
> +	{0x3c0c, 0x00},
> +	{0x3c0d, 0x00},
> +	{0x3c0e, 0x00},
> +	{0x3c0f, 0x00},
> +	{0x3c40, 0x00},
> +	{0x3c41, 0xa3},
> +	{0x3c43, 0x7d},
> +	{0x3c45, 0xd7},
> +	{0x3c47, 0xfc},
> +	{0x3c50, 0x05},
> +	{0x3c52, 0xaa},
> +	{0x3c54, 0x71},
> +	{0x3c56, 0x80},
> +	{0x3d85, 0x17},
> +	{0x3f03, 0x00},
> +	{0x3f0a, 0x00},
> +	{0x3f0b, 0x00},
> +	{0x4001, 0x60},
> +	{0x4009, 0x0d},
> +	{0x4020, 0x00},
> +	{0x4021, 0x00},
> +	{0x4022, 0x00},
> +	{0x4023, 0x00},
> +	{0x4024, 0x00},
> +	{0x4025, 0x00},
> +	{0x4026, 0x00},
> +	{0x4027, 0x00},
> +	{0x4028, 0x00},
> +	{0x4029, 0x00},
> +	{0x402a, 0x00},
> +	{0x402b, 0x00},
> +	{0x402c, 0x00},
> +	{0x402d, 0x00},
> +	{0x402e, 0x00},
> +	{0x402f, 0x00},
> +	{0x4040, 0x00},
> +	{0x4041, 0x03},
> +	{0x4042, 0x00},
> +	{0x4043, 0x7A},
> +	{0x4044, 0x00},
> +	{0x4045, 0x7A},
> +	{0x4046, 0x00},
> +	{0x4047, 0x7A},
> +	{0x4048, 0x00},
> +	{0x4049, 0x7A},
> +	{0x4303, 0x00},
> +	{0x4307, 0x30},
> +	{0x4500, 0x58},
> +	{0x4501, 0x04},
> +	{0x4502, 0x40},
> +	{0x4503, 0x10},
> +	{0x4508, 0xaa},
> +	{0x4509, 0xaa},
> +	{0x450a, 0x00},
> +	{0x450b, 0x00},
> +	{0x4600, 0x01},
> +	{0x4601, 0x00},
> +	{0x4700, 0xa4},
> +	{0x4800, 0x4c},
> +	{0x4816, 0x53},
> +	{0x481f, 0x40},
> +	{0x4837, 0x12},
> +	{0x5000, 0x56},
> +	{0x5001, 0x01},
> +	{0x5002, 0x28},
> +	{0x5004, 0x0c},
> +	{0x5006, 0x0c},
> +	{0x5007, 0xe0},
> +	{0x5008, 0x01},
> +	{0x5009, 0xb0},
> +	{0x5045, 0x05},
> +	{0x5048, 0x10},
> +	{0x5901, 0x00},
> +	{0x5a01, 0x00},
> +	{0x5a03, 0x00},
> +	{0x5a04, 0x0c},
> +	{0x5a05, 0xe0},
> +	{0x5a06, 0x09},
> +	{0x5a07, 0xb0},
> +	{0x5a08, 0x06},
> +	{0x5e00, 0x00},
> +	{0x3734, 0x40},
> +	{0x5b00, 0x01},
> +	{0x5b01, 0x10},
> +	{0x5b02, 0x01},
> +	{0x5b03, 0xdb},
> +	{0x3d8c, 0x71},
> +	{0x3d8d, 0xea},
> +	{0x4017, 0x08},
> +	{0x3618, 0x2a},
> +	{0x5780, 0x3e},
> +	{0x5781, 0x0f},
> +	{0x5782, 0x44},
> +	{0x5783, 0x02},
> +	{0x5784, 0x01},
> +	{0x5785, 0x01},
> +	{0x5786, 0x00},
> +	{0x5787, 0x04},
> +	{0x5788, 0x02},
> +	{0x5789, 0x0f},
> +	{0x578a, 0xfd},
> +	{0x578b, 0xf5},
> +	{0x578c, 0xf5},
> +	{0x578d, 0x03},
> +	{0x578e, 0x08},
> +	{0x578f, 0x0c},
> +	{0x5790, 0x08},
> +	{0x5791, 0x06},
> +	{0x5792, 0x00},
> +	{0x5793, 0x52},
> +	{0x5794, 0xa3},
> +};
> +
> +static const struct ov5670_reg mode_2576x1936_regs[] = {
> +	{0x3000, 0x00},
> +	{0x3002, 0x61},
> +	{0x3005, 0xf0},
> +	{0x3007, 0x00},
> +	{0x300D, 0x00},
> +	{0x3010, 0x40},
> +	{0x3015, 0x0f},
> +	{0x3018, 0x32},
> +	{0x301a, 0xf0},
> +	{0x301b, 0xf0},
> +	{0x301c, 0xf0},
> +	{0x301d, 0xf0},
> +	{0x301e, 0xf0},
> +	{0x3030, 0x00},
> +	{0x303c, 0xff},
> +	{0x303e, 0xff},
> +	{0x3040, 0xf0},
> +	{0x3041, 0x00},
> +	{0x3042, 0xf0},
> +	{0x3106, 0x11},
> +	{0x3500, 0x00},
> +	{0x3501, 0xb8},
> +	{0x3502, 0x80},
> +	{0x3503, 0x00},
> +	{0x3504, 0x03},
> +	{0x3505, 0x83},
> +	{0x3508, 0x04},
> +	{0x3509, 0x00},
> +	{0x350e, 0x04},
> +	{0x350f, 0x00},
> +	{0x3510, 0x00},
> +	{0x3511, 0x02},
> +	{0x3512, 0x00},
> +	{0x3601, 0xc8},
> +	{0x3610, 0xa8},
> +	{0x3612, 0x48},
> +	{0x3614, 0x5b},
> +	{0x3615, 0x96},
> +	{0x3621, 0xd0},
> +	{0x3622, 0x00},
> +	{0x3623, 0x00},
> +	{0x3633, 0x13},
> +	{0x3634, 0x13},
> +	{0x3635, 0x13},
> +	{0x3636, 0x13},
> +	{0x3645, 0x13},
> +	{0x3646, 0x82},
> +	{0x3650, 0x00},
> +	{0x3652, 0xff},
> +	{0x3655, 0x20},
> +	{0x3656, 0xff},
> +	{0x365a, 0xff},
> +	{0x365e, 0xff},
> +	{0x3668, 0x00},
> +	{0x366a, 0x07},
> +	{0x366e, 0x10},
> +	{0x366d, 0x00},
> +	{0x366f, 0x80},
> +	{0x3700, 0x28},
> +	{0x3701, 0x10},
> +	{0x3702, 0x3a},
> +	{0x3703, 0x19},
> +	{0x3704, 0x10},
> +	{0x3705, 0x00},
> +	{0x3706, 0x66},
> +	{0x3707, 0x08},
> +	{0x3708, 0x34},
> +	{0x3709, 0x40},
> +	{0x370a, 0x01},
> +	{0x370b, 0x1b},
> +	{0x3714, 0x24},
> +	{0x371a, 0x3e},
> +	{0x3733, 0x10},
> +	{0x3734, 0x40},
> +	{0x373a, 0x05},
> +	{0x373b, 0x06},
> +	{0x373c, 0x0a},
> +	{0x373f, 0xa0},
> +	{0x3755, 0x00},
> +	{0x3758, 0x00},
> +	{0x375b, 0x0e},
> +	{0x3766, 0x5f},
> +	{0x3768, 0x00},
> +	{0x3769, 0x22},
> +	{0x3773, 0x08},
> +	{0x3774, 0x1f},
> +	{0x3776, 0x06},
> +	{0x37a0, 0x88},
> +	{0x37a1, 0x5c},
> +	{0x37a7, 0x88},
> +	{0x37a8, 0x70},
> +	{0x37aa, 0x88},
> +	{0x37ab, 0x48},
> +	{0x37b3, 0x66},
> +	{0x37c2, 0x04},
> +	{0x37c5, 0x00},
> +	{0x37c8, 0x00},
> +	{0x3800, 0x00},
> +	{0x3801, 0x0c},
> +	{0x3802, 0x00},
> +	{0x3803, 0x04},
> +	{0x3804, 0x0a},
> +	{0x3805, 0x33},
> +	{0x3806, 0x07},
> +	{0x3807, 0xa3},
> +	{0x3808, 0x0a},
> +	{0x3809, 0x10},
> +	{0x380a, 0x07},
> +	{0x380b, 0x90},
> +	{0x380c, 0x06},
> +	{0x380d, 0x90},
> +	{0x380e, 0x08},
> +	{0x380f, 0x14},
> +	{0x3811, 0x04},
> +	{0x3813, 0x02},
> +	{0x3814, 0x01},
> +	{0x3815, 0x01},
> +	{0x3816, 0x00},
> +	{0x3817, 0x00},
> +	{0x3818, 0x00},
> +	{0x3819, 0x00},
> +	{0x3820, 0x84},
> +	{0x3821, 0x40},
> +	{0x3822, 0x48},
> +	{0x3826, 0x00},
> +	{0x3827, 0x08},
> +	{0x382a, 0x01},
> +	{0x382b, 0x01},
> +	{0x3830, 0x08},
> +	{0x3836, 0x02},
> +	{0x3837, 0x00},
> +	{0x3838, 0x10},
> +	{0x3841, 0xff},
> +	{0x3845, 0x01},
> +	{0x3846, 0x48},
> +	{0x3861, 0x00},
> +	{0x3862, 0x04},
> +	{0x3863, 0x06},
> +	{0x3a11, 0x01},
> +	{0x3a12, 0x78},
> +	{0x3b00, 0x00},
> +	{0x3b02, 0x00},
> +	{0x3b03, 0x00},
> +	{0x3b04, 0x00},
> +	{0x3b05, 0x00},
> +	{0x3c00, 0x89},
> +	{0x3c01, 0xab},
> +	{0x3c02, 0x01},
> +	{0x3c03, 0x00},
> +	{0x3c04, 0x00},
> +	{0x3c05, 0x03},
> +	{0x3c06, 0x00},
> +	{0x3c07, 0x05},
> +	{0x3c0c, 0x00},
> +	{0x3c0d, 0x00},
> +	{0x3c0e, 0x00},
> +	{0x3c0f, 0x00},
> +	{0x3c40, 0x00},
> +	{0x3c41, 0xa3},
> +	{0x3c43, 0x7d},
> +	{0x3c45, 0xd7},
> +	{0x3c47, 0xfc},
> +	{0x3c50, 0x05},
> +	{0x3c52, 0xaa},
> +	{0x3c54, 0x71},
> +	{0x3c56, 0x80},
> +	{0x3d85, 0x17},
> +	{0x3f03, 0x00},
> +	{0x3f0a, 0x00},
> +	{0x3f0b, 0x00},
> +	{0x4001, 0x60},
> +	{0x4009, 0x0d},
> +	{0x4020, 0x00},
> +	{0x4021, 0x00},
> +	{0x4022, 0x00},
> +	{0x4023, 0x00},
> +	{0x4024, 0x00},
> +	{0x4025, 0x00},
> +	{0x4026, 0x00},
> +	{0x4027, 0x00},
> +	{0x4028, 0x00},
> +	{0x4029, 0x00},
> +	{0x402a, 0x00},
> +	{0x402b, 0x00},
> +	{0x402c, 0x00},
> +	{0x402d, 0x00},
> +	{0x402e, 0x00},
> +	{0x402f, 0x00},
> +	{0x4040, 0x00},
> +	{0x4041, 0x03},
> +	{0x4042, 0x00},
> +	{0x4043, 0x7A},
> +	{0x4044, 0x00},
> +	{0x4045, 0x7A},
> +	{0x4046, 0x00},
> +	{0x4047, 0x7A},
> +	{0x4048, 0x00},
> +	{0x4049, 0x7A},
> +	{0x4303, 0x00},
> +	{0x4307, 0x30},
> +	{0x4500, 0x58},
> +	{0x4501, 0x04},
> +	{0x4502, 0x40},
> +	{0x4503, 0x10},
> +	{0x4508, 0xaa},
> +	{0x4509, 0xaa},
> +	{0x450a, 0x00},
> +	{0x450b, 0x00},
> +	{0x4600, 0x01},
> +	{0x4601, 0x00},
> +	{0x4700, 0xa4},
> +	{0x4800, 0x4c},
> +	{0x4816, 0x53},
> +	{0x481f, 0x40},
> +	{0x4837, 0x12},
> +	{0x5000, 0x56},
> +	{0x5001, 0x01},
> +	{0x5002, 0x28},
> +	{0x5004, 0x0c},
> +	{0x5006, 0x0c},
> +	{0x5007, 0xe0},
> +	{0x5008, 0x01},
> +	{0x5009, 0xb0},
> +	{0x5045, 0x05},
> +	{0x5048, 0x10},
> +	{0x5901, 0x00},
> +	{0x5a01, 0x00},
> +	{0x5a03, 0x00},
> +	{0x5a04, 0x0c},
> +	{0x5a05, 0xe0},
> +	{0x5a06, 0x09},
> +	{0x5a07, 0xb0},
> +	{0x5a08, 0x06},
> +	{0x5e00, 0x00},
> +	{0x3734, 0x40},
> +	{0x5b00, 0x01},
> +	{0x5b01, 0x10},
> +	{0x5b02, 0x01},
> +	{0x5b03, 0xdb},
> +	{0x3d8c, 0x71},
> +	{0x3d8d, 0xea},
> +	{0x4017, 0x08},
> +	{0x3618, 0x2a},
> +	{0x5780, 0x3e},
> +	{0x5781, 0x0f},
> +	{0x5782, 0x44},
> +	{0x5783, 0x02},
> +	{0x5784, 0x01},
> +	{0x5785, 0x01},
> +	{0x5786, 0x00},
> +	{0x5787, 0x04},
> +	{0x5788, 0x02},
> +	{0x5789, 0x0f},
> +	{0x578a, 0xfd},
> +	{0x578b, 0xf5},
> +	{0x578c, 0xf5},
> +	{0x578d, 0x03},
> +	{0x578e, 0x08},
> +	{0x578f, 0x0c},
> +	{0x5790, 0x08},
> +	{0x5791, 0x06},
> +	{0x5792, 0x00},
> +	{0x5793, 0x52},
> +	{0x5794, 0xa3},
> +};
> +
> +static const struct ov5670_link_freq_config link_freq_configs[] = {
> +	{
> +		.link_freq = OV5670_LINK_FREQ_840MBPS,
> +		.pixel_rate = 336000000,
> +		.reg_list = {
> +			.num_of_regs = ARRAY_SIZE(mipi_data_rate_840mbps),
> +			.regs = mipi_data_rate_840mbps,
> +		}
> +	}
> +};
> +
> +static const struct ov5670_mode supported_modes[] = {
> +	{
> +		.width = 2576,
> +		.height = 1936,
> +		.skip_frames = 2,
> +		.reg_list = {
> +			.num_of_regs = ARRAY_SIZE(mode_2576x1936_regs),
> +			.regs = mode_2576x1936_regs,
> +		},
> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
> +	},
> +	{
> +		.width = 2576,
> +		.height = 1456,
> +		.skip_frames = 2,
> +		.reg_list = {
> +			.num_of_regs = ARRAY_SIZE(mode_2576x1456_regs),
> +			.regs = mode_2576x1456_regs,
> +		},
> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
> +	},
> +	{
> +		.width = 2560,
> +		.height = 1440,
> +		.skip_frames = 2,
> +		.reg_list = {
> +			.num_of_regs = ARRAY_SIZE(mode_2560x1440_regs),
> +			.regs = mode_2560x1440_regs,
> +		},
> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
> +	},
> +	{
> +		.width = 1936,
> +		.height = 1096,
> +		.skip_frames = 2,
> +		.reg_list = {
> +			.num_of_regs = ARRAY_SIZE(mode_1936x1096_regs),
> +			.regs = mode_1936x1096_regs,
> +		},
> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
> +	},
> +	{
> +		.width = 1920,
> +		.height = 1080,
> +		.skip_frames = 2,
> +		.reg_list = {
> +			.num_of_regs = ARRAY_SIZE(mode_1920x1080_regs),
> +			.regs = mode_1920x1080_regs,
> +		},
> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
> +	},
> +	{
> +		.width = 1440,
> +		.height = 1080,
> +		.skip_frames = 2,
> +		.reg_list = {
> +			.num_of_regs = ARRAY_SIZE(mode_1440x1080_regs),
> +			.regs = mode_1440x1080_regs,
> +		},
> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
> +	},
> +	{
> +		.width = 1296,
> +		.height = 736,
> +		.skip_frames = 2,
> +		.reg_list = {
> +			.num_of_regs = ARRAY_SIZE(mode_1296x736_regs),
> +			.regs = mode_1296x736_regs,
> +		},
> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
> +	},
> +	{
> +		.width = 1280,
> +		.height = 720,
> +		.skip_frames = 2,
> +		.reg_list = {
> +			.num_of_regs = ARRAY_SIZE(mode_1280x720_regs),
> +			.regs = mode_1280x720_regs,
> +		},
> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
> +	},
> +	{
> +		.width = 960,
> +		.height = 720,
> +		.skip_frames = 2,
> +		.reg_list = {
> +			.num_of_regs = ARRAY_SIZE(mode_960x720_regs),
> +			.regs = mode_960x720_regs,
> +		},
> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
> +	},
> +	{
> +		.width = 656,
> +		.height = 496,
> +		.skip_frames = 2,
> +		.reg_list = {
> +			.num_of_regs = ARRAY_SIZE(mode_656x496_regs),
> +			.regs = mode_656x496_regs,
> +		},
> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
> +	},
> +	{
> +		.width = 640,
> +		.height = 480,
> +		.skip_frames = 2,
> +		.reg_list = {
> +			.num_of_regs = ARRAY_SIZE(mode_640x480_regs),
> +			.regs = mode_640x480_regs,
> +		},
> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
> +	},
> +};
> +
> +static const s64 link_freq_menu_items[] = {
> +					OV5670_LINK_FREQ_840MBPS

Indentation.

> +				};
> +
> +struct ov5670 {
> +	struct v4l2_subdev sd;
> +	struct media_pad pad;
> +
> +	struct v4l2_ctrl_handler ctrl_handler;
> +	struct {
> +		struct v4l2_ctrl *link_freq;
> +		struct v4l2_ctrl *pixel_rate;
> +	};
> +
> +	/* Current mode */
> +	const struct ov5670_mode *cur_mode;
> +
> +	/* To protect from asynchronus callbacks */
> +	struct mutex mutex;
> +
> +	int link_freq_index;

You can use link_freq->val .

> +
> +	bool streaming;
> +};
> +
> +#define to_ov5670(_sd)	container_of(_sd, struct ov5670, sd)
> +
> +/* Read registers up to 4 at a time */
> +static int ov5670_read_reg(struct ov5670 *ov5670, u16 reg, u32 len, u32 *val)
> +{
> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
> +	struct i2c_msg msgs[2];
> +	u8 *data_be_p;
> +	u32 data_be = 0;
> +	u16 reg_addr_be = cpu_to_be16(reg);
> +
> +	if (len > 4)
> +		return -EINVAL;
> +
> +	data_be_p = (u8 *)&data_be;
> +	/* Write register address */
> +	msgs[0].addr = client->addr;
> +	msgs[0].flags = 0;
> +	msgs[0].len = 2;
> +	msgs[0].buf = (u8 *)&reg_addr_be;
> +
> +	/* Read data from register */
> +	msgs[1].addr = client->addr;
> +	msgs[1].flags = I2C_M_RD;
> +	msgs[1].len = len;
> +	msgs[1].buf = &data_be_p[4 - len];
> +
> +	if (i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs)) !=
> +			 ARRAY_SIZE(msgs))

Alignment.

> +		return -EIO;
> +
> +	*val = be32_to_cpu(data_be);
> +
> +	return 0;
> +}
> +
> +/* Write registers up to 4 at a time */
> +static int ov5670_write_reg(struct ov5670 *ov5670, u16 reg, u32 len, u32 val)
> +{
> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
> +	int buf_i;
> +	int val_i;
> +	u8 buf[6];
> +	u8 *val_p;
> +
> +	if (len > 4)
> +		return -EINVAL;
> +
> +	buf[0] = reg >> 8;
> +	buf[1] = reg & 0xff;
> +
> +	buf_i = 2;
> +	val_p = (u8 *)&val;
> +	for (val_i = len - 1; val_i >= 0; val_i--, buf_i++)
> +		buf[buf_i] = val_p[val_i];
> +
> +	if (i2c_master_send(client, buf, len + 2) != len + 2)
> +		return -EIO;
> +
> +	return 0;
> +}
> +
> +/* Write a list of registers */
> +static int ov5670_write_regs(struct ov5670 *ov5670,
> +			     const struct ov5670_reg *regs,
> +			     int len)

How about using unsigned int for len?

> +{
> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
> +	int i;

i as well.

> +	int ret;
> +
> +	for (i = 0; i < len; i++) {
> +		ret = ov5670_write_reg(ov5670, regs[i].address, 1, regs[i].val);
> +		if (ret) {
> +			dev_err_ratelimited(
> +				&client->dev,
> +				"Failed to write reg 0x%4.4x. error = %d\n",
> +				regs[i].address, ret);
> +
> +			return ret;
> +		}
> +	}
> +
> +	return 0;
> +}
> +
> +static int ov5670_write_reg_list(struct ov5670 *ov5670,
> +				 const struct ov5670_reg_list *r_list)
> +{
> +	return ov5670_write_regs(ov5670, r_list->regs, r_list->num_of_regs);
> +}
> +
> +/* Open sub-device */
> +static int ov5670_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
> +{
> +	struct ov5670 *ov5670 = to_ov5670(sd);
> +	struct v4l2_mbus_framefmt *try_fmt;
> +
> +	mutex_lock(&ov5670->mutex);
> +
> +	/* Initialize try_fmt */
> +	try_fmt = v4l2_subdev_get_try_format(sd, fh->pad, 0);
> +	try_fmt->width = ov5670->cur_mode->width;
> +	try_fmt->height = ov5670->cur_mode->height;
> +	try_fmt->code = MEDIA_BUS_FMT_SGRBG10_1X10;
> +	try_fmt->field = V4L2_FIELD_NONE;
> +
> +	/* No crop or compose */
> +	mutex_unlock(&ov5670->mutex);
> +
> +	return 0;
> +}
> +
> +/* Update analog gain */
> +static int ov5670_update_analog_gain(struct ov5670 *ov5670,
> +				     struct v4l2_ctrl *ctrl)
> +{
> +	u32 analog_gain;
> +
> +	analog_gain = ctrl->val;
> +
> +	return ov5670_write_reg(ov5670, OV5670_REG_ANALOG_GAIN,
> +				OV5670_REG_VALUE_16BIT, analog_gain);

You can use ctrl->val here directly.

> +}
> +
> +/* Exposure control */
> +static int ov5670_update_exposure_ctrl(struct ov5670 *ov5670,
> +				       struct v4l2_ctrl *ctrl)
> +{
> +	u32 exposure;
> +
> +	exposure = ctrl->val;
> +
> +	return ov5670_write_reg(ov5670, OV5670_REG_EXPOSURE,
> +				OV5670_REG_VALUE_24BIT, exposure);

Ditto.

> +}
> +
> +/* Get volatile controls */
> +static int ov5670_g_volatile_ctrl(struct v4l2_ctrl *ctrl)
> +{
> +	struct ov5670 *ov5670 = container_of(ctrl->handler,
> +					struct ov5670, ctrl_handler);
> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
> +	int link_freq_index;
> +	int ret = 0;
> +
> +	link_freq_index = ov5670->cur_mode->link_freq_index;
> +
> +	switch (ctrl->id) {
> +	case V4L2_CID_LINK_FREQ:
> +		ctrl->val = link_freq_index;
> +		break;
> +	case V4L2_CID_PIXEL_RATE:
> +		ctrl->val = link_freq_configs[link_freq_index].pixel_rate;
> +		break;
> +	default:
> +		dev_info(&client->dev, "unknown control 0x%x\n", ctrl->id);
> +		ret = -EINVAL;
> +	}
> +
> +	dev_dbg(&client->dev, "%s id:0x%x val:0x%x\n", __func__, ctrl->id,
> +		ctrl->val);

No need for a debug print.

> +	return ret;
> +}
> +
> +/* Initialize control handlers */
> +static int ov5670_set_ctrl(struct v4l2_ctrl *ctrl)
> +{
> +	struct ov5670 *ov5670 = container_of(ctrl->handler,
> +						struct ov5670, ctrl_handler);
> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
> +
> +	dev_dbg(&client->dev, "%s id:0x%x val:0x%x\n", __func__, ctrl->id,
> +		ctrl->val);

Ditto.

> +
> +	switch (ctrl->id) {
> +	case V4L2_CID_ANALOGUE_GAIN:
> +		return ov5670_update_analog_gain(ov5670, ctrl);
> +	case V4L2_CID_EXPOSURE:
> +		return ov5670_update_exposure_ctrl(ov5670, ctrl);
> +	case V4L2_CID_LINK_FREQ:
> +		break;
> +	default:
> +		dev_info(&client->dev, "id:0x%x, val:0x%x\n", ctrl->id,
> +			 ctrl->val);
> +		return 0;
> +	};
> +
> +	return 0;
> +}
> +
> +static const struct v4l2_ctrl_ops ov5670_ctrl_ops = {
> +	.g_volatile_ctrl = ov5670_g_volatile_ctrl,
> +	.s_ctrl = ov5670_set_ctrl,
> +};
> +
> +/* Initialize control handlers */
> +static int ov5670_init_controls(struct ov5670 *ov5670)
> +{
> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
> +	struct v4l2_ctrl_handler *ctrl_hdlr;
> +	int ret;
> +
> +	ctrl_hdlr = &ov5670->ctrl_handler;
> +	ret = v4l2_ctrl_handler_init(ctrl_hdlr, 4);
> +	if (ret)
> +		return ret;
> +
> +	ctrl_hdlr->lock = &ov5670->mutex;
> +	ov5670->link_freq = v4l2_ctrl_new_int_menu(ctrl_hdlr,
> +				&ov5670_ctrl_ops,
> +				V4L2_CID_LINK_FREQ, 1,
> +				ARRAY_SIZE(link_freq_menu_items) - 1,
> +				link_freq_menu_items);
> +	ov5670->link_freq->flags |= V4L2_CTRL_FLAG_VOLATILE;

Link frequency should be a read-only control. Could you use
V4L2_CTRL_FLAG_READ_ONLY instead? Use v4l2_ctrl_s_ctrl() to change its
value.

Although... you have just a single value for now.

> +
> +	ov5670->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov5670_ctrl_ops,
> +					V4L2_CID_PIXEL_RATE, 0,
> +					OV5670_LINK_FREQ_840MBPS, 1,
> +					link_freq_configs[0].pixel_rate);
> +	v4l2_ctrl_cluster(2, &ov5670->link_freq);
> +
> +	/* Get min, max, step, default from sensor */
> +	v4l2_ctrl_new_std(ctrl_hdlr, &ov5670_ctrl_ops, V4L2_CID_ANALOGUE_GAIN,
> +			  ANALOG_GAIN_MIN, ANALOG_GAIN_MAX, ANALOG_GAIN_STEP,
> +			  ANALOG_GAIN_DEFAULT);
> +
> +	/* Get min, max, step, default from sensor */
> +	v4l2_ctrl_new_std(ctrl_hdlr, &ov5670_ctrl_ops, V4L2_CID_EXPOSURE,
> +			  EXPOSURE_MIN, EXPOSURE_MAX, EXPOSURE_STEP,
> +			  EXPOSURE_DEFAULT);
> +
> +	if (ctrl_hdlr->error) {
> +		ret = ctrl_hdlr->error;
> +		dev_err(&client->dev, "%s control init failed (%d)\n", __func__,
> +			ret);

This could fail once you make changes to how controls are created but it's
not needed after development time. How about removing the message?

> +		goto error;
> +	}
> +
> +	ov5670->sd.ctrl_handler = ctrl_hdlr;
> +
> +	return 0;
> +
> +error:
> +	v4l2_ctrl_handler_free(ctrl_hdlr);
> +
> +	return ret;
> +}
> +
> +static void ov5670_update_pad_format(struct ov5670 *ov5670,

You have no use for ov5670 argument.

> +				     const struct ov5670_mode *mode,
> +				     struct v4l2_subdev_format *fmt)
> +{
> +	fmt->format.width = mode->width;
> +	fmt->format.height = mode->height;
> +	fmt->format.code = MEDIA_BUS_FMT_SGRBG10_1X10;
> +	fmt->format.field = V4L2_FIELD_NONE;
> +}
> +
> +static int ov5670_do_get_pad_format(struct ov5670 *ov5670,
> +				    struct v4l2_subdev_pad_config *cfg,
> +				    struct v4l2_subdev_format *fmt)
> +{
> +	struct v4l2_mbus_framefmt *framefmt;
> +	struct v4l2_subdev *sd = &ov5670->sd;
> +
> +	if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
> +		framefmt = v4l2_subdev_get_try_format(sd, cfg, fmt->pad);
> +		fmt->format = *framefmt;

You could do without framefmt.

> +	} else {
> +		ov5670_update_pad_format(ov5670, ov5670->cur_mode, fmt);
> +	}
> +
> +	return 0;
> +}
> +
> +static int ov5670_enum_mbus_code(struct v4l2_subdev *sd,
> +				 struct v4l2_subdev_pad_config *cfg,
> +				 struct v4l2_subdev_mbus_code_enum *code)
> +{
> +	/* Only one bayer order GRBG is supported */
> +	if (code->index > 0)
> +		return -EINVAL;
> +
> +	code->code = MEDIA_BUS_FMT_SGRBG10_1X10;

Newline, please.

> +	return 0;
> +}
> +
> +static int ov5670_enum_frame_size(struct v4l2_subdev *sd,
> +				  struct v4l2_subdev_pad_config *cfg,
> +				  struct v4l2_subdev_frame_size_enum *fse)
> +{
> +	if (fse->index >= ARRAY_SIZE(supported_modes))
> +		return -EINVAL;
> +
> +	if (fse->code != MEDIA_BUS_FMT_SGRBG10_1X10)
> +		return -EINVAL;
> +
> +	fse->min_width = supported_modes[fse->index].width;
> +	fse->max_width = fse->min_width;
> +	fse->min_height = supported_modes[fse->index].height;
> +	fse->max_height = fse->min_height;
> +
> +	return 0;
> +}
> +
> +static int ov5670_get_pad_format(struct v4l2_subdev *sd,
> +				 struct v4l2_subdev_pad_config *cfg,
> +				 struct v4l2_subdev_format *fmt)
> +{
> +	struct ov5670 *ov5670 = to_ov5670(sd);
> +	int ret;
> +
> +	mutex_lock(&ov5670->mutex);
> +	ret = ov5670_do_get_pad_format(ov5670, cfg, fmt);
> +	mutex_unlock(&ov5670->mutex);
> +
> +	return ret;
> +}
> +
> +/* Calculate resolution distance */
> +static int ov5670_get_reso_dist(const struct ov5670_mode *mode,
> +				struct v4l2_mbus_framefmt *framefmt)
> +{
> +	return abs(mode->width - framefmt->width) +
> +	       abs(mode->height - framefmt->height);
> +}
> +
> +/* Find the closest supported resolution to the requested resolution */
> +static const struct ov5670_mode *ov5670_find_best_fit(
> +						struct ov5670 *ov5670,
> +						struct v4l2_subdev_format *fmt)
> +{
> +	struct v4l2_mbus_framefmt *framefmt = &fmt->format;
> +	int dist;
> +	int cur_best_fit = 0;
> +	int cur_best_fit_dist = -1;
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(supported_modes); i++) {
> +		dist = ov5670_get_reso_dist(&supported_modes[i], framefmt);
> +		if (cur_best_fit_dist == -1 || dist < cur_best_fit_dist) {
> +			cur_best_fit_dist = dist;
> +			cur_best_fit = i;
> +		}
> +	}
> +
> +	return &supported_modes[cur_best_fit];
> +}
> +
> +static int ov5670_set_pad_format(struct v4l2_subdev *sd,
> +				 struct v4l2_subdev_pad_config *cfg,
> +				 struct v4l2_subdev_format *fmt)
> +{
> +	struct ov5670 *ov5670 = to_ov5670(sd);
> +	struct i2c_client *client = v4l2_get_subdevdata(sd);
> +	const struct ov5670_mode *mode;
> +	struct v4l2_mbus_framefmt *framefmt;
> +
> +	dev_dbg(&client->dev, "%s sd_name: %s pad: %d w: %d, h: %d code: 0x%x",
> +		__func__, sd->name, fmt->pad, fmt->format.width,
> +		fmt->format.height, fmt->format.code);
> +
> +	mutex_lock(&ov5670->mutex);
> +
> +	if (fmt->format.code != MEDIA_BUS_FMT_SGRBG10_1X10) {

Instead of returning an error you should adjust the format instead. I.e. in
this case just assign it to fmt->format.code.

> +		mutex_unlock(&ov5670->mutex);
> +		return -EINVAL;
> +	}
> +
> +	mode = ov5670_find_best_fit(ov5670, fmt);
> +	ov5670_update_pad_format(ov5670, mode, fmt);
> +	if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
> +		framefmt = v4l2_subdev_get_try_format(sd, cfg, fmt->pad);
> +		*framefmt = fmt->format;

You could do without framefmt. Up to you.

> +	} else {
> +		ov5670->cur_mode = mode;
> +	}
> +
> +	mutex_unlock(&ov5670->mutex);
> +
> +	return 0;
> +}
> +
> +static int ov5670_get_skip_frames(struct v4l2_subdev *sd, u32 *frames)
> +{
> +	struct ov5670 *ov5670 = to_ov5670(sd);
> +
> +	mutex_lock(&ov5670->mutex);
> +	*frames = ov5670->cur_mode->skip_frames;
> +	mutex_unlock(&ov5670->mutex);
> +
> +	return 0;
> +}
> +
> +/* Prepare streaming by writing default values and customized values */
> +static int ov5670_prepare_streaming(struct ov5670 *ov5670)
> +{
> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
> +	const struct ov5670_reg_list *reg_list;
> +	int link_freq_index;
> +	int ret;
> +
> +	/* Write the power up registers */
> +	ret = ov5670_write_reg(ov5670, OV5670_REG_SOFTWARE_RST,
> +			       OV5670_REG_VALUE_08BIT, OV5670_SOFTWARE_RST);
> +	if (ret) {
> +		dev_err(&client->dev, "%s failed to set powerup registers\n",
> +			__func__);
> +		return ret;
> +	}
> +
> +	/* Write pll registers */
> +	link_freq_index = ov5670->cur_mode->link_freq_index;
> +	reg_list = &link_freq_configs[link_freq_index].reg_list;
> +	ret = ov5670_write_reg_list(ov5670, reg_list);
> +	if (ret) {
> +		dev_err(&client->dev, "%s failed to set plls\n", __func__);
> +		return ret;
> +	}
> +
> +	/* Write the default values of current mode */
> +	reg_list = &ov5670->cur_mode->reg_list;
> +	ret = ov5670_write_reg_list(ov5670, reg_list);
> +	if (ret) {
> +		dev_err(&client->dev, "%s failed to set mode\n", __func__);
> +		return ret;
> +	}
> +
> +	dev_dbg(&client->dev, "%s init v4l2 controls", __func__);

Please remove the debug print.

> +
> +	ret = v4l2_ctrl_handler_setup(ov5670->sd.ctrl_handler);

I'd just return what v4l2_ctrl_handler_setup() does and remove the error
message.

> +	if (ret) {
> +		dev_err(&client->dev, "%s v4l2_ctrl_handler failed\n",
> +			__func__);
> +		return ret;
> +	}
> +
> +	return 0;
> +}
> +
> +static int ov5670_start_streaming(struct ov5670 *ov5670)
> +{
> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
> +	int ret;
> +
> +	/* Write stream on list */
> +	ret = ov5670_write_reg(ov5670, OV5670_REG_MODE_SELECT,
> +			       OV5670_REG_VALUE_08BIT, OV5670_MODE_STREAMING);
> +	if (ret) {
> +		dev_err(&client->dev, "%s failed to set stream\n", __func__);
> +		return ret;
> +	}
> +
> +	ov5670->streaming = 1;
> +	return 0;
> +}
> +
> +static int ov5670_stop_streaming(struct ov5670 *ov5670)
> +{
> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
> +	int ret;
> +
> +	ret = ov5670_write_reg(ov5670, OV5670_REG_MODE_SELECT,
> +			       OV5670_REG_VALUE_08BIT, OV5670_MODE_STANDBY);
> +	if (ret) {
> +		dev_err(&client->dev, "%s failed to set stream\n", __func__);
> +		return ret;
> +	}
> +	ov5670->streaming = 0;
> +	return ret;
> +}
> +
> +static int ov5670_set_stream(struct v4l2_subdev *sd, int enable)
> +{
> +	struct ov5670 *ov5670 = to_ov5670(sd);
> +	int ret = 0;
> +
> +	mutex_lock(&ov5670->mutex);
> +	if (ov5670->streaming == enable) {
> +		mutex_unlock(&ov5670->mutex);
> +		return 0;
> +	}
> +	mutex_unlock(&ov5670->mutex);
> +
> +	if (enable) {
> +		ret = ov5670_prepare_streaming(ov5670);

ov5670_prepare_streaming() and ov5670_start_streaming() are always called
sequientally. Could you combine the two?

About locking --- you would likely benefit from an unlocked variant of
v4l2_ctrl_handler_setup(). I uploaded it here, let me know if it works for
you:

<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=ctrl-setup-unlocked>

> +		if (ret)
> +			return ret;
> +
> +		mutex_lock(&ov5670->mutex);
> +		ret = ov5670_start_streaming(ov5670);
> +		mutex_unlock(&ov5670->mutex);
> +	} else {
> +		mutex_lock(&ov5670->mutex);
> +		ret = ov5670_stop_streaming(ov5670);
> +		mutex_unlock(&ov5670->mutex);
> +	}
> +
> +	return ret;
> +}
> +
> +#ifdef CONFIG_PM
> +
> +static int ov5670_suspend(struct device *dev)

Please remove #ifdef and use __maybe_unused instead. It's not easy to get
the #ifdefs right in all cases.

> +{
> +	struct i2c_client *client = to_i2c_client(dev);
> +	struct v4l2_subdev *sd = i2c_get_clientdata(client);
> +	struct ov5670 *ov5670 = to_ov5670(sd);
> +
> +	if (ov5670->streaming)
> +		ov5670_stop_streaming(ov5670);
> +
> +	return 0;
> +}
> +
> +static int ov5670_resume(struct device *dev)
> +{
> +	struct i2c_client *client = to_i2c_client(dev);
> +	struct v4l2_subdev *sd = i2c_get_clientdata(client);
> +	struct ov5670 *ov5670 = to_ov5670(sd);
> +	int ret;
> +
> +	if (ov5670->streaming) {
> +		ret = ov5670_prepare_streaming(ov5670);
> +		if (ret)
> +			goto error_prepare;
> +		ret = ov5670_start_streaming(ov5670);
> +		if (ret)
> +			goto error_prepare;
> +	}
> +
> +	return 0;
> +
> +error_prepare:
> +	ov5670_stop_streaming(ov5670);

Newline, please.

> +	return ret;
> +}
> +
> +#else
> +
> +#define ov5670_suspend	NULL
> +#define ov5670_resume	NULL
> +
> +#endif	/* CONFIG_PM */
> +
> +static int ov5670_identify_module(struct ov5670 *ov5670,
> +				  struct i2c_client *client)
> +{
> +	int ret;
> +	u32 val;
> +
> +	ret = ov5670_read_reg(ov5670, OV5670_REG_CHIPID,
> +			      OV5670_REG_VALUE_24BIT, &val);
> +	if (ret)
> +		return ret;
> +
> +	if (val != OV5670_CHIP_ID) {
> +		dev_err(&client->dev, "Unknown sensor(0x%x) detected\n", val);
> +		return -ENOTTY;
> +	}
> +
> +	return 0;
> +}
> +
> +static const struct v4l2_subdev_video_ops ov5670_video_ops = {
> +	.s_stream = ov5670_set_stream,
> +};
> +
> +static const struct v4l2_subdev_pad_ops ov5670_pad_ops = {
> +	.enum_mbus_code = ov5670_enum_mbus_code,
> +	.get_fmt = ov5670_get_pad_format,
> +	.set_fmt = ov5670_set_pad_format,
> +	.enum_frame_size = ov5670_enum_frame_size,
> +};
> +
> +static const struct v4l2_subdev_sensor_ops ov5670_sensor_ops = {
> +	.g_skip_frames = ov5670_get_skip_frames,
> +};
> +
> +static const struct v4l2_subdev_ops ov5670_subdev_ops = {
> +	.video = &ov5670_video_ops,
> +	.pad = &ov5670_pad_ops,
> +	.sensor = &ov5670_sensor_ops,
> +};
> +
> +static const struct media_entity_operations ov5670_subdev_entity_ops = {
> +	.link_validate = v4l2_subdev_link_validate,
> +};
> +
> +static const struct v4l2_subdev_internal_ops ov5670_internal_ops = {
> +	.open = ov5670_open,
> +};
> +
> +static int ov5670_probe(struct i2c_client *client,
> +			const struct i2c_device_id *devid)
> +{
> +	struct ov5670 *ov5670;
> +	int ret;
> +
> +	ov5670 = devm_kzalloc(&client->dev, sizeof(*ov5670), GFP_KERNEL);
> +	if (!ov5670)
> +		return -ENOMEM;
> +
> +	/* Initialize subdev */
> +	v4l2_i2c_subdev_init(&ov5670->sd, client, &ov5670_subdev_ops);
> +
> +	/* Check module identity */
> +	ret = ov5670_identify_module(ov5670, client);
> +	if (ret)
> +		return ret;
> +
> +	mutex_init(&ov5670->mutex);
> +
> +	/* Set default mode to max resolution */
> +	ov5670->cur_mode = &supported_modes[0];
> +
> +	ret = ov5670_init_controls(ov5670);
> +	if (ret)
> +		return ret;
> +
> +	ov5670->sd.internal_ops = &ov5670_internal_ops;
> +	ov5670->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
> +	ov5670->sd.entity.ops = &ov5670_subdev_entity_ops;
> +	ov5670->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
> +
> +	/* Source pad initialization */
> +	ov5670->pad.flags = MEDIA_PAD_FL_SOURCE;
> +	ret = media_entity_pads_init(&ov5670->sd.entity, 1, &ov5670->pad);
> +	if (ret) {
> +		dev_err(&client->dev, "%s failed:%d\n", __func__, ret);
> +		goto error_handler_free;
> +	}
> +
> +	/* Async register for subdev */
> +	ret = v4l2_async_register_subdev(&ov5670->sd);
> +	if (ret < 0)
> +		goto error_entity_cleanup;
> +
> +	ov5670->streaming = 0;
> +	dev_info(&client->dev, "%s done\n", __func__);

In ACPI based systems the device power management is handled by ACPI. Could
you add runtime PM support for this driver as well, so the device can be
powered off while not in use?

> +
> +	return 0;
> +
> +error_entity_cleanup:
> +	media_entity_cleanup(&ov5670->sd.entity);
> +
> +error_handler_free:
> +	v4l2_ctrl_handler_free(ov5670->sd.ctrl_handler);
> +
> +	dev_err(&client->dev, "%s failed:%d\n", __func__, ret);
> +	return ret;
> +}
> +
> +static int ov5670_remove(struct i2c_client *client)
> +{
> +	struct v4l2_subdev *sd = i2c_get_clientdata(client);
> +
> +	v4l2_async_unregister_subdev(sd);
> +	media_entity_cleanup(&sd->entity);
> +	v4l2_ctrl_handler_free(sd->ctrl_handler);
> +
> +	return 0;
> +}
> +
> +static const struct i2c_device_id ov5670_id_table[] = {
> +	{"ov5670", 0},
> +	{},
> +};
> +
> +MODULE_DEVICE_TABLE(i2c, ov5670_id_table);
> +
> +static const struct dev_pm_ops ov5670_pm_ops = {
> +	.suspend = ov5670_suspend,
> +	.resume = ov5670_resume,

Could you use SET_SYSTEM_SLEEP_PM_OPS() to set these?

> +};
> +
> +#ifdef CONFIG_ACPI
> +const struct acpi_device_id ov5670_acpi_ids[] = {

static?

> +	{"INT3479"},
> +	{ /* sentinel */ }
> +};
> +
> +MODULE_DEVICE_TABLE(acpi, ov5670_acpi_ids);
> +#endif
> +
> +static struct i2c_driver ov5670_i2c_driver = {

const?

> +	.driver = {
> +		.name = "ov5670",
> +		.owner = THIS_MODULE,
> +		.pm = &ov5670_pm_ops,
> +		.acpi_match_table = ACPI_PTR(ov5670_acpi_ids),
> +	},
> +	.probe = ov5670_probe,
> +	.remove = ov5670_remove,
> +	.id_table = ov5670_id_table,
> +};
> +
> +module_i2c_driver(ov5670_i2c_driver);
> +
> +MODULE_AUTHOR("Rapolu, Chiranjeevi <[e-mail]>");
> +MODULE_AUTHOR("Yang, Hyungwoo <[e-mail]>");
> +MODULE_AUTHOR("Pu, Yuning <[e-mail]>");
> +MODULE_DESCRIPTION("Omnivision ov5670 sensor driver");
> +MODULE_LICENSE("GPL");

Sakari Ailus May 4, 2017, 8:50 a.m. UTC | #2

On Thu, May 04, 2017 at 11:48:51AM +0300, Sakari Ailus wrote:
> On Wed, May 03, 2017 at 03:06:52PM -0700, Chiranjeevi Rapolu wrote:
> > Provides single source pad with up to 2576x1936 pixels at 10-bit raw
> > bayer format over MIPI CSI2 two lanes at 640Mbps/lane.
> > Supports up to 30fps at 5M pixels, up to 60fps at 1080p.
> > 
> > Signed-off-by: Chiranjeevi Rapolu <[e-mail]>
> > ---
> >  drivers/media/i2c/Kconfig  |   11 +
> >  drivers/media/i2c/Makefile |    1 +
> >  drivers/media/i2c/ov5670.c | 3890 ++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 3902 insertions(+)
> >  create mode 100644 drivers/media/i2c/ov5670.c
> > 
> > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> > index cee1dae..ded8485 100644
> > --- a/drivers/media/i2c/Kconfig
> > +++ b/drivers/media/i2c/Kconfig
> > @@ -531,6 +531,17 @@ config VIDEO_OV2659
> >  	  To compile this driver as a module, choose M here: the
> >  	  module will be called ov2659.
> >  
> > +config VIDEO_OV5670
> > +	tristate "OmniVision OV5670 sensor support"
> > +	depends on I2C && VIDEO_V4L2
> > +	depends on MEDIA_CAMERA_SUPPORT

select V4L2_FWNODE

Chiranjeevi Rapolu May 26, 2017, 1:19 a.m. UTC | #3

Sakari,

Thanks for the review.
1. Responses embedded below. Already submitted v2 patch to address these comments.
2. Can you submit <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=ctrl-setup-unlocked>?

-----Original Message-----
>From: Sakari Ailus [mailto:[e-mail]] 
>Sent: Thursday, May 4, 2017 1:49 AM
>To: Rapolu, Chiranjeevi <[e-mail]>
>Cc: [e-mail]; [e-mail]; Zheng, Jian Xu <[e-mail]>; Mani, Rajmohan <[e-mail]>; Yang, Hyungwoo <[e-mail]>
>Subject: Re: [PATCH] ov5670: Add Omnivision OV5670 5M sensor support
>
>Hi Chiranjeevi,
>
>Thanks for the patch.
>
>On Wed, May 03, 2017 at 03:06:52PM -0700, Chiranjeevi Rapolu wrote:
>> Provides single source pad with up to 2576x1936 pixels at 10-bit raw
>> bayer format over MIPI CSI2 two lanes at 640Mbps/lane.
>> Supports up to 30fps at 5M pixels, up to 60fps at 1080p.
>> 
>> Signed-off-by: Chiranjeevi Rapolu <[e-mail]>
>> ---
>>  drivers/media/i2c/Kconfig  |   11 +
>>  drivers/media/i2c/Makefile |    1 +
>>  drivers/media/i2c/ov5670.c | 3890 ++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 3902 insertions(+)
>>  create mode 100644 drivers/media/i2c/ov5670.c
>> 
>> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
>> index cee1dae..ded8485 100644
>> --- a/drivers/media/i2c/Kconfig
>> +++ b/drivers/media/i2c/Kconfig
>> @@ -531,6 +531,17 @@ config VIDEO_OV2659
>>  	  To compile this driver as a module, choose M here: the
>>  	  module will be called ov2659.
>>  
>> +config VIDEO_OV5670
>> +	tristate "OmniVision OV5670 sensor support"
>> +	depends on I2C && VIDEO_V4L2
>> +	depends on MEDIA_CAMERA_SUPPORT
>> +	---help---
>> +	  This is a Video4Linux2 sensor-level driver for the OmniVision
>> +	  OV5670 camera.
>> +
>> +	  To compile this driver as a module, choose M here: the
>> +	  module will be called ov5670.
>> +
>>  config VIDEO_OV7640
>>  	tristate "OmniVision OV7640 sensor support"
>>  	depends on I2C && VIDEO_V4L2
>> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
>> index 5bc7bbe..3efc61f 100644
>> --- a/drivers/media/i2c/Makefile
>> +++ b/drivers/media/i2c/Makefile
>> @@ -57,6 +57,7 @@ obj-$(CONFIG_VIDEO_VP27SMPX) += vp27smpx.o
>>  obj-$(CONFIG_VIDEO_SONY_BTF_MPX) += sony-btf-mpx.o
>>  obj-$(CONFIG_VIDEO_UPD64031A) += upd64031a.o
>>  obj-$(CONFIG_VIDEO_UPD64083) += upd64083.o
>> +obj-$(CONFIG_VIDEO_OV5670) += ov5670.o
>
>The patch no longer applies cleanly to current media-tree master. Could you
>rebase it on top of that?
>
Rebased
>>  obj-$(CONFIG_VIDEO_OV7640) += ov7640.o
>>  obj-$(CONFIG_VIDEO_OV7670) += ov7670.o
>>  obj-$(CONFIG_VIDEO_OV9650) += ov9650.o
>> diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c
>> new file mode 100644
>> index 0000000..394f8f2
>> --- /dev/null
>> +++ b/drivers/media/i2c/ov5670.c
>> @@ -0,0 +1,3890 @@
>> +/*
>> + * Copyright (c) 2017 Intel Corporation.
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License version
>> + * 2 as published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + */
>> +
>> +#include <linux/acpi.h>
>> +#include <linux/delay.h>
>
>Do you need delay.h?
>
Not needed, deleted delay.h
>> +#include <linux/i2c.h>
>> +#include <linux/module.h>
>> +#include <media/v4l2-device.h>
>> +#include <media/v4l2-ctrls.h>
>
>Alphabetical order, please.
>
Sorted.
>> +
>> +#define OV5670_CHIP_ID			0x005670
>> +
>> +#define OV5670_REG_VALUE_08BIT		1
>> +#define OV5670_REG_VALUE_16BIT		2
>> +#define OV5670_REG_VALUE_24BIT		3
>> +
>> +#define OV5670_REG_MODE_SELECT		0x0100
>> +#define OV5670_MODE_STANDBY		0x00
>> +#define OV5670_MODE_STREAMING		0x01
>> +
>> +#define OV5670_REG_SOFTWARE_RST		0x0103
>> +#define OV5670_SOFTWARE_RST		0x01
>> +
>> +#define OV5670_REG_EXPOSURE		0x3500
>> +#define OV5670_REG_ANALOG_GAIN		0x3508
>> +
>> +#define OV5670_REG_CHIPID		0x300a
>> +
>> +/* Supported link frequencies */
>> +#define OV5670_LINK_FREQ_840MBPS		840000000
>> +#define OV5670_LINK_FREQ_840MBPS_INDEX		0
>
>It'd be better to define these there you have the related register lists.
>
Grouped related #defines.
>> +
>> +/* Analog gain controls from sensor */
>> +#define	ANALOG_GAIN_MIN		0
>> +#define	ANALOG_GAIN_MAX		8191
>> +#define	ANALOG_GAIN_STEP	1
>> +#define	ANALOG_GAIN_DEFAULT	128
>> +
>> +/* Exposure controls from sensor */
>> +#define	EXPOSURE_MIN		0
>> +#define	EXPOSURE_MAX		1048575
>> +#define	EXPOSURE_STEP		1
>> +#define	EXPOSURE_DEFAULT	47232
>
>Are these values dependent on sensor configuration i.e. in the case of this
>driver modes?
>
Default values for a given resolutions can be fine-tuned. I think it is up to
the HAL/application as to what default exposure for a given resolution. Driver
has the support to change per application.
>> +
>> +struct ov5670_reg {
>> +	u16 address;
>> +	u8 val;
>> +};
>> +
>> +struct ov5670_reg_list {
>> +	u32 num_of_regs;
>> +	const struct ov5670_reg *regs;
>> +};
>> +
>> +struct ov5670_link_freq_config {
>> +	s64 link_freq;
>> +	u32 pixel_rate;
>> +
>> +	const struct ov5670_reg_list reg_list;
>> +};
>> +
>> +struct ov5670_mode {
>> +	/* Frame width in pixels */
>> +	u32 width;
>> +
>> +	/* Frame height in pixels */
>> +	u32 height;
>> +
>> +	/* Initial number of frames to skip to avoid garbage in the frames */
>> +	u32 skip_frames;
>> +
>> +	/* Link frequency needed for this resolution */
>> +	u32 link_freq_index;
>> +
>> +	/* Sensor register settings for this resolution */
>> +	const struct ov5670_reg_list reg_list;
>> +};
>> +
>> +static const struct ov5670_reg mipi_data_rate_840mbps[] = {
>> +	{0x0300, 0x04},
>> +	{0x0301, 0x00},
>> +	{0x0302, 0x84},
>> +	{0x0303, 0x00},
>> +	{0x0304, 0x03},
>> +	{0x0305, 0x01},
>> +	{0x0306, 0x01},
>> +	{0x030a, 0x00},
>> +	{0x030b, 0x00},
>> +	{0x030c, 0x00},
>> +	{0x030d, 0x26},
>> +	{0x030e, 0x00},
>> +	{0x030f, 0x06},
>> +	{0x0312, 0x01},
>> +	{0x3031, 0x0a},
>> +};
>> +
>> +static const struct ov5670_reg mode_640x480_regs[] = {
>> +	{0x3000, 0x00},
>> +	{0x3002, 0x61},
>> +	{0x3005, 0xf0},
>> +	{0x3007, 0x00},
>> +	{0x300D, 0x00},
>> +	{0x3015, 0x0f},
>> +	{0x3018, 0x32},
>> +	{0x3010, 0x40},
>> +	{0x301a, 0xf0},
>> +	{0x301b, 0xf0},
>> +	{0x301c, 0xf0},
>> +	{0x301d, 0xf0},
>> +	{0x301e, 0xf0},
>> +	{0x3030, 0x00},
>> +	{0x303c, 0xff},
>> +	{0x303e, 0xff},
>> +	{0x3040, 0xf0},
>> +	{0x3041, 0x00},
>> +	{0x3042, 0xf0},
>> +	{0x3106, 0x11},
>> +	{0x3500, 0x00},
>> +	{0x3501, 0xb8},
>> +	{0x3502, 0x80},
>> +	{0x3503, 0x00},
>> +	{0x3504, 0x03},
>> +	{0x3505, 0x83},
>> +	{0x3508, 0x04},
>> +	{0x3509, 0x00},
>> +	{0x350e, 0x04},
>> +	{0x350f, 0x00},
>> +	{0x3510, 0x00},
>> +	{0x3511, 0x02},
>> +	{0x3512, 0x00},
>> +	{0x3601, 0xc8},
>> +	{0x3610, 0x88},
>> +	{0x3612, 0x48},
>> +	{0x3614, 0x5b},
>> +	{0x3615, 0x96},
>> +	{0x3621, 0xd0},
>> +	{0x3622, 0x00},
>> +	{0x3623, 0x04},
>> +	{0x3633, 0x13},
>> +	{0x3634, 0x13},
>> +	{0x3635, 0x13},
>> +	{0x3636, 0x13},
>> +	{0x3645, 0x13},
>> +	{0x3646, 0x82},
>> +	{0x3650, 0x00},
>> +	{0x3652, 0xff},
>> +	{0x3655, 0x20},
>> +	{0x3656, 0xff},
>> +	{0x365a, 0xff},
>> +	{0x365e, 0xff},
>> +	{0x3668, 0x00},
>> +	{0x366a, 0x07},
>> +	{0x366e, 0x08},
>> +	{0x366d, 0x00},
>> +	{0x366f, 0x80},
>> +	{0x3700, 0x28},
>> +	{0x3701, 0x10},
>> +	{0x3702, 0x3a},
>> +	{0x3703, 0x19},
>> +	{0x3704, 0x10},
>> +	{0x3705, 0x00},
>> +	{0x3706, 0x66},
>> +	{0x3707, 0x08},
>> +	{0x3708, 0x34},
>> +	{0x3709, 0x40},
>> +	{0x370a, 0x01},
>> +	{0x370b, 0x1b},
>> +	{0x3714, 0x24},
>> +	{0x371a, 0x3e},
>> +	{0x3733, 0x00},
>> +	{0x3734, 0x00},
>> +	{0x373a, 0x05},
>> +	{0x373b, 0x06},
>> +	{0x373c, 0x0a},
>> +	{0x373f, 0xa0},
>> +	{0x3755, 0x00},
>> +	{0x3758, 0x00},
>> +	{0x375b, 0x0e},
>> +	{0x3766, 0x5f},
>> +	{0x3768, 0x00},
>> +	{0x3769, 0x22},
>> +	{0x3773, 0x08},
>> +	{0x3774, 0x1f},
>> +	{0x3776, 0x06},
>> +	{0x37a0, 0x88},
>> +	{0x37a1, 0x5c},
>> +	{0x37a7, 0x88},
>> +	{0x37a8, 0x70},
>> +	{0x37aa, 0x88},
>> +	{0x37ab, 0x48},
>> +	{0x37b3, 0x66},
>> +	{0x37c2, 0x04},
>> +	{0x37c5, 0x00},
>> +	{0x37c8, 0x00},
>> +	{0x3800, 0x00},
>> +	{0x3801, 0x0c},
>> +	{0x3802, 0x00},
>> +	{0x3803, 0x04},
>> +	{0x3804, 0x0a},
>> +	{0x3805, 0x33},
>> +	{0x3806, 0x07},
>> +	{0x3807, 0xa3},
>> +	{0x3808, 0x02},
>> +	{0x3809, 0x80},
>> +	{0x380a, 0x01},
>> +	{0x380b, 0xe0},
>> +	{0x380c, 0x06},
>> +	{0x380d, 0xa8},
>> +	{0x380e, 0x07},
>> +	{0x380f, 0xf6},
>> +	{0x3811, 0x04},
>> +	{0x3813, 0x02},
>> +	{0x3814, 0x07},
>> +	{0x3815, 0x01},
>> +	{0x3816, 0x00},
>> +	{0x3817, 0x00},
>> +	{0x3818, 0x00},
>> +	{0x3819, 0x00},
>> +	{0x3820, 0x94},
>> +	{0x3821, 0xc0},
>> +	{0x3822, 0x48},
>> +	{0x3826, 0x00},
>> +	{0x3827, 0x08},
>> +	{0x382a, 0x07},
>> +	{0x382b, 0x01},
>> +	{0x3830, 0x08},
>> +	{0x3836, 0x02},
>> +	{0x3837, 0x00},
>> +	{0x3838, 0x10},
>> +	{0x3841, 0xff},
>> +	{0x3846, 0x48},
>> +	{0x3861, 0x00},
>> +	{0x3862, 0x04},
>> +	{0x3863, 0x06},
>> +	{0x3a11, 0x01},
>> +	{0x3a12, 0x78},
>> +	{0x3b00, 0x00},
>> +	{0x3b02, 0x00},
>> +	{0x3b03, 0x00},
>> +	{0x3b04, 0x00},
>> +	{0x3b05, 0x00},
>> +	{0x3c00, 0x89},
>> +	{0x3c01, 0xab},
>> +	{0x3c02, 0x01},
>> +	{0x3c03, 0x00},
>> +	{0x3c04, 0x00},
>> +	{0x3c05, 0x03},
>> +	{0x3c06, 0x00},
>> +	{0x3c07, 0x05},
>> +	{0x3c0c, 0x00},
>> +	{0x3c0d, 0x00},
>> +	{0x3c0e, 0x00},
>> +	{0x3c0f, 0x00},
>> +	{0x3c40, 0x00},
>> +	{0x3c41, 0xa3},
>> +	{0x3c43, 0x7d},
>> +	{0x3c45, 0xd7},
>> +	{0x3c47, 0xfc},
>> +	{0x3c50, 0x05},
>> +	{0x3c52, 0xaa},
>> +	{0x3c54, 0x71},
>> +	{0x3c56, 0x80},
>> +	{0x3d85, 0x17},
>> +	{0x3f03, 0x00},
>> +	{0x3f0a, 0x00},
>> +	{0x3f0b, 0x00},
>> +	{0x4001, 0x60},
>> +	{0x4009, 0x05},
>> +	{0x4020, 0x00},
>> +	{0x4021, 0x00},
>> +	{0x4022, 0x00},
>> +	{0x4023, 0x00},
>> +	{0x4024, 0x00},
>> +	{0x4025, 0x00},
>> +	{0x4026, 0x00},
>> +	{0x4027, 0x00},
>> +	{0x4028, 0x00},
>> +	{0x4029, 0x00},
>> +	{0x402a, 0x00},
>> +	{0x402b, 0x00},
>> +	{0x402c, 0x00},
>> +	{0x402d, 0x00},
>> +	{0x402e, 0x00},
>> +	{0x402f, 0x00},
>> +	{0x4040, 0x00},
>> +	{0x4041, 0x03},
>> +	{0x4042, 0x00},
>> +	{0x4043, 0x7A},
>> +	{0x4044, 0x00},
>> +	{0x4045, 0x7A},
>> +	{0x4046, 0x00},
>> +	{0x4047, 0x7A},
>> +	{0x4048, 0x00},
>> +	{0x4049, 0x7A},
>> +	{0x4303, 0x00},
>> +	{0x4307, 0x30},
>> +	{0x4500, 0x58},
>> +	{0x4501, 0x04},
>> +	{0x4502, 0x40},
>> +	{0x4503, 0x10},
>> +	{0x4508, 0x55},
>> +	{0x4509, 0x55},
>> +	{0x450a, 0x02},
>> +	{0x450b, 0x00},
>> +	{0x4600, 0x00},
>> +	{0x4601, 0x40},
>> +	{0x4700, 0xa4},
>> +	{0x4800, 0x4c},
>> +	{0x4816, 0x53},
>> +	{0x481f, 0x40},
>> +	{0x4837, 0x12},
>> +	{0x5000, 0x56},
>> +	{0x5001, 0x01},
>> +	{0x5002, 0x28},
>> +	{0x5004, 0x0c},
>> +	{0x5006, 0x0c},
>> +	{0x5007, 0xe0},
>> +	{0x5008, 0x01},
>> +	{0x5009, 0xb0},
>> +	{0x5045, 0x05},
>> +	{0x5048, 0x10},
>> +	{0x5901, 0x00},
>> +	{0x5a01, 0x00},
>> +	{0x5a03, 0x00},
>> +	{0x5a04, 0x0c},
>> +	{0x5a05, 0xe0},
>> +	{0x5a06, 0x09},
>> +	{0x5a07, 0xb0},
>> +	{0x5a08, 0x06},
>> +	{0x5e00, 0x00},
>> +	{0x3734, 0x40},
>> +	{0x5b00, 0x01},
>> +	{0x5b01, 0x10},
>> +	{0x5b02, 0x01},
>> +	{0x5b03, 0xdb},
>> +	{0x3d8c, 0x71},
>> +	{0x3d8d, 0xea},
>> +	{0x4017, 0x10},
>> +	{0x3618, 0x2a},
>> +	{0x5780, 0x3e},
>> +	{0x5781, 0x0f},
>> +	{0x5782, 0x44},
>> +	{0x5783, 0x02},
>> +	{0x5784, 0x01},
>> +	{0x5785, 0x01},
>> +	{0x5786, 0x00},
>> +	{0x5787, 0x04},
>> +	{0x5788, 0x02},
>> +	{0x5789, 0x0f},
>> +	{0x578a, 0xfd},
>> +	{0x578b, 0xf5},
>> +	{0x578c, 0xf5},
>> +	{0x578d, 0x03},
>> +	{0x578e, 0x08},
>> +	{0x578f, 0x0c},
>> +	{0x5790, 0x08},
>> +	{0x5791, 0x06},
>> +	{0x5792, 0x00},
>> +	{0x5793, 0x52},
>> +	{0x5794, 0xa3},
>> +};
>> +
>> +static const struct ov5670_reg mode_656x496_regs[] = {
>> +	{0x3000, 0x00},
>> +	{0x3002, 0x61},
>> +	{0x3005, 0xf0},
>> +	{0x3007, 0x00},
>> +	{0x300D, 0x00},
>> +	{0x3015, 0x0f},
>> +	{0x3018, 0x32},
>> +	{0x3010, 0x40},
>> +	{0x301a, 0xf0},
>> +	{0x301b, 0xf0},
>> +	{0x301c, 0xf0},
>> +	{0x301d, 0xf0},
>> +	{0x301e, 0xf0},
>> +	{0x3030, 0x00},
>> +	{0x303c, 0xff},
>> +	{0x303e, 0xff},
>> +	{0x3040, 0xf0},
>> +	{0x3041, 0x00},
>> +	{0x3042, 0xf0},
>> +	{0x3106, 0x11},
>> +	{0x3500, 0x00},
>> +	{0x3501, 0xb8},
>> +	{0x3502, 0x80},
>> +	{0x3503, 0x00},
>> +	{0x3504, 0x03},
>> +	{0x3505, 0x83},
>> +	{0x3508, 0x04},
>> +	{0x3509, 0x00},
>> +	{0x350e, 0x04},
>> +	{0x350f, 0x00},
>> +	{0x3510, 0x00},
>> +	{0x3511, 0x02},
>> +	{0x3512, 0x00},
>> +	{0x3601, 0xc8},
>> +	{0x3610, 0x88},
>> +	{0x3612, 0x48},
>> +	{0x3614, 0x5b},
>> +	{0x3615, 0x96},
>> +	{0x3621, 0xd0},
>> +	{0x3622, 0x00},
>> +	{0x3623, 0x04},
>> +	{0x3633, 0x13},
>> +	{0x3634, 0x13},
>> +	{0x3635, 0x13},
>> +	{0x3636, 0x13},
>> +	{0x3645, 0x13},
>> +	{0x3646, 0x82},
>> +	{0x3650, 0x00},
>> +	{0x3652, 0xff},
>> +	{0x3655, 0x20},
>> +	{0x3656, 0xff},
>> +	{0x365a, 0xff},
>> +	{0x365e, 0xff},
>> +	{0x3668, 0x00},
>> +	{0x366a, 0x07},
>> +	{0x366e, 0x08},
>> +	{0x366d, 0x00},
>> +	{0x366f, 0x80},
>> +	{0x3700, 0x28},
>> +	{0x3701, 0x10},
>> +	{0x3702, 0x3a},
>> +	{0x3703, 0x19},
>> +	{0x3704, 0x10},
>> +	{0x3705, 0x00},
>> +	{0x3706, 0x66},
>> +	{0x3707, 0x08},
>> +	{0x3708, 0x34},
>> +	{0x3709, 0x40},
>> +	{0x370a, 0x01},
>> +	{0x370b, 0x1b},
>> +	{0x3714, 0x24},
>> +	{0x371a, 0x3e},
>> +	{0x3733, 0x00},
>> +	{0x3734, 0x00},
>> +	{0x373a, 0x05},
>> +	{0x373b, 0x06},
>> +	{0x373c, 0x0a},
>> +	{0x373f, 0xa0},
>> +	{0x3755, 0x00},
>> +	{0x3758, 0x00},
>> +	{0x375b, 0x0e},
>> +	{0x3766, 0x5f},
>> +	{0x3768, 0x00},
>> +	{0x3769, 0x22},
>> +	{0x3773, 0x08},
>> +	{0x3774, 0x1f},
>> +	{0x3776, 0x06},
>> +	{0x37a0, 0x88},
>> +	{0x37a1, 0x5c},
>> +	{0x37a7, 0x88},
>> +	{0x37a8, 0x70},
>> +	{0x37aa, 0x88},
>> +	{0x37ab, 0x48},
>> +	{0x37b3, 0x66},
>> +	{0x37c2, 0x04},
>> +	{0x37c5, 0x00},
>> +	{0x37c8, 0x00},
>> +	{0x3800, 0x00},
>> +	{0x3801, 0x0c},
>> +	{0x3802, 0x00},
>> +	{0x3803, 0x04},
>> +	{0x3804, 0x0a},
>> +	{0x3805, 0x33},
>> +	{0x3806, 0x07},
>> +	{0x3807, 0xa3},
>> +	{0x3808, 0x02},
>> +	{0x3809, 0x90},
>> +	{0x380a, 0x01},
>> +	{0x380b, 0xf0},
>> +	{0x380c, 0x06},
>> +	{0x380d, 0xa8},
>> +	{0x380e, 0x07},
>> +	{0x380f, 0xf6},
>> +	{0x3811, 0x04},
>> +	{0x3813, 0x02},
>> +	{0x3814, 0x07},
>> +	{0x3815, 0x01},
>> +	{0x3816, 0x00},
>> +	{0x3817, 0x00},
>> +	{0x3818, 0x00},
>> +	{0x3819, 0x00},
>> +	{0x3820, 0x94},
>> +	{0x3821, 0xc0},
>> +	{0x3822, 0x48},
>> +	{0x3826, 0x00},
>> +	{0x3827, 0x08},
>> +	{0x382a, 0x07},
>> +	{0x382b, 0x01},
>> +	{0x3830, 0x08},
>> +	{0x3836, 0x02},
>> +	{0x3837, 0x00},
>> +	{0x3838, 0x10},
>> +	{0x3841, 0xff},
>> +	{0x3846, 0x48},
>> +	{0x3861, 0x00},
>> +	{0x3862, 0x04},
>> +	{0x3863, 0x06},
>> +	{0x3a11, 0x01},
>> +	{0x3a12, 0x78},
>> +	{0x3b00, 0x00},
>> +	{0x3b02, 0x00},
>> +	{0x3b03, 0x00},
>> +	{0x3b04, 0x00},
>> +	{0x3b05, 0x00},
>> +	{0x3c00, 0x89},
>> +	{0x3c01, 0xab},
>> +	{0x3c02, 0x01},
>> +	{0x3c03, 0x00},
>> +	{0x3c04, 0x00},
>> +	{0x3c05, 0x03},
>> +	{0x3c06, 0x00},
>> +	{0x3c07, 0x05},
>> +	{0x3c0c, 0x00},
>> +	{0x3c0d, 0x00},
>> +	{0x3c0e, 0x00},
>> +	{0x3c0f, 0x00},
>> +	{0x3c40, 0x00},
>> +	{0x3c41, 0xa3},
>> +	{0x3c43, 0x7d},
>> +	{0x3c45, 0xd7},
>> +	{0x3c47, 0xfc},
>> +	{0x3c50, 0x05},
>> +	{0x3c52, 0xaa},
>> +	{0x3c54, 0x71},
>> +	{0x3c56, 0x80},
>> +	{0x3d85, 0x17},
>> +	{0x3f03, 0x00},
>> +	{0x3f0a, 0x00},
>> +	{0x3f0b, 0x00},
>> +	{0x4001, 0x60},
>> +	{0x4009, 0x05},
>> +	{0x4020, 0x00},
>> +	{0x4021, 0x00},
>> +	{0x4022, 0x00},
>> +	{0x4023, 0x00},
>> +	{0x4024, 0x00},
>> +	{0x4025, 0x00},
>> +	{0x4026, 0x00},
>> +	{0x4027, 0x00},
>> +	{0x4028, 0x00},
>> +	{0x4029, 0x00},
>> +	{0x402a, 0x00},
>> +	{0x402b, 0x00},
>> +	{0x402c, 0x00},
>> +	{0x402d, 0x00},
>> +	{0x402e, 0x00},
>> +	{0x402f, 0x00},
>> +	{0x4040, 0x00},
>> +	{0x4041, 0x03},
>> +	{0x4042, 0x00},
>> +	{0x4043, 0x7A},
>> +	{0x4044, 0x00},
>> +	{0x4045, 0x7A},
>> +	{0x4046, 0x00},
>> +	{0x4047, 0x7A},
>> +	{0x4048, 0x00},
>> +	{0x4049, 0x7A},
>> +	{0x4303, 0x00},
>> +	{0x4307, 0x30},
>> +	{0x4500, 0x58},
>> +	{0x4501, 0x04},
>> +	{0x4502, 0x40},
>> +	{0x4503, 0x10},
>> +	{0x4508, 0x55},
>> +	{0x4509, 0x55},
>> +	{0x450a, 0x02},
>> +	{0x450b, 0x00},
>> +	{0x4600, 0x00},
>> +	{0x4601, 0x40},
>> +	{0x4700, 0xa4},
>> +	{0x4800, 0x4c},
>> +	{0x4816, 0x53},
>> +	{0x481f, 0x40},
>> +	{0x4837, 0x12},
>> +	{0x5000, 0x56},
>> +	{0x5001, 0x01},
>> +	{0x5002, 0x28},
>> +	{0x5004, 0x0c},
>> +	{0x5006, 0x0c},
>> +	{0x5007, 0xe0},
>> +	{0x5008, 0x01},
>> +	{0x5009, 0xb0},
>> +	{0x5045, 0x05},
>> +	{0x5048, 0x10},
>> +	{0x5901, 0x00},
>> +	{0x5a01, 0x00},
>> +	{0x5a03, 0x00},
>> +	{0x5a04, 0x0c},
>> +	{0x5a05, 0xe0},
>> +	{0x5a06, 0x09},
>> +	{0x5a07, 0xb0},
>> +	{0x5a08, 0x06},
>> +	{0x5e00, 0x00},
>> +	{0x3734, 0x40},
>> +	{0x5b00, 0x01},
>> +	{0x5b01, 0x10},
>> +	{0x5b02, 0x01},
>> +	{0x5b03, 0xdb},
>> +	{0x3d8c, 0x71},
>> +	{0x3d8d, 0xea},
>> +	{0x4017, 0x10},
>> +	{0x3618, 0x2a},
>> +	{0x5780, 0x3e},
>> +	{0x5781, 0x0f},
>> +	{0x5782, 0x44},
>> +	{0x5783, 0x02},
>> +	{0x5784, 0x01},
>> +	{0x5785, 0x01},
>> +	{0x5786, 0x00},
>> +	{0x5787, 0x04},
>> +	{0x5788, 0x02},
>> +	{0x5789, 0x0f},
>> +	{0x578a, 0xfd},
>> +	{0x578b, 0xf5},
>> +	{0x578c, 0xf5},
>> +	{0x578d, 0x03},
>> +	{0x578e, 0x08},
>> +	{0x578f, 0x0c},
>> +	{0x5790, 0x08},
>> +	{0x5791, 0x06},
>> +	{0x5792, 0x00},
>> +	{0x5793, 0x52},
>> +	{0x5794, 0xa3},
>> +};
>> +
>> +static const struct ov5670_reg mode_1280x720_regs[] = {
>> +	{0x3000, 0x00},
>> +	{0x3002, 0x61},
>> +	{0x3005, 0xf0},
>> +	{0x3007, 0x00},
>> +	{0x300D, 0x00},
>> +	{0x3010, 0x40},
>> +	{0x3015, 0x0f},
>> +	{0x3018, 0x32},
>> +	{0x301a, 0xf0},
>> +	{0x301b, 0xf0},
>> +	{0x301c, 0xf0},
>> +	{0x301d, 0xf0},
>> +	{0x301e, 0xf0},
>> +	{0x3030, 0x00},
>> +	{0x303c, 0xff},
>> +	{0x303e, 0xff},
>> +	{0x3040, 0xf0},
>> +	{0x3041, 0x00},
>> +	{0x3042, 0xf0},
>> +	{0x3106, 0x11},
>> +	{0x3500, 0x00},
>> +	{0x3501, 0xb8},
>> +	{0x3502, 0x80},
>> +	{0x3503, 0x00},
>> +	{0x3504, 0x03},
>> +	{0x3505, 0x83},
>> +	{0x3508, 0x04},
>> +	{0x3509, 0x00},
>> +	{0x350e, 0x04},
>> +	{0x350f, 0x00},
>> +	{0x3510, 0x00},
>> +	{0x3511, 0x02},
>> +	{0x3512, 0x00},
>> +	{0x3601, 0xc8},
>> +	{0x3610, 0x88},
>> +	{0x3612, 0x48},
>> +	{0x3614, 0x5b},
>> +	{0x3615, 0x96},
>> +	{0x3621, 0xd0},
>> +	{0x3622, 0x00},
>> +	{0x3623, 0x00},
>> +	{0x3633, 0x13},
>> +	{0x3634, 0x13},
>> +	{0x3635, 0x13},
>> +	{0x3636, 0x13},
>> +	{0x3645, 0x13},
>> +	{0x3646, 0x82},
>> +	{0x3650, 0x00},
>> +	{0x3652, 0xff},
>> +	{0x3655, 0x20},
>> +	{0x3656, 0xff},
>> +	{0x365a, 0xff},
>> +	{0x365e, 0xff},
>> +	{0x3668, 0x00},
>> +	{0x366a, 0x07},
>> +	{0x366e, 0x08},
>> +	{0x366d, 0x00},
>> +	{0x366f, 0x80},
>> +	{0x3700, 0x28},
>> +	{0x3701, 0x10},
>> +	{0x3702, 0x3a},
>> +	{0x3703, 0x19},
>> +	{0x3704, 0x10},
>> +	{0x3705, 0x00},
>> +	{0x3706, 0x66},
>> +	{0x3707, 0x08},
>> +	{0x3708, 0x34},
>> +	{0x3709, 0x40},
>> +	{0x370a, 0x01},
>> +	{0x370b, 0x1b},
>> +	{0x3714, 0x24},
>> +	{0x371a, 0x3e},
>> +	{0x3733, 0x00},
>> +	{0x3734, 0x00},
>> +	{0x373a, 0x05},
>> +	{0x373b, 0x06},
>> +	{0x373c, 0x0a},
>> +	{0x373f, 0xa0},
>> +	{0x3755, 0x00},
>> +	{0x3758, 0x00},
>> +	{0x375b, 0x0e},
>> +	{0x3766, 0x5f},
>> +	{0x3768, 0x00},
>> +	{0x3769, 0x22},
>> +	{0x3773, 0x08},
>> +	{0x3774, 0x1f},
>> +	{0x3776, 0x06},
>> +	{0x37a0, 0x88},
>> +	{0x37a1, 0x5c},
>> +	{0x37a7, 0x88},
>> +	{0x37a8, 0x70},
>> +	{0x37aa, 0x88},
>> +	{0x37ab, 0x48},
>> +	{0x37b3, 0x66},
>> +	{0x37c2, 0x04},
>> +	{0x37c5, 0x00},
>> +	{0x37c8, 0x00},
>> +	{0x3800, 0x00},
>> +	{0x3801, 0x0c},
>> +	{0x3802, 0x00},
>> +	{0x3803, 0x04},
>> +	{0x3804, 0x0a},
>> +	{0x3805, 0x33},
>> +	{0x3806, 0x07},
>> +	{0x3807, 0xa3},
>> +	{0x3808, 0x05},
>> +	{0x3809, 0x00},
>> +	{0x380a, 0x02},
>> +	{0x380b, 0xd0},
>> +	{0x380c, 0x06},
>> +	{0x380d, 0xa8},
>> +	{0x380e, 0x07},
>> +	{0x380f, 0xf6},
>> +	{0x3811, 0x04},
>> +	{0x3813, 0x02},
>> +	{0x3814, 0x03},
>> +	{0x3815, 0x01},
>> +	{0x3816, 0x00},
>> +	{0x3817, 0x00},
>> +	{0x3818, 0x00},
>> +	{0x3819, 0x00},
>> +	{0x3820, 0x94},
>> +	{0x3821, 0x41},
>> +	{0x3822, 0x48},
>> +	{0x3826, 0x00},
>> +	{0x3827, 0x08},
>> +	{0x382a, 0x03},
>> +	{0x382b, 0x01},
>> +	{0x3830, 0x08},
>> +	{0x3836, 0x02},
>> +	{0x3837, 0x00},
>> +	{0x3838, 0x10},
>> +	{0x3841, 0xff},
>> +	{0x3846, 0x48},
>> +	{0x3861, 0x00},
>> +	{0x3862, 0x04},
>> +	{0x3863, 0x06},
>> +	{0x3a11, 0x01},
>> +	{0x3a12, 0x78},
>> +	{0x3b00, 0x00},
>> +	{0x3b02, 0x00},
>> +	{0x3b03, 0x00},
>> +	{0x3b04, 0x00},
>> +	{0x3b05, 0x00},
>> +	{0x3c00, 0x89},
>> +	{0x3c01, 0xab},
>> +	{0x3c02, 0x01},
>> +	{0x3c03, 0x00},
>> +	{0x3c04, 0x00},
>> +	{0x3c05, 0x03},
>> +	{0x3c06, 0x00},
>> +	{0x3c07, 0x05},
>> +	{0x3c0c, 0x00},
>> +	{0x3c0d, 0x00},
>> +	{0x3c0e, 0x00},
>> +	{0x3c0f, 0x00},
>> +	{0x3c40, 0x00},
>> +	{0x3c41, 0xa3},
>> +	{0x3c43, 0x7d},
>> +	{0x3c45, 0xd7},
>> +	{0x3c47, 0xfc},
>> +	{0x3c50, 0x05},
>> +	{0x3c52, 0xaa},
>> +	{0x3c54, 0x71},
>> +	{0x3c56, 0x80},
>> +	{0x3d85, 0x17},
>> +	{0x3f03, 0x00},
>> +	{0x3f0a, 0x00},
>> +	{0x3f0b, 0x00},
>> +	{0x4001, 0x60},
>> +	{0x4009, 0x05},
>> +	{0x4020, 0x00},
>> +	{0x4021, 0x00},
>> +	{0x4022, 0x00},
>> +	{0x4023, 0x00},
>> +	{0x4024, 0x00},
>> +	{0x4025, 0x00},
>> +	{0x4026, 0x00},
>> +	{0x4027, 0x00},
>> +	{0x4028, 0x00},
>> +	{0x4029, 0x00},
>> +	{0x402a, 0x00},
>> +	{0x402b, 0x00},
>> +	{0x402c, 0x00},
>> +	{0x402d, 0x00},
>> +	{0x402e, 0x00},
>> +	{0x402f, 0x00},
>> +	{0x4040, 0x00},
>> +	{0x4041, 0x03},
>> +	{0x4042, 0x00},
>> +	{0x4043, 0x7A},
>> +	{0x4044, 0x00},
>> +	{0x4045, 0x7A},
>> +	{0x4046, 0x00},
>> +	{0x4047, 0x7A},
>> +	{0x4048, 0x00},
>> +	{0x4049, 0x7A},
>> +	{0x4303, 0x00},
>> +	{0x4307, 0x30},
>> +	{0x4500, 0x58},
>> +	{0x4501, 0x04},
>> +	{0x4502, 0x48},
>> +	{0x4503, 0x10},
>> +	{0x4508, 0x55},
>> +	{0x4509, 0x55},
>> +	{0x450a, 0x00},
>> +	{0x450b, 0x00},
>> +	{0x4600, 0x00},
>> +	{0x4601, 0x80},
>> +	{0x4700, 0xa4},
>> +	{0x4800, 0x4c},
>> +	{0x4816, 0x53},
>> +	{0x481f, 0x40},
>> +	{0x4837, 0x12},
>> +	{0x5000, 0x56},
>> +	{0x5001, 0x01},
>> +	{0x5002, 0x28},
>> +	{0x5004, 0x0c},
>> +	{0x5006, 0x0c},
>> +	{0x5007, 0xe0},
>> +	{0x5008, 0x01},
>> +	{0x5009, 0xb0},
>> +	{0x5045, 0x05},
>> +	{0x5048, 0x10},
>> +	{0x5901, 0x00},
>> +	{0x5a01, 0x00},
>> +	{0x5a03, 0x00},
>> +	{0x5a04, 0x0c},
>> +	{0x5a05, 0xe0},
>> +	{0x5a06, 0x09},
>> +	{0x5a07, 0xb0},
>> +	{0x5a08, 0x06},
>> +	{0x5e00, 0x00},
>> +	{0x3734, 0x40},
>> +	{0x5b00, 0x01},
>> +	{0x5b01, 0x10},
>> +	{0x5b02, 0x01},
>> +	{0x5b03, 0xdb},
>> +	{0x3d8c, 0x71},
>> +	{0x3d8d, 0xea},
>> +	{0x4017, 0x10},
>> +	{0x3618, 0x2a},
>> +	{0x5780, 0x3e},
>> +	{0x5781, 0x0f},
>> +	{0x5782, 0x44},
>> +	{0x5783, 0x02},
>> +	{0x5784, 0x01},
>> +	{0x5785, 0x01},
>> +	{0x5786, 0x00},
>> +	{0x5787, 0x04},
>> +	{0x5788, 0x02},
>> +	{0x5789, 0x0f},
>> +	{0x578a, 0xfd},
>> +	{0x578b, 0xf5},
>> +	{0x578c, 0xf5},
>> +	{0x578d, 0x03},
>> +	{0x578e, 0x08},
>> +	{0x578f, 0x0c},
>> +	{0x5790, 0x08},
>> +	{0x5791, 0x06},
>> +	{0x5792, 0x00},
>> +	{0x5793, 0x52},
>> +	{0x5794, 0xa3},
>> +};
>> +
>> +static const struct ov5670_reg mode_1296x736_regs[] = {
>> +	{0x3000, 0x00},
>> +	{0x3002, 0x61},
>> +	{0x3005, 0xf0},
>> +	{0x3007, 0x00},
>> +	{0x300D, 0x00},
>> +	{0x3010, 0x40},
>> +	{0x3015, 0x0f},
>> +	{0x3018, 0x32},
>> +	{0x301a, 0xf0},
>> +	{0x301b, 0xf0},
>> +	{0x301c, 0xf0},
>> +	{0x301d, 0xf0},
>> +	{0x301e, 0xf0},
>> +	{0x3030, 0x00},
>> +	{0x303c, 0xff},
>> +	{0x303e, 0xff},
>> +	{0x3040, 0xf0},
>> +	{0x3041, 0x00},
>> +	{0x3042, 0xf0},
>> +	{0x3106, 0x11},
>> +	{0x3500, 0x00},
>> +	{0x3501, 0xb8},
>> +	{0x3502, 0x80},
>> +	{0x3503, 0x00},
>> +	{0x3504, 0x03},
>> +	{0x3505, 0x83},
>> +	{0x3508, 0x04},
>> +	{0x3509, 0x00},
>> +	{0x350e, 0x04},
>> +	{0x350f, 0x00},
>> +	{0x3510, 0x00},
>> +	{0x3511, 0x02},
>> +	{0x3512, 0x00},
>> +	{0x3601, 0xc8},
>> +	{0x3610, 0x88},
>> +	{0x3612, 0x48},
>> +	{0x3614, 0x5b},
>> +	{0x3615, 0x96},
>> +	{0x3621, 0xd0},
>> +	{0x3622, 0x00},
>> +	{0x3623, 0x00},
>> +	{0x3633, 0x13},
>> +	{0x3634, 0x13},
>> +	{0x3635, 0x13},
>> +	{0x3636, 0x13},
>> +	{0x3645, 0x13},
>> +	{0x3646, 0x82},
>> +	{0x3650, 0x00},
>> +	{0x3652, 0xff},
>> +	{0x3655, 0x20},
>> +	{0x3656, 0xff},
>> +	{0x365a, 0xff},
>> +	{0x365e, 0xff},
>> +	{0x3668, 0x00},
>> +	{0x366a, 0x07},
>> +	{0x366e, 0x08},
>> +	{0x366d, 0x00},
>> +	{0x366f, 0x80},
>> +	{0x3700, 0x28},
>> +	{0x3701, 0x10},
>> +	{0x3702, 0x3a},
>> +	{0x3703, 0x19},
>> +	{0x3704, 0x10},
>> +	{0x3705, 0x00},
>> +	{0x3706, 0x66},
>> +	{0x3707, 0x08},
>> +	{0x3708, 0x34},
>> +	{0x3709, 0x40},
>> +	{0x370a, 0x01},
>> +	{0x370b, 0x1b},
>> +	{0x3714, 0x24},
>> +	{0x371a, 0x3e},
>> +	{0x3733, 0x00},
>> +	{0x3734, 0x00},
>> +	{0x373a, 0x05},
>> +	{0x373b, 0x06},
>> +	{0x373c, 0x0a},
>> +	{0x373f, 0xa0},
>> +	{0x3755, 0x00},
>> +	{0x3758, 0x00},
>> +	{0x375b, 0x0e},
>> +	{0x3766, 0x5f},
>> +	{0x3768, 0x00},
>> +	{0x3769, 0x22},
>> +	{0x3773, 0x08},
>> +	{0x3774, 0x1f},
>> +	{0x3776, 0x06},
>> +	{0x37a0, 0x88},
>> +	{0x37a1, 0x5c},
>> +	{0x37a7, 0x88},
>> +	{0x37a8, 0x70},
>> +	{0x37aa, 0x88},
>> +	{0x37ab, 0x48},
>> +	{0x37b3, 0x66},
>> +	{0x37c2, 0x04},
>> +	{0x37c5, 0x00},
>> +	{0x37c8, 0x00},
>> +	{0x3800, 0x00},
>> +	{0x3801, 0x0c},
>> +	{0x3802, 0x00},
>> +	{0x3803, 0x04},
>> +	{0x3804, 0x0a},
>> +	{0x3805, 0x33},
>> +	{0x3806, 0x07},
>> +	{0x3807, 0xa3},
>> +	{0x3808, 0x05},
>> +	{0x3809, 0x10},
>> +	{0x380a, 0x02},
>> +	{0x380b, 0xe0},
>> +	{0x380c, 0x06},
>> +	{0x380d, 0xa8},
>> +	{0x380e, 0x07},
>> +	{0x380f, 0xf6},
>> +	{0x3811, 0x04},
>> +	{0x3813, 0x02},
>> +	{0x3814, 0x03},
>> +	{0x3815, 0x01},
>> +	{0x3816, 0x00},
>> +	{0x3817, 0x00},
>> +	{0x3818, 0x00},
>> +	{0x3819, 0x00},
>> +	{0x3820, 0x94},
>> +	{0x3821, 0x41},
>> +	{0x3822, 0x48},
>> +	{0x3826, 0x00},
>> +	{0x3827, 0x08},
>> +	{0x382a, 0x03},
>> +	{0x382b, 0x01},
>> +	{0x3830, 0x08},
>> +	{0x3836, 0x02},
>> +	{0x3837, 0x00},
>> +	{0x3838, 0x10},
>> +	{0x3841, 0xff},
>> +	{0x3846, 0x48},
>> +	{0x3861, 0x00},
>> +	{0x3862, 0x04},
>> +	{0x3863, 0x06},
>> +	{0x3a11, 0x01},
>> +	{0x3a12, 0x78},
>> +	{0x3b00, 0x00},
>> +	{0x3b02, 0x00},
>> +	{0x3b03, 0x00},
>> +	{0x3b04, 0x00},
>> +	{0x3b05, 0x00},
>> +	{0x3c00, 0x89},
>> +	{0x3c01, 0xab},
>> +	{0x3c02, 0x01},
>> +	{0x3c03, 0x00},
>> +	{0x3c04, 0x00},
>> +	{0x3c05, 0x03},
>> +	{0x3c06, 0x00},
>> +	{0x3c07, 0x05},
>> +	{0x3c0c, 0x00},
>> +	{0x3c0d, 0x00},
>> +	{0x3c0e, 0x00},
>> +	{0x3c0f, 0x00},
>> +	{0x3c40, 0x00},
>> +	{0x3c41, 0xa3},
>> +	{0x3c43, 0x7d},
>> +	{0x3c45, 0xd7},
>> +	{0x3c47, 0xfc},
>> +	{0x3c50, 0x05},
>> +	{0x3c52, 0xaa},
>> +	{0x3c54, 0x71},
>> +	{0x3c56, 0x80},
>> +	{0x3d85, 0x17},
>> +	{0x3f03, 0x00},
>> +	{0x3f0a, 0x00},
>> +	{0x3f0b, 0x00},
>> +	{0x4001, 0x60},
>> +	{0x4009, 0x05},
>> +	{0x4020, 0x00},
>> +	{0x4021, 0x00},
>> +	{0x4022, 0x00},
>> +	{0x4023, 0x00},
>> +	{0x4024, 0x00},
>> +	{0x4025, 0x00},
>> +	{0x4026, 0x00},
>> +	{0x4027, 0x00},
>> +	{0x4028, 0x00},
>> +	{0x4029, 0x00},
>> +	{0x402a, 0x00},
>> +	{0x402b, 0x00},
>> +	{0x402c, 0x00},
>> +	{0x402d, 0x00},
>> +	{0x402e, 0x00},
>> +	{0x402f, 0x00},
>> +	{0x4040, 0x00},
>> +	{0x4041, 0x03},
>> +	{0x4042, 0x00},
>> +	{0x4043, 0x7A},
>> +	{0x4044, 0x00},
>> +	{0x4045, 0x7A},
>> +	{0x4046, 0x00},
>> +	{0x4047, 0x7A},
>> +	{0x4048, 0x00},
>> +	{0x4049, 0x7A},
>> +	{0x4303, 0x00},
>> +	{0x4307, 0x30},
>> +	{0x4500, 0x58},
>> +	{0x4501, 0x04},
>> +	{0x4502, 0x48},
>> +	{0x4503, 0x10},
>> +	{0x4508, 0x55},
>> +	{0x4509, 0x55},
>> +	{0x450a, 0x00},
>> +	{0x450b, 0x00},
>> +	{0x4600, 0x00},
>> +	{0x4601, 0x80},
>> +	{0x4700, 0xa4},
>> +	{0x4800, 0x4c},
>> +	{0x4816, 0x53},
>> +	{0x481f, 0x40},
>> +	{0x4837, 0x12},
>> +	{0x5000, 0x56},
>> +	{0x5001, 0x01},
>> +	{0x5002, 0x28},
>> +	{0x5004, 0x0c},
>> +	{0x5006, 0x0c},
>> +	{0x5007, 0xe0},
>> +	{0x5008, 0x01},
>> +	{0x5009, 0xb0},
>> +	{0x5045, 0x05},
>> +	{0x5048, 0x10},
>> +	{0x5901, 0x00},
>> +	{0x5a01, 0x00},
>> +	{0x5a03, 0x00},
>> +	{0x5a04, 0x0c},
>> +	{0x5a05, 0xe0},
>> +	{0x5a06, 0x09},
>> +	{0x5a07, 0xb0},
>> +	{0x5a08, 0x06},
>> +	{0x5e00, 0x00},
>> +	{0x3734, 0x40},
>> +	{0x5b00, 0x01},
>> +	{0x5b01, 0x10},
>> +	{0x5b02, 0x01},
>> +	{0x5b03, 0xdb},
>> +	{0x3d8c, 0x71},
>> +	{0x3d8d, 0xea},
>> +	{0x4017, 0x10},
>> +	{0x3618, 0x2a},
>> +	{0x5780, 0x3e},
>> +	{0x5781, 0x0f},
>> +	{0x5782, 0x44},
>> +	{0x5783, 0x02},
>> +	{0x5784, 0x01},
>> +	{0x5785, 0x01},
>> +	{0x5786, 0x00},
>> +	{0x5787, 0x04},
>> +	{0x5788, 0x02},
>> +	{0x5789, 0x0f},
>> +	{0x578a, 0xfd},
>> +	{0x578b, 0xf5},
>> +	{0x578c, 0xf5},
>> +	{0x578d, 0x03},
>> +	{0x578e, 0x08},
>> +	{0x578f, 0x0c},
>> +	{0x5790, 0x08},
>> +	{0x5791, 0x06},
>> +	{0x5792, 0x00},
>> +	{0x5793, 0x52},
>> +	{0x5794, 0xa3},
>> +};
>> +
>> +static const struct ov5670_reg mode_960x720_regs[] = {
>> +	{0x3000, 0x00},
>> +	{0x3002, 0x61},
>> +	{0x3005, 0xf0},
>> +	{0x3007, 0x00},
>> +	{0x300D, 0x00},
>> +	{0x3010, 0x40},
>> +	{0x3015, 0x0f},
>> +	{0x3018, 0x32},
>> +	{0x301a, 0xf0},
>> +	{0x301b, 0xf0},
>> +	{0x301c, 0xf0},
>> +	{0x301d, 0xf0},
>> +	{0x301e, 0xf0},
>> +	{0x3030, 0x00},
>> +	{0x303c, 0xff},
>> +	{0x303e, 0xff},
>> +	{0x3040, 0xf0},
>> +	{0x3041, 0x00},
>> +	{0x3042, 0xf0},
>> +	{0x3106, 0x11},
>> +	{0x3500, 0x00},
>> +	{0x3501, 0xb8},
>> +	{0x3502, 0x80},
>> +	{0x3503, 0x00},
>> +	{0x3504, 0x03},
>> +	{0x3505, 0x83},
>> +	{0x3508, 0x04},
>> +	{0x3509, 0x00},
>> +	{0x350e, 0x04},
>> +	{0x350f, 0x00},
>> +	{0x3510, 0x00},
>> +	{0x3511, 0x02},
>> +	{0x3512, 0x00},
>> +	{0x3601, 0xc8},
>> +	{0x3610, 0x88},
>> +	{0x3612, 0x48},
>> +	{0x3614, 0x5b},
>> +	{0x3615, 0x96},
>> +	{0x3621, 0xd0},
>> +	{0x3622, 0x00},
>> +	{0x3623, 0x00},
>> +	{0x3633, 0x13},
>> +	{0x3634, 0x13},
>> +	{0x3635, 0x13},
>> +	{0x3636, 0x13},
>> +	{0x3645, 0x13},
>> +	{0x3646, 0x82},
>> +	{0x3650, 0x00},
>> +	{0x3652, 0xff},
>> +	{0x3655, 0x20},
>> +	{0x3656, 0xff},
>> +	{0x365a, 0xff},
>> +	{0x365e, 0xff},
>> +	{0x3668, 0x00},
>> +	{0x366a, 0x07},
>> +	{0x366e, 0x08},
>> +	{0x366d, 0x00},
>> +	{0x366f, 0x80},
>> +	{0x3700, 0x28},
>> +	{0x3701, 0x10},
>> +	{0x3702, 0x3a},
>> +	{0x3703, 0x19},
>> +	{0x3704, 0x10},
>> +	{0x3705, 0x00},
>> +	{0x3706, 0x66},
>> +	{0x3707, 0x08},
>> +	{0x3708, 0x34},
>> +	{0x3709, 0x40},
>> +	{0x370a, 0x01},
>> +	{0x370b, 0x1b},
>> +	{0x3714, 0x24},
>> +	{0x371a, 0x3e},
>> +	{0x3733, 0x00},
>> +	{0x3734, 0x00},
>> +	{0x373a, 0x05},
>> +	{0x373b, 0x06},
>> +	{0x373c, 0x0a},
>> +	{0x373f, 0xa0},
>> +	{0x3755, 0x00},
>> +	{0x3758, 0x00},
>> +	{0x375b, 0x0e},
>> +	{0x3766, 0x5f},
>> +	{0x3768, 0x00},
>> +	{0x3769, 0x22},
>> +	{0x3773, 0x08},
>> +	{0x3774, 0x1f},
>> +	{0x3776, 0x06},
>> +	{0x37a0, 0x88},
>> +	{0x37a1, 0x5c},
>> +	{0x37a7, 0x88},
>> +	{0x37a8, 0x70},
>> +	{0x37aa, 0x88},
>> +	{0x37ab, 0x48},
>> +	{0x37b3, 0x66},
>> +	{0x37c2, 0x04},
>> +	{0x37c5, 0x00},
>> +	{0x37c8, 0x00},
>> +	{0x3800, 0x00},
>> +	{0x3801, 0x0c},
>> +	{0x3802, 0x00},
>> +	{0x3803, 0x04},
>> +	{0x3804, 0x0a},
>> +	{0x3805, 0x33},
>> +	{0x3806, 0x07},
>> +	{0x3807, 0xa3},
>> +	{0x3808, 0x03},
>> +	{0x3809, 0xc0},
>> +	{0x380a, 0x02},
>> +	{0x380b, 0xd0},
>> +	{0x380c, 0x06},
>> +	{0x380d, 0xa8},
>> +	{0x380e, 0x07},
>> +	{0x380f, 0xf6},
>> +	{0x3811, 0x04},
>> +	{0x3813, 0x02},
>> +	{0x3814, 0x03},
>> +	{0x3815, 0x01},
>> +	{0x3816, 0x00},
>> +	{0x3817, 0x00},
>> +	{0x3818, 0x00},
>> +	{0x3819, 0x00},
>> +	{0x3820, 0x94},
>> +	{0x3821, 0x41},
>> +	{0x3822, 0x48},
>> +	{0x3826, 0x00},
>> +	{0x3827, 0x08},
>> +	{0x382a, 0x03},
>> +	{0x382b, 0x01},
>> +	{0x3830, 0x08},
>> +	{0x3836, 0x02},
>> +	{0x3837, 0x00},
>> +	{0x3838, 0x10},
>> +	{0x3841, 0xff},
>> +	{0x3846, 0x48},
>> +	{0x3861, 0x00},
>> +	{0x3862, 0x04},
>> +	{0x3863, 0x06},
>> +	{0x3a11, 0x01},
>> +	{0x3a12, 0x78},
>> +	{0x3b00, 0x00},
>> +	{0x3b02, 0x00},
>> +	{0x3b03, 0x00},
>> +	{0x3b04, 0x00},
>> +	{0x3b05, 0x00},
>> +	{0x3c00, 0x89},
>> +	{0x3c01, 0xab},
>> +	{0x3c02, 0x01},
>> +	{0x3c03, 0x00},
>> +	{0x3c04, 0x00},
>> +	{0x3c05, 0x03},
>> +	{0x3c06, 0x00},
>> +	{0x3c07, 0x05},
>> +	{0x3c0c, 0x00},
>> +	{0x3c0d, 0x00},
>> +	{0x3c0e, 0x00},
>> +	{0x3c0f, 0x00},
>> +	{0x3c40, 0x00},
>> +	{0x3c41, 0xa3},
>> +	{0x3c43, 0x7d},
>> +	{0x3c45, 0xd7},
>> +	{0x3c47, 0xfc},
>> +	{0x3c50, 0x05},
>> +	{0x3c52, 0xaa},
>> +	{0x3c54, 0x71},
>> +	{0x3c56, 0x80},
>> +	{0x3d85, 0x17},
>> +	{0x3f03, 0x00},
>> +	{0x3f0a, 0x00},
>> +	{0x3f0b, 0x00},
>> +	{0x4001, 0x60},
>> +	{0x4009, 0x05},
>> +	{0x4020, 0x00},
>> +	{0x4021, 0x00},
>> +	{0x4022, 0x00},
>> +	{0x4023, 0x00},
>> +	{0x4024, 0x00},
>> +	{0x4025, 0x00},
>> +	{0x4026, 0x00},
>> +	{0x4027, 0x00},
>> +	{0x4028, 0x00},
>> +	{0x4029, 0x00},
>> +	{0x402a, 0x00},
>> +	{0x402b, 0x00},
>> +	{0x402c, 0x00},
>> +	{0x402d, 0x00},
>> +	{0x402e, 0x00},
>> +	{0x402f, 0x00},
>> +	{0x4040, 0x00},
>> +	{0x4041, 0x03},
>> +	{0x4042, 0x00},
>> +	{0x4043, 0x7A},
>> +	{0x4044, 0x00},
>> +	{0x4045, 0x7A},
>> +	{0x4046, 0x00},
>> +	{0x4047, 0x7A},
>> +	{0x4048, 0x00},
>> +	{0x4049, 0x7A},
>> +	{0x4303, 0x00},
>> +	{0x4307, 0x30},
>> +	{0x4500, 0x58},
>> +	{0x4501, 0x04},
>> +	{0x4502, 0x48},
>> +	{0x4503, 0x10},
>> +	{0x4508, 0x55},
>> +	{0x4509, 0x55},
>> +	{0x450a, 0x00},
>> +	{0x450b, 0x00},
>> +	{0x4600, 0x00},
>> +	{0x4601, 0x80},
>> +	{0x4700, 0xa4},
>> +	{0x4800, 0x4c},
>> +	{0x4816, 0x53},
>> +	{0x481f, 0x40},
>> +	{0x4837, 0x12},
>> +	{0x5000, 0x56},
>> +	{0x5001, 0x01},
>> +	{0x5002, 0x28},
>> +	{0x5004, 0x0c},
>> +	{0x5006, 0x0c},
>> +	{0x5007, 0xe0},
>> +	{0x5008, 0x01},
>> +	{0x5009, 0xb0},
>> +	{0x5045, 0x05},
>> +	{0x5048, 0x10},
>> +	{0x5901, 0x00},
>> +	{0x5a01, 0x00},
>> +	{0x5a03, 0x00},
>> +	{0x5a04, 0x0c},
>> +	{0x5a05, 0xe0},
>> +	{0x5a06, 0x09},
>> +	{0x5a07, 0xb0},
>> +	{0x5a08, 0x06},
>> +	{0x5e00, 0x00},
>> +	{0x3734, 0x40},
>> +	{0x5b00, 0x01},
>> +	{0x5b01, 0x10},
>> +	{0x5b02, 0x01},
>> +	{0x5b03, 0xdb},
>> +	{0x3d8c, 0x71},
>> +	{0x3d8d, 0xea},
>> +	{0x4017, 0x10},
>> +	{0x3618, 0x2a},
>> +	{0x5780, 0x3e},
>> +	{0x5781, 0x0f},
>> +	{0x5782, 0x44},
>> +	{0x5783, 0x02},
>> +	{0x5784, 0x01},
>> +	{0x5785, 0x01},
>> +	{0x5786, 0x00},
>> +	{0x5787, 0x04},
>> +	{0x5788, 0x02},
>> +	{0x5789, 0x0f},
>> +	{0x578a, 0xfd},
>> +	{0x578b, 0xf5},
>> +	{0x578c, 0xf5},
>> +	{0x578d, 0x03},
>> +	{0x578e, 0x08},
>> +	{0x578f, 0x0c},
>> +	{0x5790, 0x08},
>> +	{0x5791, 0x06},
>> +	{0x5792, 0x00},
>> +	{0x5793, 0x52},
>> +	{0x5794, 0xa3},
>> +};
>> +
>> +static const struct ov5670_reg mode_1920x1080_regs[] = {
>> +	{0x3000, 0x00},
>> +	{0x3002, 0x61},
>> +	{0x3005, 0xf0},
>> +	{0x3007, 0x00},
>> +	{0x300D, 0x00},
>> +	{0x3010, 0x40},
>> +	{0x3015, 0x0f},
>> +	{0x3018, 0x32},
>> +	{0x301a, 0xf0},
>> +	{0x301b, 0xf0},
>> +	{0x301c, 0xf0},
>> +	{0x301d, 0xf0},
>> +	{0x301e, 0xf0},
>> +	{0x3030, 0x00},
>> +	{0x303c, 0xff},
>> +	{0x303e, 0xff},
>> +	{0x3040, 0xf0},
>> +	{0x3041, 0x00},
>> +	{0x3042, 0xf0},
>> +	{0x3106, 0x11},
>> +	{0x3500, 0x00},
>> +	{0x3501, 0xb8},
>> +	{0x3502, 0x80},
>> +	{0x3503, 0x00},
>> +	{0x3504, 0x03},
>> +	{0x3505, 0x83},
>> +	{0x3508, 0x04},
>> +	{0x3509, 0x00},
>> +	{0x350e, 0x04},
>> +	{0x350f, 0x00},
>> +	{0x3510, 0x00},
>> +	{0x3511, 0x02},
>> +	{0x3512, 0x00},
>> +	{0x3601, 0xc8},
>> +	{0x3610, 0x88},
>> +	{0x3612, 0x48},
>> +	{0x3614, 0x5b},
>> +	{0x3615, 0x96},
>> +	{0x3621, 0xd0},
>> +	{0x3622, 0x00},
>> +	{0x3623, 0x00},
>> +	{0x3633, 0x13},
>> +	{0x3634, 0x13},
>> +	{0x3635, 0x13},
>> +	{0x3636, 0x13},
>> +	{0x3645, 0x13},
>> +	{0x3646, 0x82},
>> +	{0x3650, 0x00},
>> +	{0x3652, 0xff},
>> +	{0x3655, 0x20},
>> +	{0x3656, 0xff},
>> +	{0x365a, 0xff},
>> +	{0x365e, 0xff},
>> +	{0x3668, 0x00},
>> +	{0x366a, 0x07},
>> +	{0x366e, 0x10},
>> +	{0x366d, 0x00},
>> +	{0x366f, 0x80},
>> +	{0x3700, 0x28},
>> +	{0x3701, 0x10},
>> +	{0x3702, 0x3a},
>> +	{0x3703, 0x19},
>> +	{0x3704, 0x10},
>> +	{0x3705, 0x00},
>> +	{0x3706, 0x66},
>> +	{0x3707, 0x08},
>> +	{0x3708, 0x34},
>> +	{0x3709, 0x40},
>> +	{0x370a, 0x01},
>> +	{0x370b, 0x1b},
>> +	{0x3714, 0x24},
>> +	{0x371a, 0x3e},
>> +	{0x3733, 0x00},
>> +	{0x3734, 0x00},
>> +	{0x373a, 0x05},
>> +	{0x373b, 0x06},
>> +	{0x373c, 0x0a},
>> +	{0x373f, 0xa0},
>> +	{0x3755, 0x00},
>> +	{0x3758, 0x00},
>> +	{0x375b, 0x0e},
>> +	{0x3766, 0x5f},
>> +	{0x3768, 0x00},
>> +	{0x3769, 0x22},
>> +	{0x3773, 0x08},
>> +	{0x3774, 0x1f},
>> +	{0x3776, 0x06},
>> +	{0x37a0, 0x88},
>> +	{0x37a1, 0x5c},
>> +	{0x37a7, 0x88},
>> +	{0x37a8, 0x70},
>> +	{0x37aa, 0x88},
>> +	{0x37ab, 0x48},
>> +	{0x37b3, 0x66},
>> +	{0x37c2, 0x04},
>> +	{0x37c5, 0x00},
>> +	{0x37c8, 0x00},
>> +	{0x3800, 0x00},
>> +	{0x3801, 0x0c},
>> +	{0x3802, 0x00},
>> +	{0x3803, 0x04},
>> +	{0x3804, 0x0a},
>> +	{0x3805, 0x33},
>> +	{0x3806, 0x07},
>> +	{0x3807, 0xa3},
>> +	{0x3808, 0x07},
>> +	{0x3809, 0x80},
>> +	{0x380a, 0x04},
>> +	{0x380b, 0x38},
>> +	{0x380c, 0x06},
>> +	{0x380d, 0xa8},
>> +	{0x380e, 0x07},
>> +	{0x380f, 0xf6},
>> +	{0x3811, 0x04},
>> +	{0x3813, 0x02},
>> +	{0x3814, 0x01},
>> +	{0x3815, 0x01},
>> +	{0x3816, 0x00},
>> +	{0x3817, 0x00},
>> +	{0x3818, 0x00},
>> +	{0x3819, 0x00},
>> +	{0x3820, 0x84},
>> +	{0x3821, 0x40},
>> +	{0x3822, 0x48},
>> +	{0x3826, 0x00},
>> +	{0x3827, 0x08},
>> +	{0x382a, 0x01},
>> +	{0x382b, 0x01},
>> +	{0x3830, 0x08},
>> +	{0x3836, 0x02},
>> +	{0x3837, 0x00},
>> +	{0x3838, 0x10},
>> +	{0x3841, 0xfa},
>> +	{0x3846, 0x48},
>> +	{0x3861, 0x00},
>> +	{0x3862, 0x04},
>> +	{0x3863, 0x06},
>> +	{0x3a11, 0x01},
>> +	{0x3a12, 0x78},
>> +	{0x3b00, 0x00},
>> +	{0x3b02, 0x00},
>> +	{0x3b03, 0x00},
>> +	{0x3b04, 0x00},
>> +	{0x3b05, 0x00},
>> +	{0x3c00, 0x89},
>> +	{0x3c01, 0xab},
>> +	{0x3c02, 0x01},
>> +	{0x3c03, 0x00},
>> +	{0x3c04, 0x00},
>> +	{0x3c05, 0x03},
>> +	{0x3c06, 0x00},
>> +	{0x3c07, 0x05},
>> +	{0x3c0c, 0x00},
>> +	{0x3c0d, 0x00},
>> +	{0x3c0e, 0x00},
>> +	{0x3c0f, 0x00},
>> +	{0x3c40, 0x00},
>> +	{0x3c41, 0xa3},
>> +	{0x3c43, 0x7d},
>> +	{0x3c45, 0xd7},
>> +	{0x3c47, 0xfc},
>> +	{0x3c50, 0x05},
>> +	{0x3c52, 0xaa},
>> +	{0x3c54, 0x71},
>> +	{0x3c56, 0x80},
>> +	{0x3d85, 0x17},
>> +	{0x3f03, 0x00},
>> +	{0x3f0a, 0x00},
>> +	{0x3f0b, 0x00},
>> +	{0x4001, 0x60},
>> +	{0x4009, 0x0d},
>> +	{0x4020, 0x00},
>> +	{0x4021, 0x00},
>> +	{0x4022, 0x00},
>> +	{0x4023, 0x00},
>> +	{0x4024, 0x00},
>> +	{0x4025, 0x00},
>> +	{0x4026, 0x00},
>> +	{0x4027, 0x00},
>> +	{0x4028, 0x00},
>> +	{0x4029, 0x00},
>> +	{0x402a, 0x00},
>> +	{0x402b, 0x00},
>> +	{0x402c, 0x00},
>> +	{0x402d, 0x00},
>> +	{0x402e, 0x00},
>> +	{0x402f, 0x00},
>> +	{0x4040, 0x00},
>> +	{0x4041, 0x03},
>> +	{0x4042, 0x00},
>> +	{0x4043, 0x7A},
>> +	{0x4044, 0x00},
>> +	{0x4045, 0x7A},
>> +	{0x4046, 0x00},
>> +	{0x4047, 0x7A},
>> +	{0x4048, 0x00},
>> +	{0x4049, 0x7A},
>> +	{0x4303, 0x00},
>> +	{0x4307, 0x30},
>> +	{0x4500, 0x58},
>> +	{0x4501, 0x04},
>> +	{0x4502, 0x40},
>> +	{0x4503, 0x10},
>> +	{0x4508, 0xaa},
>> +	{0x4509, 0xaa},
>> +	{0x450a, 0x00},
>> +	{0x450b, 0x00},
>> +	{0x4600, 0x00},
>> +	{0x4601, 0xc0},
>> +	{0x4700, 0xa4},
>> +	{0x4800, 0x4c},
>> +	{0x4816, 0x53},
>> +	{0x481f, 0x40},
>> +	{0x4837, 0x12},
>> +	{0x5000, 0x56},
>> +	{0x5001, 0x01},
>> +	{0x5002, 0x28},
>> +	{0x5004, 0x0c},
>> +	{0x5006, 0x0c},
>> +	{0x5007, 0xe0},
>> +	{0x5008, 0x01},
>> +	{0x5009, 0xb0},
>> +	{0x5045, 0x05},
>> +	{0x5048, 0x10},
>> +	{0x5901, 0x00},
>> +	{0x5a01, 0x00},
>> +	{0x5a03, 0x00},
>> +	{0x5a04, 0x0c},
>> +	{0x5a05, 0xe0},
>> +	{0x5a06, 0x09},
>> +	{0x5a07, 0xb0},
>> +	{0x5a08, 0x06},
>> +	{0x5e00, 0x00},
>> +	{0x3734, 0x40},
>> +	{0x5b00, 0x01},
>> +	{0x5b01, 0x10},
>> +	{0x5b02, 0x01},
>> +	{0x5b03, 0xdb},
>> +	{0x3d8c, 0x71},
>> +	{0x3d8d, 0xea},
>> +	{0x4017, 0x08},
>> +	{0x3618, 0x2a},
>> +	{0x5780, 0x3e},
>> +	{0x5781, 0x0f},
>> +	{0x5782, 0x44},
>> +	{0x5783, 0x02},
>> +	{0x5784, 0x01},
>> +	{0x5785, 0x01},
>> +	{0x5786, 0x00},
>> +	{0x5787, 0x04},
>> +	{0x5788, 0x02},
>> +	{0x5789, 0x0f},
>> +	{0x578a, 0xfd},
>> +	{0x578b, 0xf5},
>> +	{0x578c, 0xf5},
>> +	{0x578d, 0x03},
>> +	{0x578e, 0x08},
>> +	{0x578f, 0x0c},
>> +	{0x5790, 0x08},
>> +	{0x5791, 0x06},
>> +	{0x5792, 0x00},
>> +	{0x5793, 0x52},
>> +	{0x5794, 0xa3},
>> +};
>> +
>> +static const struct ov5670_reg mode_1440x1080_regs[] = {
>> +	{0x3000, 0x00},
>> +	{0x3002, 0x61},
>> +	{0x3005, 0xf0},
>> +	{0x3007, 0x00},
>> +	{0x300D, 0x00},
>> +	{0x3010, 0x40},
>> +	{0x3015, 0x0f},
>> +	{0x3018, 0x32},
>> +	{0x301a, 0xf0},
>> +	{0x301b, 0xf0},
>> +	{0x301c, 0xf0},
>> +	{0x301d, 0xf0},
>> +	{0x301e, 0xf0},
>> +	{0x3030, 0x00},
>> +	{0x303c, 0xff},
>> +	{0x303e, 0xff},
>> +	{0x3040, 0xf0},
>> +	{0x3041, 0x00},
>> +	{0x3042, 0xf0},
>> +	{0x3106, 0x11},
>> +	{0x3500, 0x00},
>> +	{0x3501, 0xb8},
>> +	{0x3502, 0x80},
>> +	{0x3503, 0x00},
>> +	{0x3504, 0x03},
>> +	{0x3505, 0x83},
>> +	{0x3508, 0x04},
>> +	{0x3509, 0x00},
>> +	{0x350e, 0x04},
>> +	{0x350f, 0x00},
>> +	{0x3510, 0x00},
>> +	{0x3511, 0x02},
>> +	{0x3512, 0x00},
>> +	{0x3601, 0xc8},
>> +	{0x3610, 0x88},
>> +	{0x3612, 0x48},
>> +	{0x3614, 0x5b},
>> +	{0x3615, 0x96},
>> +	{0x3621, 0xd0},
>> +	{0x3622, 0x00},
>> +	{0x3623, 0x00},
>> +	{0x3633, 0x13},
>> +	{0x3634, 0x13},
>> +	{0x3635, 0x13},
>> +	{0x3636, 0x13},
>> +	{0x3645, 0x13},
>> +	{0x3646, 0x82},
>> +	{0x3650, 0x00},
>> +	{0x3652, 0xff},
>> +	{0x3655, 0x20},
>> +	{0x3656, 0xff},
>> +	{0x365a, 0xff},
>> +	{0x365e, 0xff},
>> +	{0x3668, 0x00},
>> +	{0x366a, 0x07},
>> +	{0x366e, 0x10},
>> +	{0x366d, 0x00},
>> +	{0x366f, 0x80},
>> +	{0x3700, 0x28},
>> +	{0x3701, 0x10},
>> +	{0x3702, 0x3a},
>> +	{0x3703, 0x19},
>> +	{0x3704, 0x10},
>> +	{0x3705, 0x00},
>> +	{0x3706, 0x66},
>> +	{0x3707, 0x08},
>> +	{0x3708, 0x34},
>> +	{0x3709, 0x40},
>> +	{0x370a, 0x01},
>> +	{0x370b, 0x1b},
>> +	{0x3714, 0x24},
>> +	{0x371a, 0x3e},
>> +	{0x3733, 0x00},
>> +	{0x3734, 0x00},
>> +	{0x373a, 0x05},
>> +	{0x373b, 0x06},
>> +	{0x373c, 0x0a},
>> +	{0x373f, 0xa0},
>> +	{0x3755, 0x00},
>> +	{0x3758, 0x00},
>> +	{0x375b, 0x0e},
>> +	{0x3766, 0x5f},
>> +	{0x3768, 0x00},
>> +	{0x3769, 0x22},
>> +	{0x3773, 0x08},
>> +	{0x3774, 0x1f},
>> +	{0x3776, 0x06},
>> +	{0x37a0, 0x88},
>> +	{0x37a1, 0x5c},
>> +	{0x37a7, 0x88},
>> +	{0x37a8, 0x70},
>> +	{0x37aa, 0x88},
>> +	{0x37ab, 0x48},
>> +	{0x37b3, 0x66},
>> +	{0x37c2, 0x04},
>> +	{0x37c5, 0x00},
>> +	{0x37c8, 0x00},
>> +	{0x3800, 0x00},
>> +	{0x3801, 0x0c},
>> +	{0x3802, 0x00},
>> +	{0x3803, 0x04},
>> +	{0x3804, 0x0a},
>> +	{0x3805, 0x33},
>> +	{0x3806, 0x07},
>> +	{0x3807, 0xa3},
>> +	{0x3808, 0x05},
>> +	{0x3809, 0xa0},
>> +	{0x380a, 0x04},
>> +	{0x380b, 0x38},
>> +	{0x380c, 0x06},
>> +	{0x380d, 0xa8},
>> +	{0x380e, 0x07},
>> +	{0x380f, 0xf6},
>> +	{0x3811, 0x04},
>> +	{0x3813, 0x02},
>> +	{0x3814, 0x01},
>> +	{0x3815, 0x01},
>> +	{0x3816, 0x00},
>> +	{0x3817, 0x00},
>> +	{0x3818, 0x00},
>> +	{0x3819, 0x00},
>> +	{0x3820, 0x84},
>> +	{0x3821, 0x40},
>> +	{0x3822, 0x48},
>> +	{0x3826, 0x00},
>> +	{0x3827, 0x08},
>> +	{0x382a, 0x01},
>> +	{0x382b, 0x01},
>> +	{0x3830, 0x08},
>> +	{0x3836, 0x02},
>> +	{0x3837, 0x00},
>> +	{0x3838, 0x10},
>> +	{0x3841, 0xff},
>> +	{0x3846, 0x48},
>> +	{0x3861, 0x00},
>> +	{0x3862, 0x04},
>> +	{0x3863, 0x06},
>> +	{0x3a11, 0x01},
>> +	{0x3a12, 0x78},
>> +	{0x3b00, 0x00},
>> +	{0x3b02, 0x00},
>> +	{0x3b03, 0x00},
>> +	{0x3b04, 0x00},
>> +	{0x3b05, 0x00},
>> +	{0x3c00, 0x89},
>> +	{0x3c01, 0xab},
>> +	{0x3c02, 0x01},
>> +	{0x3c03, 0x00},
>> +	{0x3c04, 0x00},
>> +	{0x3c05, 0x03},
>> +	{0x3c06, 0x00},
>> +	{0x3c07, 0x05},
>> +	{0x3c0c, 0x00},
>> +	{0x3c0d, 0x00},
>> +	{0x3c0e, 0x00},
>> +	{0x3c0f, 0x00},
>> +	{0x3c40, 0x00},
>> +	{0x3c41, 0xa3},
>> +	{0x3c43, 0x7d},
>> +	{0x3c45, 0xd7},
>> +	{0x3c47, 0xfc},
>> +	{0x3c50, 0x05},
>> +	{0x3c52, 0xaa},
>> +	{0x3c54, 0x71},
>> +	{0x3c56, 0x80},
>> +	{0x3d85, 0x17},
>> +	{0x3f03, 0x00},
>> +	{0x3f0a, 0x00},
>> +	{0x3f0b, 0x00},
>> +	{0x4001, 0x60},
>> +	{0x4009, 0x0d},
>> +	{0x4020, 0x00},
>> +	{0x4021, 0x00},
>> +	{0x4022, 0x00},
>> +	{0x4023, 0x00},
>> +	{0x4024, 0x00},
>> +	{0x4025, 0x00},
>> +	{0x4026, 0x00},
>> +	{0x4027, 0x00},
>> +	{0x4028, 0x00},
>> +	{0x4029, 0x00},
>> +	{0x402a, 0x00},
>> +	{0x402b, 0x00},
>> +	{0x402c, 0x00},
>> +	{0x402d, 0x00},
>> +	{0x402e, 0x00},
>> +	{0x402f, 0x00},
>> +	{0x4040, 0x00},
>> +	{0x4041, 0x03},
>> +	{0x4042, 0x00},
>> +	{0x4043, 0x7A},
>> +	{0x4044, 0x00},
>> +	{0x4045, 0x7A},
>> +	{0x4046, 0x00},
>> +	{0x4047, 0x7A},
>> +	{0x4048, 0x00},
>> +	{0x4049, 0x7A},
>> +	{0x4303, 0x00},
>> +	{0x4307, 0x30},
>> +	{0x4500, 0x58},
>> +	{0x4501, 0x04},
>> +	{0x4502, 0x40},
>> +	{0x4503, 0x10},
>> +	{0x4508, 0xaa},
>> +	{0x4509, 0xaa},
>> +	{0x450a, 0x00},
>> +	{0x450b, 0x00},
>> +	{0x4600, 0x00},
>> +	{0x4601, 0xc0},
>> +	{0x4700, 0xa4},
>> +	{0x4800, 0x4c},
>> +	{0x4816, 0x53},
>> +	{0x481f, 0x40},
>> +	{0x4837, 0x12},
>> +	{0x5000, 0x56},
>> +	{0x5001, 0x01},
>> +	{0x5002, 0x28},
>> +	{0x5004, 0x0c},
>> +	{0x5006, 0x0c},
>> +	{0x5007, 0xe0},
>> +	{0x5008, 0x01},
>> +	{0x5009, 0xb0},
>> +	{0x5045, 0x05},
>> +	{0x5048, 0x10},
>> +	{0x5901, 0x00},
>> +	{0x5a01, 0x00},
>> +	{0x5a03, 0x00},
>> +	{0x5a04, 0x0c},
>> +	{0x5a05, 0xe0},
>> +	{0x5a06, 0x09},
>> +	{0x5a07, 0xb0},
>> +	{0x5a08, 0x06},
>> +	{0x5e00, 0x00},
>> +	{0x3734, 0x40},
>> +	{0x5b00, 0x01},
>> +	{0x5b01, 0x10},
>> +	{0x5b02, 0x01},
>> +	{0x5b03, 0xdb},
>> +	{0x3d8c, 0x71},
>> +	{0x3d8d, 0xea},
>> +	{0x4017, 0x08},
>> +	{0x3618, 0x2a},
>> +	{0x5780, 0x3e},
>> +	{0x5781, 0x0f},
>> +	{0x5782, 0x44},
>> +	{0x5783, 0x02},
>> +	{0x5784, 0x01},
>> +	{0x5785, 0x01},
>> +	{0x5786, 0x00},
>> +	{0x5787, 0x04},
>> +	{0x5788, 0x02},
>> +	{0x5789, 0x0f},
>> +	{0x578a, 0xfd},
>> +	{0x578b, 0xf5},
>> +	{0x578c, 0xf5},
>> +	{0x578d, 0x03},
>> +	{0x578e, 0x08},
>> +	{0x578f, 0x0c},
>> +	{0x5790, 0x08},
>> +	{0x5791, 0x06},
>> +	{0x5792, 0x00},
>> +	{0x5793, 0x52},
>> +	{0x5794, 0xa3},
>> +};
>> +
>> +static const struct ov5670_reg mode_1936x1096_regs[] = {
>> +	{0x3000, 0x00},
>> +	{0x3002, 0x61},
>> +	{0x3005, 0xf0},
>> +	{0x3007, 0x00},
>> +	{0x300D, 0x00},
>> +	{0x3010, 0x40},
>> +	{0x3015, 0x0f},
>> +	{0x3018, 0x32},
>> +	{0x301a, 0xf0},
>> +	{0x301b, 0xf0},
>> +	{0x301c, 0xf0},
>> +	{0x301d, 0xf0},
>> +	{0x301e, 0xf0},
>> +	{0x3030, 0x00},
>> +	{0x303c, 0xff},
>> +	{0x303e, 0xff},
>> +	{0x3040, 0xf0},
>> +	{0x3041, 0x00},
>> +	{0x3042, 0xf0},
>> +	{0x3106, 0x11},
>> +	{0x3500, 0x00},
>> +	{0x3501, 0xb8},
>> +	{0x3502, 0x80},
>> +	{0x3503, 0x00},
>> +	{0x3504, 0x03},
>> +	{0x3505, 0x83},
>> +	{0x3508, 0x04},
>> +	{0x3509, 0x00},
>> +	{0x350e, 0x04},
>> +	{0x350f, 0x00},
>> +	{0x3510, 0x00},
>> +	{0x3511, 0x02},
>> +	{0x3512, 0x00},
>> +	{0x3601, 0xc8},
>> +	{0x3610, 0x88},
>> +	{0x3612, 0x48},
>> +	{0x3614, 0x5b},
>> +	{0x3615, 0x96},
>> +	{0x3621, 0xd0},
>> +	{0x3622, 0x00},
>> +	{0x3623, 0x00},
>> +	{0x3633, 0x13},
>> +	{0x3634, 0x13},
>> +	{0x3635, 0x13},
>> +	{0x3636, 0x13},
>> +	{0x3645, 0x13},
>> +	{0x3646, 0x82},
>> +	{0x3650, 0x00},
>> +	{0x3652, 0xff},
>> +	{0x3655, 0x20},
>> +	{0x3656, 0xff},
>> +	{0x365a, 0xff},
>> +	{0x365e, 0xff},
>> +	{0x3668, 0x00},
>> +	{0x366a, 0x07},
>> +	{0x366e, 0x10},
>> +	{0x366d, 0x00},
>> +	{0x366f, 0x80},
>> +	{0x3700, 0x28},
>> +	{0x3701, 0x10},
>> +	{0x3702, 0x3a},
>> +	{0x3703, 0x19},
>> +	{0x3704, 0x10},
>> +	{0x3705, 0x00},
>> +	{0x3706, 0x66},
>> +	{0x3707, 0x08},
>> +	{0x3708, 0x34},
>> +	{0x3709, 0x40},
>> +	{0x370a, 0x01},
>> +	{0x370b, 0x1b},
>> +	{0x3714, 0x24},
>> +	{0x371a, 0x3e},
>> +	{0x3733, 0x00},
>> +	{0x3734, 0x00},
>> +	{0x373a, 0x05},
>> +	{0x373b, 0x06},
>> +	{0x373c, 0x0a},
>> +	{0x373f, 0xa0},
>> +	{0x3755, 0x00},
>> +	{0x3758, 0x00},
>> +	{0x375b, 0x0e},
>> +	{0x3766, 0x5f},
>> +	{0x3768, 0x00},
>> +	{0x3769, 0x22},
>> +	{0x3773, 0x08},
>> +	{0x3774, 0x1f},
>> +	{0x3776, 0x06},
>> +	{0x37a0, 0x88},
>> +	{0x37a1, 0x5c},
>> +	{0x37a7, 0x88},
>> +	{0x37a8, 0x70},
>> +	{0x37aa, 0x88},
>> +	{0x37ab, 0x48},
>> +	{0x37b3, 0x66},
>> +	{0x37c2, 0x04},
>> +	{0x37c5, 0x00},
>> +	{0x37c8, 0x00},
>> +	{0x3800, 0x00},
>> +	{0x3801, 0x0c},
>> +	{0x3802, 0x00},
>> +	{0x3803, 0x04},
>> +	{0x3804, 0x0a},
>> +	{0x3805, 0x33},
>> +	{0x3806, 0x07},
>> +	{0x3807, 0xa3},
>> +	{0x3808, 0x07},
>> +	{0x3809, 0x90},
>> +	{0x380a, 0x04},
>> +	{0x380b, 0x48},
>> +	{0x380c, 0x06},
>> +	{0x380d, 0xa8},
>> +	{0x380e, 0x07},
>> +	{0x380f, 0xf6},
>> +	{0x3811, 0x04},
>> +	{0x3813, 0x02},
>> +	{0x3814, 0x01},
>> +	{0x3815, 0x01},
>> +	{0x3816, 0x00},
>> +	{0x3817, 0x00},
>> +	{0x3818, 0x00},
>> +	{0x3819, 0x00},
>> +	{0x3820, 0x84},
>> +	{0x3821, 0x40},
>> +	{0x3822, 0x48},
>> +	{0x3826, 0x00},
>> +	{0x3827, 0x08},
>> +	{0x382a, 0x01},
>> +	{0x382b, 0x01},
>> +	{0x3830, 0x08},
>> +	{0x3836, 0x02},
>> +	{0x3837, 0x00},
>> +	{0x3838, 0x10},
>> +	{0x3841, 0xff},
>> +	{0x3846, 0x48},
>> +	{0x3861, 0x00},
>> +	{0x3862, 0x04},
>> +	{0x3863, 0x06},
>> +	{0x3a11, 0x01},
>> +	{0x3a12, 0x78},
>> +	{0x3b00, 0x00},
>> +	{0x3b02, 0x00},
>> +	{0x3b03, 0x00},
>> +	{0x3b04, 0x00},
>> +	{0x3b05, 0x00},
>> +	{0x3c00, 0x89},
>> +	{0x3c01, 0xab},
>> +	{0x3c02, 0x01},
>> +	{0x3c03, 0x00},
>> +	{0x3c04, 0x00},
>> +	{0x3c05, 0x03},
>> +	{0x3c06, 0x00},
>> +	{0x3c07, 0x05},
>> +	{0x3c0c, 0x00},
>> +	{0x3c0d, 0x00},
>> +	{0x3c0e, 0x00},
>> +	{0x3c0f, 0x00},
>> +	{0x3c40, 0x00},
>> +	{0x3c41, 0xa3},
>> +	{0x3c43, 0x7d},
>> +	{0x3c45, 0xd7},
>> +	{0x3c47, 0xfc},
>> +	{0x3c50, 0x05},
>> +	{0x3c52, 0xaa},
>> +	{0x3c54, 0x71},
>> +	{0x3c56, 0x80},
>> +	{0x3d85, 0x17},
>> +	{0x3f03, 0x00},
>> +	{0x3f0a, 0x00},
>> +	{0x3f0b, 0x00},
>> +	{0x4001, 0x60},
>> +	{0x4009, 0x0d},
>> +	{0x4020, 0x00},
>> +	{0x4021, 0x00},
>> +	{0x4022, 0x00},
>> +	{0x4023, 0x00},
>> +	{0x4024, 0x00},
>> +	{0x4025, 0x00},
>> +	{0x4026, 0x00},
>> +	{0x4027, 0x00},
>> +	{0x4028, 0x00},
>> +	{0x4029, 0x00},
>> +	{0x402a, 0x00},
>> +	{0x402b, 0x00},
>> +	{0x402c, 0x00},
>> +	{0x402d, 0x00},
>> +	{0x402e, 0x00},
>> +	{0x402f, 0x00},
>> +	{0x4040, 0x00},
>> +	{0x4041, 0x03},
>> +	{0x4042, 0x00},
>> +	{0x4043, 0x7A},
>> +	{0x4044, 0x00},
>> +	{0x4045, 0x7A},
>> +	{0x4046, 0x00},
>> +	{0x4047, 0x7A},
>> +	{0x4048, 0x00},
>> +	{0x4049, 0x7A},
>> +	{0x4303, 0x00},
>> +	{0x4307, 0x30},
>> +	{0x4500, 0x58},
>> +	{0x4501, 0x04},
>> +	{0x4502, 0x40},
>> +	{0x4503, 0x10},
>> +	{0x4508, 0xaa},
>> +	{0x4509, 0xaa},
>> +	{0x450a, 0x00},
>> +	{0x450b, 0x00},
>> +	{0x4600, 0x00},
>> +	{0x4601, 0xc0},
>> +	{0x4700, 0xa4},
>> +	{0x4800, 0x4c},
>> +	{0x4816, 0x53},
>> +	{0x481f, 0x40},
>> +	{0x4837, 0x12},
>> +	{0x5000, 0x56},
>> +	{0x5001, 0x01},
>> +	{0x5002, 0x28},
>> +	{0x5004, 0x0c},
>> +	{0x5006, 0x0c},
>> +	{0x5007, 0xe0},
>> +	{0x5008, 0x01},
>> +	{0x5009, 0xb0},
>> +	{0x5045, 0x05},
>> +	{0x5048, 0x10},
>> +	{0x5901, 0x00},
>> +	{0x5a01, 0x00},
>> +	{0x5a03, 0x00},
>> +	{0x5a04, 0x0c},
>> +	{0x5a05, 0xe0},
>> +	{0x5a06, 0x09},
>> +	{0x5a07, 0xb0},
>> +	{0x5a08, 0x06},
>> +	{0x5e00, 0x00},
>> +	{0x3734, 0x40},
>> +	{0x5b00, 0x01},
>> +	{0x5b01, 0x10},
>> +	{0x5b02, 0x01},
>> +	{0x5b03, 0xdb},
>> +	{0x3d8c, 0x71},
>> +	{0x3d8d, 0xea},
>> +	{0x4017, 0x08},
>> +	{0x3618, 0x2a},
>> +	{0x5780, 0x3e},
>> +	{0x5781, 0x0f},
>> +	{0x5782, 0x44},
>> +	{0x5783, 0x02},
>> +	{0x5784, 0x01},
>> +	{0x5785, 0x01},
>> +	{0x5786, 0x00},
>> +	{0x5787, 0x04},
>> +	{0x5788, 0x02},
>> +	{0x5789, 0x0f},
>> +	{0x578a, 0xfd},
>> +	{0x578b, 0xf5},
>> +	{0x578c, 0xf5},
>> +	{0x578d, 0x03},
>> +	{0x578e, 0x08},
>> +	{0x578f, 0x0c},
>> +	{0x5790, 0x08},
>> +	{0x5791, 0x06},
>> +	{0x5792, 0x00},
>> +	{0x5793, 0x52},
>> +	{0x5794, 0xa3},
>> +};
>> +
>> +static const struct ov5670_reg mode_2560x1440_regs[] = {
>> +	{0x3000, 0x00},
>> +	{0x3002, 0x61},
>> +	{0x3005, 0xf0},
>> +	{0x3007, 0x00},
>> +	{0x300D, 0x00},
>> +	{0x3010, 0x40},
>> +	{0x3015, 0x0f},
>> +	{0x3018, 0x32},
>> +	{0x301a, 0xf0},
>> +	{0x301b, 0xf0},
>> +	{0x301c, 0xf0},
>> +	{0x301d, 0xf0},
>> +	{0x301e, 0xf0},
>> +	{0x3030, 0x00},
>> +	{0x303c, 0xff},
>> +	{0x303e, 0xff},
>> +	{0x3040, 0xf0},
>> +	{0x3041, 0x00},
>> +	{0x3042, 0xf0},
>> +	{0x3106, 0x11},
>> +	{0x3500, 0x00},
>> +	{0x3501, 0xb8},
>> +	{0x3502, 0x80},
>> +	{0x3503, 0x00},
>> +	{0x3504, 0x03},
>> +	{0x3505, 0x83},
>> +	{0x3508, 0x04},
>> +	{0x3509, 0x00},
>> +	{0x350e, 0x04},
>> +	{0x350f, 0x00},
>> +	{0x3510, 0x00},
>> +	{0x3511, 0x02},
>> +	{0x3512, 0x00},
>> +	{0x3601, 0xc8},
>> +	{0x3610, 0xa8},
>> +	{0x3612, 0x48},
>> +	{0x3614, 0x5b},
>> +	{0x3615, 0x96},
>> +	{0x3621, 0xd0},
>> +	{0x3622, 0x00},
>> +	{0x3623, 0x00},
>> +	{0x3633, 0x13},
>> +	{0x3634, 0x13},
>> +	{0x3635, 0x13},
>> +	{0x3636, 0x13},
>> +	{0x3645, 0x13},
>> +	{0x3646, 0x82},
>> +	{0x3650, 0x00},
>> +	{0x3652, 0xff},
>> +	{0x3655, 0x20},
>> +	{0x3656, 0xff},
>> +	{0x365a, 0xff},
>> +	{0x365e, 0xff},
>> +	{0x3668, 0x00},
>> +	{0x366a, 0x07},
>> +	{0x366e, 0x10},
>> +	{0x366d, 0x00},
>> +	{0x366f, 0x80},
>> +	{0x3700, 0x28},
>> +	{0x3701, 0x10},
>> +	{0x3702, 0x3a},
>> +	{0x3703, 0x19},
>> +	{0x3704, 0x10},
>> +	{0x3705, 0x00},
>> +	{0x3706, 0x66},
>> +	{0x3707, 0x08},
>> +	{0x3708, 0x34},
>> +	{0x3709, 0x40},
>> +	{0x370a, 0x01},
>> +	{0x370b, 0x1b},
>> +	{0x3714, 0x24},
>> +	{0x371a, 0x3e},
>> +	{0x3733, 0x10},
>> +	{0x3734, 0x40},
>> +	{0x373a, 0x05},
>> +	{0x373b, 0x06},
>> +	{0x373c, 0x0a},
>> +	{0x373f, 0xa0},
>> +	{0x3755, 0x00},
>> +	{0x3758, 0x00},
>> +	{0x375b, 0x0e},
>> +	{0x3766, 0x5f},
>> +	{0x3768, 0x00},
>> +	{0x3769, 0x22},
>> +	{0x3773, 0x08},
>> +	{0x3774, 0x1f},
>> +	{0x3776, 0x06},
>> +	{0x37a0, 0x88},
>> +	{0x37a1, 0x5c},
>> +	{0x37a7, 0x88},
>> +	{0x37a8, 0x70},
>> +	{0x37aa, 0x88},
>> +	{0x37ab, 0x48},
>> +	{0x37b3, 0x66},
>> +	{0x37c2, 0x04},
>> +	{0x37c5, 0x00},
>> +	{0x37c8, 0x00},
>> +	{0x3800, 0x00},
>> +	{0x3801, 0x0c},
>> +	{0x3802, 0x00},
>> +	{0x3803, 0x04},
>> +	{0x3804, 0x0a},
>> +	{0x3805, 0x33},
>> +	{0x3806, 0x07},
>> +	{0x3807, 0xa3},
>> +	{0x3808, 0x0a},
>> +	{0x3809, 0x00},
>> +	{0x380a, 0x05},
>> +	{0x380b, 0xa0},
>> +	{0x380c, 0x06},
>> +	{0x380d, 0x90},
>> +	{0x380e, 0x08},
>> +	{0x380f, 0x14},
>> +	{0x3811, 0x04},
>> +	{0x3813, 0x02},
>> +	{0x3814, 0x01},
>> +	{0x3815, 0x01},
>> +	{0x3816, 0x00},
>> +	{0x3817, 0x00},
>> +	{0x3818, 0x00},
>> +	{0x3819, 0x00},
>> +	{0x3820, 0x84},
>> +	{0x3821, 0x40},
>> +	{0x3822, 0x48},
>> +	{0x3826, 0x00},
>> +	{0x3827, 0x08},
>> +	{0x382a, 0x01},
>> +	{0x382b, 0x01},
>> +	{0x3830, 0x08},
>> +	{0x3836, 0x02},
>> +	{0x3837, 0x00},
>> +	{0x3838, 0x10},
>> +	{0x3841, 0xff},
>> +	{0x3845, 0x01},
>> +	{0x3846, 0x48},
>> +	{0x3861, 0x00},
>> +	{0x3862, 0x04},
>> +	{0x3863, 0x06},
>> +	{0x3a11, 0x01},
>> +	{0x3a12, 0x78},
>> +	{0x3b00, 0x00},
>> +	{0x3b02, 0x00},
>> +	{0x3b03, 0x00},
>> +	{0x3b04, 0x00},
>> +	{0x3b05, 0x00},
>> +	{0x3c00, 0x89},
>> +	{0x3c01, 0xab},
>> +	{0x3c02, 0x01},
>> +	{0x3c03, 0x00},
>> +	{0x3c04, 0x00},
>> +	{0x3c05, 0x03},
>> +	{0x3c06, 0x00},
>> +	{0x3c07, 0x05},
>> +	{0x3c0c, 0x00},
>> +	{0x3c0d, 0x00},
>> +	{0x3c0e, 0x00},
>> +	{0x3c0f, 0x00},
>> +	{0x3c40, 0x00},
>> +	{0x3c41, 0xa3},
>> +	{0x3c43, 0x7d},
>> +	{0x3c45, 0xd7},
>> +	{0x3c47, 0xfc},
>> +	{0x3c50, 0x05},
>> +	{0x3c52, 0xaa},
>> +	{0x3c54, 0x71},
>> +	{0x3c56, 0x80},
>> +	{0x3d85, 0x17},
>> +	{0x3f03, 0x00},
>> +	{0x3f0a, 0x00},
>> +	{0x3f0b, 0x00},
>> +	{0x4001, 0x60},
>> +	{0x4009, 0x0d},
>> +	{0x4020, 0x00},
>> +	{0x4021, 0x00},
>> +	{0x4022, 0x00},
>> +	{0x4023, 0x00},
>> +	{0x4024, 0x00},
>> +	{0x4025, 0x00},
>> +	{0x4026, 0x00},
>> +	{0x4027, 0x00},
>> +	{0x4028, 0x00},
>> +	{0x4029, 0x00},
>> +	{0x402a, 0x00},
>> +	{0x402b, 0x00},
>> +	{0x402c, 0x00},
>> +	{0x402d, 0x00},
>> +	{0x402e, 0x00},
>> +	{0x402f, 0x00},
>> +	{0x4040, 0x00},
>> +	{0x4041, 0x03},
>> +	{0x4042, 0x00},
>> +	{0x4043, 0x7A},
>> +	{0x4044, 0x00},
>> +	{0x4045, 0x7A},
>> +	{0x4046, 0x00},
>> +	{0x4047, 0x7A},
>> +	{0x4048, 0x00},
>> +	{0x4049, 0x7A},
>> +	{0x4303, 0x00},
>> +	{0x4307, 0x30},
>> +	{0x4500, 0x58},
>> +	{0x4501, 0x04},
>> +	{0x4502, 0x40},
>> +	{0x4503, 0x10},
>> +	{0x4508, 0xaa},
>> +	{0x4509, 0xaa},
>> +	{0x450a, 0x00},
>> +	{0x450b, 0x00},
>> +	{0x4600, 0x01},
>> +	{0x4601, 0x00},
>> +	{0x4700, 0xa4},
>> +	{0x4800, 0x4c},
>> +	{0x4816, 0x53},
>> +	{0x481f, 0x40},
>> +	{0x4837, 0x12},
>> +	{0x5000, 0x56},
>> +	{0x5001, 0x01},
>> +	{0x5002, 0x28},
>> +	{0x5004, 0x0c},
>> +	{0x5006, 0x0c},
>> +	{0x5007, 0xe0},
>> +	{0x5008, 0x01},
>> +	{0x5009, 0xb0},
>> +	{0x5045, 0x05},
>> +	{0x5048, 0x10},
>> +	{0x5901, 0x00},
>> +	{0x5a01, 0x00},
>> +	{0x5a03, 0x00},
>> +	{0x5a04, 0x0c},
>> +	{0x5a05, 0xe0},
>> +	{0x5a06, 0x09},
>> +	{0x5a07, 0xb0},
>> +	{0x5a08, 0x06},
>> +	{0x5e00, 0x00},
>> +	{0x3734, 0x40},
>> +	{0x5b00, 0x01},
>> +	{0x5b01, 0x10},
>> +	{0x5b02, 0x01},
>> +	{0x5b03, 0xdb},
>> +	{0x3d8c, 0x71},
>> +	{0x3d8d, 0xea},
>> +	{0x4017, 0x08},
>> +	{0x3618, 0x2a},
>> +	{0x5780, 0x3e},
>> +	{0x5781, 0x0f},
>> +	{0x5782, 0x44},
>> +	{0x5783, 0x02},
>> +	{0x5784, 0x01},
>> +	{0x5785, 0x01},
>> +	{0x5786, 0x00},
>> +	{0x5787, 0x04},
>> +	{0x5788, 0x02},
>> +	{0x5789, 0x0f},
>> +	{0x578a, 0xfd},
>> +	{0x578b, 0xf5},
>> +	{0x578c, 0xf5},
>> +	{0x578d, 0x03},
>> +	{0x578e, 0x08},
>> +	{0x578f, 0x0c},
>> +	{0x5790, 0x08},
>> +	{0x5791, 0x06},
>> +	{0x5792, 0x00},
>> +	{0x5793, 0x52},
>> +	{0x5794, 0xa3},
>> +};
>> +
>> +static const struct ov5670_reg mode_2576x1456_regs[] = {
>> +	{0x3000, 0x00},
>> +	{0x3002, 0x61},
>> +	{0x3005, 0xf0},
>> +	{0x3007, 0x00},
>> +	{0x300D, 0x00},
>> +	{0x3010, 0x40},
>> +	{0x3015, 0x0f},
>> +	{0x3018, 0x32},
>> +	{0x301a, 0xf0},
>> +	{0x301b, 0xf0},
>> +	{0x301c, 0xf0},
>> +	{0x301d, 0xf0},
>> +	{0x301e, 0xf0},
>> +	{0x3030, 0x00},
>> +	{0x303c, 0xff},
>> +	{0x303e, 0xff},
>> +	{0x3040, 0xf0},
>> +	{0x3041, 0x00},
>> +	{0x3042, 0xf0},
>> +	{0x3106, 0x11},
>> +	{0x3500, 0x00},
>> +	{0x3501, 0xb8},
>> +	{0x3502, 0x80},
>> +	{0x3503, 0x00},
>> +	{0x3504, 0x03},
>> +	{0x3505, 0x83},
>> +	{0x3508, 0x04},
>> +	{0x3509, 0x00},
>> +	{0x350e, 0x04},
>> +	{0x350f, 0x00},
>> +	{0x3510, 0x00},
>> +	{0x3511, 0x02},
>> +	{0x3512, 0x00},
>> +	{0x3601, 0xc8},
>> +	{0x3610, 0xa8},
>> +	{0x3612, 0x48},
>> +	{0x3614, 0x5b},
>> +	{0x3615, 0x96},
>> +	{0x3621, 0xd0},
>> +	{0x3622, 0x00},
>> +	{0x3623, 0x00},
>> +	{0x3633, 0x13},
>> +	{0x3634, 0x13},
>> +	{0x3635, 0x13},
>> +	{0x3636, 0x13},
>> +	{0x3645, 0x13},
>> +	{0x3646, 0x82},
>> +	{0x3650, 0x00},
>> +	{0x3652, 0xff},
>> +	{0x3655, 0x20},
>> +	{0x3656, 0xff},
>> +	{0x365a, 0xff},
>> +	{0x365e, 0xff},
>> +	{0x3668, 0x00},
>> +	{0x366a, 0x07},
>> +	{0x366e, 0x10},
>> +	{0x366d, 0x00},
>> +	{0x366f, 0x80},
>> +	{0x3700, 0x28},
>> +	{0x3701, 0x10},
>> +	{0x3702, 0x3a},
>> +	{0x3703, 0x19},
>> +	{0x3704, 0x10},
>> +	{0x3705, 0x00},
>> +	{0x3706, 0x66},
>> +	{0x3707, 0x08},
>> +	{0x3708, 0x34},
>> +	{0x3709, 0x40},
>> +	{0x370a, 0x01},
>> +	{0x370b, 0x1b},
>> +	{0x3714, 0x24},
>> +	{0x371a, 0x3e},
>> +	{0x3733, 0x10},
>> +	{0x3734, 0x40},
>> +	{0x373a, 0x05},
>> +	{0x373b, 0x06},
>> +	{0x373c, 0x0a},
>> +	{0x373f, 0xa0},
>> +	{0x3755, 0x00},
>> +	{0x3758, 0x00},
>> +	{0x375b, 0x0e},
>> +	{0x3766, 0x5f},
>> +	{0x3768, 0x00},
>> +	{0x3769, 0x22},
>> +	{0x3773, 0x08},
>> +	{0x3774, 0x1f},
>> +	{0x3776, 0x06},
>> +	{0x37a0, 0x88},
>> +	{0x37a1, 0x5c},
>> +	{0x37a7, 0x88},
>> +	{0x37a8, 0x70},
>> +	{0x37aa, 0x88},
>> +	{0x37ab, 0x48},
>> +	{0x37b3, 0x66},
>> +	{0x37c2, 0x04},
>> +	{0x37c5, 0x00},
>> +	{0x37c8, 0x00},
>> +	{0x3800, 0x00},
>> +	{0x3801, 0x0c},
>> +	{0x3802, 0x00},
>> +	{0x3803, 0x04},
>> +	{0x3804, 0x0a},
>> +	{0x3805, 0x33},
>> +	{0x3806, 0x07},
>> +	{0x3807, 0xa3},
>> +	{0x3808, 0x0a},
>> +	{0x3809, 0x10},
>> +	{0x380a, 0x05},
>> +	{0x380b, 0xb0},
>> +	{0x380c, 0x06},
>> +	{0x380d, 0x90},
>> +	{0x380e, 0x08},
>> +	{0x380f, 0x14},
>> +	{0x3811, 0x04},
>> +	{0x3813, 0x02},
>> +	{0x3814, 0x01},
>> +	{0x3815, 0x01},
>> +	{0x3816, 0x00},
>> +	{0x3817, 0x00},
>> +	{0x3818, 0x00},
>> +	{0x3819, 0x00},
>> +	{0x3820, 0x84},
>> +	{0x3821, 0x40},
>> +	{0x3822, 0x48},
>> +	{0x3826, 0x00},
>> +	{0x3827, 0x08},
>> +	{0x382a, 0x01},
>> +	{0x382b, 0x01},
>> +	{0x3830, 0x08},
>> +	{0x3836, 0x02},
>> +	{0x3837, 0x00},
>> +	{0x3838, 0x10},
>> +	{0x3841, 0xff},
>> +	{0x3845, 0x01},
>> +	{0x3846, 0x48},
>> +	{0x3861, 0x00},
>> +	{0x3862, 0x04},
>> +	{0x3863, 0x06},
>> +	{0x3a11, 0x01},
>> +	{0x3a12, 0x78},
>> +	{0x3b00, 0x00},
>> +	{0x3b02, 0x00},
>> +	{0x3b03, 0x00},
>> +	{0x3b04, 0x00},
>> +	{0x3b05, 0x00},
>> +	{0x3c00, 0x89},
>> +	{0x3c01, 0xab},
>> +	{0x3c02, 0x01},
>> +	{0x3c03, 0x00},
>> +	{0x3c04, 0x00},
>> +	{0x3c05, 0x03},
>> +	{0x3c06, 0x00},
>> +	{0x3c07, 0x05},
>> +	{0x3c0c, 0x00},
>> +	{0x3c0d, 0x00},
>> +	{0x3c0e, 0x00},
>> +	{0x3c0f, 0x00},
>> +	{0x3c40, 0x00},
>> +	{0x3c41, 0xa3},
>> +	{0x3c43, 0x7d},
>> +	{0x3c45, 0xd7},
>> +	{0x3c47, 0xfc},
>> +	{0x3c50, 0x05},
>> +	{0x3c52, 0xaa},
>> +	{0x3c54, 0x71},
>> +	{0x3c56, 0x80},
>> +	{0x3d85, 0x17},
>> +	{0x3f03, 0x00},
>> +	{0x3f0a, 0x00},
>> +	{0x3f0b, 0x00},
>> +	{0x4001, 0x60},
>> +	{0x4009, 0x0d},
>> +	{0x4020, 0x00},
>> +	{0x4021, 0x00},
>> +	{0x4022, 0x00},
>> +	{0x4023, 0x00},
>> +	{0x4024, 0x00},
>> +	{0x4025, 0x00},
>> +	{0x4026, 0x00},
>> +	{0x4027, 0x00},
>> +	{0x4028, 0x00},
>> +	{0x4029, 0x00},
>> +	{0x402a, 0x00},
>> +	{0x402b, 0x00},
>> +	{0x402c, 0x00},
>> +	{0x402d, 0x00},
>> +	{0x402e, 0x00},
>> +	{0x402f, 0x00},
>> +	{0x4040, 0x00},
>> +	{0x4041, 0x03},
>> +	{0x4042, 0x00},
>> +	{0x4043, 0x7A},
>> +	{0x4044, 0x00},
>> +	{0x4045, 0x7A},
>> +	{0x4046, 0x00},
>> +	{0x4047, 0x7A},
>> +	{0x4048, 0x00},
>> +	{0x4049, 0x7A},
>> +	{0x4303, 0x00},
>> +	{0x4307, 0x30},
>> +	{0x4500, 0x58},
>> +	{0x4501, 0x04},
>> +	{0x4502, 0x40},
>> +	{0x4503, 0x10},
>> +	{0x4508, 0xaa},
>> +	{0x4509, 0xaa},
>> +	{0x450a, 0x00},
>> +	{0x450b, 0x00},
>> +	{0x4600, 0x01},
>> +	{0x4601, 0x00},
>> +	{0x4700, 0xa4},
>> +	{0x4800, 0x4c},
>> +	{0x4816, 0x53},
>> +	{0x481f, 0x40},
>> +	{0x4837, 0x12},
>> +	{0x5000, 0x56},
>> +	{0x5001, 0x01},
>> +	{0x5002, 0x28},
>> +	{0x5004, 0x0c},
>> +	{0x5006, 0x0c},
>> +	{0x5007, 0xe0},
>> +	{0x5008, 0x01},
>> +	{0x5009, 0xb0},
>> +	{0x5045, 0x05},
>> +	{0x5048, 0x10},
>> +	{0x5901, 0x00},
>> +	{0x5a01, 0x00},
>> +	{0x5a03, 0x00},
>> +	{0x5a04, 0x0c},
>> +	{0x5a05, 0xe0},
>> +	{0x5a06, 0x09},
>> +	{0x5a07, 0xb0},
>> +	{0x5a08, 0x06},
>> +	{0x5e00, 0x00},
>> +	{0x3734, 0x40},
>> +	{0x5b00, 0x01},
>> +	{0x5b01, 0x10},
>> +	{0x5b02, 0x01},
>> +	{0x5b03, 0xdb},
>> +	{0x3d8c, 0x71},
>> +	{0x3d8d, 0xea},
>> +	{0x4017, 0x08},
>> +	{0x3618, 0x2a},
>> +	{0x5780, 0x3e},
>> +	{0x5781, 0x0f},
>> +	{0x5782, 0x44},
>> +	{0x5783, 0x02},
>> +	{0x5784, 0x01},
>> +	{0x5785, 0x01},
>> +	{0x5786, 0x00},
>> +	{0x5787, 0x04},
>> +	{0x5788, 0x02},
>> +	{0x5789, 0x0f},
>> +	{0x578a, 0xfd},
>> +	{0x578b, 0xf5},
>> +	{0x578c, 0xf5},
>> +	{0x578d, 0x03},
>> +	{0x578e, 0x08},
>> +	{0x578f, 0x0c},
>> +	{0x5790, 0x08},
>> +	{0x5791, 0x06},
>> +	{0x5792, 0x00},
>> +	{0x5793, 0x52},
>> +	{0x5794, 0xa3},
>> +};
>> +
>> +static const struct ov5670_reg mode_2576x1936_regs[] = {
>> +	{0x3000, 0x00},
>> +	{0x3002, 0x61},
>> +	{0x3005, 0xf0},
>> +	{0x3007, 0x00},
>> +	{0x300D, 0x00},
>> +	{0x3010, 0x40},
>> +	{0x3015, 0x0f},
>> +	{0x3018, 0x32},
>> +	{0x301a, 0xf0},
>> +	{0x301b, 0xf0},
>> +	{0x301c, 0xf0},
>> +	{0x301d, 0xf0},
>> +	{0x301e, 0xf0},
>> +	{0x3030, 0x00},
>> +	{0x303c, 0xff},
>> +	{0x303e, 0xff},
>> +	{0x3040, 0xf0},
>> +	{0x3041, 0x00},
>> +	{0x3042, 0xf0},
>> +	{0x3106, 0x11},
>> +	{0x3500, 0x00},
>> +	{0x3501, 0xb8},
>> +	{0x3502, 0x80},
>> +	{0x3503, 0x00},
>> +	{0x3504, 0x03},
>> +	{0x3505, 0x83},
>> +	{0x3508, 0x04},
>> +	{0x3509, 0x00},
>> +	{0x350e, 0x04},
>> +	{0x350f, 0x00},
>> +	{0x3510, 0x00},
>> +	{0x3511, 0x02},
>> +	{0x3512, 0x00},
>> +	{0x3601, 0xc8},
>> +	{0x3610, 0xa8},
>> +	{0x3612, 0x48},
>> +	{0x3614, 0x5b},
>> +	{0x3615, 0x96},
>> +	{0x3621, 0xd0},
>> +	{0x3622, 0x00},
>> +	{0x3623, 0x00},
>> +	{0x3633, 0x13},
>> +	{0x3634, 0x13},
>> +	{0x3635, 0x13},
>> +	{0x3636, 0x13},
>> +	{0x3645, 0x13},
>> +	{0x3646, 0x82},
>> +	{0x3650, 0x00},
>> +	{0x3652, 0xff},
>> +	{0x3655, 0x20},
>> +	{0x3656, 0xff},
>> +	{0x365a, 0xff},
>> +	{0x365e, 0xff},
>> +	{0x3668, 0x00},
>> +	{0x366a, 0x07},
>> +	{0x366e, 0x10},
>> +	{0x366d, 0x00},
>> +	{0x366f, 0x80},
>> +	{0x3700, 0x28},
>> +	{0x3701, 0x10},
>> +	{0x3702, 0x3a},
>> +	{0x3703, 0x19},
>> +	{0x3704, 0x10},
>> +	{0x3705, 0x00},
>> +	{0x3706, 0x66},
>> +	{0x3707, 0x08},
>> +	{0x3708, 0x34},
>> +	{0x3709, 0x40},
>> +	{0x370a, 0x01},
>> +	{0x370b, 0x1b},
>> +	{0x3714, 0x24},
>> +	{0x371a, 0x3e},
>> +	{0x3733, 0x10},
>> +	{0x3734, 0x40},
>> +	{0x373a, 0x05},
>> +	{0x373b, 0x06},
>> +	{0x373c, 0x0a},
>> +	{0x373f, 0xa0},
>> +	{0x3755, 0x00},
>> +	{0x3758, 0x00},
>> +	{0x375b, 0x0e},
>> +	{0x3766, 0x5f},
>> +	{0x3768, 0x00},
>> +	{0x3769, 0x22},
>> +	{0x3773, 0x08},
>> +	{0x3774, 0x1f},
>> +	{0x3776, 0x06},
>> +	{0x37a0, 0x88},
>> +	{0x37a1, 0x5c},
>> +	{0x37a7, 0x88},
>> +	{0x37a8, 0x70},
>> +	{0x37aa, 0x88},
>> +	{0x37ab, 0x48},
>> +	{0x37b3, 0x66},
>> +	{0x37c2, 0x04},
>> +	{0x37c5, 0x00},
>> +	{0x37c8, 0x00},
>> +	{0x3800, 0x00},
>> +	{0x3801, 0x0c},
>> +	{0x3802, 0x00},
>> +	{0x3803, 0x04},
>> +	{0x3804, 0x0a},
>> +	{0x3805, 0x33},
>> +	{0x3806, 0x07},
>> +	{0x3807, 0xa3},
>> +	{0x3808, 0x0a},
>> +	{0x3809, 0x10},
>> +	{0x380a, 0x07},
>> +	{0x380b, 0x90},
>> +	{0x380c, 0x06},
>> +	{0x380d, 0x90},
>> +	{0x380e, 0x08},
>> +	{0x380f, 0x14},
>> +	{0x3811, 0x04},
>> +	{0x3813, 0x02},
>> +	{0x3814, 0x01},
>> +	{0x3815, 0x01},
>> +	{0x3816, 0x00},
>> +	{0x3817, 0x00},
>> +	{0x3818, 0x00},
>> +	{0x3819, 0x00},
>> +	{0x3820, 0x84},
>> +	{0x3821, 0x40},
>> +	{0x3822, 0x48},
>> +	{0x3826, 0x00},
>> +	{0x3827, 0x08},
>> +	{0x382a, 0x01},
>> +	{0x382b, 0x01},
>> +	{0x3830, 0x08},
>> +	{0x3836, 0x02},
>> +	{0x3837, 0x00},
>> +	{0x3838, 0x10},
>> +	{0x3841, 0xff},
>> +	{0x3845, 0x01},
>> +	{0x3846, 0x48},
>> +	{0x3861, 0x00},
>> +	{0x3862, 0x04},
>> +	{0x3863, 0x06},
>> +	{0x3a11, 0x01},
>> +	{0x3a12, 0x78},
>> +	{0x3b00, 0x00},
>> +	{0x3b02, 0x00},
>> +	{0x3b03, 0x00},
>> +	{0x3b04, 0x00},
>> +	{0x3b05, 0x00},
>> +	{0x3c00, 0x89},
>> +	{0x3c01, 0xab},
>> +	{0x3c02, 0x01},
>> +	{0x3c03, 0x00},
>> +	{0x3c04, 0x00},
>> +	{0x3c05, 0x03},
>> +	{0x3c06, 0x00},
>> +	{0x3c07, 0x05},
>> +	{0x3c0c, 0x00},
>> +	{0x3c0d, 0x00},
>> +	{0x3c0e, 0x00},
>> +	{0x3c0f, 0x00},
>> +	{0x3c40, 0x00},
>> +	{0x3c41, 0xa3},
>> +	{0x3c43, 0x7d},
>> +	{0x3c45, 0xd7},
>> +	{0x3c47, 0xfc},
>> +	{0x3c50, 0x05},
>> +	{0x3c52, 0xaa},
>> +	{0x3c54, 0x71},
>> +	{0x3c56, 0x80},
>> +	{0x3d85, 0x17},
>> +	{0x3f03, 0x00},
>> +	{0x3f0a, 0x00},
>> +	{0x3f0b, 0x00},
>> +	{0x4001, 0x60},
>> +	{0x4009, 0x0d},
>> +	{0x4020, 0x00},
>> +	{0x4021, 0x00},
>> +	{0x4022, 0x00},
>> +	{0x4023, 0x00},
>> +	{0x4024, 0x00},
>> +	{0x4025, 0x00},
>> +	{0x4026, 0x00},
>> +	{0x4027, 0x00},
>> +	{0x4028, 0x00},
>> +	{0x4029, 0x00},
>> +	{0x402a, 0x00},
>> +	{0x402b, 0x00},
>> +	{0x402c, 0x00},
>> +	{0x402d, 0x00},
>> +	{0x402e, 0x00},
>> +	{0x402f, 0x00},
>> +	{0x4040, 0x00},
>> +	{0x4041, 0x03},
>> +	{0x4042, 0x00},
>> +	{0x4043, 0x7A},
>> +	{0x4044, 0x00},
>> +	{0x4045, 0x7A},
>> +	{0x4046, 0x00},
>> +	{0x4047, 0x7A},
>> +	{0x4048, 0x00},
>> +	{0x4049, 0x7A},
>> +	{0x4303, 0x00},
>> +	{0x4307, 0x30},
>> +	{0x4500, 0x58},
>> +	{0x4501, 0x04},
>> +	{0x4502, 0x40},
>> +	{0x4503, 0x10},
>> +	{0x4508, 0xaa},
>> +	{0x4509, 0xaa},
>> +	{0x450a, 0x00},
>> +	{0x450b, 0x00},
>> +	{0x4600, 0x01},
>> +	{0x4601, 0x00},
>> +	{0x4700, 0xa4},
>> +	{0x4800, 0x4c},
>> +	{0x4816, 0x53},
>> +	{0x481f, 0x40},
>> +	{0x4837, 0x12},
>> +	{0x5000, 0x56},
>> +	{0x5001, 0x01},
>> +	{0x5002, 0x28},
>> +	{0x5004, 0x0c},
>> +	{0x5006, 0x0c},
>> +	{0x5007, 0xe0},
>> +	{0x5008, 0x01},
>> +	{0x5009, 0xb0},
>> +	{0x5045, 0x05},
>> +	{0x5048, 0x10},
>> +	{0x5901, 0x00},
>> +	{0x5a01, 0x00},
>> +	{0x5a03, 0x00},
>> +	{0x5a04, 0x0c},
>> +	{0x5a05, 0xe0},
>> +	{0x5a06, 0x09},
>> +	{0x5a07, 0xb0},
>> +	{0x5a08, 0x06},
>> +	{0x5e00, 0x00},
>> +	{0x3734, 0x40},
>> +	{0x5b00, 0x01},
>> +	{0x5b01, 0x10},
>> +	{0x5b02, 0x01},
>> +	{0x5b03, 0xdb},
>> +	{0x3d8c, 0x71},
>> +	{0x3d8d, 0xea},
>> +	{0x4017, 0x08},
>> +	{0x3618, 0x2a},
>> +	{0x5780, 0x3e},
>> +	{0x5781, 0x0f},
>> +	{0x5782, 0x44},
>> +	{0x5783, 0x02},
>> +	{0x5784, 0x01},
>> +	{0x5785, 0x01},
>> +	{0x5786, 0x00},
>> +	{0x5787, 0x04},
>> +	{0x5788, 0x02},
>> +	{0x5789, 0x0f},
>> +	{0x578a, 0xfd},
>> +	{0x578b, 0xf5},
>> +	{0x578c, 0xf5},
>> +	{0x578d, 0x03},
>> +	{0x578e, 0x08},
>> +	{0x578f, 0x0c},
>> +	{0x5790, 0x08},
>> +	{0x5791, 0x06},
>> +	{0x5792, 0x00},
>> +	{0x5793, 0x52},
>> +	{0x5794, 0xa3},
>> +};
>> +
>> +static const struct ov5670_link_freq_config link_freq_configs[] = {
>> +	{
>> +		.link_freq = OV5670_LINK_FREQ_840MBPS,
>> +		.pixel_rate = 336000000,
>> +		.reg_list = {
>> +			.num_of_regs = ARRAY_SIZE(mipi_data_rate_840mbps),
>> +			.regs = mipi_data_rate_840mbps,
>> +		}
>> +	}
>> +};
>> +
>> +static const struct ov5670_mode supported_modes[] = {
>> +	{
>> +		.width = 2576,
>> +		.height = 1936,
>> +		.skip_frames = 2,
>> +		.reg_list = {
>> +			.num_of_regs = ARRAY_SIZE(mode_2576x1936_regs),
>> +			.regs = mode_2576x1936_regs,
>> +		},
>> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
>> +	},
>> +	{
>> +		.width = 2576,
>> +		.height = 1456,
>> +		.skip_frames = 2,
>> +		.reg_list = {
>> +			.num_of_regs = ARRAY_SIZE(mode_2576x1456_regs),
>> +			.regs = mode_2576x1456_regs,
>> +		},
>> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
>> +	},
>> +	{
>> +		.width = 2560,
>> +		.height = 1440,
>> +		.skip_frames = 2,
>> +		.reg_list = {
>> +			.num_of_regs = ARRAY_SIZE(mode_2560x1440_regs),
>> +			.regs = mode_2560x1440_regs,
>> +		},
>> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
>> +	},
>> +	{
>> +		.width = 1936,
>> +		.height = 1096,
>> +		.skip_frames = 2,
>> +		.reg_list = {
>> +			.num_of_regs = ARRAY_SIZE(mode_1936x1096_regs),
>> +			.regs = mode_1936x1096_regs,
>> +		},
>> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
>> +	},
>> +	{
>> +		.width = 1920,
>> +		.height = 1080,
>> +		.skip_frames = 2,
>> +		.reg_list = {
>> +			.num_of_regs = ARRAY_SIZE(mode_1920x1080_regs),
>> +			.regs = mode_1920x1080_regs,
>> +		},
>> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
>> +	},
>> +	{
>> +		.width = 1440,
>> +		.height = 1080,
>> +		.skip_frames = 2,
>> +		.reg_list = {
>> +			.num_of_regs = ARRAY_SIZE(mode_1440x1080_regs),
>> +			.regs = mode_1440x1080_regs,
>> +		},
>> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
>> +	},
>> +	{
>> +		.width = 1296,
>> +		.height = 736,
>> +		.skip_frames = 2,
>> +		.reg_list = {
>> +			.num_of_regs = ARRAY_SIZE(mode_1296x736_regs),
>> +			.regs = mode_1296x736_regs,
>> +		},
>> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
>> +	},
>> +	{
>> +		.width = 1280,
>> +		.height = 720,
>> +		.skip_frames = 2,
>> +		.reg_list = {
>> +			.num_of_regs = ARRAY_SIZE(mode_1280x720_regs),
>> +			.regs = mode_1280x720_regs,
>> +		},
>> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
>> +	},
>> +	{
>> +		.width = 960,
>> +		.height = 720,
>> +		.skip_frames = 2,
>> +		.reg_list = {
>> +			.num_of_regs = ARRAY_SIZE(mode_960x720_regs),
>> +			.regs = mode_960x720_regs,
>> +		},
>> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
>> +	},
>> +	{
>> +		.width = 656,
>> +		.height = 496,
>> +		.skip_frames = 2,
>> +		.reg_list = {
>> +			.num_of_regs = ARRAY_SIZE(mode_656x496_regs),
>> +			.regs = mode_656x496_regs,
>> +		},
>> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
>> +	},
>> +	{
>> +		.width = 640,
>> +		.height = 480,
>> +		.skip_frames = 2,
>> +		.reg_list = {
>> +			.num_of_regs = ARRAY_SIZE(mode_640x480_regs),
>> +			.regs = mode_640x480_regs,
>> +		},
>> +		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
>> +	},
>> +};
>> +
>> +static const s64 link_freq_menu_items[] = {
>> +					OV5670_LINK_FREQ_840MBPS
>
>Indentation.
>
Reduced indentation to single tab
>> +				};
>> +
>> +struct ov5670 {
>> +	struct v4l2_subdev sd;
>> +	struct media_pad pad;
>> +
>> +	struct v4l2_ctrl_handler ctrl_handler;
>> +	struct {
>> +		struct v4l2_ctrl *link_freq;
>> +		struct v4l2_ctrl *pixel_rate;
>> +	};
>> +
>> +	/* Current mode */
>> +	const struct ov5670_mode *cur_mode;
>> +
>> +	/* To protect from asynchronus callbacks */
>> +	struct mutex mutex;
>> +
>> +	int link_freq_index;
>
>You can use link_freq->val .
>
Removed link_freq_index from struct ov5670.
>> +
>> +	bool streaming;
>> +};
>> +
>> +#define to_ov5670(_sd)	container_of(_sd, struct ov5670, sd)
>> +
>> +/* Read registers up to 4 at a time */
>> +static int ov5670_read_reg(struct ov5670 *ov5670, u16 reg, u32 len, u32 *val)
>> +{
>> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
>> +	struct i2c_msg msgs[2];
>> +	u8 *data_be_p;
>> +	u32 data_be = 0;
>> +	u16 reg_addr_be = cpu_to_be16(reg);
>> +
>> +	if (len > 4)
>> +		return -EINVAL;
>> +
>> +	data_be_p = (u8 *)&data_be;
>> +	/* Write register address */
>> +	msgs[0].addr = client->addr;
>> +	msgs[0].flags = 0;
>> +	msgs[0].len = 2;
>> +	msgs[0].buf = (u8 *)&reg_addr_be;
>> +
>> +	/* Read data from register */
>> +	msgs[1].addr = client->addr;
>> +	msgs[1].flags = I2C_M_RD;
>> +	msgs[1].len = len;
>> +	msgs[1].buf = &data_be_p[4 - len];
>> +
>> +	if (i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs)) !=
>> +			 ARRAY_SIZE(msgs))
>
>Alignment.
>
Aligned.
>> +		return -EIO;
>> +
>> +	*val = be32_to_cpu(data_be);
>> +
>> +	return 0;
>> +}
>> +
>> +/* Write registers up to 4 at a time */
>> +static int ov5670_write_reg(struct ov5670 *ov5670, u16 reg, u32 len, u32 val)
>> +{
>> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
>> +	int buf_i;
>> +	int val_i;
>> +	u8 buf[6];
>> +	u8 *val_p;
>> +
>> +	if (len > 4)
>> +		return -EINVAL;
>> +
>> +	buf[0] = reg >> 8;
>> +	buf[1] = reg & 0xff;
>> +
>> +	buf_i = 2;
>> +	val_p = (u8 *)&val;
>> +	for (val_i = len - 1; val_i >= 0; val_i--, buf_i++)
>> +		buf[buf_i] = val_p[val_i];
>> +
>> +	if (i2c_master_send(client, buf, len + 2) != len + 2)
>> +		return -EIO;
>> +
>> +	return 0;
>> +}
>> +
>> +/* Write a list of registers */
>> +static int ov5670_write_regs(struct ov5670 *ov5670,
>> +			     const struct ov5670_reg *regs,
>> +			     int len)
>
>How about using unsigned int for len?
>
Now u32 len.
>> +{
>> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
>> +	int i;
>
>i as well.
>
Now u32 i
>> +	int ret;
>> +
>> +	for (i = 0; i < len; i++) {
>> +		ret = ov5670_write_reg(ov5670, regs[i].address, 1, regs[i].val);
>> +		if (ret) {
>> +			dev_err_ratelimited(
>> +				&client->dev,
>> +				"Failed to write reg 0x%4.4x. error = %d\n",
>> +				regs[i].address, ret);
>> +
>> +			return ret;
>> +		}
>> +	}
>> +
>> +	return 0;
>> +}
>> +
>> +static int ov5670_write_reg_list(struct ov5670 *ov5670,
>> +				 const struct ov5670_reg_list *r_list)
>> +{
>> +	return ov5670_write_regs(ov5670, r_list->regs, r_list->num_of_regs);
>> +}
>> +
>> +/* Open sub-device */
>> +static int ov5670_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
>> +{
>> +	struct ov5670 *ov5670 = to_ov5670(sd);
>> +	struct v4l2_mbus_framefmt *try_fmt;
>> +
>> +	mutex_lock(&ov5670->mutex);
>> +
>> +	/* Initialize try_fmt */
>> +	try_fmt = v4l2_subdev_get_try_format(sd, fh->pad, 0);
>> +	try_fmt->width = ov5670->cur_mode->width;
>> +	try_fmt->height = ov5670->cur_mode->height;
>> +	try_fmt->code = MEDIA_BUS_FMT_SGRBG10_1X10;
>> +	try_fmt->field = V4L2_FIELD_NONE;
>> +
>> +	/* No crop or compose */
>> +	mutex_unlock(&ov5670->mutex);
>> +
>> +	return 0;
>> +}
>> +
>> +/* Update analog gain */
>> +static int ov5670_update_analog_gain(struct ov5670 *ov5670,
>> +				     struct v4l2_ctrl *ctrl)
>> +{
>> +	u32 analog_gain;
>> +
>> +	analog_gain = ctrl->val;
>> +
>> +	return ov5670_write_reg(ov5670, OV5670_REG_ANALOG_GAIN,
>> +				OV5670_REG_VALUE_16BIT, analog_gain);
>
>You can use ctrl->val here directly.
>
Used ctrl->val directly.
>> +}
>> +
>> +/* Exposure control */
>> +static int ov5670_update_exposure_ctrl(struct ov5670 *ov5670,
>> +				       struct v4l2_ctrl *ctrl)
>> +{
>> +	u32 exposure;
>> +
>> +	exposure = ctrl->val;
>> +
>> +	return ov5670_write_reg(ov5670, OV5670_REG_EXPOSURE,
>> +				OV5670_REG_VALUE_24BIT, exposure);
>
>Ditto.
>
Used ctrl->val directly.
>> +}
>> +
>> +/* Get volatile controls */
>> +static int ov5670_g_volatile_ctrl(struct v4l2_ctrl *ctrl)
>> +{
>> +	struct ov5670 *ov5670 = container_of(ctrl->handler,
>> +					struct ov5670, ctrl_handler);
>> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
>> +	int link_freq_index;
>> +	int ret = 0;
>> +
>> +	link_freq_index = ov5670->cur_mode->link_freq_index;
>> +
>> +	switch (ctrl->id) {
>> +	case V4L2_CID_LINK_FREQ:
>> +		ctrl->val = link_freq_index;
>> +		break;
>> +	case V4L2_CID_PIXEL_RATE:
>> +		ctrl->val = link_freq_configs[link_freq_index].pixel_rate;
>> +		break;
>> +	default:
>> +		dev_info(&client->dev, "unknown control 0x%x\n", ctrl->id);
>> +		ret = -EINVAL;
>> +	}
>> +
>> +	dev_dbg(&client->dev, "%s id:0x%x val:0x%x\n", __func__, ctrl->id,
>> +		ctrl->val);
>
>No need for a debug print.
>
Deleted debug print.
>> +	return ret;
>> +}
>> +
>> +/* Initialize control handlers */
>> +static int ov5670_set_ctrl(struct v4l2_ctrl *ctrl)
>> +{
>> +	struct ov5670 *ov5670 = container_of(ctrl->handler,
>> +						struct ov5670, ctrl_handler);
>> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
>> +
>> +	dev_dbg(&client->dev, "%s id:0x%x val:0x%x\n", __func__, ctrl->id,
>> +		ctrl->val);
>
>Ditto.
>
Deleted debug print.
>> +
>> +	switch (ctrl->id) {
>> +	case V4L2_CID_ANALOGUE_GAIN:
>> +		return ov5670_update_analog_gain(ov5670, ctrl);
>> +	case V4L2_CID_EXPOSURE:
>> +		return ov5670_update_exposure_ctrl(ov5670, ctrl);
>> +	case V4L2_CID_LINK_FREQ:
>> +		break;
>> +	default:
>> +		dev_info(&client->dev, "id:0x%x, val:0x%x\n", ctrl->id,
>> +			 ctrl->val);
>> +		return 0;
>> +	};
>> +
>> +	return 0;
>> +}
>> +
>> +static const struct v4l2_ctrl_ops ov5670_ctrl_ops = {
>> +	.g_volatile_ctrl = ov5670_g_volatile_ctrl,
>> +	.s_ctrl = ov5670_set_ctrl,
>> +};
>> +
>> +/* Initialize control handlers */
>> +static int ov5670_init_controls(struct ov5670 *ov5670)
>> +{
>> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
>> +	struct v4l2_ctrl_handler *ctrl_hdlr;
>> +	int ret;
>> +
>> +	ctrl_hdlr = &ov5670->ctrl_handler;
>> +	ret = v4l2_ctrl_handler_init(ctrl_hdlr, 4);
>> +	if (ret)
>> +		return ret;
>> +
>> +	ctrl_hdlr->lock = &ov5670->mutex;
>> +	ov5670->link_freq = v4l2_ctrl_new_int_menu(ctrl_hdlr,
>> +				&ov5670_ctrl_ops,
>> +				V4L2_CID_LINK_FREQ, 1,
>> +				ARRAY_SIZE(link_freq_menu_items) - 1,
>> +				link_freq_menu_items);
>> +	ov5670->link_freq->flags |= V4L2_CTRL_FLAG_VOLATILE;
>
>Link frequency should be a read-only control. Could you use
>V4L2_CTRL_FLAG_READ_ONLY instead? Use v4l2_ctrl_s_ctrl() to change its
>value.
>
>Although... you have just a single value for now.
>
Made link frequency V4L2_CTRL_FLAG_READ_ONLY control.
>> +
>> +	ov5670->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov5670_ctrl_ops,
>> +					V4L2_CID_PIXEL_RATE, 0,
>> +					OV5670_LINK_FREQ_840MBPS, 1,
>> +					link_freq_configs[0].pixel_rate);
>> +	v4l2_ctrl_cluster(2, &ov5670->link_freq);
>> +
>> +	/* Get min, max, step, default from sensor */
>> +	v4l2_ctrl_new_std(ctrl_hdlr, &ov5670_ctrl_ops, V4L2_CID_ANALOGUE_GAIN,
>> +			  ANALOG_GAIN_MIN, ANALOG_GAIN_MAX, ANALOG_GAIN_STEP,
>> +			  ANALOG_GAIN_DEFAULT);
>> +
>> +	/* Get min, max, step, default from sensor */
>> +	v4l2_ctrl_new_std(ctrl_hdlr, &ov5670_ctrl_ops, V4L2_CID_EXPOSURE,
>> +			  EXPOSURE_MIN, EXPOSURE_MAX, EXPOSURE_STEP,
>> +			  EXPOSURE_DEFAULT);
>> +
>> +	if (ctrl_hdlr->error) {
>> +		ret = ctrl_hdlr->error;
>> +		dev_err(&client->dev, "%s control init failed (%d)\n", __func__,
>> +			ret);
>
>This could fail once you make changes to how controls are created but it's
>not needed after development time. How about removing the message?
>
Deleted debug print.
>> +		goto error;
>> +	}
>> +
>> +	ov5670->sd.ctrl_handler = ctrl_hdlr;
>> +
>> +	return 0;
>> +
>> +error:
>> +	v4l2_ctrl_handler_free(ctrl_hdlr);
>> +
>> +	return ret;
>> +}
>> +
>> +static void ov5670_update_pad_format(struct ov5670 *ov5670,
>
>You have no use for ov5670 argument.
>
Removed unused argument.
>> +				     const struct ov5670_mode *mode,
>> +				     struct v4l2_subdev_format *fmt)
>> +{
>> +	fmt->format.width = mode->width;
>> +	fmt->format.height = mode->height;
>> +	fmt->format.code = MEDIA_BUS_FMT_SGRBG10_1X10;
>> +	fmt->format.field = V4L2_FIELD_NONE;
>> +}
>> +
>> +static int ov5670_do_get_pad_format(struct ov5670 *ov5670,
>> +				    struct v4l2_subdev_pad_config *cfg,
>> +				    struct v4l2_subdev_format *fmt)
>> +{
>> +	struct v4l2_mbus_framefmt *framefmt;
>> +	struct v4l2_subdev *sd = &ov5670->sd;
>> +
>> +	if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
>> +		framefmt = v4l2_subdev_get_try_format(sd, cfg, fmt->pad);
>> +		fmt->format = *framefmt;
>
>You could do without framefmt.
>
Did without framefmt.
>> +	} else {
>> +		ov5670_update_pad_format(ov5670, ov5670->cur_mode, fmt);
>> +	}
>> +
>> +	return 0;
>> +}
>> +
>> +static int ov5670_enum_mbus_code(struct v4l2_subdev *sd,
>> +				 struct v4l2_subdev_pad_config *cfg,
>> +				 struct v4l2_subdev_mbus_code_enum *code)
>> +{
>> +	/* Only one bayer order GRBG is supported */
>> +	if (code->index > 0)
>> +		return -EINVAL;
>> +
>> +	code->code = MEDIA_BUS_FMT_SGRBG10_1X10;
>
>Newline, please.
>
Added.
>> +	return 0;
>> +}
>> +
>> +static int ov5670_enum_frame_size(struct v4l2_subdev *sd,
>> +				  struct v4l2_subdev_pad_config *cfg,
>> +				  struct v4l2_subdev_frame_size_enum *fse)
>> +{
>> +	if (fse->index >= ARRAY_SIZE(supported_modes))
>> +		return -EINVAL;
>> +
>> +	if (fse->code != MEDIA_BUS_FMT_SGRBG10_1X10)
>> +		return -EINVAL;
>> +
>> +	fse->min_width = supported_modes[fse->index].width;
>> +	fse->max_width = fse->min_width;
>> +	fse->min_height = supported_modes[fse->index].height;
>> +	fse->max_height = fse->min_height;
>> +
>> +	return 0;
>> +}
>> +
>> +static int ov5670_get_pad_format(struct v4l2_subdev *sd,
>> +				 struct v4l2_subdev_pad_config *cfg,
>> +				 struct v4l2_subdev_format *fmt)
>> +{
>> +	struct ov5670 *ov5670 = to_ov5670(sd);
>> +	int ret;
>> +
>> +	mutex_lock(&ov5670->mutex);
>> +	ret = ov5670_do_get_pad_format(ov5670, cfg, fmt);
>> +	mutex_unlock(&ov5670->mutex);
>> +
>> +	return ret;
>> +}
>> +
>> +/* Calculate resolution distance */
>> +static int ov5670_get_reso_dist(const struct ov5670_mode *mode,
>> +				struct v4l2_mbus_framefmt *framefmt)
>> +{
>> +	return abs(mode->width - framefmt->width) +
>> +	       abs(mode->height - framefmt->height);
>> +}
>> +
>> +/* Find the closest supported resolution to the requested resolution */
>> +static const struct ov5670_mode *ov5670_find_best_fit(
>> +						struct ov5670 *ov5670,
>> +						struct v4l2_subdev_format *fmt)
>> +{
>> +	struct v4l2_mbus_framefmt *framefmt = &fmt->format;
>> +	int dist;
>> +	int cur_best_fit = 0;
>> +	int cur_best_fit_dist = -1;
>> +	int i;
>> +
>> +	for (i = 0; i < ARRAY_SIZE(supported_modes); i++) {
>> +		dist = ov5670_get_reso_dist(&supported_modes[i], framefmt);
>> +		if (cur_best_fit_dist == -1 || dist < cur_best_fit_dist) {
>> +			cur_best_fit_dist = dist;
>> +			cur_best_fit = i;
>> +		}
>> +	}
>> +
>> +	return &supported_modes[cur_best_fit];
>> +}
>> +
>> +static int ov5670_set_pad_format(struct v4l2_subdev *sd,
>> +				 struct v4l2_subdev_pad_config *cfg,
>> +				 struct v4l2_subdev_format *fmt)
>> +{
>> +	struct ov5670 *ov5670 = to_ov5670(sd);
>> +	struct i2c_client *client = v4l2_get_subdevdata(sd);
>> +	const struct ov5670_mode *mode;
>> +	struct v4l2_mbus_framefmt *framefmt;
>> +
>> +	dev_dbg(&client->dev, "%s sd_name: %s pad: %d w: %d, h: %d code: 0x%x",
>> +		__func__, sd->name, fmt->pad, fmt->format.width,
>> +		fmt->format.height, fmt->format.code);
>> +
>> +	mutex_lock(&ov5670->mutex);
>> +
>> +	if (fmt->format.code != MEDIA_BUS_FMT_SGRBG10_1X10) {
>
>Instead of returning an error you should adjust the format instead. I.e. in
>this case just assign it to fmt->format.code.
>
Adjusted format code.
>> +		mutex_unlock(&ov5670->mutex);
>> +		return -EINVAL;
>> +	}
>> +
>> +	mode = ov5670_find_best_fit(ov5670, fmt);
>> +	ov5670_update_pad_format(ov5670, mode, fmt);
>> +	if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
>> +		framefmt = v4l2_subdev_get_try_format(sd, cfg, fmt->pad);
>> +		*framefmt = fmt->format;
>
>You could do without framefmt. Up to you.
>
Did.
>> +	} else {
>> +		ov5670->cur_mode = mode;
>> +	}
>> +
>> +	mutex_unlock(&ov5670->mutex);
>> +
>> +	return 0;
>> +}
>> +
>> +static int ov5670_get_skip_frames(struct v4l2_subdev *sd, u32 *frames)
>> +{
>> +	struct ov5670 *ov5670 = to_ov5670(sd);
>> +
>> +	mutex_lock(&ov5670->mutex);
>> +	*frames = ov5670->cur_mode->skip_frames;
>> +	mutex_unlock(&ov5670->mutex);
>> +
>> +	return 0;
>> +}
>> +
>> +/* Prepare streaming by writing default values and customized values */
>> +static int ov5670_prepare_streaming(struct ov5670 *ov5670)
>> +{
>> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
>> +	const struct ov5670_reg_list *reg_list;
>> +	int link_freq_index;
>> +	int ret;
>> +
>> +	/* Write the power up registers */
>> +	ret = ov5670_write_reg(ov5670, OV5670_REG_SOFTWARE_RST,
>> +			       OV5670_REG_VALUE_08BIT, OV5670_SOFTWARE_RST);
>> +	if (ret) {
>> +		dev_err(&client->dev, "%s failed to set powerup registers\n",
>> +			__func__);
>> +		return ret;
>> +	}
>> +
>> +	/* Write pll registers */
>> +	link_freq_index = ov5670->cur_mode->link_freq_index;
>> +	reg_list = &link_freq_configs[link_freq_index].reg_list;
>> +	ret = ov5670_write_reg_list(ov5670, reg_list);
>> +	if (ret) {
>> +		dev_err(&client->dev, "%s failed to set plls\n", __func__);
>> +		return ret;
>> +	}
>> +
>> +	/* Write the default values of current mode */
>> +	reg_list = &ov5670->cur_mode->reg_list;
>> +	ret = ov5670_write_reg_list(ov5670, reg_list);
>> +	if (ret) {
>> +		dev_err(&client->dev, "%s failed to set mode\n", __func__);
>> +		return ret;
>> +	}
>> +
>> +	dev_dbg(&client->dev, "%s init v4l2 controls", __func__);
>
>Please remove the debug print.
>
Removed.
>> +
>> +	ret = v4l2_ctrl_handler_setup(ov5670->sd.ctrl_handler);
>
>I'd just return what v4l2_ctrl_handler_setup() does and remove the error
>message.
>
Did.
>> +	if (ret) {
>> +		dev_err(&client->dev, "%s v4l2_ctrl_handler failed\n",
>> +			__func__);
>> +		return ret;
>> +	}
>> +
>> +	return 0;
>> +}
>> +
>> +static int ov5670_start_streaming(struct ov5670 *ov5670)
>> +{
>> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
>> +	int ret;
>> +
>> +	/* Write stream on list */
>> +	ret = ov5670_write_reg(ov5670, OV5670_REG_MODE_SELECT,
>> +			       OV5670_REG_VALUE_08BIT, OV5670_MODE_STREAMING);
>> +	if (ret) {
>> +		dev_err(&client->dev, "%s failed to set stream\n", __func__);
>> +		return ret;
>> +	}
>> +
>> +	ov5670->streaming = 1;
>> +	return 0;
>> +}
>> +
>> +static int ov5670_stop_streaming(struct ov5670 *ov5670)
>> +{
>> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
>> +	int ret;
>> +
>> +	ret = ov5670_write_reg(ov5670, OV5670_REG_MODE_SELECT,
>> +			       OV5670_REG_VALUE_08BIT, OV5670_MODE_STANDBY);
>> +	if (ret) {
>> +		dev_err(&client->dev, "%s failed to set stream\n", __func__);
>> +		return ret;
>> +	}
>> +	ov5670->streaming = 0;
>> +	return ret;
>> +}
>> +
>> +static int ov5670_set_stream(struct v4l2_subdev *sd, int enable)
>> +{
>> +	struct ov5670 *ov5670 = to_ov5670(sd);
>> +	int ret = 0;
>> +
>> +	mutex_lock(&ov5670->mutex);
>> +	if (ov5670->streaming == enable) {
>> +		mutex_unlock(&ov5670->mutex);
>> +		return 0;
>> +	}
>> +	mutex_unlock(&ov5670->mutex);
>> +
>> +	if (enable) {
>> +		ret = ov5670_prepare_streaming(ov5670);
>
>ov5670_prepare_streaming() and ov5670_start_streaming() are always called
>sequientally. Could you combine the two?
>
>About locking --- you would likely benefit from an unlocked variant of
>v4l2_ctrl_handler_setup(). I uploaded it here, let me know if it works for
>you:
>
><URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=ctrl-setup-unlocked>
>
Tried unlocked __v4l2_ctrl_handler_setup(), working fine, used.
Can you push this patch?
>> +		if (ret)
>> +			return ret;
>> +
>> +		mutex_lock(&ov5670->mutex);
>> +		ret = ov5670_start_streaming(ov5670);
>> +		mutex_unlock(&ov5670->mutex);
>> +	} else {
>> +		mutex_lock(&ov5670->mutex);
>> +		ret = ov5670_stop_streaming(ov5670);
>> +		mutex_unlock(&ov5670->mutex);
>> +	}
>> +
>> +	return ret;
>> +}
>> +
>> +#ifdef CONFIG_PM
>> +
>> +static int ov5670_suspend(struct device *dev)
>
>Please remove #ifdef and use __maybe_unused instead. It's not easy to get
>the #ifdefs right in all cases.
>
Used __maybe_unused.
>> +{
>> +	struct i2c_client *client = to_i2c_client(dev);
>> +	struct v4l2_subdev *sd = i2c_get_clientdata(client);
>> +	struct ov5670 *ov5670 = to_ov5670(sd);
>> +
>> +	if (ov5670->streaming)
>> +		ov5670_stop_streaming(ov5670);
>> +
>> +	return 0;
>> +}
>> +
>> +static int ov5670_resume(struct device *dev)
>> +{
>> +	struct i2c_client *client = to_i2c_client(dev);
>> +	struct v4l2_subdev *sd = i2c_get_clientdata(client);
>> +	struct ov5670 *ov5670 = to_ov5670(sd);
>> +	int ret;
>> +
>> +	if (ov5670->streaming) {
>> +		ret = ov5670_prepare_streaming(ov5670);
>> +		if (ret)
>> +			goto error_prepare;
>> +		ret = ov5670_start_streaming(ov5670);
>> +		if (ret)
>> +			goto error_prepare;
>> +	}
>> +
>> +	return 0;
>> +
>> +error_prepare:
>> +	ov5670_stop_streaming(ov5670);
>
>Newline, please.
>
Added.
>> +	return ret;
>> +}
>> +
>> +#else
>> +
>> +#define ov5670_suspend	NULL
>> +#define ov5670_resume	NULL
>> +
>> +#endif	/* CONFIG_PM */
>> +
>> +static int ov5670_identify_module(struct ov5670 *ov5670,
>> +				  struct i2c_client *client)
>> +{
>> +	int ret;
>> +	u32 val;
>> +
>> +	ret = ov5670_read_reg(ov5670, OV5670_REG_CHIPID,
>> +			      OV5670_REG_VALUE_24BIT, &val);
>> +	if (ret)
>> +		return ret;
>> +
>> +	if (val != OV5670_CHIP_ID) {
>> +		dev_err(&client->dev, "Unknown sensor(0x%x) detected\n", val);
>> +		return -ENOTTY;
>> +	}
>> +
>> +	return 0;
>> +}
>> +
>> +static const struct v4l2_subdev_video_ops ov5670_video_ops = {
>> +	.s_stream = ov5670_set_stream,
>> +};
>> +
>> +static const struct v4l2_subdev_pad_ops ov5670_pad_ops = {
>> +	.enum_mbus_code = ov5670_enum_mbus_code,
>> +	.get_fmt = ov5670_get_pad_format,
>> +	.set_fmt = ov5670_set_pad_format,
>> +	.enum_frame_size = ov5670_enum_frame_size,
>> +};
>> +
>> +static const struct v4l2_subdev_sensor_ops ov5670_sensor_ops = {
>> +	.g_skip_frames = ov5670_get_skip_frames,
>> +};
>> +
>> +static const struct v4l2_subdev_ops ov5670_subdev_ops = {
>> +	.video = &ov5670_video_ops,
>> +	.pad = &ov5670_pad_ops,
>> +	.sensor = &ov5670_sensor_ops,
>> +};
>> +
>> +static const struct media_entity_operations ov5670_subdev_entity_ops = {
>> +	.link_validate = v4l2_subdev_link_validate,
>> +};
>> +
>> +static const struct v4l2_subdev_internal_ops ov5670_internal_ops = {
>> +	.open = ov5670_open,
>> +};
>> +
>> +static int ov5670_probe(struct i2c_client *client,
>> +			const struct i2c_device_id *devid)
>> +{
>> +	struct ov5670 *ov5670;
>> +	int ret;
>> +
>> +	ov5670 = devm_kzalloc(&client->dev, sizeof(*ov5670), GFP_KERNEL);
>> +	if (!ov5670)
>> +		return -ENOMEM;
>> +
>> +	/* Initialize subdev */
>> +	v4l2_i2c_subdev_init(&ov5670->sd, client, &ov5670_subdev_ops);
>> +
>> +	/* Check module identity */
>> +	ret = ov5670_identify_module(ov5670, client);
>> +	if (ret)
>> +		return ret;
>> +
>> +	mutex_init(&ov5670->mutex);
>> +
>> +	/* Set default mode to max resolution */
>> +	ov5670->cur_mode = &supported_modes[0];
>> +
>> +	ret = ov5670_init_controls(ov5670);
>> +	if (ret)
>> +		return ret;
>> +
>> +	ov5670->sd.internal_ops = &ov5670_internal_ops;
>> +	ov5670->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
>> +	ov5670->sd.entity.ops = &ov5670_subdev_entity_ops;
>> +	ov5670->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
>> +
>> +	/* Source pad initialization */
>> +	ov5670->pad.flags = MEDIA_PAD_FL_SOURCE;
>> +	ret = media_entity_pads_init(&ov5670->sd.entity, 1, &ov5670->pad);
>> +	if (ret) {
>> +		dev_err(&client->dev, "%s failed:%d\n", __func__, ret);
>> +		goto error_handler_free;
>> +	}
>> +
>> +	/* Async register for subdev */
>> +	ret = v4l2_async_register_subdev(&ov5670->sd);
>> +	if (ret < 0)
>> +		goto error_entity_cleanup;
>> +
>> +	ov5670->streaming = 0;
>> +	dev_info(&client->dev, "%s done\n", __func__);
>
>In ACPI based systems the device power management is handled by ACPI. Could
>you add runtime PM support for this driver as well, so the device can be
>powered off while not in use?
>
Added runtime PM support.
>> +
>> +	return 0;
>> +
>> +error_entity_cleanup:
>> +	media_entity_cleanup(&ov5670->sd.entity);
>> +
>> +error_handler_free:
>> +	v4l2_ctrl_handler_free(ov5670->sd.ctrl_handler);
>> +
>> +	dev_err(&client->dev, "%s failed:%d\n", __func__, ret);
>> +	return ret;
>> +}
>> +
>> +static int ov5670_remove(struct i2c_client *client)
>> +{
>> +	struct v4l2_subdev *sd = i2c_get_clientdata(client);
>> +
>> +	v4l2_async_unregister_subdev(sd);
>> +	media_entity_cleanup(&sd->entity);
>> +	v4l2_ctrl_handler_free(sd->ctrl_handler);
>> +
>> +	return 0;
>> +}
>> +
>> +static const struct i2c_device_id ov5670_id_table[] = {
>> +	{"ov5670", 0},
>> +	{},
>> +};
>> +
>> +MODULE_DEVICE_TABLE(i2c, ov5670_id_table);
>> +
>> +static const struct dev_pm_ops ov5670_pm_ops = {
>> +	.suspend = ov5670_suspend,
>> +	.resume = ov5670_resume,
>
>Could you use SET_SYSTEM_SLEEP_PM_OPS() to set these?
>
Used.
>> +};
>> +
>> +#ifdef CONFIG_ACPI
>> +const struct acpi_device_id ov5670_acpi_ids[] = {
>
>static?
>
Made static
>> +	{"INT3479"},
>> +	{ /* sentinel */ }
>> +};
>> +
>> +MODULE_DEVICE_TABLE(acpi, ov5670_acpi_ids);
>> +#endif
>> +
>> +static struct i2c_driver ov5670_i2c_driver = {
>
>const?
>
Made const
>> +	.driver = {
>> +		.name = "ov5670",
>> +		.owner = THIS_MODULE,
>> +		.pm = &ov5670_pm_ops,
>> +		.acpi_match_table = ACPI_PTR(ov5670_acpi_ids),
>> +	},
>> +	.probe = ov5670_probe,
>> +	.remove = ov5670_remove,
>> +	.id_table = ov5670_id_table,
>> +};
>> +
>> +module_i2c_driver(ov5670_i2c_driver);
>> +
>> +MODULE_AUTHOR("Rapolu, Chiranjeevi <[e-mail]>");
>> +MODULE_AUTHOR("Yang, Hyungwoo <[e-mail]>");
>> +MODULE_AUTHOR("Pu, Yuning <[e-mail]>");
>> +MODULE_DESCRIPTION("Omnivision ov5670 sensor driver");
>> +MODULE_LICENSE("GPL");
>
>-- 
>Kind regards,
>
>Sakari Ailus
>e-mail: [e-mail]	XMPP: [e-mail]

Chiranjeevi Rapolu May 26, 2017, 1:21 a.m. UTC | #4

Sakari,
V2 patch selects V4L2_FWNODE.

-----Original Message-----
From: Sakari Ailus [mailto:[e-mail]] 
Sent: Thursday, May 4, 2017 1:50 AM
To: Rapolu, Chiranjeevi <[e-mail]>
Cc: [e-mail]; [e-mail]; Zheng, Jian Xu <[e-mail]>; Mani, Rajmohan <[e-mail]>; Yang, Hyungwoo <[e-mail]>
Subject: Re: [PATCH] ov5670: Add Omnivision OV5670 5M sensor support

On Thu, May 04, 2017 at 11:48:51AM +0300, Sakari Ailus wrote:
> On Wed, May 03, 2017 at 03:06:52PM -0700, Chiranjeevi Rapolu wrote:
> > Provides single source pad with up to 2576x1936 pixels at 10-bit raw 
> > bayer format over MIPI CSI2 two lanes at 640Mbps/lane.
> > Supports up to 30fps at 5M pixels, up to 60fps at 1080p.
> > 
> > Signed-off-by: Chiranjeevi Rapolu <[e-mail]>
> > ---
> >  drivers/media/i2c/Kconfig  |   11 +
> >  drivers/media/i2c/Makefile |    1 +
> >  drivers/media/i2c/ov5670.c | 3890 
> > ++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 3902 insertions(+)  create mode 100644 
> > drivers/media/i2c/ov5670.c
> > 
> > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig 
> > index cee1dae..ded8485 100644
> > --- a/drivers/media/i2c/Kconfig
> > +++ b/drivers/media/i2c/Kconfig
> > @@ -531,6 +531,17 @@ config VIDEO_OV2659
> >  	  To compile this driver as a module, choose M here: the
> >  	  module will be called ov2659.
> >  
> > +config VIDEO_OV5670
> > +	tristate "OmniVision OV5670 sensor support"
> > +	depends on I2C && VIDEO_V4L2
> > +	depends on MEDIA_CAMERA_SUPPORT

select V4L2_FWNODE

--
Sakari Ailus
e-mail: [e-mail]	XMPP: [e-mail]

Sakari Ailus May 26, 2017, 8:29 a.m. UTC | #5

Hi Chiranjeevi,

On Fri, May 26, 2017 at 01:19:59AM +0000, Rapolu, Chiranjeevi wrote:
> >> +/* Analog gain controls from sensor */
> >> +#define	ANALOG_GAIN_MIN		0
> >> +#define	ANALOG_GAIN_MAX		8191
> >> +#define	ANALOG_GAIN_STEP	1
> >> +#define	ANALOG_GAIN_DEFAULT	128
> >> +
> >> +/* Exposure controls from sensor */
> >> +#define	EXPOSURE_MIN		0
> >> +#define	EXPOSURE_MAX		1048575
> >> +#define	EXPOSURE_STEP		1
> >> +#define	EXPOSURE_DEFAULT	47232
> >
> >Are these values dependent on sensor configuration i.e. in the case of this
> >driver modes?
> >
> Default values for a given resolutions can be fine-tuned. I think it is up to
> the HAL/application as to what default exposure for a given resolution. Driver
> has the support to change per application.

How about the minimum and maximum values? Are they dependent on other
configuration?

...

> >> +/* Write a list of registers */
> >> +static int ov5670_write_regs(struct ov5670 *ov5670,
> >> +			     const struct ov5670_reg *regs,
> >> +			     int len)
> >
> >How about using unsigned int for len?
> >
> Now u32 len.
> >> +{
> >> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
> >> +	int i;
> >
> >i as well.
> >
> Now u32 i

An insigned int should do. Types with explicit widths should be only used
when the exact value ranges is known, e.g. a 32-bit or 16-bit register.

...

> >> +static int ov5670_set_stream(struct v4l2_subdev *sd, int enable)
> >> +{
> >> +	struct ov5670 *ov5670 = to_ov5670(sd);
> >> +	int ret = 0;
> >> +
> >> +	mutex_lock(&ov5670->mutex);
> >> +	if (ov5670->streaming == enable) {
> >> +		mutex_unlock(&ov5670->mutex);
> >> +		return 0;
> >> +	}
> >> +	mutex_unlock(&ov5670->mutex);
> >> +
> >> +	if (enable) {
> >> +		ret = ov5670_prepare_streaming(ov5670);
> >
> >ov5670_prepare_streaming() and ov5670_start_streaming() are always called
> >sequientally. Could you combine the two?
> >
> >About locking --- you would likely benefit from an unlocked variant of
> >v4l2_ctrl_handler_setup(). I uploaded it here, let me know if it works for
> >you:
> >
> ><URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=ctrl-setup-unlocked>
> >
> Tried unlocked __v4l2_ctrl_handler_setup(), working fine, used.
> Can you push this patch?

Great! I sent it to the list a moment ago. :-)

> >> +static struct i2c_driver ov5670_i2c_driver = {
> >
> >const?
> >
> Made const

I later on figured out this was probably a bad suggestion. The driver
registration changes the i2c_driver struct, causing a compiler warning.

> >> +	.driver = {
> >> +		.name = "ov5670",
> >> +		.owner = THIS_MODULE,
> >> +		.pm = &ov5670_pm_ops,
> >> +		.acpi_match_table = ACPI_PTR(ov5670_acpi_ids),
> >> +	},
> >> +	.probe = ov5670_probe,
> >> +	.remove = ov5670_remove,
> >> +	.id_table = ov5670_id_table,
> >> +};
> >> +
> >> +module_i2c_driver(ov5670_i2c_driver);
> >> +
> >> +MODULE_AUTHOR("Rapolu, Chiranjeevi <[e-mail]>");
> >> +MODULE_AUTHOR("Yang, Hyungwoo <[e-mail]>");
> >> +MODULE_AUTHOR("Pu, Yuning <[e-mail]>");
> >> +MODULE_DESCRIPTION("Omnivision ov5670 sensor driver");
> >> +MODULE_LICENSE("GPL");

Chiranjeevi Rapolu June 14, 2017, 6:27 p.m. UTC | #6

Sakari,

Thanks for the review. Version 3 uploaded. See the responses below.
Got some syntax suggestions from automated scripts on v3, will submit v4 soon.

Thanks,
Chiran.


-----Original Message-----
>From: Sakari Ailus [mailto:[e-mail]] 
>Sent: Friday, May 26, 2017 1:29 AM
>To: Rapolu, Chiranjeevi <[e-mail]>
>Cc: [e-mail]; [e-mail]; Zheng, Jian Xu <[e-mail]>; Mani, Rajmohan <[e-mail]>; Yang, Hyungwoo <[e-mail]>; [e-mail]
>Subject: Re: [PATCH] ov5670: Add Omnivision OV5670 5M sensor support
>
>Hi Chiranjeevi,
>
>On Fri, May 26, 2017 at 01:19:59AM +0000, Rapolu, Chiranjeevi wrote:
>> >> +/* Analog gain controls from sensor */
>> >> +#define	ANALOG_GAIN_MIN		0
>> >> +#define	ANALOG_GAIN_MAX		8191
>> >> +#define	ANALOG_GAIN_STEP	1
>> >> +#define	ANALOG_GAIN_DEFAULT	128
>> >> +
>> >> +/* Exposure controls from sensor */
>> >> +#define	EXPOSURE_MIN		0
>> >> +#define	EXPOSURE_MAX		1048575
>> >> +#define	EXPOSURE_STEP		1
>> >> +#define	EXPOSURE_DEFAULT	47232
>> >
>> >Are these values dependent on sensor configuration i.e. in the case 
>> >of this driver modes?
>> >
>> Default values for a given resolutions can be fine-tuned. I think it 
>> is up to the HAL/application as to what default exposure for a given 
>> resolution. Driver has the support to change per application.
>
>How about the minimum and maximum values? Are they dependent on other configuration?
Exposure is now dependent on VBLANK and mode, modifies exposure-ranges dynamically through __v4l2_ctrl_modify_range().

>
>...
>
>> >> +/* Write a list of registers */
>> >> +static int ov5670_write_regs(struct ov5670 *ov5670,
>> >> +			     const struct ov5670_reg *regs,
>> >> +			     int len)
>> >
>> >How about using unsigned int for len?
>> >
>> Now u32 len.
>> >> +{
>> >> +	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
>> >> +	int i;
>> >
>> >i as well.
>> >
>> Now u32 i
>
>An insigned int should do. Types with explicit widths should be only used when the exact value ranges is known, e.g. a 32-bit or 16-bit register.
Now, unsigned int.

>
>...
>
>> >> +static int ov5670_set_stream(struct v4l2_subdev *sd, int enable) {
>> >> +	struct ov5670 *ov5670 = to_ov5670(sd);
>> >> +	int ret = 0;
>> >> +
>> >> +	mutex_lock(&ov5670->mutex);
>> >> +	if (ov5670->streaming == enable) {
>> >> +		mutex_unlock(&ov5670->mutex);
>> >> +		return 0;
>> >> +	}
>> >> +	mutex_unlock(&ov5670->mutex);
>> >> +
>> >> +	if (enable) {
>> >> +		ret = ov5670_prepare_streaming(ov5670);
>> >
>> >ov5670_prepare_streaming() and ov5670_start_streaming() are always 
>> >called sequientally. Could you combine the two?
>> >
>> >About locking --- you would likely benefit from an unlocked variant 
>> >of v4l2_ctrl_handler_setup(). I uploaded it here, let me know if it 
>> >works for
>> >you:
>> >
>> ><URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=ctrl-setup-
>> >unlocked>
>> >
>> Tried unlocked __v4l2_ctrl_handler_setup(), working fine, used.
>> Can you push this patch?
>
>Great! I sent it to the list a moment ago. :-)
Thanks, Sakari.

>
>> >> +static struct i2c_driver ov5670_i2c_driver = {
>> >
>> >const?
>> >
>> Made const
>
>I later on figured out this was probably a bad suggestion. The driver registration changes the i2c_driver struct, causing a compiler warning.
Yes, no const.

>
>> >> +	.driver = {
>> >> +		.name = "ov5670",
>> >> +		.owner = THIS_MODULE,
>> >> +		.pm = &ov5670_pm_ops,
>> >> +		.acpi_match_table = ACPI_PTR(ov5670_acpi_ids),
>> >> +	},
>> >> +	.probe = ov5670_probe,
>> >> +	.remove = ov5670_remove,
>> >> +	.id_table = ov5670_id_table,
>> >> +};
>> >> +
>> >> +module_i2c_driver(ov5670_i2c_driver);
>> >> +
>> >> +MODULE_AUTHOR("Rapolu, Chiranjeevi 
>> >> +<[e-mail]>"); MODULE_AUTHOR("Yang, Hyungwoo 
>> >> +<[e-mail]>"); MODULE_AUTHOR("Pu, Yuning 
>> >> +<[e-mail]>"); MODULE_DESCRIPTION("Omnivision ov5670 
>> >> +sensor driver"); MODULE_LICENSE("GPL");
>
>--
>Kind regards,
>
>Sakari Ailus
>e-mail: [e-mail]	XMPP: [e-mail]

Patch

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index cee1dae..ded8485 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -531,6 +531,17 @@  config VIDEO_OV2659
 	  To compile this driver as a module, choose M here: the
 	  module will be called ov2659.
 
+config VIDEO_OV5670
+	tristate "OmniVision OV5670 sensor support"
+	depends on I2C && VIDEO_V4L2
+	depends on MEDIA_CAMERA_SUPPORT
+	---help---
+	  This is a Video4Linux2 sensor-level driver for the OmniVision
+	  OV5670 camera.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called ov5670.
+
 config VIDEO_OV7640
 	tristate "OmniVision OV7640 sensor support"
 	depends on I2C && VIDEO_V4L2
diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
index 5bc7bbe..3efc61f 100644
--- a/drivers/media/i2c/Makefile
+++ b/drivers/media/i2c/Makefile
@@ -57,6 +57,7 @@  obj-$(CONFIG_VIDEO_VP27SMPX) += vp27smpx.o
 obj-$(CONFIG_VIDEO_SONY_BTF_MPX) += sony-btf-mpx.o
 obj-$(CONFIG_VIDEO_UPD64031A) += upd64031a.o
 obj-$(CONFIG_VIDEO_UPD64083) += upd64083.o
+obj-$(CONFIG_VIDEO_OV5670) += ov5670.o
 obj-$(CONFIG_VIDEO_OV7640) += ov7640.o
 obj-$(CONFIG_VIDEO_OV7670) += ov7670.o
 obj-$(CONFIG_VIDEO_OV9650) += ov9650.o
diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c
new file mode 100644
index 0000000..394f8f2
--- /dev/null
+++ b/drivers/media/i2c/ov5670.c
@@ -0,0 +1,3890 @@ 
+/*
+ * Copyright (c) 2017 Intel Corporation.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License version
+ * 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ */
+
+#include <linux/acpi.h>
+#include <linux/delay.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <media/v4l2-device.h>
+#include <media/v4l2-ctrls.h>
+
+#define OV5670_CHIP_ID			0x005670
+
+#define OV5670_REG_VALUE_08BIT		1
+#define OV5670_REG_VALUE_16BIT		2
+#define OV5670_REG_VALUE_24BIT		3
+
+#define OV5670_REG_MODE_SELECT		0x0100
+#define OV5670_MODE_STANDBY		0x00
+#define OV5670_MODE_STREAMING		0x01
+
+#define OV5670_REG_SOFTWARE_RST		0x0103
+#define OV5670_SOFTWARE_RST		0x01
+
+#define OV5670_REG_EXPOSURE		0x3500
+#define OV5670_REG_ANALOG_GAIN		0x3508
+
+#define OV5670_REG_CHIPID		0x300a
+
+/* Supported link frequencies */
+#define OV5670_LINK_FREQ_840MBPS		840000000
+#define OV5670_LINK_FREQ_840MBPS_INDEX		0
+
+/* Analog gain controls from sensor */
+#define	ANALOG_GAIN_MIN		0
+#define	ANALOG_GAIN_MAX		8191
+#define	ANALOG_GAIN_STEP	1
+#define	ANALOG_GAIN_DEFAULT	128
+
+/* Exposure controls from sensor */
+#define	EXPOSURE_MIN		0
+#define	EXPOSURE_MAX		1048575
+#define	EXPOSURE_STEP		1
+#define	EXPOSURE_DEFAULT	47232
+
+struct ov5670_reg {
+	u16 address;
+	u8 val;
+};
+
+struct ov5670_reg_list {
+	u32 num_of_regs;
+	const struct ov5670_reg *regs;
+};
+
+struct ov5670_link_freq_config {
+	s64 link_freq;
+	u32 pixel_rate;
+
+	const struct ov5670_reg_list reg_list;
+};
+
+struct ov5670_mode {
+	/* Frame width in pixels */
+	u32 width;
+
+	/* Frame height in pixels */
+	u32 height;
+
+	/* Initial number of frames to skip to avoid garbage in the frames */
+	u32 skip_frames;
+
+	/* Link frequency needed for this resolution */
+	u32 link_freq_index;
+
+	/* Sensor register settings for this resolution */
+	const struct ov5670_reg_list reg_list;
+};
+
+static const struct ov5670_reg mipi_data_rate_840mbps[] = {
+	{0x0300, 0x04},
+	{0x0301, 0x00},
+	{0x0302, 0x84},
+	{0x0303, 0x00},
+	{0x0304, 0x03},
+	{0x0305, 0x01},
+	{0x0306, 0x01},
+	{0x030a, 0x00},
+	{0x030b, 0x00},
+	{0x030c, 0x00},
+	{0x030d, 0x26},
+	{0x030e, 0x00},
+	{0x030f, 0x06},
+	{0x0312, 0x01},
+	{0x3031, 0x0a},
+};
+
+static const struct ov5670_reg mode_640x480_regs[] = {
+	{0x3000, 0x00},
+	{0x3002, 0x61},
+	{0x3005, 0xf0},
+	{0x3007, 0x00},
+	{0x300D, 0x00},
+	{0x3015, 0x0f},
+	{0x3018, 0x32},
+	{0x3010, 0x40},
+	{0x301a, 0xf0},
+	{0x301b, 0xf0},
+	{0x301c, 0xf0},
+	{0x301d, 0xf0},
+	{0x301e, 0xf0},
+	{0x3030, 0x00},
+	{0x303c, 0xff},
+	{0x303e, 0xff},
+	{0x3040, 0xf0},
+	{0x3041, 0x00},
+	{0x3042, 0xf0},
+	{0x3106, 0x11},
+	{0x3500, 0x00},
+	{0x3501, 0xb8},
+	{0x3502, 0x80},
+	{0x3503, 0x00},
+	{0x3504, 0x03},
+	{0x3505, 0x83},
+	{0x3508, 0x04},
+	{0x3509, 0x00},
+	{0x350e, 0x04},
+	{0x350f, 0x00},
+	{0x3510, 0x00},
+	{0x3511, 0x02},
+	{0x3512, 0x00},
+	{0x3601, 0xc8},
+	{0x3610, 0x88},
+	{0x3612, 0x48},
+	{0x3614, 0x5b},
+	{0x3615, 0x96},
+	{0x3621, 0xd0},
+	{0x3622, 0x00},
+	{0x3623, 0x04},
+	{0x3633, 0x13},
+	{0x3634, 0x13},
+	{0x3635, 0x13},
+	{0x3636, 0x13},
+	{0x3645, 0x13},
+	{0x3646, 0x82},
+	{0x3650, 0x00},
+	{0x3652, 0xff},
+	{0x3655, 0x20},
+	{0x3656, 0xff},
+	{0x365a, 0xff},
+	{0x365e, 0xff},
+	{0x3668, 0x00},
+	{0x366a, 0x07},
+	{0x366e, 0x08},
+	{0x366d, 0x00},
+	{0x366f, 0x80},
+	{0x3700, 0x28},
+	{0x3701, 0x10},
+	{0x3702, 0x3a},
+	{0x3703, 0x19},
+	{0x3704, 0x10},
+	{0x3705, 0x00},
+	{0x3706, 0x66},
+	{0x3707, 0x08},
+	{0x3708, 0x34},
+	{0x3709, 0x40},
+	{0x370a, 0x01},
+	{0x370b, 0x1b},
+	{0x3714, 0x24},
+	{0x371a, 0x3e},
+	{0x3733, 0x00},
+	{0x3734, 0x00},
+	{0x373a, 0x05},
+	{0x373b, 0x06},
+	{0x373c, 0x0a},
+	{0x373f, 0xa0},
+	{0x3755, 0x00},
+	{0x3758, 0x00},
+	{0x375b, 0x0e},
+	{0x3766, 0x5f},
+	{0x3768, 0x00},
+	{0x3769, 0x22},
+	{0x3773, 0x08},
+	{0x3774, 0x1f},
+	{0x3776, 0x06},
+	{0x37a0, 0x88},
+	{0x37a1, 0x5c},
+	{0x37a7, 0x88},
+	{0x37a8, 0x70},
+	{0x37aa, 0x88},
+	{0x37ab, 0x48},
+	{0x37b3, 0x66},
+	{0x37c2, 0x04},
+	{0x37c5, 0x00},
+	{0x37c8, 0x00},
+	{0x3800, 0x00},
+	{0x3801, 0x0c},
+	{0x3802, 0x00},
+	{0x3803, 0x04},
+	{0x3804, 0x0a},
+	{0x3805, 0x33},
+	{0x3806, 0x07},
+	{0x3807, 0xa3},
+	{0x3808, 0x02},
+	{0x3809, 0x80},
+	{0x380a, 0x01},
+	{0x380b, 0xe0},
+	{0x380c, 0x06},
+	{0x380d, 0xa8},
+	{0x380e, 0x07},
+	{0x380f, 0xf6},
+	{0x3811, 0x04},
+	{0x3813, 0x02},
+	{0x3814, 0x07},
+	{0x3815, 0x01},
+	{0x3816, 0x00},
+	{0x3817, 0x00},
+	{0x3818, 0x00},
+	{0x3819, 0x00},
+	{0x3820, 0x94},
+	{0x3821, 0xc0},
+	{0x3822, 0x48},
+	{0x3826, 0x00},
+	{0x3827, 0x08},
+	{0x382a, 0x07},
+	{0x382b, 0x01},
+	{0x3830, 0x08},
+	{0x3836, 0x02},
+	{0x3837, 0x00},
+	{0x3838, 0x10},
+	{0x3841, 0xff},
+	{0x3846, 0x48},
+	{0x3861, 0x00},
+	{0x3862, 0x04},
+	{0x3863, 0x06},
+	{0x3a11, 0x01},
+	{0x3a12, 0x78},
+	{0x3b00, 0x00},
+	{0x3b02, 0x00},
+	{0x3b03, 0x00},
+	{0x3b04, 0x00},
+	{0x3b05, 0x00},
+	{0x3c00, 0x89},
+	{0x3c01, 0xab},
+	{0x3c02, 0x01},
+	{0x3c03, 0x00},
+	{0x3c04, 0x00},
+	{0x3c05, 0x03},
+	{0x3c06, 0x00},
+	{0x3c07, 0x05},
+	{0x3c0c, 0x00},
+	{0x3c0d, 0x00},
+	{0x3c0e, 0x00},
+	{0x3c0f, 0x00},
+	{0x3c40, 0x00},
+	{0x3c41, 0xa3},
+	{0x3c43, 0x7d},
+	{0x3c45, 0xd7},
+	{0x3c47, 0xfc},
+	{0x3c50, 0x05},
+	{0x3c52, 0xaa},
+	{0x3c54, 0x71},
+	{0x3c56, 0x80},
+	{0x3d85, 0x17},
+	{0x3f03, 0x00},
+	{0x3f0a, 0x00},
+	{0x3f0b, 0x00},
+	{0x4001, 0x60},
+	{0x4009, 0x05},
+	{0x4020, 0x00},
+	{0x4021, 0x00},
+	{0x4022, 0x00},
+	{0x4023, 0x00},
+	{0x4024, 0x00},
+	{0x4025, 0x00},
+	{0x4026, 0x00},
+	{0x4027, 0x00},
+	{0x4028, 0x00},
+	{0x4029, 0x00},
+	{0x402a, 0x00},
+	{0x402b, 0x00},
+	{0x402c, 0x00},
+	{0x402d, 0x00},
+	{0x402e, 0x00},
+	{0x402f, 0x00},
+	{0x4040, 0x00},
+	{0x4041, 0x03},
+	{0x4042, 0x00},
+	{0x4043, 0x7A},
+	{0x4044, 0x00},
+	{0x4045, 0x7A},
+	{0x4046, 0x00},
+	{0x4047, 0x7A},
+	{0x4048, 0x00},
+	{0x4049, 0x7A},
+	{0x4303, 0x00},
+	{0x4307, 0x30},
+	{0x4500, 0x58},
+	{0x4501, 0x04},
+	{0x4502, 0x40},
+	{0x4503, 0x10},
+	{0x4508, 0x55},
+	{0x4509, 0x55},
+	{0x450a, 0x02},
+	{0x450b, 0x00},
+	{0x4600, 0x00},
+	{0x4601, 0x40},
+	{0x4700, 0xa4},
+	{0x4800, 0x4c},
+	{0x4816, 0x53},
+	{0x481f, 0x40},
+	{0x4837, 0x12},
+	{0x5000, 0x56},
+	{0x5001, 0x01},
+	{0x5002, 0x28},
+	{0x5004, 0x0c},
+	{0x5006, 0x0c},
+	{0x5007, 0xe0},
+	{0x5008, 0x01},
+	{0x5009, 0xb0},
+	{0x5045, 0x05},
+	{0x5048, 0x10},
+	{0x5901, 0x00},
+	{0x5a01, 0x00},
+	{0x5a03, 0x00},
+	{0x5a04, 0x0c},
+	{0x5a05, 0xe0},
+	{0x5a06, 0x09},
+	{0x5a07, 0xb0},
+	{0x5a08, 0x06},
+	{0x5e00, 0x00},
+	{0x3734, 0x40},
+	{0x5b00, 0x01},
+	{0x5b01, 0x10},
+	{0x5b02, 0x01},
+	{0x5b03, 0xdb},
+	{0x3d8c, 0x71},
+	{0x3d8d, 0xea},
+	{0x4017, 0x10},
+	{0x3618, 0x2a},
+	{0x5780, 0x3e},
+	{0x5781, 0x0f},
+	{0x5782, 0x44},
+	{0x5783, 0x02},
+	{0x5784, 0x01},
+	{0x5785, 0x01},
+	{0x5786, 0x00},
+	{0x5787, 0x04},
+	{0x5788, 0x02},
+	{0x5789, 0x0f},
+	{0x578a, 0xfd},
+	{0x578b, 0xf5},
+	{0x578c, 0xf5},
+	{0x578d, 0x03},
+	{0x578e, 0x08},
+	{0x578f, 0x0c},
+	{0x5790, 0x08},
+	{0x5791, 0x06},
+	{0x5792, 0x00},
+	{0x5793, 0x52},
+	{0x5794, 0xa3},
+};
+
+static const struct ov5670_reg mode_656x496_regs[] = {
+	{0x3000, 0x00},
+	{0x3002, 0x61},
+	{0x3005, 0xf0},
+	{0x3007, 0x00},
+	{0x300D, 0x00},
+	{0x3015, 0x0f},
+	{0x3018, 0x32},
+	{0x3010, 0x40},
+	{0x301a, 0xf0},
+	{0x301b, 0xf0},
+	{0x301c, 0xf0},
+	{0x301d, 0xf0},
+	{0x301e, 0xf0},
+	{0x3030, 0x00},
+	{0x303c, 0xff},
+	{0x303e, 0xff},
+	{0x3040, 0xf0},
+	{0x3041, 0x00},
+	{0x3042, 0xf0},
+	{0x3106, 0x11},
+	{0x3500, 0x00},
+	{0x3501, 0xb8},
+	{0x3502, 0x80},
+	{0x3503, 0x00},
+	{0x3504, 0x03},
+	{0x3505, 0x83},
+	{0x3508, 0x04},
+	{0x3509, 0x00},
+	{0x350e, 0x04},
+	{0x350f, 0x00},
+	{0x3510, 0x00},
+	{0x3511, 0x02},
+	{0x3512, 0x00},
+	{0x3601, 0xc8},
+	{0x3610, 0x88},
+	{0x3612, 0x48},
+	{0x3614, 0x5b},
+	{0x3615, 0x96},
+	{0x3621, 0xd0},
+	{0x3622, 0x00},
+	{0x3623, 0x04},
+	{0x3633, 0x13},
+	{0x3634, 0x13},
+	{0x3635, 0x13},
+	{0x3636, 0x13},
+	{0x3645, 0x13},
+	{0x3646, 0x82},
+	{0x3650, 0x00},
+	{0x3652, 0xff},
+	{0x3655, 0x20},
+	{0x3656, 0xff},
+	{0x365a, 0xff},
+	{0x365e, 0xff},
+	{0x3668, 0x00},
+	{0x366a, 0x07},
+	{0x366e, 0x08},
+	{0x366d, 0x00},
+	{0x366f, 0x80},
+	{0x3700, 0x28},
+	{0x3701, 0x10},
+	{0x3702, 0x3a},
+	{0x3703, 0x19},
+	{0x3704, 0x10},
+	{0x3705, 0x00},
+	{0x3706, 0x66},
+	{0x3707, 0x08},
+	{0x3708, 0x34},
+	{0x3709, 0x40},
+	{0x370a, 0x01},
+	{0x370b, 0x1b},
+	{0x3714, 0x24},
+	{0x371a, 0x3e},
+	{0x3733, 0x00},
+	{0x3734, 0x00},
+	{0x373a, 0x05},
+	{0x373b, 0x06},
+	{0x373c, 0x0a},
+	{0x373f, 0xa0},
+	{0x3755, 0x00},
+	{0x3758, 0x00},
+	{0x375b, 0x0e},
+	{0x3766, 0x5f},
+	{0x3768, 0x00},
+	{0x3769, 0x22},
+	{0x3773, 0x08},
+	{0x3774, 0x1f},
+	{0x3776, 0x06},
+	{0x37a0, 0x88},
+	{0x37a1, 0x5c},
+	{0x37a7, 0x88},
+	{0x37a8, 0x70},
+	{0x37aa, 0x88},
+	{0x37ab, 0x48},
+	{0x37b3, 0x66},
+	{0x37c2, 0x04},
+	{0x37c5, 0x00},
+	{0x37c8, 0x00},
+	{0x3800, 0x00},
+	{0x3801, 0x0c},
+	{0x3802, 0x00},
+	{0x3803, 0x04},
+	{0x3804, 0x0a},
+	{0x3805, 0x33},
+	{0x3806, 0x07},
+	{0x3807, 0xa3},
+	{0x3808, 0x02},
+	{0x3809, 0x90},
+	{0x380a, 0x01},
+	{0x380b, 0xf0},
+	{0x380c, 0x06},
+	{0x380d, 0xa8},
+	{0x380e, 0x07},
+	{0x380f, 0xf6},
+	{0x3811, 0x04},
+	{0x3813, 0x02},
+	{0x3814, 0x07},
+	{0x3815, 0x01},
+	{0x3816, 0x00},
+	{0x3817, 0x00},
+	{0x3818, 0x00},
+	{0x3819, 0x00},
+	{0x3820, 0x94},
+	{0x3821, 0xc0},
+	{0x3822, 0x48},
+	{0x3826, 0x00},
+	{0x3827, 0x08},
+	{0x382a, 0x07},
+	{0x382b, 0x01},
+	{0x3830, 0x08},
+	{0x3836, 0x02},
+	{0x3837, 0x00},
+	{0x3838, 0x10},
+	{0x3841, 0xff},
+	{0x3846, 0x48},
+	{0x3861, 0x00},
+	{0x3862, 0x04},
+	{0x3863, 0x06},
+	{0x3a11, 0x01},
+	{0x3a12, 0x78},
+	{0x3b00, 0x00},
+	{0x3b02, 0x00},
+	{0x3b03, 0x00},
+	{0x3b04, 0x00},
+	{0x3b05, 0x00},
+	{0x3c00, 0x89},
+	{0x3c01, 0xab},
+	{0x3c02, 0x01},
+	{0x3c03, 0x00},
+	{0x3c04, 0x00},
+	{0x3c05, 0x03},
+	{0x3c06, 0x00},
+	{0x3c07, 0x05},
+	{0x3c0c, 0x00},
+	{0x3c0d, 0x00},
+	{0x3c0e, 0x00},
+	{0x3c0f, 0x00},
+	{0x3c40, 0x00},
+	{0x3c41, 0xa3},
+	{0x3c43, 0x7d},
+	{0x3c45, 0xd7},
+	{0x3c47, 0xfc},
+	{0x3c50, 0x05},
+	{0x3c52, 0xaa},
+	{0x3c54, 0x71},
+	{0x3c56, 0x80},
+	{0x3d85, 0x17},
+	{0x3f03, 0x00},
+	{0x3f0a, 0x00},
+	{0x3f0b, 0x00},
+	{0x4001, 0x60},
+	{0x4009, 0x05},
+	{0x4020, 0x00},
+	{0x4021, 0x00},
+	{0x4022, 0x00},
+	{0x4023, 0x00},
+	{0x4024, 0x00},
+	{0x4025, 0x00},
+	{0x4026, 0x00},
+	{0x4027, 0x00},
+	{0x4028, 0x00},
+	{0x4029, 0x00},
+	{0x402a, 0x00},
+	{0x402b, 0x00},
+	{0x402c, 0x00},
+	{0x402d, 0x00},
+	{0x402e, 0x00},
+	{0x402f, 0x00},
+	{0x4040, 0x00},
+	{0x4041, 0x03},
+	{0x4042, 0x00},
+	{0x4043, 0x7A},
+	{0x4044, 0x00},
+	{0x4045, 0x7A},
+	{0x4046, 0x00},
+	{0x4047, 0x7A},
+	{0x4048, 0x00},
+	{0x4049, 0x7A},
+	{0x4303, 0x00},
+	{0x4307, 0x30},
+	{0x4500, 0x58},
+	{0x4501, 0x04},
+	{0x4502, 0x40},
+	{0x4503, 0x10},
+	{0x4508, 0x55},
+	{0x4509, 0x55},
+	{0x450a, 0x02},
+	{0x450b, 0x00},
+	{0x4600, 0x00},
+	{0x4601, 0x40},
+	{0x4700, 0xa4},
+	{0x4800, 0x4c},
+	{0x4816, 0x53},
+	{0x481f, 0x40},
+	{0x4837, 0x12},
+	{0x5000, 0x56},
+	{0x5001, 0x01},
+	{0x5002, 0x28},
+	{0x5004, 0x0c},
+	{0x5006, 0x0c},
+	{0x5007, 0xe0},
+	{0x5008, 0x01},
+	{0x5009, 0xb0},
+	{0x5045, 0x05},
+	{0x5048, 0x10},
+	{0x5901, 0x00},
+	{0x5a01, 0x00},
+	{0x5a03, 0x00},
+	{0x5a04, 0x0c},
+	{0x5a05, 0xe0},
+	{0x5a06, 0x09},
+	{0x5a07, 0xb0},
+	{0x5a08, 0x06},
+	{0x5e00, 0x00},
+	{0x3734, 0x40},
+	{0x5b00, 0x01},
+	{0x5b01, 0x10},
+	{0x5b02, 0x01},
+	{0x5b03, 0xdb},
+	{0x3d8c, 0x71},
+	{0x3d8d, 0xea},
+	{0x4017, 0x10},
+	{0x3618, 0x2a},
+	{0x5780, 0x3e},
+	{0x5781, 0x0f},
+	{0x5782, 0x44},
+	{0x5783, 0x02},
+	{0x5784, 0x01},
+	{0x5785, 0x01},
+	{0x5786, 0x00},
+	{0x5787, 0x04},
+	{0x5788, 0x02},
+	{0x5789, 0x0f},
+	{0x578a, 0xfd},
+	{0x578b, 0xf5},
+	{0x578c, 0xf5},
+	{0x578d, 0x03},
+	{0x578e, 0x08},
+	{0x578f, 0x0c},
+	{0x5790, 0x08},
+	{0x5791, 0x06},
+	{0x5792, 0x00},
+	{0x5793, 0x52},
+	{0x5794, 0xa3},
+};
+
+static const struct ov5670_reg mode_1280x720_regs[] = {
+	{0x3000, 0x00},
+	{0x3002, 0x61},
+	{0x3005, 0xf0},
+	{0x3007, 0x00},
+	{0x300D, 0x00},
+	{0x3010, 0x40},
+	{0x3015, 0x0f},
+	{0x3018, 0x32},
+	{0x301a, 0xf0},
+	{0x301b, 0xf0},
+	{0x301c, 0xf0},
+	{0x301d, 0xf0},
+	{0x301e, 0xf0},
+	{0x3030, 0x00},
+	{0x303c, 0xff},
+	{0x303e, 0xff},
+	{0x3040, 0xf0},
+	{0x3041, 0x00},
+	{0x3042, 0xf0},
+	{0x3106, 0x11},
+	{0x3500, 0x00},
+	{0x3501, 0xb8},
+	{0x3502, 0x80},
+	{0x3503, 0x00},
+	{0x3504, 0x03},
+	{0x3505, 0x83},
+	{0x3508, 0x04},
+	{0x3509, 0x00},
+	{0x350e, 0x04},
+	{0x350f, 0x00},
+	{0x3510, 0x00},
+	{0x3511, 0x02},
+	{0x3512, 0x00},
+	{0x3601, 0xc8},
+	{0x3610, 0x88},
+	{0x3612, 0x48},
+	{0x3614, 0x5b},
+	{0x3615, 0x96},
+	{0x3621, 0xd0},
+	{0x3622, 0x00},
+	{0x3623, 0x00},
+	{0x3633, 0x13},
+	{0x3634, 0x13},
+	{0x3635, 0x13},
+	{0x3636, 0x13},
+	{0x3645, 0x13},
+	{0x3646, 0x82},
+	{0x3650, 0x00},
+	{0x3652, 0xff},
+	{0x3655, 0x20},
+	{0x3656, 0xff},
+	{0x365a, 0xff},
+	{0x365e, 0xff},
+	{0x3668, 0x00},
+	{0x366a, 0x07},
+	{0x366e, 0x08},
+	{0x366d, 0x00},
+	{0x366f, 0x80},
+	{0x3700, 0x28},
+	{0x3701, 0x10},
+	{0x3702, 0x3a},
+	{0x3703, 0x19},
+	{0x3704, 0x10},
+	{0x3705, 0x00},
+	{0x3706, 0x66},
+	{0x3707, 0x08},
+	{0x3708, 0x34},
+	{0x3709, 0x40},
+	{0x370a, 0x01},
+	{0x370b, 0x1b},
+	{0x3714, 0x24},
+	{0x371a, 0x3e},
+	{0x3733, 0x00},
+	{0x3734, 0x00},
+	{0x373a, 0x05},
+	{0x373b, 0x06},
+	{0x373c, 0x0a},
+	{0x373f, 0xa0},
+	{0x3755, 0x00},
+	{0x3758, 0x00},
+	{0x375b, 0x0e},
+	{0x3766, 0x5f},
+	{0x3768, 0x00},
+	{0x3769, 0x22},
+	{0x3773, 0x08},
+	{0x3774, 0x1f},
+	{0x3776, 0x06},
+	{0x37a0, 0x88},
+	{0x37a1, 0x5c},
+	{0x37a7, 0x88},
+	{0x37a8, 0x70},
+	{0x37aa, 0x88},
+	{0x37ab, 0x48},
+	{0x37b3, 0x66},
+	{0x37c2, 0x04},
+	{0x37c5, 0x00},
+	{0x37c8, 0x00},
+	{0x3800, 0x00},
+	{0x3801, 0x0c},
+	{0x3802, 0x00},
+	{0x3803, 0x04},
+	{0x3804, 0x0a},
+	{0x3805, 0x33},
+	{0x3806, 0x07},
+	{0x3807, 0xa3},
+	{0x3808, 0x05},
+	{0x3809, 0x00},
+	{0x380a, 0x02},
+	{0x380b, 0xd0},
+	{0x380c, 0x06},
+	{0x380d, 0xa8},
+	{0x380e, 0x07},
+	{0x380f, 0xf6},
+	{0x3811, 0x04},
+	{0x3813, 0x02},
+	{0x3814, 0x03},
+	{0x3815, 0x01},
+	{0x3816, 0x00},
+	{0x3817, 0x00},
+	{0x3818, 0x00},
+	{0x3819, 0x00},
+	{0x3820, 0x94},
+	{0x3821, 0x41},
+	{0x3822, 0x48},
+	{0x3826, 0x00},
+	{0x3827, 0x08},
+	{0x382a, 0x03},
+	{0x382b, 0x01},
+	{0x3830, 0x08},
+	{0x3836, 0x02},
+	{0x3837, 0x00},
+	{0x3838, 0x10},
+	{0x3841, 0xff},
+	{0x3846, 0x48},
+	{0x3861, 0x00},
+	{0x3862, 0x04},
+	{0x3863, 0x06},
+	{0x3a11, 0x01},
+	{0x3a12, 0x78},
+	{0x3b00, 0x00},
+	{0x3b02, 0x00},
+	{0x3b03, 0x00},
+	{0x3b04, 0x00},
+	{0x3b05, 0x00},
+	{0x3c00, 0x89},
+	{0x3c01, 0xab},
+	{0x3c02, 0x01},
+	{0x3c03, 0x00},
+	{0x3c04, 0x00},
+	{0x3c05, 0x03},
+	{0x3c06, 0x00},
+	{0x3c07, 0x05},
+	{0x3c0c, 0x00},
+	{0x3c0d, 0x00},
+	{0x3c0e, 0x00},
+	{0x3c0f, 0x00},
+	{0x3c40, 0x00},
+	{0x3c41, 0xa3},
+	{0x3c43, 0x7d},
+	{0x3c45, 0xd7},
+	{0x3c47, 0xfc},
+	{0x3c50, 0x05},
+	{0x3c52, 0xaa},
+	{0x3c54, 0x71},
+	{0x3c56, 0x80},
+	{0x3d85, 0x17},
+	{0x3f03, 0x00},
+	{0x3f0a, 0x00},
+	{0x3f0b, 0x00},
+	{0x4001, 0x60},
+	{0x4009, 0x05},
+	{0x4020, 0x00},
+	{0x4021, 0x00},
+	{0x4022, 0x00},
+	{0x4023, 0x00},
+	{0x4024, 0x00},
+	{0x4025, 0x00},
+	{0x4026, 0x00},
+	{0x4027, 0x00},
+	{0x4028, 0x00},
+	{0x4029, 0x00},
+	{0x402a, 0x00},
+	{0x402b, 0x00},
+	{0x402c, 0x00},
+	{0x402d, 0x00},
+	{0x402e, 0x00},
+	{0x402f, 0x00},
+	{0x4040, 0x00},
+	{0x4041, 0x03},
+	{0x4042, 0x00},
+	{0x4043, 0x7A},
+	{0x4044, 0x00},
+	{0x4045, 0x7A},
+	{0x4046, 0x00},
+	{0x4047, 0x7A},
+	{0x4048, 0x00},
+	{0x4049, 0x7A},
+	{0x4303, 0x00},
+	{0x4307, 0x30},
+	{0x4500, 0x58},
+	{0x4501, 0x04},
+	{0x4502, 0x48},
+	{0x4503, 0x10},
+	{0x4508, 0x55},
+	{0x4509, 0x55},
+	{0x450a, 0x00},
+	{0x450b, 0x00},
+	{0x4600, 0x00},
+	{0x4601, 0x80},
+	{0x4700, 0xa4},
+	{0x4800, 0x4c},
+	{0x4816, 0x53},
+	{0x481f, 0x40},
+	{0x4837, 0x12},
+	{0x5000, 0x56},
+	{0x5001, 0x01},
+	{0x5002, 0x28},
+	{0x5004, 0x0c},
+	{0x5006, 0x0c},
+	{0x5007, 0xe0},
+	{0x5008, 0x01},
+	{0x5009, 0xb0},
+	{0x5045, 0x05},
+	{0x5048, 0x10},
+	{0x5901, 0x00},
+	{0x5a01, 0x00},
+	{0x5a03, 0x00},
+	{0x5a04, 0x0c},
+	{0x5a05, 0xe0},
+	{0x5a06, 0x09},
+	{0x5a07, 0xb0},
+	{0x5a08, 0x06},
+	{0x5e00, 0x00},
+	{0x3734, 0x40},
+	{0x5b00, 0x01},
+	{0x5b01, 0x10},
+	{0x5b02, 0x01},
+	{0x5b03, 0xdb},
+	{0x3d8c, 0x71},
+	{0x3d8d, 0xea},
+	{0x4017, 0x10},
+	{0x3618, 0x2a},
+	{0x5780, 0x3e},
+	{0x5781, 0x0f},
+	{0x5782, 0x44},
+	{0x5783, 0x02},
+	{0x5784, 0x01},
+	{0x5785, 0x01},
+	{0x5786, 0x00},
+	{0x5787, 0x04},
+	{0x5788, 0x02},
+	{0x5789, 0x0f},
+	{0x578a, 0xfd},
+	{0x578b, 0xf5},
+	{0x578c, 0xf5},
+	{0x578d, 0x03},
+	{0x578e, 0x08},
+	{0x578f, 0x0c},
+	{0x5790, 0x08},
+	{0x5791, 0x06},
+	{0x5792, 0x00},
+	{0x5793, 0x52},
+	{0x5794, 0xa3},
+};
+
+static const struct ov5670_reg mode_1296x736_regs[] = {
+	{0x3000, 0x00},
+	{0x3002, 0x61},
+	{0x3005, 0xf0},
+	{0x3007, 0x00},
+	{0x300D, 0x00},
+	{0x3010, 0x40},
+	{0x3015, 0x0f},
+	{0x3018, 0x32},
+	{0x301a, 0xf0},
+	{0x301b, 0xf0},
+	{0x301c, 0xf0},
+	{0x301d, 0xf0},
+	{0x301e, 0xf0},
+	{0x3030, 0x00},
+	{0x303c, 0xff},
+	{0x303e, 0xff},
+	{0x3040, 0xf0},
+	{0x3041, 0x00},
+	{0x3042, 0xf0},
+	{0x3106, 0x11},
+	{0x3500, 0x00},
+	{0x3501, 0xb8},
+	{0x3502, 0x80},
+	{0x3503, 0x00},
+	{0x3504, 0x03},
+	{0x3505, 0x83},
+	{0x3508, 0x04},
+	{0x3509, 0x00},
+	{0x350e, 0x04},
+	{0x350f, 0x00},
+	{0x3510, 0x00},
+	{0x3511, 0x02},
+	{0x3512, 0x00},
+	{0x3601, 0xc8},
+	{0x3610, 0x88},
+	{0x3612, 0x48},
+	{0x3614, 0x5b},
+	{0x3615, 0x96},
+	{0x3621, 0xd0},
+	{0x3622, 0x00},
+	{0x3623, 0x00},
+	{0x3633, 0x13},
+	{0x3634, 0x13},
+	{0x3635, 0x13},
+	{0x3636, 0x13},
+	{0x3645, 0x13},
+	{0x3646, 0x82},
+	{0x3650, 0x00},
+	{0x3652, 0xff},
+	{0x3655, 0x20},
+	{0x3656, 0xff},
+	{0x365a, 0xff},
+	{0x365e, 0xff},
+	{0x3668, 0x00},
+	{0x366a, 0x07},
+	{0x366e, 0x08},
+	{0x366d, 0x00},
+	{0x366f, 0x80},
+	{0x3700, 0x28},
+	{0x3701, 0x10},
+	{0x3702, 0x3a},
+	{0x3703, 0x19},
+	{0x3704, 0x10},
+	{0x3705, 0x00},
+	{0x3706, 0x66},
+	{0x3707, 0x08},
+	{0x3708, 0x34},
+	{0x3709, 0x40},
+	{0x370a, 0x01},
+	{0x370b, 0x1b},
+	{0x3714, 0x24},
+	{0x371a, 0x3e},
+	{0x3733, 0x00},
+	{0x3734, 0x00},
+	{0x373a, 0x05},
+	{0x373b, 0x06},
+	{0x373c, 0x0a},
+	{0x373f, 0xa0},
+	{0x3755, 0x00},
+	{0x3758, 0x00},
+	{0x375b, 0x0e},
+	{0x3766, 0x5f},
+	{0x3768, 0x00},
+	{0x3769, 0x22},
+	{0x3773, 0x08},
+	{0x3774, 0x1f},
+	{0x3776, 0x06},
+	{0x37a0, 0x88},
+	{0x37a1, 0x5c},
+	{0x37a7, 0x88},
+	{0x37a8, 0x70},
+	{0x37aa, 0x88},
+	{0x37ab, 0x48},
+	{0x37b3, 0x66},
+	{0x37c2, 0x04},
+	{0x37c5, 0x00},
+	{0x37c8, 0x00},
+	{0x3800, 0x00},
+	{0x3801, 0x0c},
+	{0x3802, 0x00},
+	{0x3803, 0x04},
+	{0x3804, 0x0a},
+	{0x3805, 0x33},
+	{0x3806, 0x07},
+	{0x3807, 0xa3},
+	{0x3808, 0x05},
+	{0x3809, 0x10},
+	{0x380a, 0x02},
+	{0x380b, 0xe0},
+	{0x380c, 0x06},
+	{0x380d, 0xa8},
+	{0x380e, 0x07},
+	{0x380f, 0xf6},
+	{0x3811, 0x04},
+	{0x3813, 0x02},
+	{0x3814, 0x03},
+	{0x3815, 0x01},
+	{0x3816, 0x00},
+	{0x3817, 0x00},
+	{0x3818, 0x00},
+	{0x3819, 0x00},
+	{0x3820, 0x94},
+	{0x3821, 0x41},
+	{0x3822, 0x48},
+	{0x3826, 0x00},
+	{0x3827, 0x08},
+	{0x382a, 0x03},
+	{0x382b, 0x01},
+	{0x3830, 0x08},
+	{0x3836, 0x02},
+	{0x3837, 0x00},
+	{0x3838, 0x10},
+	{0x3841, 0xff},
+	{0x3846, 0x48},
+	{0x3861, 0x00},
+	{0x3862, 0x04},
+	{0x3863, 0x06},
+	{0x3a11, 0x01},
+	{0x3a12, 0x78},
+	{0x3b00, 0x00},
+	{0x3b02, 0x00},
+	{0x3b03, 0x00},
+	{0x3b04, 0x00},
+	{0x3b05, 0x00},
+	{0x3c00, 0x89},
+	{0x3c01, 0xab},
+	{0x3c02, 0x01},
+	{0x3c03, 0x00},
+	{0x3c04, 0x00},
+	{0x3c05, 0x03},
+	{0x3c06, 0x00},
+	{0x3c07, 0x05},
+	{0x3c0c, 0x00},
+	{0x3c0d, 0x00},
+	{0x3c0e, 0x00},
+	{0x3c0f, 0x00},
+	{0x3c40, 0x00},
+	{0x3c41, 0xa3},
+	{0x3c43, 0x7d},
+	{0x3c45, 0xd7},
+	{0x3c47, 0xfc},
+	{0x3c50, 0x05},
+	{0x3c52, 0xaa},
+	{0x3c54, 0x71},
+	{0x3c56, 0x80},
+	{0x3d85, 0x17},
+	{0x3f03, 0x00},
+	{0x3f0a, 0x00},
+	{0x3f0b, 0x00},
+	{0x4001, 0x60},
+	{0x4009, 0x05},
+	{0x4020, 0x00},
+	{0x4021, 0x00},
+	{0x4022, 0x00},
+	{0x4023, 0x00},
+	{0x4024, 0x00},
+	{0x4025, 0x00},
+	{0x4026, 0x00},
+	{0x4027, 0x00},
+	{0x4028, 0x00},
+	{0x4029, 0x00},
+	{0x402a, 0x00},
+	{0x402b, 0x00},
+	{0x402c, 0x00},
+	{0x402d, 0x00},
+	{0x402e, 0x00},
+	{0x402f, 0x00},
+	{0x4040, 0x00},
+	{0x4041, 0x03},
+	{0x4042, 0x00},
+	{0x4043, 0x7A},
+	{0x4044, 0x00},
+	{0x4045, 0x7A},
+	{0x4046, 0x00},
+	{0x4047, 0x7A},
+	{0x4048, 0x00},
+	{0x4049, 0x7A},
+	{0x4303, 0x00},
+	{0x4307, 0x30},
+	{0x4500, 0x58},
+	{0x4501, 0x04},
+	{0x4502, 0x48},
+	{0x4503, 0x10},
+	{0x4508, 0x55},
+	{0x4509, 0x55},
+	{0x450a, 0x00},
+	{0x450b, 0x00},
+	{0x4600, 0x00},
+	{0x4601, 0x80},
+	{0x4700, 0xa4},
+	{0x4800, 0x4c},
+	{0x4816, 0x53},
+	{0x481f, 0x40},
+	{0x4837, 0x12},
+	{0x5000, 0x56},
+	{0x5001, 0x01},
+	{0x5002, 0x28},
+	{0x5004, 0x0c},
+	{0x5006, 0x0c},
+	{0x5007, 0xe0},
+	{0x5008, 0x01},
+	{0x5009, 0xb0},
+	{0x5045, 0x05},
+	{0x5048, 0x10},
+	{0x5901, 0x00},
+	{0x5a01, 0x00},
+	{0x5a03, 0x00},
+	{0x5a04, 0x0c},
+	{0x5a05, 0xe0},
+	{0x5a06, 0x09},
+	{0x5a07, 0xb0},
+	{0x5a08, 0x06},
+	{0x5e00, 0x00},
+	{0x3734, 0x40},
+	{0x5b00, 0x01},
+	{0x5b01, 0x10},
+	{0x5b02, 0x01},
+	{0x5b03, 0xdb},
+	{0x3d8c, 0x71},
+	{0x3d8d, 0xea},
+	{0x4017, 0x10},
+	{0x3618, 0x2a},
+	{0x5780, 0x3e},
+	{0x5781, 0x0f},
+	{0x5782, 0x44},
+	{0x5783, 0x02},
+	{0x5784, 0x01},
+	{0x5785, 0x01},
+	{0x5786, 0x00},
+	{0x5787, 0x04},
+	{0x5788, 0x02},
+	{0x5789, 0x0f},
+	{0x578a, 0xfd},
+	{0x578b, 0xf5},
+	{0x578c, 0xf5},
+	{0x578d, 0x03},
+	{0x578e, 0x08},
+	{0x578f, 0x0c},
+	{0x5790, 0x08},
+	{0x5791, 0x06},
+	{0x5792, 0x00},
+	{0x5793, 0x52},
+	{0x5794, 0xa3},
+};
+
+static const struct ov5670_reg mode_960x720_regs[] = {
+	{0x3000, 0x00},
+	{0x3002, 0x61},
+	{0x3005, 0xf0},
+	{0x3007, 0x00},
+	{0x300D, 0x00},
+	{0x3010, 0x40},
+	{0x3015, 0x0f},
+	{0x3018, 0x32},
+	{0x301a, 0xf0},
+	{0x301b, 0xf0},
+	{0x301c, 0xf0},
+	{0x301d, 0xf0},
+	{0x301e, 0xf0},
+	{0x3030, 0x00},
+	{0x303c, 0xff},
+	{0x303e, 0xff},
+	{0x3040, 0xf0},
+	{0x3041, 0x00},
+	{0x3042, 0xf0},
+	{0x3106, 0x11},
+	{0x3500, 0x00},
+	{0x3501, 0xb8},
+	{0x3502, 0x80},
+	{0x3503, 0x00},
+	{0x3504, 0x03},
+	{0x3505, 0x83},
+	{0x3508, 0x04},
+	{0x3509, 0x00},
+	{0x350e, 0x04},
+	{0x350f, 0x00},
+	{0x3510, 0x00},
+	{0x3511, 0x02},
+	{0x3512, 0x00},
+	{0x3601, 0xc8},
+	{0x3610, 0x88},
+	{0x3612, 0x48},
+	{0x3614, 0x5b},
+	{0x3615, 0x96},
+	{0x3621, 0xd0},
+	{0x3622, 0x00},
+	{0x3623, 0x00},
+	{0x3633, 0x13},
+	{0x3634, 0x13},
+	{0x3635, 0x13},
+	{0x3636, 0x13},
+	{0x3645, 0x13},
+	{0x3646, 0x82},
+	{0x3650, 0x00},
+	{0x3652, 0xff},
+	{0x3655, 0x20},
+	{0x3656, 0xff},
+	{0x365a, 0xff},
+	{0x365e, 0xff},
+	{0x3668, 0x00},
+	{0x366a, 0x07},
+	{0x366e, 0x08},
+	{0x366d, 0x00},
+	{0x366f, 0x80},
+	{0x3700, 0x28},
+	{0x3701, 0x10},
+	{0x3702, 0x3a},
+	{0x3703, 0x19},
+	{0x3704, 0x10},
+	{0x3705, 0x00},
+	{0x3706, 0x66},
+	{0x3707, 0x08},
+	{0x3708, 0x34},
+	{0x3709, 0x40},
+	{0x370a, 0x01},
+	{0x370b, 0x1b},
+	{0x3714, 0x24},
+	{0x371a, 0x3e},
+	{0x3733, 0x00},
+	{0x3734, 0x00},
+	{0x373a, 0x05},
+	{0x373b, 0x06},
+	{0x373c, 0x0a},
+	{0x373f, 0xa0},
+	{0x3755, 0x00},
+	{0x3758, 0x00},
+	{0x375b, 0x0e},
+	{0x3766, 0x5f},
+	{0x3768, 0x00},
+	{0x3769, 0x22},
+	{0x3773, 0x08},
+	{0x3774, 0x1f},
+	{0x3776, 0x06},
+	{0x37a0, 0x88},
+	{0x37a1, 0x5c},
+	{0x37a7, 0x88},
+	{0x37a8, 0x70},
+	{0x37aa, 0x88},
+	{0x37ab, 0x48},
+	{0x37b3, 0x66},
+	{0x37c2, 0x04},
+	{0x37c5, 0x00},
+	{0x37c8, 0x00},
+	{0x3800, 0x00},
+	{0x3801, 0x0c},
+	{0x3802, 0x00},
+	{0x3803, 0x04},
+	{0x3804, 0x0a},
+	{0x3805, 0x33},
+	{0x3806, 0x07},
+	{0x3807, 0xa3},
+	{0x3808, 0x03},
+	{0x3809, 0xc0},
+	{0x380a, 0x02},
+	{0x380b, 0xd0},
+	{0x380c, 0x06},
+	{0x380d, 0xa8},
+	{0x380e, 0x07},
+	{0x380f, 0xf6},
+	{0x3811, 0x04},
+	{0x3813, 0x02},
+	{0x3814, 0x03},
+	{0x3815, 0x01},
+	{0x3816, 0x00},
+	{0x3817, 0x00},
+	{0x3818, 0x00},
+	{0x3819, 0x00},
+	{0x3820, 0x94},
+	{0x3821, 0x41},
+	{0x3822, 0x48},
+	{0x3826, 0x00},
+	{0x3827, 0x08},
+	{0x382a, 0x03},
+	{0x382b, 0x01},
+	{0x3830, 0x08},
+	{0x3836, 0x02},
+	{0x3837, 0x00},
+	{0x3838, 0x10},
+	{0x3841, 0xff},
+	{0x3846, 0x48},
+	{0x3861, 0x00},
+	{0x3862, 0x04},
+	{0x3863, 0x06},
+	{0x3a11, 0x01},
+	{0x3a12, 0x78},
+	{0x3b00, 0x00},
+	{0x3b02, 0x00},
+	{0x3b03, 0x00},
+	{0x3b04, 0x00},
+	{0x3b05, 0x00},
+	{0x3c00, 0x89},
+	{0x3c01, 0xab},
+	{0x3c02, 0x01},
+	{0x3c03, 0x00},
+	{0x3c04, 0x00},
+	{0x3c05, 0x03},
+	{0x3c06, 0x00},
+	{0x3c07, 0x05},
+	{0x3c0c, 0x00},
+	{0x3c0d, 0x00},
+	{0x3c0e, 0x00},
+	{0x3c0f, 0x00},
+	{0x3c40, 0x00},
+	{0x3c41, 0xa3},
+	{0x3c43, 0x7d},
+	{0x3c45, 0xd7},
+	{0x3c47, 0xfc},
+	{0x3c50, 0x05},
+	{0x3c52, 0xaa},
+	{0x3c54, 0x71},
+	{0x3c56, 0x80},
+	{0x3d85, 0x17},
+	{0x3f03, 0x00},
+	{0x3f0a, 0x00},
+	{0x3f0b, 0x00},
+	{0x4001, 0x60},
+	{0x4009, 0x05},
+	{0x4020, 0x00},
+	{0x4021, 0x00},
+	{0x4022, 0x00},
+	{0x4023, 0x00},
+	{0x4024, 0x00},
+	{0x4025, 0x00},
+	{0x4026, 0x00},
+	{0x4027, 0x00},
+	{0x4028, 0x00},
+	{0x4029, 0x00},
+	{0x402a, 0x00},
+	{0x402b, 0x00},
+	{0x402c, 0x00},
+	{0x402d, 0x00},
+	{0x402e, 0x00},
+	{0x402f, 0x00},
+	{0x4040, 0x00},
+	{0x4041, 0x03},
+	{0x4042, 0x00},
+	{0x4043, 0x7A},
+	{0x4044, 0x00},
+	{0x4045, 0x7A},
+	{0x4046, 0x00},
+	{0x4047, 0x7A},
+	{0x4048, 0x00},
+	{0x4049, 0x7A},
+	{0x4303, 0x00},
+	{0x4307, 0x30},
+	{0x4500, 0x58},
+	{0x4501, 0x04},
+	{0x4502, 0x48},
+	{0x4503, 0x10},
+	{0x4508, 0x55},
+	{0x4509, 0x55},
+	{0x450a, 0x00},
+	{0x450b, 0x00},
+	{0x4600, 0x00},
+	{0x4601, 0x80},
+	{0x4700, 0xa4},
+	{0x4800, 0x4c},
+	{0x4816, 0x53},
+	{0x481f, 0x40},
+	{0x4837, 0x12},
+	{0x5000, 0x56},
+	{0x5001, 0x01},
+	{0x5002, 0x28},
+	{0x5004, 0x0c},
+	{0x5006, 0x0c},
+	{0x5007, 0xe0},
+	{0x5008, 0x01},
+	{0x5009, 0xb0},
+	{0x5045, 0x05},
+	{0x5048, 0x10},
+	{0x5901, 0x00},
+	{0x5a01, 0x00},
+	{0x5a03, 0x00},
+	{0x5a04, 0x0c},
+	{0x5a05, 0xe0},
+	{0x5a06, 0x09},
+	{0x5a07, 0xb0},
+	{0x5a08, 0x06},
+	{0x5e00, 0x00},
+	{0x3734, 0x40},
+	{0x5b00, 0x01},
+	{0x5b01, 0x10},
+	{0x5b02, 0x01},
+	{0x5b03, 0xdb},
+	{0x3d8c, 0x71},
+	{0x3d8d, 0xea},
+	{0x4017, 0x10},
+	{0x3618, 0x2a},
+	{0x5780, 0x3e},
+	{0x5781, 0x0f},
+	{0x5782, 0x44},
+	{0x5783, 0x02},
+	{0x5784, 0x01},
+	{0x5785, 0x01},
+	{0x5786, 0x00},
+	{0x5787, 0x04},
+	{0x5788, 0x02},
+	{0x5789, 0x0f},
+	{0x578a, 0xfd},
+	{0x578b, 0xf5},
+	{0x578c, 0xf5},
+	{0x578d, 0x03},
+	{0x578e, 0x08},
+	{0x578f, 0x0c},
+	{0x5790, 0x08},
+	{0x5791, 0x06},
+	{0x5792, 0x00},
+	{0x5793, 0x52},
+	{0x5794, 0xa3},
+};
+
+static const struct ov5670_reg mode_1920x1080_regs[] = {
+	{0x3000, 0x00},
+	{0x3002, 0x61},
+	{0x3005, 0xf0},
+	{0x3007, 0x00},
+	{0x300D, 0x00},
+	{0x3010, 0x40},
+	{0x3015, 0x0f},
+	{0x3018, 0x32},
+	{0x301a, 0xf0},
+	{0x301b, 0xf0},
+	{0x301c, 0xf0},
+	{0x301d, 0xf0},
+	{0x301e, 0xf0},
+	{0x3030, 0x00},
+	{0x303c, 0xff},
+	{0x303e, 0xff},
+	{0x3040, 0xf0},
+	{0x3041, 0x00},
+	{0x3042, 0xf0},
+	{0x3106, 0x11},
+	{0x3500, 0x00},
+	{0x3501, 0xb8},
+	{0x3502, 0x80},
+	{0x3503, 0x00},
+	{0x3504, 0x03},
+	{0x3505, 0x83},
+	{0x3508, 0x04},
+	{0x3509, 0x00},
+	{0x350e, 0x04},
+	{0x350f, 0x00},
+	{0x3510, 0x00},
+	{0x3511, 0x02},
+	{0x3512, 0x00},
+	{0x3601, 0xc8},
+	{0x3610, 0x88},
+	{0x3612, 0x48},
+	{0x3614, 0x5b},
+	{0x3615, 0x96},
+	{0x3621, 0xd0},
+	{0x3622, 0x00},
+	{0x3623, 0x00},
+	{0x3633, 0x13},
+	{0x3634, 0x13},
+	{0x3635, 0x13},
+	{0x3636, 0x13},
+	{0x3645, 0x13},
+	{0x3646, 0x82},
+	{0x3650, 0x00},
+	{0x3652, 0xff},
+	{0x3655, 0x20},
+	{0x3656, 0xff},
+	{0x365a, 0xff},
+	{0x365e, 0xff},
+	{0x3668, 0x00},
+	{0x366a, 0x07},
+	{0x366e, 0x10},
+	{0x366d, 0x00},
+	{0x366f, 0x80},
+	{0x3700, 0x28},
+	{0x3701, 0x10},
+	{0x3702, 0x3a},
+	{0x3703, 0x19},
+	{0x3704, 0x10},
+	{0x3705, 0x00},
+	{0x3706, 0x66},
+	{0x3707, 0x08},
+	{0x3708, 0x34},
+	{0x3709, 0x40},
+	{0x370a, 0x01},
+	{0x370b, 0x1b},
+	{0x3714, 0x24},
+	{0x371a, 0x3e},
+	{0x3733, 0x00},
+	{0x3734, 0x00},
+	{0x373a, 0x05},
+	{0x373b, 0x06},
+	{0x373c, 0x0a},
+	{0x373f, 0xa0},
+	{0x3755, 0x00},
+	{0x3758, 0x00},
+	{0x375b, 0x0e},
+	{0x3766, 0x5f},
+	{0x3768, 0x00},
+	{0x3769, 0x22},
+	{0x3773, 0x08},
+	{0x3774, 0x1f},
+	{0x3776, 0x06},
+	{0x37a0, 0x88},
+	{0x37a1, 0x5c},
+	{0x37a7, 0x88},
+	{0x37a8, 0x70},
+	{0x37aa, 0x88},
+	{0x37ab, 0x48},
+	{0x37b3, 0x66},
+	{0x37c2, 0x04},
+	{0x37c5, 0x00},
+	{0x37c8, 0x00},
+	{0x3800, 0x00},
+	{0x3801, 0x0c},
+	{0x3802, 0x00},
+	{0x3803, 0x04},
+	{0x3804, 0x0a},
+	{0x3805, 0x33},
+	{0x3806, 0x07},
+	{0x3807, 0xa3},
+	{0x3808, 0x07},
+	{0x3809, 0x80},
+	{0x380a, 0x04},
+	{0x380b, 0x38},
+	{0x380c, 0x06},
+	{0x380d, 0xa8},
+	{0x380e, 0x07},
+	{0x380f, 0xf6},
+	{0x3811, 0x04},
+	{0x3813, 0x02},
+	{0x3814, 0x01},
+	{0x3815, 0x01},
+	{0x3816, 0x00},
+	{0x3817, 0x00},
+	{0x3818, 0x00},
+	{0x3819, 0x00},
+	{0x3820, 0x84},
+	{0x3821, 0x40},
+	{0x3822, 0x48},
+	{0x3826, 0x00},
+	{0x3827, 0x08},
+	{0x382a, 0x01},
+	{0x382b, 0x01},
+	{0x3830, 0x08},
+	{0x3836, 0x02},
+	{0x3837, 0x00},
+	{0x3838, 0x10},
+	{0x3841, 0xfa},
+	{0x3846, 0x48},
+	{0x3861, 0x00},
+	{0x3862, 0x04},
+	{0x3863, 0x06},
+	{0x3a11, 0x01},
+	{0x3a12, 0x78},
+	{0x3b00, 0x00},
+	{0x3b02, 0x00},
+	{0x3b03, 0x00},
+	{0x3b04, 0x00},
+	{0x3b05, 0x00},
+	{0x3c00, 0x89},
+	{0x3c01, 0xab},
+	{0x3c02, 0x01},
+	{0x3c03, 0x00},
+	{0x3c04, 0x00},
+	{0x3c05, 0x03},
+	{0x3c06, 0x00},
+	{0x3c07, 0x05},
+	{0x3c0c, 0x00},
+	{0x3c0d, 0x00},
+	{0x3c0e, 0x00},
+	{0x3c0f, 0x00},
+	{0x3c40, 0x00},
+	{0x3c41, 0xa3},
+	{0x3c43, 0x7d},
+	{0x3c45, 0xd7},
+	{0x3c47, 0xfc},
+	{0x3c50, 0x05},
+	{0x3c52, 0xaa},
+	{0x3c54, 0x71},
+	{0x3c56, 0x80},
+	{0x3d85, 0x17},
+	{0x3f03, 0x00},
+	{0x3f0a, 0x00},
+	{0x3f0b, 0x00},
+	{0x4001, 0x60},
+	{0x4009, 0x0d},
+	{0x4020, 0x00},
+	{0x4021, 0x00},
+	{0x4022, 0x00},
+	{0x4023, 0x00},
+	{0x4024, 0x00},
+	{0x4025, 0x00},
+	{0x4026, 0x00},
+	{0x4027, 0x00},
+	{0x4028, 0x00},
+	{0x4029, 0x00},
+	{0x402a, 0x00},
+	{0x402b, 0x00},
+	{0x402c, 0x00},
+	{0x402d, 0x00},
+	{0x402e, 0x00},
+	{0x402f, 0x00},
+	{0x4040, 0x00},
+	{0x4041, 0x03},
+	{0x4042, 0x00},
+	{0x4043, 0x7A},
+	{0x4044, 0x00},
+	{0x4045, 0x7A},
+	{0x4046, 0x00},
+	{0x4047, 0x7A},
+	{0x4048, 0x00},
+	{0x4049, 0x7A},
+	{0x4303, 0x00},
+	{0x4307, 0x30},
+	{0x4500, 0x58},
+	{0x4501, 0x04},
+	{0x4502, 0x40},
+	{0x4503, 0x10},
+	{0x4508, 0xaa},
+	{0x4509, 0xaa},
+	{0x450a, 0x00},
+	{0x450b, 0x00},
+	{0x4600, 0x00},
+	{0x4601, 0xc0},
+	{0x4700, 0xa4},
+	{0x4800, 0x4c},
+	{0x4816, 0x53},
+	{0x481f, 0x40},
+	{0x4837, 0x12},
+	{0x5000, 0x56},
+	{0x5001, 0x01},
+	{0x5002, 0x28},
+	{0x5004, 0x0c},
+	{0x5006, 0x0c},
+	{0x5007, 0xe0},
+	{0x5008, 0x01},
+	{0x5009, 0xb0},
+	{0x5045, 0x05},
+	{0x5048, 0x10},
+	{0x5901, 0x00},
+	{0x5a01, 0x00},
+	{0x5a03, 0x00},
+	{0x5a04, 0x0c},
+	{0x5a05, 0xe0},
+	{0x5a06, 0x09},
+	{0x5a07, 0xb0},
+	{0x5a08, 0x06},
+	{0x5e00, 0x00},
+	{0x3734, 0x40},
+	{0x5b00, 0x01},
+	{0x5b01, 0x10},
+	{0x5b02, 0x01},
+	{0x5b03, 0xdb},
+	{0x3d8c, 0x71},
+	{0x3d8d, 0xea},
+	{0x4017, 0x08},
+	{0x3618, 0x2a},
+	{0x5780, 0x3e},
+	{0x5781, 0x0f},
+	{0x5782, 0x44},
+	{0x5783, 0x02},
+	{0x5784, 0x01},
+	{0x5785, 0x01},
+	{0x5786, 0x00},
+	{0x5787, 0x04},
+	{0x5788, 0x02},
+	{0x5789, 0x0f},
+	{0x578a, 0xfd},
+	{0x578b, 0xf5},
+	{0x578c, 0xf5},
+	{0x578d, 0x03},
+	{0x578e, 0x08},
+	{0x578f, 0x0c},
+	{0x5790, 0x08},
+	{0x5791, 0x06},
+	{0x5792, 0x00},
+	{0x5793, 0x52},
+	{0x5794, 0xa3},
+};
+
+static const struct ov5670_reg mode_1440x1080_regs[] = {
+	{0x3000, 0x00},
+	{0x3002, 0x61},
+	{0x3005, 0xf0},
+	{0x3007, 0x00},
+	{0x300D, 0x00},
+	{0x3010, 0x40},
+	{0x3015, 0x0f},
+	{0x3018, 0x32},
+	{0x301a, 0xf0},
+	{0x301b, 0xf0},
+	{0x301c, 0xf0},
+	{0x301d, 0xf0},
+	{0x301e, 0xf0},
+	{0x3030, 0x00},
+	{0x303c, 0xff},
+	{0x303e, 0xff},
+	{0x3040, 0xf0},
+	{0x3041, 0x00},
+	{0x3042, 0xf0},
+	{0x3106, 0x11},
+	{0x3500, 0x00},
+	{0x3501, 0xb8},
+	{0x3502, 0x80},
+	{0x3503, 0x00},
+	{0x3504, 0x03},
+	{0x3505, 0x83},
+	{0x3508, 0x04},
+	{0x3509, 0x00},
+	{0x350e, 0x04},
+	{0x350f, 0x00},
+	{0x3510, 0x00},
+	{0x3511, 0x02},
+	{0x3512, 0x00},
+	{0x3601, 0xc8},
+	{0x3610, 0x88},
+	{0x3612, 0x48},
+	{0x3614, 0x5b},
+	{0x3615, 0x96},
+	{0x3621, 0xd0},
+	{0x3622, 0x00},
+	{0x3623, 0x00},
+	{0x3633, 0x13},
+	{0x3634, 0x13},
+	{0x3635, 0x13},
+	{0x3636, 0x13},
+	{0x3645, 0x13},
+	{0x3646, 0x82},
+	{0x3650, 0x00},
+	{0x3652, 0xff},
+	{0x3655, 0x20},
+	{0x3656, 0xff},
+	{0x365a, 0xff},
+	{0x365e, 0xff},
+	{0x3668, 0x00},
+	{0x366a, 0x07},
+	{0x366e, 0x10},
+	{0x366d, 0x00},
+	{0x366f, 0x80},
+	{0x3700, 0x28},
+	{0x3701, 0x10},
+	{0x3702, 0x3a},
+	{0x3703, 0x19},
+	{0x3704, 0x10},
+	{0x3705, 0x00},
+	{0x3706, 0x66},
+	{0x3707, 0x08},
+	{0x3708, 0x34},
+	{0x3709, 0x40},
+	{0x370a, 0x01},
+	{0x370b, 0x1b},
+	{0x3714, 0x24},
+	{0x371a, 0x3e},
+	{0x3733, 0x00},
+	{0x3734, 0x00},
+	{0x373a, 0x05},
+	{0x373b, 0x06},
+	{0x373c, 0x0a},
+	{0x373f, 0xa0},
+	{0x3755, 0x00},
+	{0x3758, 0x00},
+	{0x375b, 0x0e},
+	{0x3766, 0x5f},
+	{0x3768, 0x00},
+	{0x3769, 0x22},
+	{0x3773, 0x08},
+	{0x3774, 0x1f},
+	{0x3776, 0x06},
+	{0x37a0, 0x88},
+	{0x37a1, 0x5c},
+	{0x37a7, 0x88},
+	{0x37a8, 0x70},
+	{0x37aa, 0x88},
+	{0x37ab, 0x48},
+	{0x37b3, 0x66},
+	{0x37c2, 0x04},
+	{0x37c5, 0x00},
+	{0x37c8, 0x00},
+	{0x3800, 0x00},
+	{0x3801, 0x0c},
+	{0x3802, 0x00},
+	{0x3803, 0x04},
+	{0x3804, 0x0a},
+	{0x3805, 0x33},
+	{0x3806, 0x07},
+	{0x3807, 0xa3},
+	{0x3808, 0x05},
+	{0x3809, 0xa0},
+	{0x380a, 0x04},
+	{0x380b, 0x38},
+	{0x380c, 0x06},
+	{0x380d, 0xa8},
+	{0x380e, 0x07},
+	{0x380f, 0xf6},
+	{0x3811, 0x04},
+	{0x3813, 0x02},
+	{0x3814, 0x01},
+	{0x3815, 0x01},
+	{0x3816, 0x00},
+	{0x3817, 0x00},
+	{0x3818, 0x00},
+	{0x3819, 0x00},
+	{0x3820, 0x84},
+	{0x3821, 0x40},
+	{0x3822, 0x48},
+	{0x3826, 0x00},
+	{0x3827, 0x08},
+	{0x382a, 0x01},
+	{0x382b, 0x01},
+	{0x3830, 0x08},
+	{0x3836, 0x02},
+	{0x3837, 0x00},
+	{0x3838, 0x10},
+	{0x3841, 0xff},
+	{0x3846, 0x48},
+	{0x3861, 0x00},
+	{0x3862, 0x04},
+	{0x3863, 0x06},
+	{0x3a11, 0x01},
+	{0x3a12, 0x78},
+	{0x3b00, 0x00},
+	{0x3b02, 0x00},
+	{0x3b03, 0x00},
+	{0x3b04, 0x00},
+	{0x3b05, 0x00},
+	{0x3c00, 0x89},
+	{0x3c01, 0xab},
+	{0x3c02, 0x01},
+	{0x3c03, 0x00},
+	{0x3c04, 0x00},
+	{0x3c05, 0x03},
+	{0x3c06, 0x00},
+	{0x3c07, 0x05},
+	{0x3c0c, 0x00},
+	{0x3c0d, 0x00},
+	{0x3c0e, 0x00},
+	{0x3c0f, 0x00},
+	{0x3c40, 0x00},
+	{0x3c41, 0xa3},
+	{0x3c43, 0x7d},
+	{0x3c45, 0xd7},
+	{0x3c47, 0xfc},
+	{0x3c50, 0x05},
+	{0x3c52, 0xaa},
+	{0x3c54, 0x71},
+	{0x3c56, 0x80},
+	{0x3d85, 0x17},
+	{0x3f03, 0x00},
+	{0x3f0a, 0x00},
+	{0x3f0b, 0x00},
+	{0x4001, 0x60},
+	{0x4009, 0x0d},
+	{0x4020, 0x00},
+	{0x4021, 0x00},
+	{0x4022, 0x00},
+	{0x4023, 0x00},
+	{0x4024, 0x00},
+	{0x4025, 0x00},
+	{0x4026, 0x00},
+	{0x4027, 0x00},
+	{0x4028, 0x00},
+	{0x4029, 0x00},
+	{0x402a, 0x00},
+	{0x402b, 0x00},
+	{0x402c, 0x00},
+	{0x402d, 0x00},
+	{0x402e, 0x00},
+	{0x402f, 0x00},
+	{0x4040, 0x00},
+	{0x4041, 0x03},
+	{0x4042, 0x00},
+	{0x4043, 0x7A},
+	{0x4044, 0x00},
+	{0x4045, 0x7A},
+	{0x4046, 0x00},
+	{0x4047, 0x7A},
+	{0x4048, 0x00},
+	{0x4049, 0x7A},
+	{0x4303, 0x00},
+	{0x4307, 0x30},
+	{0x4500, 0x58},
+	{0x4501, 0x04},
+	{0x4502, 0x40},
+	{0x4503, 0x10},
+	{0x4508, 0xaa},
+	{0x4509, 0xaa},
+	{0x450a, 0x00},
+	{0x450b, 0x00},
+	{0x4600, 0x00},
+	{0x4601, 0xc0},
+	{0x4700, 0xa4},
+	{0x4800, 0x4c},
+	{0x4816, 0x53},
+	{0x481f, 0x40},
+	{0x4837, 0x12},
+	{0x5000, 0x56},
+	{0x5001, 0x01},
+	{0x5002, 0x28},
+	{0x5004, 0x0c},
+	{0x5006, 0x0c},
+	{0x5007, 0xe0},
+	{0x5008, 0x01},
+	{0x5009, 0xb0},
+	{0x5045, 0x05},
+	{0x5048, 0x10},
+	{0x5901, 0x00},
+	{0x5a01, 0x00},
+	{0x5a03, 0x00},
+	{0x5a04, 0x0c},
+	{0x5a05, 0xe0},
+	{0x5a06, 0x09},
+	{0x5a07, 0xb0},
+	{0x5a08, 0x06},
+	{0x5e00, 0x00},
+	{0x3734, 0x40},
+	{0x5b00, 0x01},
+	{0x5b01, 0x10},
+	{0x5b02, 0x01},
+	{0x5b03, 0xdb},
+	{0x3d8c, 0x71},
+	{0x3d8d, 0xea},
+	{0x4017, 0x08},
+	{0x3618, 0x2a},
+	{0x5780, 0x3e},
+	{0x5781, 0x0f},
+	{0x5782, 0x44},
+	{0x5783, 0x02},
+	{0x5784, 0x01},
+	{0x5785, 0x01},
+	{0x5786, 0x00},
+	{0x5787, 0x04},
+	{0x5788, 0x02},
+	{0x5789, 0x0f},
+	{0x578a, 0xfd},
+	{0x578b, 0xf5},
+	{0x578c, 0xf5},
+	{0x578d, 0x03},
+	{0x578e, 0x08},
+	{0x578f, 0x0c},
+	{0x5790, 0x08},
+	{0x5791, 0x06},
+	{0x5792, 0x00},
+	{0x5793, 0x52},
+	{0x5794, 0xa3},
+};
+
+static const struct ov5670_reg mode_1936x1096_regs[] = {
+	{0x3000, 0x00},
+	{0x3002, 0x61},
+	{0x3005, 0xf0},
+	{0x3007, 0x00},
+	{0x300D, 0x00},
+	{0x3010, 0x40},
+	{0x3015, 0x0f},
+	{0x3018, 0x32},
+	{0x301a, 0xf0},
+	{0x301b, 0xf0},
+	{0x301c, 0xf0},
+	{0x301d, 0xf0},
+	{0x301e, 0xf0},
+	{0x3030, 0x00},
+	{0x303c, 0xff},
+	{0x303e, 0xff},
+	{0x3040, 0xf0},
+	{0x3041, 0x00},
+	{0x3042, 0xf0},
+	{0x3106, 0x11},
+	{0x3500, 0x00},
+	{0x3501, 0xb8},
+	{0x3502, 0x80},
+	{0x3503, 0x00},
+	{0x3504, 0x03},
+	{0x3505, 0x83},
+	{0x3508, 0x04},
+	{0x3509, 0x00},
+	{0x350e, 0x04},
+	{0x350f, 0x00},
+	{0x3510, 0x00},
+	{0x3511, 0x02},
+	{0x3512, 0x00},
+	{0x3601, 0xc8},
+	{0x3610, 0x88},
+	{0x3612, 0x48},
+	{0x3614, 0x5b},
+	{0x3615, 0x96},
+	{0x3621, 0xd0},
+	{0x3622, 0x00},
+	{0x3623, 0x00},
+	{0x3633, 0x13},
+	{0x3634, 0x13},
+	{0x3635, 0x13},
+	{0x3636, 0x13},
+	{0x3645, 0x13},
+	{0x3646, 0x82},
+	{0x3650, 0x00},
+	{0x3652, 0xff},
+	{0x3655, 0x20},
+	{0x3656, 0xff},
+	{0x365a, 0xff},
+	{0x365e, 0xff},
+	{0x3668, 0x00},
+	{0x366a, 0x07},
+	{0x366e, 0x10},
+	{0x366d, 0x00},
+	{0x366f, 0x80},
+	{0x3700, 0x28},
+	{0x3701, 0x10},
+	{0x3702, 0x3a},
+	{0x3703, 0x19},
+	{0x3704, 0x10},
+	{0x3705, 0x00},
+	{0x3706, 0x66},
+	{0x3707, 0x08},
+	{0x3708, 0x34},
+	{0x3709, 0x40},
+	{0x370a, 0x01},
+	{0x370b, 0x1b},
+	{0x3714, 0x24},
+	{0x371a, 0x3e},
+	{0x3733, 0x00},
+	{0x3734, 0x00},
+	{0x373a, 0x05},
+	{0x373b, 0x06},
+	{0x373c, 0x0a},
+	{0x373f, 0xa0},
+	{0x3755, 0x00},
+	{0x3758, 0x00},
+	{0x375b, 0x0e},
+	{0x3766, 0x5f},
+	{0x3768, 0x00},
+	{0x3769, 0x22},
+	{0x3773, 0x08},
+	{0x3774, 0x1f},
+	{0x3776, 0x06},
+	{0x37a0, 0x88},
+	{0x37a1, 0x5c},
+	{0x37a7, 0x88},
+	{0x37a8, 0x70},
+	{0x37aa, 0x88},
+	{0x37ab, 0x48},
+	{0x37b3, 0x66},
+	{0x37c2, 0x04},
+	{0x37c5, 0x00},
+	{0x37c8, 0x00},
+	{0x3800, 0x00},
+	{0x3801, 0x0c},
+	{0x3802, 0x00},
+	{0x3803, 0x04},
+	{0x3804, 0x0a},
+	{0x3805, 0x33},
+	{0x3806, 0x07},
+	{0x3807, 0xa3},
+	{0x3808, 0x07},
+	{0x3809, 0x90},
+	{0x380a, 0x04},
+	{0x380b, 0x48},
+	{0x380c, 0x06},
+	{0x380d, 0xa8},
+	{0x380e, 0x07},
+	{0x380f, 0xf6},
+	{0x3811, 0x04},
+	{0x3813, 0x02},
+	{0x3814, 0x01},
+	{0x3815, 0x01},
+	{0x3816, 0x00},
+	{0x3817, 0x00},
+	{0x3818, 0x00},
+	{0x3819, 0x00},
+	{0x3820, 0x84},
+	{0x3821, 0x40},
+	{0x3822, 0x48},
+	{0x3826, 0x00},
+	{0x3827, 0x08},
+	{0x382a, 0x01},
+	{0x382b, 0x01},
+	{0x3830, 0x08},
+	{0x3836, 0x02},
+	{0x3837, 0x00},
+	{0x3838, 0x10},
+	{0x3841, 0xff},
+	{0x3846, 0x48},
+	{0x3861, 0x00},
+	{0x3862, 0x04},
+	{0x3863, 0x06},
+	{0x3a11, 0x01},
+	{0x3a12, 0x78},
+	{0x3b00, 0x00},
+	{0x3b02, 0x00},
+	{0x3b03, 0x00},
+	{0x3b04, 0x00},
+	{0x3b05, 0x00},
+	{0x3c00, 0x89},
+	{0x3c01, 0xab},
+	{0x3c02, 0x01},
+	{0x3c03, 0x00},
+	{0x3c04, 0x00},
+	{0x3c05, 0x03},
+	{0x3c06, 0x00},
+	{0x3c07, 0x05},
+	{0x3c0c, 0x00},
+	{0x3c0d, 0x00},
+	{0x3c0e, 0x00},
+	{0x3c0f, 0x00},
+	{0x3c40, 0x00},
+	{0x3c41, 0xa3},
+	{0x3c43, 0x7d},
+	{0x3c45, 0xd7},
+	{0x3c47, 0xfc},
+	{0x3c50, 0x05},
+	{0x3c52, 0xaa},
+	{0x3c54, 0x71},
+	{0x3c56, 0x80},
+	{0x3d85, 0x17},
+	{0x3f03, 0x00},
+	{0x3f0a, 0x00},
+	{0x3f0b, 0x00},
+	{0x4001, 0x60},
+	{0x4009, 0x0d},
+	{0x4020, 0x00},
+	{0x4021, 0x00},
+	{0x4022, 0x00},
+	{0x4023, 0x00},
+	{0x4024, 0x00},
+	{0x4025, 0x00},
+	{0x4026, 0x00},
+	{0x4027, 0x00},
+	{0x4028, 0x00},
+	{0x4029, 0x00},
+	{0x402a, 0x00},
+	{0x402b, 0x00},
+	{0x402c, 0x00},
+	{0x402d, 0x00},
+	{0x402e, 0x00},
+	{0x402f, 0x00},
+	{0x4040, 0x00},
+	{0x4041, 0x03},
+	{0x4042, 0x00},
+	{0x4043, 0x7A},
+	{0x4044, 0x00},
+	{0x4045, 0x7A},
+	{0x4046, 0x00},
+	{0x4047, 0x7A},
+	{0x4048, 0x00},
+	{0x4049, 0x7A},
+	{0x4303, 0x00},
+	{0x4307, 0x30},
+	{0x4500, 0x58},
+	{0x4501, 0x04},
+	{0x4502, 0x40},
+	{0x4503, 0x10},
+	{0x4508, 0xaa},
+	{0x4509, 0xaa},
+	{0x450a, 0x00},
+	{0x450b, 0x00},
+	{0x4600, 0x00},
+	{0x4601, 0xc0},
+	{0x4700, 0xa4},
+	{0x4800, 0x4c},
+	{0x4816, 0x53},
+	{0x481f, 0x40},
+	{0x4837, 0x12},
+	{0x5000, 0x56},
+	{0x5001, 0x01},
+	{0x5002, 0x28},
+	{0x5004, 0x0c},
+	{0x5006, 0x0c},
+	{0x5007, 0xe0},
+	{0x5008, 0x01},
+	{0x5009, 0xb0},
+	{0x5045, 0x05},
+	{0x5048, 0x10},
+	{0x5901, 0x00},
+	{0x5a01, 0x00},
+	{0x5a03, 0x00},
+	{0x5a04, 0x0c},
+	{0x5a05, 0xe0},
+	{0x5a06, 0x09},
+	{0x5a07, 0xb0},
+	{0x5a08, 0x06},
+	{0x5e00, 0x00},
+	{0x3734, 0x40},
+	{0x5b00, 0x01},
+	{0x5b01, 0x10},
+	{0x5b02, 0x01},
+	{0x5b03, 0xdb},
+	{0x3d8c, 0x71},
+	{0x3d8d, 0xea},
+	{0x4017, 0x08},
+	{0x3618, 0x2a},
+	{0x5780, 0x3e},
+	{0x5781, 0x0f},
+	{0x5782, 0x44},
+	{0x5783, 0x02},
+	{0x5784, 0x01},
+	{0x5785, 0x01},
+	{0x5786, 0x00},
+	{0x5787, 0x04},
+	{0x5788, 0x02},
+	{0x5789, 0x0f},
+	{0x578a, 0xfd},
+	{0x578b, 0xf5},
+	{0x578c, 0xf5},
+	{0x578d, 0x03},
+	{0x578e, 0x08},
+	{0x578f, 0x0c},
+	{0x5790, 0x08},
+	{0x5791, 0x06},
+	{0x5792, 0x00},
+	{0x5793, 0x52},
+	{0x5794, 0xa3},
+};
+
+static const struct ov5670_reg mode_2560x1440_regs[] = {
+	{0x3000, 0x00},
+	{0x3002, 0x61},
+	{0x3005, 0xf0},
+	{0x3007, 0x00},
+	{0x300D, 0x00},
+	{0x3010, 0x40},
+	{0x3015, 0x0f},
+	{0x3018, 0x32},
+	{0x301a, 0xf0},
+	{0x301b, 0xf0},
+	{0x301c, 0xf0},
+	{0x301d, 0xf0},
+	{0x301e, 0xf0},
+	{0x3030, 0x00},
+	{0x303c, 0xff},
+	{0x303e, 0xff},
+	{0x3040, 0xf0},
+	{0x3041, 0x00},
+	{0x3042, 0xf0},
+	{0x3106, 0x11},
+	{0x3500, 0x00},
+	{0x3501, 0xb8},
+	{0x3502, 0x80},
+	{0x3503, 0x00},
+	{0x3504, 0x03},
+	{0x3505, 0x83},
+	{0x3508, 0x04},
+	{0x3509, 0x00},
+	{0x350e, 0x04},
+	{0x350f, 0x00},
+	{0x3510, 0x00},
+	{0x3511, 0x02},
+	{0x3512, 0x00},
+	{0x3601, 0xc8},
+	{0x3610, 0xa8},
+	{0x3612, 0x48},
+	{0x3614, 0x5b},
+	{0x3615, 0x96},
+	{0x3621, 0xd0},
+	{0x3622, 0x00},
+	{0x3623, 0x00},
+	{0x3633, 0x13},
+	{0x3634, 0x13},
+	{0x3635, 0x13},
+	{0x3636, 0x13},
+	{0x3645, 0x13},
+	{0x3646, 0x82},
+	{0x3650, 0x00},
+	{0x3652, 0xff},
+	{0x3655, 0x20},
+	{0x3656, 0xff},
+	{0x365a, 0xff},
+	{0x365e, 0xff},
+	{0x3668, 0x00},
+	{0x366a, 0x07},
+	{0x366e, 0x10},
+	{0x366d, 0x00},
+	{0x366f, 0x80},
+	{0x3700, 0x28},
+	{0x3701, 0x10},
+	{0x3702, 0x3a},
+	{0x3703, 0x19},
+	{0x3704, 0x10},
+	{0x3705, 0x00},
+	{0x3706, 0x66},
+	{0x3707, 0x08},
+	{0x3708, 0x34},
+	{0x3709, 0x40},
+	{0x370a, 0x01},
+	{0x370b, 0x1b},
+	{0x3714, 0x24},
+	{0x371a, 0x3e},
+	{0x3733, 0x10},
+	{0x3734, 0x40},
+	{0x373a, 0x05},
+	{0x373b, 0x06},
+	{0x373c, 0x0a},
+	{0x373f, 0xa0},
+	{0x3755, 0x00},
+	{0x3758, 0x00},
+	{0x375b, 0x0e},
+	{0x3766, 0x5f},
+	{0x3768, 0x00},
+	{0x3769, 0x22},
+	{0x3773, 0x08},
+	{0x3774, 0x1f},
+	{0x3776, 0x06},
+	{0x37a0, 0x88},
+	{0x37a1, 0x5c},
+	{0x37a7, 0x88},
+	{0x37a8, 0x70},
+	{0x37aa, 0x88},
+	{0x37ab, 0x48},
+	{0x37b3, 0x66},
+	{0x37c2, 0x04},
+	{0x37c5, 0x00},
+	{0x37c8, 0x00},
+	{0x3800, 0x00},
+	{0x3801, 0x0c},
+	{0x3802, 0x00},
+	{0x3803, 0x04},
+	{0x3804, 0x0a},
+	{0x3805, 0x33},
+	{0x3806, 0x07},
+	{0x3807, 0xa3},
+	{0x3808, 0x0a},
+	{0x3809, 0x00},
+	{0x380a, 0x05},
+	{0x380b, 0xa0},
+	{0x380c, 0x06},
+	{0x380d, 0x90},
+	{0x380e, 0x08},
+	{0x380f, 0x14},
+	{0x3811, 0x04},
+	{0x3813, 0x02},
+	{0x3814, 0x01},
+	{0x3815, 0x01},
+	{0x3816, 0x00},
+	{0x3817, 0x00},
+	{0x3818, 0x00},
+	{0x3819, 0x00},
+	{0x3820, 0x84},
+	{0x3821, 0x40},
+	{0x3822, 0x48},
+	{0x3826, 0x00},
+	{0x3827, 0x08},
+	{0x382a, 0x01},
+	{0x382b, 0x01},
+	{0x3830, 0x08},
+	{0x3836, 0x02},
+	{0x3837, 0x00},
+	{0x3838, 0x10},
+	{0x3841, 0xff},
+	{0x3845, 0x01},
+	{0x3846, 0x48},
+	{0x3861, 0x00},
+	{0x3862, 0x04},
+	{0x3863, 0x06},
+	{0x3a11, 0x01},
+	{0x3a12, 0x78},
+	{0x3b00, 0x00},
+	{0x3b02, 0x00},
+	{0x3b03, 0x00},
+	{0x3b04, 0x00},
+	{0x3b05, 0x00},
+	{0x3c00, 0x89},
+	{0x3c01, 0xab},
+	{0x3c02, 0x01},
+	{0x3c03, 0x00},
+	{0x3c04, 0x00},
+	{0x3c05, 0x03},
+	{0x3c06, 0x00},
+	{0x3c07, 0x05},
+	{0x3c0c, 0x00},
+	{0x3c0d, 0x00},
+	{0x3c0e, 0x00},
+	{0x3c0f, 0x00},
+	{0x3c40, 0x00},
+	{0x3c41, 0xa3},
+	{0x3c43, 0x7d},
+	{0x3c45, 0xd7},
+	{0x3c47, 0xfc},
+	{0x3c50, 0x05},
+	{0x3c52, 0xaa},
+	{0x3c54, 0x71},
+	{0x3c56, 0x80},
+	{0x3d85, 0x17},
+	{0x3f03, 0x00},
+	{0x3f0a, 0x00},
+	{0x3f0b, 0x00},
+	{0x4001, 0x60},
+	{0x4009, 0x0d},
+	{0x4020, 0x00},
+	{0x4021, 0x00},
+	{0x4022, 0x00},
+	{0x4023, 0x00},
+	{0x4024, 0x00},
+	{0x4025, 0x00},
+	{0x4026, 0x00},
+	{0x4027, 0x00},
+	{0x4028, 0x00},
+	{0x4029, 0x00},
+	{0x402a, 0x00},
+	{0x402b, 0x00},
+	{0x402c, 0x00},
+	{0x402d, 0x00},
+	{0x402e, 0x00},
+	{0x402f, 0x00},
+	{0x4040, 0x00},
+	{0x4041, 0x03},
+	{0x4042, 0x00},
+	{0x4043, 0x7A},
+	{0x4044, 0x00},
+	{0x4045, 0x7A},
+	{0x4046, 0x00},
+	{0x4047, 0x7A},
+	{0x4048, 0x00},
+	{0x4049, 0x7A},
+	{0x4303, 0x00},
+	{0x4307, 0x30},
+	{0x4500, 0x58},
+	{0x4501, 0x04},
+	{0x4502, 0x40},
+	{0x4503, 0x10},
+	{0x4508, 0xaa},
+	{0x4509, 0xaa},
+	{0x450a, 0x00},
+	{0x450b, 0x00},
+	{0x4600, 0x01},
+	{0x4601, 0x00},
+	{0x4700, 0xa4},
+	{0x4800, 0x4c},
+	{0x4816, 0x53},
+	{0x481f, 0x40},
+	{0x4837, 0x12},
+	{0x5000, 0x56},
+	{0x5001, 0x01},
+	{0x5002, 0x28},
+	{0x5004, 0x0c},
+	{0x5006, 0x0c},
+	{0x5007, 0xe0},
+	{0x5008, 0x01},
+	{0x5009, 0xb0},
+	{0x5045, 0x05},
+	{0x5048, 0x10},
+	{0x5901, 0x00},
+	{0x5a01, 0x00},
+	{0x5a03, 0x00},
+	{0x5a04, 0x0c},
+	{0x5a05, 0xe0},
+	{0x5a06, 0x09},
+	{0x5a07, 0xb0},
+	{0x5a08, 0x06},
+	{0x5e00, 0x00},
+	{0x3734, 0x40},
+	{0x5b00, 0x01},
+	{0x5b01, 0x10},
+	{0x5b02, 0x01},
+	{0x5b03, 0xdb},
+	{0x3d8c, 0x71},
+	{0x3d8d, 0xea},
+	{0x4017, 0x08},
+	{0x3618, 0x2a},
+	{0x5780, 0x3e},
+	{0x5781, 0x0f},
+	{0x5782, 0x44},
+	{0x5783, 0x02},
+	{0x5784, 0x01},
+	{0x5785, 0x01},
+	{0x5786, 0x00},
+	{0x5787, 0x04},
+	{0x5788, 0x02},
+	{0x5789, 0x0f},
+	{0x578a, 0xfd},
+	{0x578b, 0xf5},
+	{0x578c, 0xf5},
+	{0x578d, 0x03},
+	{0x578e, 0x08},
+	{0x578f, 0x0c},
+	{0x5790, 0x08},
+	{0x5791, 0x06},
+	{0x5792, 0x00},
+	{0x5793, 0x52},
+	{0x5794, 0xa3},
+};
+
+static const struct ov5670_reg mode_2576x1456_regs[] = {
+	{0x3000, 0x00},
+	{0x3002, 0x61},
+	{0x3005, 0xf0},
+	{0x3007, 0x00},
+	{0x300D, 0x00},
+	{0x3010, 0x40},
+	{0x3015, 0x0f},
+	{0x3018, 0x32},
+	{0x301a, 0xf0},
+	{0x301b, 0xf0},
+	{0x301c, 0xf0},
+	{0x301d, 0xf0},
+	{0x301e, 0xf0},
+	{0x3030, 0x00},
+	{0x303c, 0xff},
+	{0x303e, 0xff},
+	{0x3040, 0xf0},
+	{0x3041, 0x00},
+	{0x3042, 0xf0},
+	{0x3106, 0x11},
+	{0x3500, 0x00},
+	{0x3501, 0xb8},
+	{0x3502, 0x80},
+	{0x3503, 0x00},
+	{0x3504, 0x03},
+	{0x3505, 0x83},
+	{0x3508, 0x04},
+	{0x3509, 0x00},
+	{0x350e, 0x04},
+	{0x350f, 0x00},
+	{0x3510, 0x00},
+	{0x3511, 0x02},
+	{0x3512, 0x00},
+	{0x3601, 0xc8},
+	{0x3610, 0xa8},
+	{0x3612, 0x48},
+	{0x3614, 0x5b},
+	{0x3615, 0x96},
+	{0x3621, 0xd0},
+	{0x3622, 0x00},
+	{0x3623, 0x00},
+	{0x3633, 0x13},
+	{0x3634, 0x13},
+	{0x3635, 0x13},
+	{0x3636, 0x13},
+	{0x3645, 0x13},
+	{0x3646, 0x82},
+	{0x3650, 0x00},
+	{0x3652, 0xff},
+	{0x3655, 0x20},
+	{0x3656, 0xff},
+	{0x365a, 0xff},
+	{0x365e, 0xff},
+	{0x3668, 0x00},
+	{0x366a, 0x07},
+	{0x366e, 0x10},
+	{0x366d, 0x00},
+	{0x366f, 0x80},
+	{0x3700, 0x28},
+	{0x3701, 0x10},
+	{0x3702, 0x3a},
+	{0x3703, 0x19},
+	{0x3704, 0x10},
+	{0x3705, 0x00},
+	{0x3706, 0x66},
+	{0x3707, 0x08},
+	{0x3708, 0x34},
+	{0x3709, 0x40},
+	{0x370a, 0x01},
+	{0x370b, 0x1b},
+	{0x3714, 0x24},
+	{0x371a, 0x3e},
+	{0x3733, 0x10},
+	{0x3734, 0x40},
+	{0x373a, 0x05},
+	{0x373b, 0x06},
+	{0x373c, 0x0a},
+	{0x373f, 0xa0},
+	{0x3755, 0x00},
+	{0x3758, 0x00},
+	{0x375b, 0x0e},
+	{0x3766, 0x5f},
+	{0x3768, 0x00},
+	{0x3769, 0x22},
+	{0x3773, 0x08},
+	{0x3774, 0x1f},
+	{0x3776, 0x06},
+	{0x37a0, 0x88},
+	{0x37a1, 0x5c},
+	{0x37a7, 0x88},
+	{0x37a8, 0x70},
+	{0x37aa, 0x88},
+	{0x37ab, 0x48},
+	{0x37b3, 0x66},
+	{0x37c2, 0x04},
+	{0x37c5, 0x00},
+	{0x37c8, 0x00},
+	{0x3800, 0x00},
+	{0x3801, 0x0c},
+	{0x3802, 0x00},
+	{0x3803, 0x04},
+	{0x3804, 0x0a},
+	{0x3805, 0x33},
+	{0x3806, 0x07},
+	{0x3807, 0xa3},
+	{0x3808, 0x0a},
+	{0x3809, 0x10},
+	{0x380a, 0x05},
+	{0x380b, 0xb0},
+	{0x380c, 0x06},
+	{0x380d, 0x90},
+	{0x380e, 0x08},
+	{0x380f, 0x14},
+	{0x3811, 0x04},
+	{0x3813, 0x02},
+	{0x3814, 0x01},
+	{0x3815, 0x01},
+	{0x3816, 0x00},
+	{0x3817, 0x00},
+	{0x3818, 0x00},
+	{0x3819, 0x00},
+	{0x3820, 0x84},
+	{0x3821, 0x40},
+	{0x3822, 0x48},
+	{0x3826, 0x00},
+	{0x3827, 0x08},
+	{0x382a, 0x01},
+	{0x382b, 0x01},
+	{0x3830, 0x08},
+	{0x3836, 0x02},
+	{0x3837, 0x00},
+	{0x3838, 0x10},
+	{0x3841, 0xff},
+	{0x3845, 0x01},
+	{0x3846, 0x48},
+	{0x3861, 0x00},
+	{0x3862, 0x04},
+	{0x3863, 0x06},
+	{0x3a11, 0x01},
+	{0x3a12, 0x78},
+	{0x3b00, 0x00},
+	{0x3b02, 0x00},
+	{0x3b03, 0x00},
+	{0x3b04, 0x00},
+	{0x3b05, 0x00},
+	{0x3c00, 0x89},
+	{0x3c01, 0xab},
+	{0x3c02, 0x01},
+	{0x3c03, 0x00},
+	{0x3c04, 0x00},
+	{0x3c05, 0x03},
+	{0x3c06, 0x00},
+	{0x3c07, 0x05},
+	{0x3c0c, 0x00},
+	{0x3c0d, 0x00},
+	{0x3c0e, 0x00},
+	{0x3c0f, 0x00},
+	{0x3c40, 0x00},
+	{0x3c41, 0xa3},
+	{0x3c43, 0x7d},
+	{0x3c45, 0xd7},
+	{0x3c47, 0xfc},
+	{0x3c50, 0x05},
+	{0x3c52, 0xaa},
+	{0x3c54, 0x71},
+	{0x3c56, 0x80},
+	{0x3d85, 0x17},
+	{0x3f03, 0x00},
+	{0x3f0a, 0x00},
+	{0x3f0b, 0x00},
+	{0x4001, 0x60},
+	{0x4009, 0x0d},
+	{0x4020, 0x00},
+	{0x4021, 0x00},
+	{0x4022, 0x00},
+	{0x4023, 0x00},
+	{0x4024, 0x00},
+	{0x4025, 0x00},
+	{0x4026, 0x00},
+	{0x4027, 0x00},
+	{0x4028, 0x00},
+	{0x4029, 0x00},
+	{0x402a, 0x00},
+	{0x402b, 0x00},
+	{0x402c, 0x00},
+	{0x402d, 0x00},
+	{0x402e, 0x00},
+	{0x402f, 0x00},
+	{0x4040, 0x00},
+	{0x4041, 0x03},
+	{0x4042, 0x00},
+	{0x4043, 0x7A},
+	{0x4044, 0x00},
+	{0x4045, 0x7A},
+	{0x4046, 0x00},
+	{0x4047, 0x7A},
+	{0x4048, 0x00},
+	{0x4049, 0x7A},
+	{0x4303, 0x00},
+	{0x4307, 0x30},
+	{0x4500, 0x58},
+	{0x4501, 0x04},
+	{0x4502, 0x40},
+	{0x4503, 0x10},
+	{0x4508, 0xaa},
+	{0x4509, 0xaa},
+	{0x450a, 0x00},
+	{0x450b, 0x00},
+	{0x4600, 0x01},
+	{0x4601, 0x00},
+	{0x4700, 0xa4},
+	{0x4800, 0x4c},
+	{0x4816, 0x53},
+	{0x481f, 0x40},
+	{0x4837, 0x12},
+	{0x5000, 0x56},
+	{0x5001, 0x01},
+	{0x5002, 0x28},
+	{0x5004, 0x0c},
+	{0x5006, 0x0c},
+	{0x5007, 0xe0},
+	{0x5008, 0x01},
+	{0x5009, 0xb0},
+	{0x5045, 0x05},
+	{0x5048, 0x10},
+	{0x5901, 0x00},
+	{0x5a01, 0x00},
+	{0x5a03, 0x00},
+	{0x5a04, 0x0c},
+	{0x5a05, 0xe0},
+	{0x5a06, 0x09},
+	{0x5a07, 0xb0},
+	{0x5a08, 0x06},
+	{0x5e00, 0x00},
+	{0x3734, 0x40},
+	{0x5b00, 0x01},
+	{0x5b01, 0x10},
+	{0x5b02, 0x01},
+	{0x5b03, 0xdb},
+	{0x3d8c, 0x71},
+	{0x3d8d, 0xea},
+	{0x4017, 0x08},
+	{0x3618, 0x2a},
+	{0x5780, 0x3e},
+	{0x5781, 0x0f},
+	{0x5782, 0x44},
+	{0x5783, 0x02},
+	{0x5784, 0x01},
+	{0x5785, 0x01},
+	{0x5786, 0x00},
+	{0x5787, 0x04},
+	{0x5788, 0x02},
+	{0x5789, 0x0f},
+	{0x578a, 0xfd},
+	{0x578b, 0xf5},
+	{0x578c, 0xf5},
+	{0x578d, 0x03},
+	{0x578e, 0x08},
+	{0x578f, 0x0c},
+	{0x5790, 0x08},
+	{0x5791, 0x06},
+	{0x5792, 0x00},
+	{0x5793, 0x52},
+	{0x5794, 0xa3},
+};
+
+static const struct ov5670_reg mode_2576x1936_regs[] = {
+	{0x3000, 0x00},
+	{0x3002, 0x61},
+	{0x3005, 0xf0},
+	{0x3007, 0x00},
+	{0x300D, 0x00},
+	{0x3010, 0x40},
+	{0x3015, 0x0f},
+	{0x3018, 0x32},
+	{0x301a, 0xf0},
+	{0x301b, 0xf0},
+	{0x301c, 0xf0},
+	{0x301d, 0xf0},
+	{0x301e, 0xf0},
+	{0x3030, 0x00},
+	{0x303c, 0xff},
+	{0x303e, 0xff},
+	{0x3040, 0xf0},
+	{0x3041, 0x00},
+	{0x3042, 0xf0},
+	{0x3106, 0x11},
+	{0x3500, 0x00},
+	{0x3501, 0xb8},
+	{0x3502, 0x80},
+	{0x3503, 0x00},
+	{0x3504, 0x03},
+	{0x3505, 0x83},
+	{0x3508, 0x04},
+	{0x3509, 0x00},
+	{0x350e, 0x04},
+	{0x350f, 0x00},
+	{0x3510, 0x00},
+	{0x3511, 0x02},
+	{0x3512, 0x00},
+	{0x3601, 0xc8},
+	{0x3610, 0xa8},
+	{0x3612, 0x48},
+	{0x3614, 0x5b},
+	{0x3615, 0x96},
+	{0x3621, 0xd0},
+	{0x3622, 0x00},
+	{0x3623, 0x00},
+	{0x3633, 0x13},
+	{0x3634, 0x13},
+	{0x3635, 0x13},
+	{0x3636, 0x13},
+	{0x3645, 0x13},
+	{0x3646, 0x82},
+	{0x3650, 0x00},
+	{0x3652, 0xff},
+	{0x3655, 0x20},
+	{0x3656, 0xff},
+	{0x365a, 0xff},
+	{0x365e, 0xff},
+	{0x3668, 0x00},
+	{0x366a, 0x07},
+	{0x366e, 0x10},
+	{0x366d, 0x00},
+	{0x366f, 0x80},
+	{0x3700, 0x28},
+	{0x3701, 0x10},
+	{0x3702, 0x3a},
+	{0x3703, 0x19},
+	{0x3704, 0x10},
+	{0x3705, 0x00},
+	{0x3706, 0x66},
+	{0x3707, 0x08},
+	{0x3708, 0x34},
+	{0x3709, 0x40},
+	{0x370a, 0x01},
+	{0x370b, 0x1b},
+	{0x3714, 0x24},
+	{0x371a, 0x3e},
+	{0x3733, 0x10},
+	{0x3734, 0x40},
+	{0x373a, 0x05},
+	{0x373b, 0x06},
+	{0x373c, 0x0a},
+	{0x373f, 0xa0},
+	{0x3755, 0x00},
+	{0x3758, 0x00},
+	{0x375b, 0x0e},
+	{0x3766, 0x5f},
+	{0x3768, 0x00},
+	{0x3769, 0x22},
+	{0x3773, 0x08},
+	{0x3774, 0x1f},
+	{0x3776, 0x06},
+	{0x37a0, 0x88},
+	{0x37a1, 0x5c},
+	{0x37a7, 0x88},
+	{0x37a8, 0x70},
+	{0x37aa, 0x88},
+	{0x37ab, 0x48},
+	{0x37b3, 0x66},
+	{0x37c2, 0x04},
+	{0x37c5, 0x00},
+	{0x37c8, 0x00},
+	{0x3800, 0x00},
+	{0x3801, 0x0c},
+	{0x3802, 0x00},
+	{0x3803, 0x04},
+	{0x3804, 0x0a},
+	{0x3805, 0x33},
+	{0x3806, 0x07},
+	{0x3807, 0xa3},
+	{0x3808, 0x0a},
+	{0x3809, 0x10},
+	{0x380a, 0x07},
+	{0x380b, 0x90},
+	{0x380c, 0x06},
+	{0x380d, 0x90},
+	{0x380e, 0x08},
+	{0x380f, 0x14},
+	{0x3811, 0x04},
+	{0x3813, 0x02},
+	{0x3814, 0x01},
+	{0x3815, 0x01},
+	{0x3816, 0x00},
+	{0x3817, 0x00},
+	{0x3818, 0x00},
+	{0x3819, 0x00},
+	{0x3820, 0x84},
+	{0x3821, 0x40},
+	{0x3822, 0x48},
+	{0x3826, 0x00},
+	{0x3827, 0x08},
+	{0x382a, 0x01},
+	{0x382b, 0x01},
+	{0x3830, 0x08},
+	{0x3836, 0x02},
+	{0x3837, 0x00},
+	{0x3838, 0x10},
+	{0x3841, 0xff},
+	{0x3845, 0x01},
+	{0x3846, 0x48},
+	{0x3861, 0x00},
+	{0x3862, 0x04},
+	{0x3863, 0x06},
+	{0x3a11, 0x01},
+	{0x3a12, 0x78},
+	{0x3b00, 0x00},
+	{0x3b02, 0x00},
+	{0x3b03, 0x00},
+	{0x3b04, 0x00},
+	{0x3b05, 0x00},
+	{0x3c00, 0x89},
+	{0x3c01, 0xab},
+	{0x3c02, 0x01},
+	{0x3c03, 0x00},
+	{0x3c04, 0x00},
+	{0x3c05, 0x03},
+	{0x3c06, 0x00},
+	{0x3c07, 0x05},
+	{0x3c0c, 0x00},
+	{0x3c0d, 0x00},
+	{0x3c0e, 0x00},
+	{0x3c0f, 0x00},
+	{0x3c40, 0x00},
+	{0x3c41, 0xa3},
+	{0x3c43, 0x7d},
+	{0x3c45, 0xd7},
+	{0x3c47, 0xfc},
+	{0x3c50, 0x05},
+	{0x3c52, 0xaa},
+	{0x3c54, 0x71},
+	{0x3c56, 0x80},
+	{0x3d85, 0x17},
+	{0x3f03, 0x00},
+	{0x3f0a, 0x00},
+	{0x3f0b, 0x00},
+	{0x4001, 0x60},
+	{0x4009, 0x0d},
+	{0x4020, 0x00},
+	{0x4021, 0x00},
+	{0x4022, 0x00},
+	{0x4023, 0x00},
+	{0x4024, 0x00},
+	{0x4025, 0x00},
+	{0x4026, 0x00},
+	{0x4027, 0x00},
+	{0x4028, 0x00},
+	{0x4029, 0x00},
+	{0x402a, 0x00},
+	{0x402b, 0x00},
+	{0x402c, 0x00},
+	{0x402d, 0x00},
+	{0x402e, 0x00},
+	{0x402f, 0x00},
+	{0x4040, 0x00},
+	{0x4041, 0x03},
+	{0x4042, 0x00},
+	{0x4043, 0x7A},
+	{0x4044, 0x00},
+	{0x4045, 0x7A},
+	{0x4046, 0x00},
+	{0x4047, 0x7A},
+	{0x4048, 0x00},
+	{0x4049, 0x7A},
+	{0x4303, 0x00},
+	{0x4307, 0x30},
+	{0x4500, 0x58},
+	{0x4501, 0x04},
+	{0x4502, 0x40},
+	{0x4503, 0x10},
+	{0x4508, 0xaa},
+	{0x4509, 0xaa},
+	{0x450a, 0x00},
+	{0x450b, 0x00},
+	{0x4600, 0x01},
+	{0x4601, 0x00},
+	{0x4700, 0xa4},
+	{0x4800, 0x4c},
+	{0x4816, 0x53},
+	{0x481f, 0x40},
+	{0x4837, 0x12},
+	{0x5000, 0x56},
+	{0x5001, 0x01},
+	{0x5002, 0x28},
+	{0x5004, 0x0c},
+	{0x5006, 0x0c},
+	{0x5007, 0xe0},
+	{0x5008, 0x01},
+	{0x5009, 0xb0},
+	{0x5045, 0x05},
+	{0x5048, 0x10},
+	{0x5901, 0x00},
+	{0x5a01, 0x00},
+	{0x5a03, 0x00},
+	{0x5a04, 0x0c},
+	{0x5a05, 0xe0},
+	{0x5a06, 0x09},
+	{0x5a07, 0xb0},
+	{0x5a08, 0x06},
+	{0x5e00, 0x00},
+	{0x3734, 0x40},
+	{0x5b00, 0x01},
+	{0x5b01, 0x10},
+	{0x5b02, 0x01},
+	{0x5b03, 0xdb},
+	{0x3d8c, 0x71},
+	{0x3d8d, 0xea},
+	{0x4017, 0x08},
+	{0x3618, 0x2a},
+	{0x5780, 0x3e},
+	{0x5781, 0x0f},
+	{0x5782, 0x44},
+	{0x5783, 0x02},
+	{0x5784, 0x01},
+	{0x5785, 0x01},
+	{0x5786, 0x00},
+	{0x5787, 0x04},
+	{0x5788, 0x02},
+	{0x5789, 0x0f},
+	{0x578a, 0xfd},
+	{0x578b, 0xf5},
+	{0x578c, 0xf5},
+	{0x578d, 0x03},
+	{0x578e, 0x08},
+	{0x578f, 0x0c},
+	{0x5790, 0x08},
+	{0x5791, 0x06},
+	{0x5792, 0x00},
+	{0x5793, 0x52},
+	{0x5794, 0xa3},
+};
+
+static const struct ov5670_link_freq_config link_freq_configs[] = {
+	{
+		.link_freq = OV5670_LINK_FREQ_840MBPS,
+		.pixel_rate = 336000000,
+		.reg_list = {
+			.num_of_regs = ARRAY_SIZE(mipi_data_rate_840mbps),
+			.regs = mipi_data_rate_840mbps,
+		}
+	}
+};
+
+static const struct ov5670_mode supported_modes[] = {
+	{
+		.width = 2576,
+		.height = 1936,
+		.skip_frames = 2,
+		.reg_list = {
+			.num_of_regs = ARRAY_SIZE(mode_2576x1936_regs),
+			.regs = mode_2576x1936_regs,
+		},
+		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
+	},
+	{
+		.width = 2576,
+		.height = 1456,
+		.skip_frames = 2,
+		.reg_list = {
+			.num_of_regs = ARRAY_SIZE(mode_2576x1456_regs),
+			.regs = mode_2576x1456_regs,
+		},
+		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
+	},
+	{
+		.width = 2560,
+		.height = 1440,
+		.skip_frames = 2,
+		.reg_list = {
+			.num_of_regs = ARRAY_SIZE(mode_2560x1440_regs),
+			.regs = mode_2560x1440_regs,
+		},
+		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
+	},
+	{
+		.width = 1936,
+		.height = 1096,
+		.skip_frames = 2,
+		.reg_list = {
+			.num_of_regs = ARRAY_SIZE(mode_1936x1096_regs),
+			.regs = mode_1936x1096_regs,
+		},
+		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
+	},
+	{
+		.width = 1920,
+		.height = 1080,
+		.skip_frames = 2,
+		.reg_list = {
+			.num_of_regs = ARRAY_SIZE(mode_1920x1080_regs),
+			.regs = mode_1920x1080_regs,
+		},
+		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
+	},
+	{
+		.width = 1440,
+		.height = 1080,
+		.skip_frames = 2,
+		.reg_list = {
+			.num_of_regs = ARRAY_SIZE(mode_1440x1080_regs),
+			.regs = mode_1440x1080_regs,
+		},
+		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
+	},
+	{
+		.width = 1296,
+		.height = 736,
+		.skip_frames = 2,
+		.reg_list = {
+			.num_of_regs = ARRAY_SIZE(mode_1296x736_regs),
+			.regs = mode_1296x736_regs,
+		},
+		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
+	},
+	{
+		.width = 1280,
+		.height = 720,
+		.skip_frames = 2,
+		.reg_list = {
+			.num_of_regs = ARRAY_SIZE(mode_1280x720_regs),
+			.regs = mode_1280x720_regs,
+		},
+		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
+	},
+	{
+		.width = 960,
+		.height = 720,
+		.skip_frames = 2,
+		.reg_list = {
+			.num_of_regs = ARRAY_SIZE(mode_960x720_regs),
+			.regs = mode_960x720_regs,
+		},
+		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
+	},
+	{
+		.width = 656,
+		.height = 496,
+		.skip_frames = 2,
+		.reg_list = {
+			.num_of_regs = ARRAY_SIZE(mode_656x496_regs),
+			.regs = mode_656x496_regs,
+		},
+		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
+	},
+	{
+		.width = 640,
+		.height = 480,
+		.skip_frames = 2,
+		.reg_list = {
+			.num_of_regs = ARRAY_SIZE(mode_640x480_regs),
+			.regs = mode_640x480_regs,
+		},
+		.link_freq_index = OV5670_LINK_FREQ_840MBPS_INDEX,
+	},
+};
+
+static const s64 link_freq_menu_items[] = {
+					OV5670_LINK_FREQ_840MBPS
+				};
+
+struct ov5670 {
+	struct v4l2_subdev sd;
+	struct media_pad pad;
+
+	struct v4l2_ctrl_handler ctrl_handler;
+	struct {
+		struct v4l2_ctrl *link_freq;
+		struct v4l2_ctrl *pixel_rate;
+	};
+
+	/* Current mode */
+	const struct ov5670_mode *cur_mode;
+
+	/* To protect from asynchronus callbacks */
+	struct mutex mutex;
+
+	int link_freq_index;
+
+	bool streaming;
+};
+
+#define to_ov5670(_sd)	container_of(_sd, struct ov5670, sd)
+
+/* Read registers up to 4 at a time */
+static int ov5670_read_reg(struct ov5670 *ov5670, u16 reg, u32 len, u32 *val)
+{
+	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
+	struct i2c_msg msgs[2];
+	u8 *data_be_p;
+	u32 data_be = 0;
+	u16 reg_addr_be = cpu_to_be16(reg);
+
+	if (len > 4)
+		return -EINVAL;
+
+	data_be_p = (u8 *)&data_be;
+	/* Write register address */
+	msgs[0].addr = client->addr;
+	msgs[0].flags = 0;
+	msgs[0].len = 2;
+	msgs[0].buf = (u8 *)&reg_addr_be;
+
+	/* Read data from register */
+	msgs[1].addr = client->addr;
+	msgs[1].flags = I2C_M_RD;
+	msgs[1].len = len;
+	msgs[1].buf = &data_be_p[4 - len];
+
+	if (i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs)) !=
+			 ARRAY_SIZE(msgs))
+		return -EIO;
+
+	*val = be32_to_cpu(data_be);
+
+	return 0;
+}
+
+/* Write registers up to 4 at a time */
+static int ov5670_write_reg(struct ov5670 *ov5670, u16 reg, u32 len, u32 val)
+{
+	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
+	int buf_i;
+	int val_i;
+	u8 buf[6];
+	u8 *val_p;
+
+	if (len > 4)
+		return -EINVAL;
+
+	buf[0] = reg >> 8;
+	buf[1] = reg & 0xff;
+
+	buf_i = 2;
+	val_p = (u8 *)&val;
+	for (val_i = len - 1; val_i >= 0; val_i--, buf_i++)
+		buf[buf_i] = val_p[val_i];
+
+	if (i2c_master_send(client, buf, len + 2) != len + 2)
+		return -EIO;
+
+	return 0;
+}
+
+/* Write a list of registers */
+static int ov5670_write_regs(struct ov5670 *ov5670,
+			     const struct ov5670_reg *regs,
+			     int len)
+{
+	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
+	int i;
+	int ret;
+
+	for (i = 0; i < len; i++) {
+		ret = ov5670_write_reg(ov5670, regs[i].address, 1, regs[i].val);
+		if (ret) {
+			dev_err_ratelimited(
+				&client->dev,
+				"Failed to write reg 0x%4.4x. error = %d\n",
+				regs[i].address, ret);
+
+			return ret;
+		}
+	}
+
+	return 0;
+}
+
+static int ov5670_write_reg_list(struct ov5670 *ov5670,
+				 const struct ov5670_reg_list *r_list)
+{
+	return ov5670_write_regs(ov5670, r_list->regs, r_list->num_of_regs);
+}
+
+/* Open sub-device */
+static int ov5670_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
+{
+	struct ov5670 *ov5670 = to_ov5670(sd);
+	struct v4l2_mbus_framefmt *try_fmt;
+
+	mutex_lock(&ov5670->mutex);
+
+	/* Initialize try_fmt */
+	try_fmt = v4l2_subdev_get_try_format(sd, fh->pad, 0);
+	try_fmt->width = ov5670->cur_mode->width;
+	try_fmt->height = ov5670->cur_mode->height;
+	try_fmt->code = MEDIA_BUS_FMT_SGRBG10_1X10;
+	try_fmt->field = V4L2_FIELD_NONE;
+
+	/* No crop or compose */
+	mutex_unlock(&ov5670->mutex);
+
+	return 0;
+}
+
+/* Update analog gain */
+static int ov5670_update_analog_gain(struct ov5670 *ov5670,
+				     struct v4l2_ctrl *ctrl)
+{
+	u32 analog_gain;
+
+	analog_gain = ctrl->val;
+
+	return ov5670_write_reg(ov5670, OV5670_REG_ANALOG_GAIN,
+				OV5670_REG_VALUE_16BIT, analog_gain);
+}
+
+/* Exposure control */
+static int ov5670_update_exposure_ctrl(struct ov5670 *ov5670,
+				       struct v4l2_ctrl *ctrl)
+{
+	u32 exposure;
+
+	exposure = ctrl->val;
+
+	return ov5670_write_reg(ov5670, OV5670_REG_EXPOSURE,
+				OV5670_REG_VALUE_24BIT, exposure);
+}
+
+/* Get volatile controls */
+static int ov5670_g_volatile_ctrl(struct v4l2_ctrl *ctrl)
+{
+	struct ov5670 *ov5670 = container_of(ctrl->handler,
+					struct ov5670, ctrl_handler);
+	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
+	int link_freq_index;
+	int ret = 0;
+
+	link_freq_index = ov5670->cur_mode->link_freq_index;
+
+	switch (ctrl->id) {
+	case V4L2_CID_LINK_FREQ:
+		ctrl->val = link_freq_index;
+		break;
+	case V4L2_CID_PIXEL_RATE:
+		ctrl->val = link_freq_configs[link_freq_index].pixel_rate;
+		break;
+	default:
+		dev_info(&client->dev, "unknown control 0x%x\n", ctrl->id);
+		ret = -EINVAL;
+	}
+
+	dev_dbg(&client->dev, "%s id:0x%x val:0x%x\n", __func__, ctrl->id,
+		ctrl->val);
+	return ret;
+}
+
+/* Initialize control handlers */
+static int ov5670_set_ctrl(struct v4l2_ctrl *ctrl)
+{
+	struct ov5670 *ov5670 = container_of(ctrl->handler,
+						struct ov5670, ctrl_handler);
+	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
+
+	dev_dbg(&client->dev, "%s id:0x%x val:0x%x\n", __func__, ctrl->id,
+		ctrl->val);
+
+	switch (ctrl->id) {
+	case V4L2_CID_ANALOGUE_GAIN:
+		return ov5670_update_analog_gain(ov5670, ctrl);
+	case V4L2_CID_EXPOSURE:
+		return ov5670_update_exposure_ctrl(ov5670, ctrl);
+	case V4L2_CID_LINK_FREQ:
+		break;
+	default:
+		dev_info(&client->dev, "id:0x%x, val:0x%x\n", ctrl->id,
+			 ctrl->val);
+		return 0;
+	};
+
+	return 0;
+}
+
+static const struct v4l2_ctrl_ops ov5670_ctrl_ops = {
+	.g_volatile_ctrl = ov5670_g_volatile_ctrl,
+	.s_ctrl = ov5670_set_ctrl,
+};
+
+/* Initialize control handlers */
+static int ov5670_init_controls(struct ov5670 *ov5670)
+{
+	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
+	struct v4l2_ctrl_handler *ctrl_hdlr;
+	int ret;
+
+	ctrl_hdlr = &ov5670->ctrl_handler;
+	ret = v4l2_ctrl_handler_init(ctrl_hdlr, 4);
+	if (ret)
+		return ret;
+
+	ctrl_hdlr->lock = &ov5670->mutex;
+	ov5670->link_freq = v4l2_ctrl_new_int_menu(ctrl_hdlr,
+				&ov5670_ctrl_ops,
+				V4L2_CID_LINK_FREQ, 1,
+				ARRAY_SIZE(link_freq_menu_items) - 1,
+				link_freq_menu_items);
+	ov5670->link_freq->flags |= V4L2_CTRL_FLAG_VOLATILE;
+
+	ov5670->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov5670_ctrl_ops,
+					V4L2_CID_PIXEL_RATE, 0,
+					OV5670_LINK_FREQ_840MBPS, 1,
+					link_freq_configs[0].pixel_rate);
+	v4l2_ctrl_cluster(2, &ov5670->link_freq);
+
+	/* Get min, max, step, default from sensor */
+	v4l2_ctrl_new_std(ctrl_hdlr, &ov5670_ctrl_ops, V4L2_CID_ANALOGUE_GAIN,
+			  ANALOG_GAIN_MIN, ANALOG_GAIN_MAX, ANALOG_GAIN_STEP,
+			  ANALOG_GAIN_DEFAULT);
+
+	/* Get min, max, step, default from sensor */
+	v4l2_ctrl_new_std(ctrl_hdlr, &ov5670_ctrl_ops, V4L2_CID_EXPOSURE,
+			  EXPOSURE_MIN, EXPOSURE_MAX, EXPOSURE_STEP,
+			  EXPOSURE_DEFAULT);
+
+	if (ctrl_hdlr->error) {
+		ret = ctrl_hdlr->error;
+		dev_err(&client->dev, "%s control init failed (%d)\n", __func__,
+			ret);
+		goto error;
+	}
+
+	ov5670->sd.ctrl_handler = ctrl_hdlr;
+
+	return 0;
+
+error:
+	v4l2_ctrl_handler_free(ctrl_hdlr);
+
+	return ret;
+}
+
+static void ov5670_update_pad_format(struct ov5670 *ov5670,
+				     const struct ov5670_mode *mode,
+				     struct v4l2_subdev_format *fmt)
+{
+	fmt->format.width = mode->width;
+	fmt->format.height = mode->height;
+	fmt->format.code = MEDIA_BUS_FMT_SGRBG10_1X10;
+	fmt->format.field = V4L2_FIELD_NONE;
+}
+
+static int ov5670_do_get_pad_format(struct ov5670 *ov5670,
+				    struct v4l2_subdev_pad_config *cfg,
+				    struct v4l2_subdev_format *fmt)
+{
+	struct v4l2_mbus_framefmt *framefmt;
+	struct v4l2_subdev *sd = &ov5670->sd;
+
+	if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
+		framefmt = v4l2_subdev_get_try_format(sd, cfg, fmt->pad);
+		fmt->format = *framefmt;
+	} else {
+		ov5670_update_pad_format(ov5670, ov5670->cur_mode, fmt);
+	}
+
+	return 0;
+}
+
+static int ov5670_enum_mbus_code(struct v4l2_subdev *sd,
+				 struct v4l2_subdev_pad_config *cfg,
+				 struct v4l2_subdev_mbus_code_enum *code)
+{
+	/* Only one bayer order GRBG is supported */
+	if (code->index > 0)
+		return -EINVAL;
+
+	code->code = MEDIA_BUS_FMT_SGRBG10_1X10;
+	return 0;
+}
+
+static int ov5670_enum_frame_size(struct v4l2_subdev *sd,
+				  struct v4l2_subdev_pad_config *cfg,
+				  struct v4l2_subdev_frame_size_enum *fse)
+{
+	if (fse->index >= ARRAY_SIZE(supported_modes))
+		return -EINVAL;
+
+	if (fse->code != MEDIA_BUS_FMT_SGRBG10_1X10)
+		return -EINVAL;
+
+	fse->min_width = supported_modes[fse->index].width;
+	fse->max_width = fse->min_width;
+	fse->min_height = supported_modes[fse->index].height;
+	fse->max_height = fse->min_height;
+
+	return 0;
+}
+
+static int ov5670_get_pad_format(struct v4l2_subdev *sd,
+				 struct v4l2_subdev_pad_config *cfg,
+				 struct v4l2_subdev_format *fmt)
+{
+	struct ov5670 *ov5670 = to_ov5670(sd);
+	int ret;
+
+	mutex_lock(&ov5670->mutex);
+	ret = ov5670_do_get_pad_format(ov5670, cfg, fmt);
+	mutex_unlock(&ov5670->mutex);
+
+	return ret;
+}
+
+/* Calculate resolution distance */
+static int ov5670_get_reso_dist(const struct ov5670_mode *mode,
+				struct v4l2_mbus_framefmt *framefmt)
+{
+	return abs(mode->width - framefmt->width) +
+	       abs(mode->height - framefmt->height);
+}
+
+/* Find the closest supported resolution to the requested resolution */
+static const struct ov5670_mode *ov5670_find_best_fit(
+						struct ov5670 *ov5670,
+						struct v4l2_subdev_format *fmt)
+{
+	struct v4l2_mbus_framefmt *framefmt = &fmt->format;
+	int dist;
+	int cur_best_fit = 0;
+	int cur_best_fit_dist = -1;
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(supported_modes); i++) {
+		dist = ov5670_get_reso_dist(&supported_modes[i], framefmt);
+		if (cur_best_fit_dist == -1 || dist < cur_best_fit_dist) {
+			cur_best_fit_dist = dist;
+			cur_best_fit = i;
+		}
+	}
+
+	return &supported_modes[cur_best_fit];
+}
+
+static int ov5670_set_pad_format(struct v4l2_subdev *sd,
+				 struct v4l2_subdev_pad_config *cfg,
+				 struct v4l2_subdev_format *fmt)
+{
+	struct ov5670 *ov5670 = to_ov5670(sd);
+	struct i2c_client *client = v4l2_get_subdevdata(sd);
+	const struct ov5670_mode *mode;
+	struct v4l2_mbus_framefmt *framefmt;
+
+	dev_dbg(&client->dev, "%s sd_name: %s pad: %d w: %d, h: %d code: 0x%x",
+		__func__, sd->name, fmt->pad, fmt->format.width,
+		fmt->format.height, fmt->format.code);
+
+	mutex_lock(&ov5670->mutex);
+
+	if (fmt->format.code != MEDIA_BUS_FMT_SGRBG10_1X10) {
+		mutex_unlock(&ov5670->mutex);
+		return -EINVAL;
+	}
+
+	mode = ov5670_find_best_fit(ov5670, fmt);
+	ov5670_update_pad_format(ov5670, mode, fmt);
+	if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
+		framefmt = v4l2_subdev_get_try_format(sd, cfg, fmt->pad);
+		*framefmt = fmt->format;
+	} else {
+		ov5670->cur_mode = mode;
+	}
+
+	mutex_unlock(&ov5670->mutex);
+
+	return 0;
+}
+
+static int ov5670_get_skip_frames(struct v4l2_subdev *sd, u32 *frames)
+{
+	struct ov5670 *ov5670 = to_ov5670(sd);
+
+	mutex_lock(&ov5670->mutex);
+	*frames = ov5670->cur_mode->skip_frames;
+	mutex_unlock(&ov5670->mutex);
+
+	return 0;
+}
+
+/* Prepare streaming by writing default values and customized values */
+static int ov5670_prepare_streaming(struct ov5670 *ov5670)
+{
+	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
+	const struct ov5670_reg_list *reg_list;
+	int link_freq_index;
+	int ret;
+
+	/* Write the power up registers */
+	ret = ov5670_write_reg(ov5670, OV5670_REG_SOFTWARE_RST,
+			       OV5670_REG_VALUE_08BIT, OV5670_SOFTWARE_RST);
+	if (ret) {
+		dev_err(&client->dev, "%s failed to set powerup registers\n",
+			__func__);
+		return ret;
+	}
+
+	/* Write pll registers */
+	link_freq_index = ov5670->cur_mode->link_freq_index;
+	reg_list = &link_freq_configs[link_freq_index].reg_list;
+	ret = ov5670_write_reg_list(ov5670, reg_list);
+	if (ret) {
+		dev_err(&client->dev, "%s failed to set plls\n", __func__);
+		return ret;
+	}
+
+	/* Write the default values of current mode */
+	reg_list = &ov5670->cur_mode->reg_list;
+	ret = ov5670_write_reg_list(ov5670, reg_list);
+	if (ret) {
+		dev_err(&client->dev, "%s failed to set mode\n", __func__);
+		return ret;
+	}
+
+	dev_dbg(&client->dev, "%s init v4l2 controls", __func__);
+
+	ret = v4l2_ctrl_handler_setup(ov5670->sd.ctrl_handler);
+	if (ret) {
+		dev_err(&client->dev, "%s v4l2_ctrl_handler failed\n",
+			__func__);
+		return ret;
+	}
+
+	return 0;
+}
+
+static int ov5670_start_streaming(struct ov5670 *ov5670)
+{
+	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
+	int ret;
+
+	/* Write stream on list */
+	ret = ov5670_write_reg(ov5670, OV5670_REG_MODE_SELECT,
+			       OV5670_REG_VALUE_08BIT, OV5670_MODE_STREAMING);
+	if (ret) {
+		dev_err(&client->dev, "%s failed to set stream\n", __func__);
+		return ret;
+	}
+
+	ov5670->streaming = 1;
+	return 0;
+}
+
+static int ov5670_stop_streaming(struct ov5670 *ov5670)
+{
+	struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);
+	int ret;
+
+	ret = ov5670_write_reg(ov5670, OV5670_REG_MODE_SELECT,
+			       OV5670_REG_VALUE_08BIT, OV5670_MODE_STANDBY);
+	if (ret) {
+		dev_err(&client->dev, "%s failed to set stream\n", __func__);
+		return ret;
+	}
+	ov5670->streaming = 0;
+	return ret;
+}
+
+static int ov5670_set_stream(struct v4l2_subdev *sd, int enable)
+{
+	struct ov5670 *ov5670 = to_ov5670(sd);
+	int ret = 0;
+
+	mutex_lock(&ov5670->mutex);
+	if (ov5670->streaming == enable) {
+		mutex_unlock(&ov5670->mutex);
+		return 0;
+	}
+	mutex_unlock(&ov5670->mutex);
+
+	if (enable) {
+		ret = ov5670_prepare_streaming(ov5670);
+		if (ret)
+			return ret;
+
+		mutex_lock(&ov5670->mutex);
+		ret = ov5670_start_streaming(ov5670);
+		mutex_unlock(&ov5670->mutex);
+	} else {
+		mutex_lock(&ov5670->mutex);
+		ret = ov5670_stop_streaming(ov5670);
+		mutex_unlock(&ov5670->mutex);
+	}
+
+	return ret;
+}
+
+#ifdef CONFIG_PM
+
+static int ov5670_suspend(struct device *dev)
+{
+	struct i2c_client *client = to_i2c_client(dev);
+	struct v4l2_subdev *sd = i2c_get_clientdata(client);
+	struct ov5670 *ov5670 = to_ov5670(sd);
+
+	if (ov5670->streaming)
+		ov5670_stop_streaming(ov5670);
+
+	return 0;
+}
+
+static int ov5670_resume(struct device *dev)
+{
+	struct i2c_client *client = to_i2c_client(dev);
+	struct v4l2_subdev *sd = i2c_get_clientdata(client);
+	struct ov5670 *ov5670 = to_ov5670(sd);
+	int ret;
+
+	if (ov5670->streaming) {
+		ret = ov5670_prepare_streaming(ov5670);
+		if (ret)
+			goto error_prepare;
+		ret = ov5670_start_streaming(ov5670);
+		if (ret)
+			goto error_prepare;
+	}
+
+	return 0;
+
+error_prepare:
+	ov5670_stop_streaming(ov5670);
+	return ret;
+}
+
+#else
+
+#define ov5670_suspend	NULL
+#define ov5670_resume	NULL
+
+#endif	/* CONFIG_PM */
+
+static int ov5670_identify_module(struct ov5670 *ov5670,
+				  struct i2c_client *client)
+{
+	int ret;
+	u32 val;
+
+	ret = ov5670_read_reg(ov5670, OV5670_REG_CHIPID,
+			      OV5670_REG_VALUE_24BIT, &val);
+	if (ret)
+		return ret;
+
+	if (val != OV5670_CHIP_ID) {
+		dev_err(&client->dev, "Unknown sensor(0x%x) detected\n", val);
+		return -ENOTTY;
+	}
+
+	return 0;
+}
+
+static const struct v4l2_subdev_video_ops ov5670_video_ops = {
+	.s_stream = ov5670_set_stream,
+};
+
+static const struct v4l2_subdev_pad_ops ov5670_pad_ops = {
+	.enum_mbus_code = ov5670_enum_mbus_code,
+	.get_fmt = ov5670_get_pad_format,
+	.set_fmt = ov5670_set_pad_format,
+	.enum_frame_size = ov5670_enum_frame_size,
+};
+
+static const struct v4l2_subdev_sensor_ops ov5670_sensor_ops = {
+	.g_skip_frames = ov5670_get_skip_frames,
+};
+
+static const struct v4l2_subdev_ops ov5670_subdev_ops = {
+	.video = &ov5670_video_ops,
+	.pad = &ov5670_pad_ops,
+	.sensor = &ov5670_sensor_ops,
+};
+
+static const struct media_entity_operations ov5670_subdev_entity_ops = {
+	.link_validate = v4l2_subdev_link_validate,
+};
+
+static const struct v4l2_subdev_internal_ops ov5670_internal_ops = {
+	.open = ov5670_open,
+};
+
+static int ov5670_probe(struct i2c_client *client,
+			const struct i2c_device_id *devid)
+{
+	struct ov5670 *ov5670;
+	int ret;
+
+	ov5670 = devm_kzalloc(&client->dev, sizeof(*ov5670), GFP_KERNEL);
+	if (!ov5670)
+		return -ENOMEM;
+
+	/* Initialize subdev */
+	v4l2_i2c_subdev_init(&ov5670->sd, client, &ov5670_subdev_ops);
+
+	/* Check module identity */
+	ret = ov5670_identify_module(ov5670, client);
+	if (ret)
+		return ret;
+
+	mutex_init(&ov5670->mutex);
+
+	/* Set default mode to max resolution */
+	ov5670->cur_mode = &supported_modes[0];
+
+	ret = ov5670_init_controls(ov5670);
+	if (ret)
+		return ret;
+
+	ov5670->sd.internal_ops = &ov5670_internal_ops;
+	ov5670->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
+	ov5670->sd.entity.ops = &ov5670_subdev_entity_ops;
+	ov5670->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
+
+	/* Source pad initialization */
+	ov5670->pad.flags = MEDIA_PAD_FL_SOURCE;
+	ret = media_entity_pads_init(&ov5670->sd.entity, 1, &ov5670->pad);
+	if (ret) {
+		dev_err(&client->dev, "%s failed:%d\n", __func__, ret);
+		goto error_handler_free;
+	}
+
+	/* Async register for subdev */
+	ret = v4l2_async_register_subdev(&ov5670->sd);
+	if (ret < 0)
+		goto error_entity_cleanup;
+
+	ov5670->streaming = 0;
+	dev_info(&client->dev, "%s done\n", __func__);
+
+	return 0;
+
+error_entity_cleanup:
+	media_entity_cleanup(&ov5670->sd.entity);
+
+error_handler_free:
+	v4l2_ctrl_handler_free(ov5670->sd.ctrl_handler);
+
+	dev_err(&client->dev, "%s failed:%d\n", __func__, ret);
+	return ret;
+}
+
+static int ov5670_remove(struct i2c_client *client)
+{
+	struct v4l2_subdev *sd = i2c_get_clientdata(client);
+
+	v4l2_async_unregister_subdev(sd);
+	media_entity_cleanup(&sd->entity);
+	v4l2_ctrl_handler_free(sd->ctrl_handler);
+
+	return 0;
+}
+
+static const struct i2c_device_id ov5670_id_table[] = {
+	{"ov5670", 0},
+	{},
+};
+
+MODULE_DEVICE_TABLE(i2c, ov5670_id_table);
+
+static const struct dev_pm_ops ov5670_pm_ops = {
+	.suspend = ov5670_suspend,
+	.resume = ov5670_resume,
+};
+
+#ifdef CONFIG_ACPI
+const struct acpi_device_id ov5670_acpi_ids[] = {
+	{"INT3479"},
+	{ /* sentinel */ }
+};
+
+MODULE_DEVICE_TABLE(acpi, ov5670_acpi_ids);
+#endif
+
+static struct i2c_driver ov5670_i2c_driver = {
+	.driver = {
+		.name = "ov5670",
+		.owner = THIS_MODULE,
+		.pm = &ov5670_pm_ops,
+		.acpi_match_table = ACPI_PTR(ov5670_acpi_ids),
+	},
+	.probe = ov5670_probe,
+	.remove = ov5670_remove,
+	.id_table = ov5670_id_table,
+};
+
+module_i2c_driver(ov5670_i2c_driver);
+
+MODULE_AUTHOR("Rapolu, Chiranjeevi <[e-mail]>");
+MODULE_AUTHOR("Yang, Hyungwoo <[e-mail]>");
+MODULE_AUTHOR("Pu, Yuning <[e-mail]>");
+MODULE_DESCRIPTION("Omnivision ov5670 sensor driver");
+MODULE_LICENSE("GPL");