From patchwork Mon Jul 3 09:16:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugues FRUCHET X-Patchwork-Id: 9822339 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6B93660246 for ; Mon, 3 Jul 2017 09:20:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5CB192853F for ; Mon, 3 Jul 2017 09:20:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4EACC2854A; Mon, 3 Jul 2017 09:20:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CD7BE2853F for ; Mon, 3 Jul 2017 09:20:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753784AbdGCJSh (ORCPT ); Mon, 3 Jul 2017 05:18:37 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:55621 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753238AbdGCJRC (ORCPT ); Mon, 3 Jul 2017 05:17:02 -0400 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v63913mE015212; Mon, 3 Jul 2017 11:16:32 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-.pphosted.com with ESMTP id 2be2mbtm6v-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 03 Jul 2017 11:16:31 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A86063D; Mon, 3 Jul 2017 09:16:30 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas23.st.com [10.75.90.46]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C19A713AA; Mon, 3 Jul 2017 09:16:29 +0000 (GMT) Received: from localhost (10.201.23.73) by webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.339.0; Mon, 3 Jul 2017 11:16:29 +0200 From: Hugues Fruchet To: Sylwester Nawrocki , " H. Nikolaus Schaller" , Guennadi Liakhovetski , Rob Herring , Mark Rutland , Maxime Coquelin , Alexandre Torgue , Mauro Carvalho Chehab , Hans Verkuil CC: , , , , Benjamin Gaignard , Yannick Fertre , Hugues Fruchet Subject: [PATCH v2 7/7] [media] ov9650: add analog power supply and clock gating Date: Mon, 3 Jul 2017 11:16:08 +0200 Message-ID: <1499073368-31905-8-git-send-email-hugues.fruchet@st.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1499073368-31905-1-git-send-email-hugues.fruchet@st.com> References: <1499073368-31905-1-git-send-email-hugues.fruchet@st.com> MIME-Version: 1.0 X-Originating-IP: [10.201.23.73] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-07-03_04:, , signatures=0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add optional analog power supply and clock gating. Signed-off-by: H. Nikolaus Schaller Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov9650.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c index 9ff0782..56b1eb3 100644 --- a/drivers/media/i2c/ov9650.c +++ b/drivers/media/i2c/ov9650.c @@ -29,6 +29,7 @@ #include #include #include +#include #include #include #include @@ -374,6 +375,7 @@ struct ov965x { /* External master clock frequency */ unsigned long mclk_frequency; struct clk *clk; + struct regulator *avdd; /* Protects the struct fields below */ struct mutex lock; @@ -943,13 +945,31 @@ static void ov965x_gpio_set(struct gpio_desc *gpio, int val) static void __ov965x_set_power(struct ov965x *ov965x, int on) { + int ret; + if (on) { + /* Bring up the power supply */ + ret = regulator_enable(ov965x->avdd); + if (ret) + dev_warn(&ov965x->client->dev, + "Failed to enable analog power (%d)\n", ret); + msleep(25); + /* Enable clock */ + ret = clk_prepare_enable(ov965x->clk); + if (ret) + dev_warn(&ov965x->client->dev, + "Failed to enable clock (%d)\n", ret); + msleep(25); + ov965x_gpio_set(ov965x->gpios[GPIO_PWDN], 0); ov965x_gpio_set(ov965x->gpios[GPIO_RST], 0); msleep(25); } else { ov965x_gpio_set(ov965x->gpios[GPIO_RST], 1); ov965x_gpio_set(ov965x->gpios[GPIO_PWDN], 1); + + clk_disable_unprepare(ov965x->clk); + regulator_disable(ov965x->avdd); } ov965x->streaming = 0; @@ -1969,6 +1989,12 @@ static int ov965x_probe(struct i2c_client *client, devm_gpiod_get_optional(&client->dev, "pwdn", GPIOD_OUT_HIGH); + ov965x->avdd = devm_regulator_get(&client->dev, "avdd"); + if (IS_ERR(ov965x->avdd)) { + dev_err(&client->dev, "Could not get analog regulator\n"); + return PTR_ERR(ov965x->avdd); + } + ov965x->clk = devm_clk_get(&client->dev, NULL); if (IS_ERR(ov965x->clk)) { dev_err(&client->dev, "Could not get clock\n");