From patchwork Wed Jul 19 03:34:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 9850447 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 87F0C60393 for ; Wed, 19 Jul 2017 03:34:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3AD701FF81 for ; Wed, 19 Jul 2017 03:34:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B8A21FF4D; Wed, 19 Jul 2017 03:34:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9DE72285FF for ; Wed, 19 Jul 2017 03:34:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752045AbdGSDet (ORCPT ); Tue, 18 Jul 2017 23:34:49 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:34491 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdGSDes (ORCPT ); Tue, 18 Jul 2017 23:34:48 -0400 Received: by mail-qk0-f195.google.com with SMTP id q66so4860020qki.1 for ; Tue, 18 Jul 2017 20:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=yg8vn2t/w5lDGgeuGaFRtA+wrYRjafLlVpafWp8gIYE=; b=cl8yyGjN7iE+I81/T8bRLh/MWtfIsfjpoAiwnoBkT52VdxMIr0XcH5zoWhTjrErg93 okN3xpcW+9ZItn45zPBrSappptur8ydXQJtE57rK6Ye3d8HD0seeZA49oR2wPxAk2GHl FfXouP+wwuk8VOBNQFKh0JJN7SXkI6vAsgP5UoKki/qT4dG4bg6ifm9ZAErdS0DK+8z6 nmnZH1FSSB5uGAAjwd3xLbbvn/o6KwQa6OS1//mZHDK7VKxI35GXaSGUg+J7uEIlAWSe PS2d5ve0Lt9FahDloqISfO+jCP+m2Pf+y7TI+uOvMIeGqy57YDsqi7ovULTJYrR5S6/i pXEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yg8vn2t/w5lDGgeuGaFRtA+wrYRjafLlVpafWp8gIYE=; b=OPeuUYnStYZJkRMVcuaQ8Bu0INuRhjeAUloBj65A+DQ86osoZhr+Wf5OKH/NbvBaWd XmeGR91MZ6VvVoh1TegGp6jcNR+vQu99TPbq49PfX/gYaIrBE8e8a45MvOfbNeDhpD/F 4W+4dh88Ms371G3LswWH3xbXnkYFDeqfjFWk19/Jawyk2QlnOGwte9opBpgXTGENpf8e WI5yeOyGaYDM9H2sH7plG4ki2umqC1mB+a5c7RkpXcEEg9B7P2e+Z4dDaSONGzolI9yN uo7iD2mui3iT+3qfHco6eSGK6XAUIrGcSJHTCImPGjUl4r6V20XfKAxLErUokKtoc6rD qjcA== X-Gm-Message-State: AIVw112mmUs+R9Nwh2rJn58st9UMnRQvLB0MV526FB0lD6d44bk6ZRjX iOu/4YWPL9d3hT00 X-Received: by 10.55.96.6 with SMTP id u6mr936510qkb.104.1500435288007; Tue, 18 Jul 2017 20:34:48 -0700 (PDT) Received: from localhost.localdomain ([189.61.213.245]) by smtp.gmail.com with ESMTPSA id u67sm2963376qkd.67.2017.07.18.20.34.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 18 Jul 2017 20:34:47 -0700 (PDT) From: Fabio Estevam To: mchehab@s-opensource.com Cc: hans.verkuil@cisco.com, corbet@lwn.net, linux-media@vger.kernel.org, Fabio Estevam Subject: [PATCH 1/2] [media] ov7670: Return the real error code Date: Wed, 19 Jul 2017 00:34:18 -0300 Message-Id: <1500435259-5838-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam When devm_clk_get() fails the real error code should be propagated, instead of always returning -EPROBE_DEFER. Signed-off-by: Fabio Estevam --- drivers/media/i2c/ov7670.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 7270c68..552a881 100644 --- a/drivers/media/i2c/ov7670.c +++ b/drivers/media/i2c/ov7670.c @@ -1614,7 +1614,7 @@ static int ov7670_probe(struct i2c_client *client, info->clk = devm_clk_get(&client->dev, "xclk"); if (IS_ERR(info->clk)) - return -EPROBE_DEFER; + return PTR_ERR(info->clk); clk_prepare_enable(info->clk); ret = ov7670_init_gpio(client, info);