From patchwork Wed Jul 19 03:34:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 9850449 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 86B1A601C8 for ; Wed, 19 Jul 2017 03:34:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A46520602 for ; Wed, 19 Jul 2017 03:34:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4D1BA2015F; Wed, 19 Jul 2017 03:34:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E26B328600 for ; Wed, 19 Jul 2017 03:34:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbdGSDew (ORCPT ); Tue, 18 Jul 2017 23:34:52 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:32831 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdGSDev (ORCPT ); Tue, 18 Jul 2017 23:34:51 -0400 Received: by mail-qt0-f193.google.com with SMTP id 50so3662487qtz.0 for ; Tue, 18 Jul 2017 20:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4QwBF7u981ubE068/y0dPdjTjrEFeV5NmyFJ8WMWZPI=; b=mijbn+VIkrdx/ACvXp0JBpH75JGWRp1Wip4E7mNN7K8BTT1d2ROZrqhEoP7kIF2I2t 4+tOBWw9BwvxPZYjjcgC4QPCz+od9PeDM8OK9XavlfZa9hEbT7ckdvH7CjtXzI7Zmrq3 U3A1bH3rteK4jybn8lAORhFYhjygOcVGM2heKeOMdkv1pv8PIjKFSG9j4yJOdUW790eK 0n/Rr07ddYb1UG5OtbtT55ceGhq04dpJz9ejeTGxeyrOYUy/WKxhPasUXJr6cTjQyeN8 6tsRs1ml1xZou+mw6o11IJgAgzGcjOBK7hxxqHfRzxZBvIb9/jNbX+TeQN31xeNsWRg+ f8oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4QwBF7u981ubE068/y0dPdjTjrEFeV5NmyFJ8WMWZPI=; b=WlMrnwcpuN0MELOmhWrjh/qn4FUpwYOK3eqIL4CATkESY9SO9d8eU6zKDJ+VAknpmP t+ovhGV1bXwfNupI/gOU0e3sL3njII4QvTH4qoMhFQTyUcp4gAWMwphxpd2/cAJBtB9G 8uGO8u3qYbhOvTTr/a8JkDauLivhGZvqlQ0tFkCyunBApQpaUoywbvIltHNQq3dbassZ RA6Wz/fjOisaQ+sp6sOQC4Gj2OH6QQlKH7DiLCVBdkP2ET1Gkp2JGXLbxQ5MTw9qbGih WLQIGIolzQ+Yekb6PPQ+Pyl2L9OZc7jrrxFF613T7KgpGhE9tBgr25V6wt6LGz6pcwnQ e+pQ== X-Gm-Message-State: AIVw113DB46p12unAtD+bUAGwDO8VbyVOCtJVDaj1pyr6AO5YxDxWB2V 5/oL7raSMBPDTw== X-Received: by 10.200.35.168 with SMTP id q37mr861760qtq.129.1500435291176; Tue, 18 Jul 2017 20:34:51 -0700 (PDT) Received: from localhost.localdomain ([189.61.213.245]) by smtp.gmail.com with ESMTPSA id u67sm2963376qkd.67.2017.07.18.20.34.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 18 Jul 2017 20:34:50 -0700 (PDT) From: Fabio Estevam To: mchehab@s-opensource.com Cc: hans.verkuil@cisco.com, corbet@lwn.net, linux-media@vger.kernel.org, Fabio Estevam Subject: [PATCH 2/2] [media] ov7670: Check the return value from clk_prepare_enable() Date: Wed, 19 Jul 2017 00:34:19 -0300 Message-Id: <1500435259-5838-2-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500435259-5838-1-git-send-email-festevam@gmail.com> References: <1500435259-5838-1-git-send-email-festevam@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam --- drivers/media/i2c/ov7670.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 552a881..e88549f 100644 --- a/drivers/media/i2c/ov7670.c +++ b/drivers/media/i2c/ov7670.c @@ -1615,7 +1615,9 @@ static int ov7670_probe(struct i2c_client *client, info->clk = devm_clk_get(&client->dev, "xclk"); if (IS_ERR(info->clk)) return PTR_ERR(info->clk); - clk_prepare_enable(info->clk); + ret = clk_prepare_enable(info->clk); + if (ret) + return ret; ret = ov7670_init_gpio(client, info); if (ret)