| Message ID | 1502189912-28794-7-git-send-email-Julia.Lawall@lip6.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Julia, Thank you for the patch. On Tuesday 08 Aug 2017 12:58:32 Julia Lawall wrote: > uvc_subdev_ops is only passed as the second argument of > v4l2_subdev_init, which is const, so uvc_subdev_ops can be > const as well. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> and applied to my tree (with the first word of the commit message after the prefix capitalized to match the rest of the driver's commit messages, let me know if that's a problem :-)). > > --- > drivers/media/usb/uvc/uvc_entity.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/uvc/uvc_entity.c > b/drivers/media/usb/uvc/uvc_entity.c index ac386bb..554063c 100644 > --- a/drivers/media/usb/uvc/uvc_entity.c > +++ b/drivers/media/usb/uvc/uvc_entity.c > @@ -61,7 +61,7 @@ static int uvc_mc_create_links(struct uvc_video_chain > *chain, return 0; > } > > -static struct v4l2_subdev_ops uvc_subdev_ops = { > +static const struct v4l2_subdev_ops uvc_subdev_ops = { > }; > > void uvc_mc_cleanup_entity(struct uvc_entity *entity)
On Tue, 8 Aug 2017, Laurent Pinchart wrote: > Hi Julia, > > Thank you for the patch. > > On Tuesday 08 Aug 2017 12:58:32 Julia Lawall wrote: > > uvc_subdev_ops is only passed as the second argument of > > v4l2_subdev_init, which is const, so uvc_subdev_ops can be > > const as well. > > > > Done with the help of Coccinelle. > > > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > and applied to my tree (with the first word of the commit message after the > prefix capitalized to match the rest of the driver's commit messages, let me > know if that's a problem :-)). No, of course not. I will try to watch out for that in the future. julia > > > > --- > > drivers/media/usb/uvc/uvc_entity.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/usb/uvc/uvc_entity.c > > b/drivers/media/usb/uvc/uvc_entity.c index ac386bb..554063c 100644 > > --- a/drivers/media/usb/uvc/uvc_entity.c > > +++ b/drivers/media/usb/uvc/uvc_entity.c > > @@ -61,7 +61,7 @@ static int uvc_mc_create_links(struct uvc_video_chain > > *chain, return 0; > > } > > > > -static struct v4l2_subdev_ops uvc_subdev_ops = { > > +static const struct v4l2_subdev_ops uvc_subdev_ops = { > > }; > > > > void uvc_mc_cleanup_entity(struct uvc_entity *entity) > > -- > Regards, > > Laurent Pinchart > >
diff --git a/drivers/media/usb/uvc/uvc_entity.c b/drivers/media/usb/uvc/uvc_entity.c index ac386bb..554063c 100644 --- a/drivers/media/usb/uvc/uvc_entity.c +++ b/drivers/media/usb/uvc/uvc_entity.c @@ -61,7 +61,7 @@ static int uvc_mc_create_links(struct uvc_video_chain *chain, return 0; } -static struct v4l2_subdev_ops uvc_subdev_ops = { +static const struct v4l2_subdev_ops uvc_subdev_ops = { }; void uvc_mc_cleanup_entity(struct uvc_entity *entity)
uvc_subdev_ops is only passed as the second argument of v4l2_subdev_init, which is const, so uvc_subdev_ops can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/media/usb/uvc/uvc_entity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)