| Message ID | 1502191628-11958-4-git-send-email-andrzej.p@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 08/08/2017 01:27 PM, Andrzej Pietrasiewicz wrote: > The value to be processed must be first masked and then shifted, > not the other way round. > > Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com> > --- > drivers/media/platform/s5p-jpeg/jpeg-regs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/s5p-jpeg/jpeg-regs.h b/drivers/media/platform/s5p-jpeg/jpeg-regs.h > index 1870400..df790b1 100644 > --- a/drivers/media/platform/s5p-jpeg/jpeg-regs.h > +++ b/drivers/media/platform/s5p-jpeg/jpeg-regs.h > @@ -371,7 +371,7 @@ > #define EXYNOS4_NF_SHIFT 16 > #define EXYNOS4_NF_MASK 0xff > #define EXYNOS4_NF(x) \ > - (((x) << EXYNOS4_NF_SHIFT) & EXYNOS4_NF_MASK) > + (((x) & EXYNOS4_NF_MASK) << EXYNOS4_NF_SHIFT) I'm going to add below tag when applying this patch. Fixes: 6c96dbbc2aa9f5b4a ("[media] s5p-jpeg: add support for 5433")
diff --git a/drivers/media/platform/s5p-jpeg/jpeg-regs.h b/drivers/media/platform/s5p-jpeg/jpeg-regs.h index 1870400..df790b1 100644 --- a/drivers/media/platform/s5p-jpeg/jpeg-regs.h +++ b/drivers/media/platform/s5p-jpeg/jpeg-regs.h @@ -371,7 +371,7 @@ #define EXYNOS4_NF_SHIFT 16 #define EXYNOS4_NF_MASK 0xff #define EXYNOS4_NF(x) \ - (((x) << EXYNOS4_NF_SHIFT) & EXYNOS4_NF_MASK) + (((x) & EXYNOS4_NF_MASK) << EXYNOS4_NF_SHIFT) /* JPEG quantizer table register */ #define EXYNOS4_QTBL_CONTENT(n) (0x100 + (n) * 0x40)
The value to be processed must be first masked and then shifted, not the other way round. Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com> --- drivers/media/platform/s5p-jpeg/jpeg-regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)