| Message ID | 1502708457-13344-1-git-send-email-cakturk@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Akturk, this has already been fixed, see
4560cb4a0c ("media: imx: add VIDEO_V4L2_SUBDEV_API dependency").
Steve
On 08/14/2017 04:00 AM, Cihangir Akturk wrote:
> This driver uses various v4l2_subdev_get_try_*() functions provided by
> V4L2 sub-device userspace API. Current configuration of Kconfig file
> allows us to enable VIDEO_IMX_MEDIA without enabling this API. This
> breaks the build of driver.
>
> Depend on VIDEO_V4L2_SUBDEV_API to fix this issue.
>
> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
> ---
> drivers/staging/media/imx/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index 7eff50b..d8c3890 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -1,6 +1,7 @@
> config VIDEO_IMX_MEDIA
> tristate "i.MX5/6 V4L2 media core driver"
> - depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
> + depends on MEDIA_CONTROLLER && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && \
> + ARCH_MXC && IMX_IPUV3_CORE
> select V4L2_FWNODE
> ---help---
> Say yes here to enable support for video4linux media controller
On Mon, Aug 14, 2017 at 10:57:46AM -0700, Steve Longerbeam wrote: > Hi Akturk, this has already been fixed, see Sorry. Apparently, I missed to update my tree, somehow. > > 4560cb4a0c ("media: imx: add VIDEO_V4L2_SUBDEV_API dependency"). > > Steve > > On 08/14/2017 04:00 AM, Cihangir Akturk wrote: > > This driver uses various v4l2_subdev_get_try_*() functions provided by > > V4L2 sub-device userspace API. Current configuration of Kconfig file > > allows us to enable VIDEO_IMX_MEDIA without enabling this API. This > > breaks the build of driver. > > > > Depend on VIDEO_V4L2_SUBDEV_API to fix this issue. > > > > Signed-off-by: Cihangir Akturk <cakturk@gmail.com> > > --- > > drivers/staging/media/imx/Kconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig > > index 7eff50b..d8c3890 100644 > > --- a/drivers/staging/media/imx/Kconfig > > +++ b/drivers/staging/media/imx/Kconfig > > @@ -1,6 +1,7 @@ > > config VIDEO_IMX_MEDIA > > tristate "i.MX5/6 V4L2 media core driver" > > - depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE > > + depends on MEDIA_CONTROLLER && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && \ > > + ARCH_MXC && IMX_IPUV3_CORE > > select V4L2_FWNODE > > ---help--- > > Say yes here to enable support for video4linux media controller >
diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig index 7eff50b..d8c3890 100644 --- a/drivers/staging/media/imx/Kconfig +++ b/drivers/staging/media/imx/Kconfig @@ -1,6 +1,7 @@ config VIDEO_IMX_MEDIA tristate "i.MX5/6 V4L2 media core driver" - depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE + depends on MEDIA_CONTROLLER && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && \ + ARCH_MXC && IMX_IPUV3_CORE select V4L2_FWNODE ---help--- Say yes here to enable support for video4linux media controller
This driver uses various v4l2_subdev_get_try_*() functions provided by V4L2 sub-device userspace API. Current configuration of Kconfig file allows us to enable VIDEO_IMX_MEDIA without enabling this API. This breaks the build of driver. Depend on VIDEO_V4L2_SUBDEV_API to fix this issue. Signed-off-by: Cihangir Akturk <cakturk@gmail.com> --- drivers/staging/media/imx/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)