From patchwork Tue Dec 12 13:47:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 10107453 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 99309602B3 for ; Tue, 12 Dec 2017 13:45:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 89A3529750 for ; Tue, 12 Dec 2017 13:45:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7E8CB29959; Tue, 12 Dec 2017 13:45:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3431E29750 for ; Tue, 12 Dec 2017 13:45:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753902AbdLLNpa (ORCPT ); Tue, 12 Dec 2017 08:45:30 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:37642 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753105AbdLLNp0 (ORCPT ); Tue, 12 Dec 2017 08:45:26 -0500 Received: by mail-pf0-f195.google.com with SMTP id n6so14238584pfa.4; Tue, 12 Dec 2017 05:45:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=iF9l1kM8SBj4tmwBzn/ssaVK4Berex+K/liAcyIOY/w=; b=IXQYdtbpzD44xkGCOsqEATPHz/gg7jRRsDGz4UrmjlUmkZYkmbg9qGz3jZoOOu3oP+ gQ7wanW3BMGVz3e4op8usaZHlnxXoegeeHfc2aFNxHq7XcqQgPv9SbV5HzLnLmPEOVPL ESOdUsqQyBQHio6fDTd/lPmUzelTwgWzZnImmG8gu1Ipbbalk1BevmVR9k6C6pgyrddo FGFTJcSdJyHYvLv4FsxW9uozlASIOCw6r4TijLgDtRKCZVjf0HxJizjfEXZ79i9Mt0Gw DY/Cv9EE/KgksTBQqdgMqTlpNu4AG1dydgXT94yeACnodRTTvVjX70nrkGxqf1lQCxU6 EX9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=iF9l1kM8SBj4tmwBzn/ssaVK4Berex+K/liAcyIOY/w=; b=pgFomjHdSh45OvlXEAlcvz7bM4UOgBrE0SeE6BhyrSCj4oMEp2lGvTe8NZc2MlW8KG rR+iuRm07rqN7WdeSQ8bcWON4yOp7yRbIqKYhzwZ+Z4gKPukF3v++LcH58kst7STXIzR x695uW6UJu8DSd+R79XjmhF1CaRYPdytH7Z1kXp/JVPkwgqjed62TraURJFkhdHmb665 tmLY28isxjUlfzd0nN6m8sGeKT8UtmXZnqALv1NghfnaPh03CB1y+W8HZXmZPrwMYXxT HymzoJpfKzWh5693LBH+Fd/c9RhGx5YlpgRlQxkubYNWnssDzEEaxT8UMGhmjez4rRW1 0F/Q== X-Gm-Message-State: AKGB3mIiZpR+xAXXIkR6I8YDFQnhwpkm4FVZ0T7haxxASzOATkcwYsuG cx9Si+ZQ4aFBnT+PVNnakhsSg93M X-Google-Smtp-Source: ACJfBovvmnxsP1oTmFF+GJJvikspyFrAo5rWgJ8bnJsBSat9inEqQdQDYB+kDeLpETfGTO5KHB/DLQ== X-Received: by 10.101.70.196 with SMTP id n4mr2073924pgr.353.1513086325614; Tue, 12 Dec 2017 05:45:25 -0800 (PST) Received: from bai-oslab.tsinghua.edu.cn ([2402:f000:1:4413:7146:1b55:9590:7719]) by smtp.gmail.com with ESMTPSA id d2sm31850399pfe.164.2017.12.12.05.45.22 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Dec 2017 05:45:25 -0800 (PST) From: Jia-Ju Bai To: fabien.dessenne@st.com, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH 2/2] bdisp: Fix a possible sleep-in-atomic bug in bdisp_hw_save_request Date: Tue, 12 Dec 2017 21:47:38 +0800 Message-Id: <1513086458-29304-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver may sleep under a spinlock. The function call path is: bdisp_device_run (acquire the spinlock) bdisp_hw_update bdisp_hw_save_request devm_kzalloc(GFP_KERNEL) --> may sleep To fix it, GFP_KERNEL is replaced with GFP_ATOMIC. This bug is found by my static analysis tool(DSAC) and checked by my code review. Signed-off-by: Jia-Ju Bai Reviewed-by: Fabien Dessenne --- drivers/media/platform/sti/bdisp/bdisp-hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c b/drivers/media/platform/sti/bdisp/bdisp-hw.c index 4b62ceb..7b45b43 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-hw.c +++ b/drivers/media/platform/sti/bdisp/bdisp-hw.c @@ -1064,7 +1064,7 @@ static void bdisp_hw_save_request(struct bdisp_ctx *ctx) if (!copy_node[i]) { copy_node[i] = devm_kzalloc(ctx->bdisp_dev->dev, sizeof(*copy_node[i]), - GFP_KERNEL); + GFP_ATOMIC); if (!copy_node[i]) return; }