From patchwork Fri Mar 2 14:46:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 10254859 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7FF4B60211 for ; Fri, 2 Mar 2018 14:47:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 70D65289BE for ; Fri, 2 Mar 2018 14:47:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 65C90289C6; Fri, 2 Mar 2018 14:47:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DC2B7289BE for ; Fri, 2 Mar 2018 14:47:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1428699AbeCBOrV (ORCPT ); Fri, 2 Mar 2018 09:47:21 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:49042 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1428676AbeCBOrT (ORCPT ); Fri, 2 Mar 2018 09:47:19 -0500 Received: from w540.lan (unknown [IPv6:2001:b07:2e0:f265:f056:c2e8:fc6b:a908]) (Authenticated sender: jacopo@jmondi.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id A561EA812A; Fri, 2 Mar 2018 15:47:15 +0100 (CET) From: Jacopo Mondi To: mchehab@s-opensource.com, laurent.pinchart@ideasonboard.com, hans.verkuil@cisco.com, g.liakhovetski@gmx.de, bhumirks@gmail.com, joe@perches.com Cc: Jacopo Mondi , linux-media@vger.kernel.org Subject: [PATCH v2 09/11] media: ov772x: Re-order variables declaration Date: Fri, 2 Mar 2018 15:46:41 +0100 Message-Id: <1520002003-10200-10-git-send-email-jacopo+renesas@jmondi.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1520002003-10200-1-git-send-email-jacopo+renesas@jmondi.org> References: <1520002003-10200-1-git-send-email-jacopo+renesas@jmondi.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Re-order variables declaration to respect 'reverse christmas tree' ordering whenever possible. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/ov772x.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c index 4f464ac..1fd6d4b 100644 --- a/drivers/media/i2c/ov772x.c +++ b/drivers/media/i2c/ov772x.c @@ -1098,8 +1098,8 @@ static int ov772x_set_fmt(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, struct v4l2_subdev_format *format) { - struct ov772x_priv *priv = to_ov772x(sd); struct v4l2_mbus_framefmt *mf = &format->format; + struct ov772x_priv *priv = to_ov772x(sd); const struct ov772x_color_format *cfmt; const struct ov772x_win_size *win; int ret; @@ -1135,10 +1135,11 @@ static int ov772x_set_fmt(struct v4l2_subdev *sd, static int ov772x_video_probe(struct ov772x_priv *priv) { - struct i2c_client *client = v4l2_get_subdevdata(&priv->subdev); - u8 pid, ver; - const char *devname; - int ret; + struct i2c_client *client = v4l2_get_subdevdata(&priv->subdev); + const char *devname; + int ret; + u8 pid; + u8 ver; ret = ov772x_s_power(&priv->subdev, 1); if (ret < 0) @@ -1246,9 +1247,9 @@ static const struct v4l2_subdev_ops ov772x_subdev_ops = { static int ov772x_probe(struct i2c_client *client, const struct i2c_device_id *did) { - struct ov772x_priv *priv; - struct i2c_adapter *adapter = client->adapter; - int ret; + struct i2c_adapter *adapter = client->adapter; + struct ov772x_priv *priv; + int ret; if (!client->dev.platform_data) { dev_err(&client->dev, "Missing ov772x platform data\n");