From patchwork Sat Apr 7 15:48:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 10327889 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B0CCA600CB for ; Sat, 7 Apr 2018 15:48:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A13DB2951C for ; Sat, 7 Apr 2018 15:48:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 95DA829529; Sat, 7 Apr 2018 15:48:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4663E2951C for ; Sat, 7 Apr 2018 15:48:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751704AbeDGPsq (ORCPT ); Sat, 7 Apr 2018 11:48:46 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35118 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbeDGPsp (ORCPT ); Sat, 7 Apr 2018 11:48:45 -0400 Received: by mail-pf0-f195.google.com with SMTP id u86so2878135pfd.2; Sat, 07 Apr 2018 08:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SCIM8w1mNzVKONNjPiOT2eVBDE/fbbNIWX1O5hmJKEY=; b=n1mwZ57/O4VeIRQ1nPpqCRF399eEDcCj8EM03OwlXInfL71uVLsaQiPOLKx9NYRVEm NMQktcAnC8hrV/ZZkKkM41kHvhs1FWX9y0ShppufoNhfTHiFHr0osqPWCRN9Inm7++Mw yNjBONl9mWpufEZzJuXCXb8cCkzzIhggJty8w0W27AUKhMLiXd9qjbVv62hoP2Ce2Zeu fL9bea3ajpkclJhpb4G+6vwbmtGGiLM7dgK5YVZ4PSm4G+aL5zmims9CC0CjfOd3i+U9 Pjttf4ZPfv5H88mlYnms00a3V5OOH4Ch4oPLJDqsXgbcCt/bTPQ7INW7kjZP0LinB0JM THWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SCIM8w1mNzVKONNjPiOT2eVBDE/fbbNIWX1O5hmJKEY=; b=rqkw9vCrv8PpxUAtIc6IMiGF/MSIiyU+ZkCvWd3jDeg4aUzKDGlirnwtJl/uex3aGW LUffbUOtWFuby6bgl7bHtAQxla/agM9RFo/O0XUiw+v5Obmv8FlyLVbwza/kk8VvxwZo wHkBRbs+izhpdfDb5gKpaSSzwruEQu0Q/n6sgeoZMjqz+0nmE03a/KFF7jgrW3sMdUGo JXk8zkztDzIiIxuhjicXbdksSdHL7ltRbOesxNMQGSEz3KtdfR3ASex4j8/0+n8dvw/b HTTVk6MriCb8GnfhgohSziyo/e6N0ywLh47g7hWd7N5WIz02hlqAPg9PGK4e7wMCp1k7 cPqQ== X-Gm-Message-State: AElRT7HtQYLWXcdNJswFp2i66l0XzdWlPYQKLRUxGa84rBE+mTcUpOAX HwVY26IA/8WvHxp3PeCEgB05XA== X-Google-Smtp-Source: AIpwx4/m3SSaLHd6fbzAZ9xeVWVfFHa4Ip6q94PFneBiMpbyPJ80OFRhj2pvzfoES/ksJiii08h5pg== X-Received: by 10.99.4.202 with SMTP id 193mr20523543pge.409.1523116124738; Sat, 07 Apr 2018 08:48:44 -0700 (PDT) Received: from localhost.localdomain ([240f:4:c2bc:1:3c69:7d24:eba0:888]) by smtp.gmail.com with ESMTPSA id x14sm23536871pgo.82.2018.04.07.08.48.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 07 Apr 2018 08:48:44 -0700 (PDT) From: Akinobu Mita To: linux-media@vger.kernel.org, devicetree@vger.kernel.org Cc: Akinobu Mita , Jacopo Mondi , Laurent Pinchart , Hans Verkuil , Sakari Ailus , Mauro Carvalho Chehab Subject: [PATCH 2/6] media: ov772x: add checks for register read errors Date: Sun, 8 Apr 2018 00:48:06 +0900 Message-Id: <1523116090-13101-3-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523116090-13101-1-git-send-email-akinobu.mita@gmail.com> References: <1523116090-13101-1-git-send-email-akinobu.mita@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This change adds checks for register read errors and returns correct error code. Cc: Jacopo Mondi Cc: Laurent Pinchart Cc: Hans Verkuil Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- drivers/media/i2c/ov772x.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c index 283ae2c..c56f910 100644 --- a/drivers/media/i2c/ov772x.c +++ b/drivers/media/i2c/ov772x.c @@ -1169,8 +1169,15 @@ static int ov772x_video_probe(struct ov772x_priv *priv) return ret; /* Check and show product ID and manufacturer ID. */ - pid = ov772x_read(client, PID); - ver = ov772x_read(client, VER); + ret = ov772x_read(client, PID); + if (ret < 0) + return ret; + pid = ret; + + ret = ov772x_read(client, VER); + if (ret < 0) + return ret; + ver = ret; switch (VERSION(pid, ver)) { case OV7720: