From patchwork Tue Apr 24 23:12:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Devin Heitmueller X-Patchwork-Id: 10361197 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 69D40601BE for ; Tue, 24 Apr 2018 23:13:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 59DD928E8F for ; Tue, 24 Apr 2018 23:13:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4E87B28E99; Tue, 24 Apr 2018 23:13:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D70828E8F for ; Tue, 24 Apr 2018 23:13:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750995AbeDXXNH (ORCPT ); Tue, 24 Apr 2018 19:13:07 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:39341 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbeDXXNG (ORCPT ); Tue, 24 Apr 2018 19:13:06 -0400 Received: by mail-qt0-f193.google.com with SMTP id f1-v6so7336209qtj.6 for ; Tue, 24 Apr 2018 16:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernellabs-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1yn9J7MtxmqfGw64Kf3lzGQ5CPNXK0KAU1+h4BqmJi0=; b=EHnkKGYeRUQIG6alFy1bNQarNzhowBca931PoRAUGowsN7inWG6YkiDGhvk9f+2pGg L+5YYJzlTWe5zh9Yuzy7UebQjhzwl7Elw/4jZnMgwTu7o2hExv1ZXtFhKyRsbL/Z4Zv2 hzCcSHlS2Uhj0F1jqDq/pqXSPkg5KNNSud1AgE281qqN0O/70rXxCLG2WAkEW5tamxJQ vBYbEjZ11/0qXk0xvY3TVOHODXBvCYQgZyR8K+qIUwZ0/ddiZOwqjvwfrSs9iNbaIFyF AloI166zZrfhWDf9H2RKfHjTX9xwNSZulIS8heVAkLgi3EdWm6CH3SPEdS6NykSH9k9I pAfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1yn9J7MtxmqfGw64Kf3lzGQ5CPNXK0KAU1+h4BqmJi0=; b=AMVxBLqo0WylMzJ7QMb9KOGwTfDJGBWLCQeSBTVvnpINI8FS1ZEWRcZo0JT4A7AmK5 0tgPvY6JcDRJhmMVO0Lu7g5h2QUBwwsr/TZwzfoc9AN/laaop2tYIvl4lC9J+T4Oef9t oJo+EtbOYHEfgSVijGCB9Kkxkzq/qKmprTpeJSCnMv9BhOldoY8dHoVTzxBUboPsEA3q ldKko4TForKrVem9JjhdteFTxAKI53e1OziNTrfI0M3dLM8GrdNhOOXJkyUoUJ/XuaWy FAns/7juZTnnimaQHcNpTw5jrmoZRm5qD0hhNVWPzk0KcDtaljeGjgX47GLd1NYdDUjn Ve+A== X-Gm-Message-State: ALQs6tATjyCu7DN2kHitkja06PujklS55jtaP2ifl11SgNBXWyy/qA/Z Gh04IHFd8DdX0xIrQPRYrm4Iq+E6 X-Google-Smtp-Source: AB8JxZoTk0+xOsCKEOsyMZwh/gouVEFO/8TOzhrcJRnefWdallIOxBd5wiEEz/Fx0GAXNZ7IF/KxMQ== X-Received: by 2002:ac8:36f3:: with SMTP id b48-v6mr30653668qtc.334.1524611585288; Tue, 24 Apr 2018 16:13:05 -0700 (PDT) Received: from localhost.localdomain (cpe-74-71-96-2.nyc.res.rr.com. [74.71.96.2]) by smtp.gmail.com with ESMTPSA id b125sm12873434qkd.62.2018.04.24.16.13.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 24 Apr 2018 16:13:04 -0700 (PDT) From: Devin Heitmueller To: linux-media@vger.kernel.org Cc: Devin Heitmueller , Hans Verkuil Subject: [PATCH] cx88: Get rid of spurious call to cx8800_start_vbi_dma() Date: Tue, 24 Apr 2018 19:12:52 -0400 Message-Id: <1524611572-6075-1-git-send-email-dheitmueller@kernellabs.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This was left over from the conversion to VB2, where the call was getting invoked both in buffer_queue and start_streaming, which was intermittently causing invalid opcodes on the VBI RISC queue. This change effectively mirrors the exact same change Hans Verkuil made in cx88-video.c in 389208e1173e097590856ed24a505551510f78d4. Thanks to Daniel Glöckner for spotting the actual bug after I spent several days trying to chase down the issue. Signed-off-by: Devin Heitmueller Thanks-to: Daniel Glöckner Cc: Hans Verkuil --- drivers/media/pci/cx88/cx88-vbi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/pci/cx88/cx88-vbi.c b/drivers/media/pci/cx88/cx88-vbi.c index c637679..58489ea 100644 --- a/drivers/media/pci/cx88/cx88-vbi.c +++ b/drivers/media/pci/cx88/cx88-vbi.c @@ -178,7 +178,6 @@ static void buffer_queue(struct vb2_buffer *vb) if (list_empty(&q->active)) { list_add_tail(&buf->list, &q->active); - cx8800_start_vbi_dma(dev, q, buf); dprintk(2, "[%p/%d] vbi_queue - first active\n", buf, buf->vb.vb2_buf.index);