diff mbox

[1/2] dt-bindings: media: i2c: Add mt9t111 image sensor

Message ID 1524654014-17852-2-git-send-email-jacopo+renesas@jmondi.org (mailing list archive)
State New, archived
Headers show

Commit Message

Jacopo Mondi April 25, 2018, 11 a.m. UTC
Add device tree bindings documentation for Micron MT9T111/MT9T112 image
sensors.

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 Documentation/devicetree/bindings/mt9t112.txt | 41 +++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mt9t112.txt

Comments

Rob Herring (Arm) May 1, 2018, 2:28 p.m. UTC | #1
On Wed, Apr 25, 2018 at 01:00:13PM +0200, Jacopo Mondi wrote:
> Add device tree bindings documentation for Micron MT9T111/MT9T112 image
> sensors.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
>  Documentation/devicetree/bindings/mt9t112.txt | 41 +++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mt9t112.txt
> 
> diff --git a/Documentation/devicetree/bindings/mt9t112.txt b/Documentation/devicetree/bindings/mt9t112.txt
> new file mode 100644
> index 0000000..cbad475
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mt9t112.txt
> @@ -0,0 +1,41 @@
> +Micron 3.1Mp CMOS Digital Image Sensor
> +--------------------------------------
> +
> +The Micron MT9T111 and MT9T112 are 1/4 inch 3.1Mp System-On-A-Chip (SOC) CMOS
> +digital image sensors which support up to QXGA (2048x1536) image resolution in
> +4/3 format.
> +
> +The sensors can be programmed through a two-wire serial interface and can
> +work both in parallel data output mode as well as in MIPI CSI-2 mode.
> +
> +Required Properties:
> +- compatible: shall be one of the following values
> +  	"micron,mt9t111" for MT9T111 sensors
> +	"micron,mt9t112" for MT9T112 sensors
> +
> +Optional properties:
> +- powerdown-gpios: reference to powerdown input GPIO signal. Pin name "STANDBY".
> +  Active level is high.
> +
> +The device node shall contain one 'port' sub-node with one 'endpoint' child
> +node, modeled accordingly to bindings described in:
> +Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example:
> +--------
> +
> +	mt9t112@3d {

camera-sensor@3d

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

> +		compatible = "micron,mt9t112";
> +		reg = <0x3d>;
> +
> +		powerdown-gpios = <&gpio4 2 GPIO_ACTIVE_HIGH>;
> +
> +		port {
> +			mt9t112_out: endpoint {
> +				pclk-sample = <1>;
> +				remote-endpoint = <&ceu_in>;
> +			};
> +		};
> +	};
> +
> +
> -- 
> 2.7.4
>
Sakari Ailus May 7, 2018, 9:17 a.m. UTC | #2
Hi Jacopo,

On Wed, Apr 25, 2018 at 01:00:13PM +0200, Jacopo Mondi wrote:
> Add device tree bindings documentation for Micron MT9T111/MT9T112 image
> sensors.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
>  Documentation/devicetree/bindings/mt9t112.txt | 41 +++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mt9t112.txt
> 
> diff --git a/Documentation/devicetree/bindings/mt9t112.txt b/Documentation/devicetree/bindings/mt9t112.txt
> new file mode 100644
> index 0000000..cbad475
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mt9t112.txt
> @@ -0,0 +1,41 @@
> +Micron 3.1Mp CMOS Digital Image Sensor
> +--------------------------------------
> +
> +The Micron MT9T111 and MT9T112 are 1/4 inch 3.1Mp System-On-A-Chip (SOC) CMOS
> +digital image sensors which support up to QXGA (2048x1536) image resolution in
> +4/3 format.
> +
> +The sensors can be programmed through a two-wire serial interface and can
> +work both in parallel data output mode as well as in MIPI CSI-2 mode.
> +
> +Required Properties:
> +- compatible: shall be one of the following values
> +  	"micron,mt9t111" for MT9T111 sensors
> +	"micron,mt9t112" for MT9T112 sensors
> +
> +Optional properties:
> +- powerdown-gpios: reference to powerdown input GPIO signal. Pin name "STANDBY".
> +  Active level is high.
> +
> +The device node shall contain one 'port' sub-node with one 'endpoint' child
> +node, modeled accordingly to bindings described in:
> +Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example:
> +--------
> +
> +	mt9t112@3d {
> +		compatible = "micron,mt9t112";
> +		reg = <0x3d>;
> +
> +		powerdown-gpios = <&gpio4 2 GPIO_ACTIVE_HIGH>;
> +
> +		port {
> +			mt9t112_out: endpoint {
> +				pclk-sample = <1>;

Could you document pclk-sample as an endpoint property? I'd suggest making
it optional with a default configuration.

> +				remote-endpoint = <&ceu_in>;
> +			};
> +		};
> +	};
> +
> +
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/mt9t112.txt b/Documentation/devicetree/bindings/mt9t112.txt
new file mode 100644
index 0000000..cbad475
--- /dev/null
+++ b/Documentation/devicetree/bindings/mt9t112.txt
@@ -0,0 +1,41 @@ 
+Micron 3.1Mp CMOS Digital Image Sensor
+--------------------------------------
+
+The Micron MT9T111 and MT9T112 are 1/4 inch 3.1Mp System-On-A-Chip (SOC) CMOS
+digital image sensors which support up to QXGA (2048x1536) image resolution in
+4/3 format.
+
+The sensors can be programmed through a two-wire serial interface and can
+work both in parallel data output mode as well as in MIPI CSI-2 mode.
+
+Required Properties:
+- compatible: shall be one of the following values
+  	"micron,mt9t111" for MT9T111 sensors
+	"micron,mt9t112" for MT9T112 sensors
+
+Optional properties:
+- powerdown-gpios: reference to powerdown input GPIO signal. Pin name "STANDBY".
+  Active level is high.
+
+The device node shall contain one 'port' sub-node with one 'endpoint' child
+node, modeled accordingly to bindings described in:
+Documentation/devicetree/bindings/media/video-interfaces.txt
+
+Example:
+--------
+
+	mt9t112@3d {
+		compatible = "micron,mt9t112";
+		reg = <0x3d>;
+
+		powerdown-gpios = <&gpio4 2 GPIO_ACTIVE_HIGH>;
+
+		port {
+			mt9t112_out: endpoint {
+				pclk-sample = <1>;
+				remote-endpoint = <&ceu_in>;
+			};
+		};
+	};
+
+