| Message ID | 1524654920-18749-3-git-send-email-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Thanks Jacopo, I'm very pleased to see this series. On Wed, Apr 25, 2018 at 01:15:20PM +0200, Jacopo Mondi wrote: > Enable CEU0 peripheral for Renesas R-Mobile A1 R8A7740. Given 'status = "disabled"' below I think you are describing but not enabling CEU0. Also in the subject. Should we also describe CEU1? > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi > index afd3bc5..05ec41e 100644 > --- a/arch/arm/boot/dts/r8a7740.dtsi > +++ b/arch/arm/boot/dts/r8a7740.dtsi > @@ -67,6 +67,16 @@ > power-domains = <&pd_d4>; > }; > > + ceu0: ceu@fe910000 { > + reg = <0xfe910000 0x100>; Should the size of the range be 0x3000 ? That would seem to match my reading of table 32.3 and also be consistent with r7s72100.dtsi. > + compatible = "renesas,r8a7740-ceu"; > + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp1_clks R8A7740_CLK_CEU20>; > + clock-names = "ceu20"; > + power-domains = <&pd_a4mp>; My reading of table 1.7 is that the power domain should be A4R (&pd_a4r). > + status = "disabled"; > + }; > + > cmt1: timer@e6138000 { > compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48"; > reg = <0xe6138000 0x170>; > -- > 2.7.4 >
Hi Simon, On Thu, Apr 26, 2018 at 08:11:30AM +0200, Simon Horman wrote: > Thanks Jacopo, > > I'm very pleased to see this series. Credits to Geert that pointed out to me R-Mobile A1 comes with a CEU. I should mention him in next iteration actually, sorry about that. > > On Wed, Apr 25, 2018 at 01:15:20PM +0200, Jacopo Mondi wrote: > > Enable CEU0 peripheral for Renesas R-Mobile A1 R8A7740. > > Given 'status = "disabled"' below I think you > are describing but not enabling CEU0. Also in the subject. Right. > > Should we also describe CEU1? Armadillo board file only describe CEU0. If there are R-Mobile A1 board files where I can steal informations from I can do that. If there's a public datasheet, that would be even better. > > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > --- > > arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi > > index afd3bc5..05ec41e 100644 > > --- a/arch/arm/boot/dts/r8a7740.dtsi > > +++ b/arch/arm/boot/dts/r8a7740.dtsi > > @@ -67,6 +67,16 @@ > > power-domains = <&pd_d4>; > > }; > > > > + ceu0: ceu@fe910000 { > > + reg = <0xfe910000 0x100>; > > Should the size of the range be 0x3000 ? > That would seem to match my reading of table 32.3 > and also be consistent with r7s72100.dtsi. I got this from static struct resource ceu0_resources[] = { [0] = { .name = "CEU", .start = 0xfe910000, .end = 0xfe91009f, .flags = IORESOURCE_MEM, }, but I also noticed the r7s72100 one was bigger. I'm fine enlarging this, if that's what the manual reports too. > > + compatible = "renesas,r8a7740-ceu"; > > + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&mstp1_clks R8A7740_CLK_CEU20>; > > + clock-names = "ceu20"; > > + power-domains = <&pd_a4mp>; > > My reading of table 1.7 is that the power domain should be A4R (&pd_a4r). Ah yes, my bad. The long time goal would be describe the camera module (mt9t112) which is installed on armadillo. Unfortunately that would probably require some more work on the CEU side. Thanks j > > > + status = "disabled"; > > + }; > > + > > cmt1: timer@e6138000 { > > compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48"; > > reg = <0xe6138000 0x170>; > > -- > > 2.7.4 > >
On Thu, Apr 26, 2018 at 09:26:09AM +0200, jacopo mondi wrote: > Hi Simon, > > On Thu, Apr 26, 2018 at 08:11:30AM +0200, Simon Horman wrote: > > Thanks Jacopo, > > > > I'm very pleased to see this series. > > Credits to Geert that pointed out to me R-Mobile A1 comes with a CEU. > I should mention him in next iteration actually, sorry about that. > > > > > On Wed, Apr 25, 2018 at 01:15:20PM +0200, Jacopo Mondi wrote: > > > Enable CEU0 peripheral for Renesas R-Mobile A1 R8A7740. > > > > Given 'status = "disabled"' below I think you > > are describing but not enabling CEU0. Also in the subject. > > Right. > > > > > Should we also describe CEU1? > > Armadillo board file only describe CEU0. If there are R-Mobile A1 > board files where I can steal informations from I can do that. If > there's a public datasheet, that would be even better. I have the datasheet, so perhaps I can add CEU1 after you have added CEU0. > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > > --- > > > arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi > > > index afd3bc5..05ec41e 100644 > > > --- a/arch/arm/boot/dts/r8a7740.dtsi > > > +++ b/arch/arm/boot/dts/r8a7740.dtsi > > > @@ -67,6 +67,16 @@ > > > power-domains = <&pd_d4>; > > > }; > > > > > > + ceu0: ceu@fe910000 { > > > + reg = <0xfe910000 0x100>; > > > > Should the size of the range be 0x3000 ? > > That would seem to match my reading of table 32.3 > > and also be consistent with r7s72100.dtsi. > > I got this from > > static struct resource ceu0_resources[] = { > [0] = { > .name = "CEU", > .start = 0xfe910000, > .end = 0xfe91009f, > .flags = IORESOURCE_MEM, > }, > but I also noticed the r7s72100 one was bigger. > I'm fine enlarging this, if that's what the manual reports too. I think that would be best. > > > + compatible = "renesas,r8a7740-ceu"; > > > + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>; > > > + clocks = <&mstp1_clks R8A7740_CLK_CEU20>; > > > + clock-names = "ceu20"; > > > + power-domains = <&pd_a4mp>; > > > > My reading of table 1.7 is that the power domain should be A4R (&pd_a4r). > > Ah yes, my bad. > > The long time goal would be describe the camera module (mt9t112) which > is installed on armadillo. Unfortunately that would probably require > some more work on the CEU side. Thanks, understood.
diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi index afd3bc5..05ec41e 100644 --- a/arch/arm/boot/dts/r8a7740.dtsi +++ b/arch/arm/boot/dts/r8a7740.dtsi @@ -67,6 +67,16 @@ power-domains = <&pd_d4>; }; + ceu0: ceu@fe910000 { + reg = <0xfe910000 0x100>; + compatible = "renesas,r8a7740-ceu"; + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp1_clks R8A7740_CLK_CEU20>; + clock-names = "ceu20"; + power-domains = <&pd_a4mp>; + status = "disabled"; + }; + cmt1: timer@e6138000 { compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48"; reg = <0xe6138000 0x170>;
Enable CEU0 peripheral for Renesas R-Mobile A1 R8A7740. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)