From patchwork Sun May 6 18:08:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Hollstegge X-Patchwork-Id: 10382955 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1821060353 for ; Sun, 6 May 2018 18:08:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 07334286B1 for ; Sun, 6 May 2018 18:08:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EA081289D0; Sun, 6 May 2018 18:08:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 18539286B1 for ; Sun, 6 May 2018 18:08:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751822AbeEFSIt (ORCPT ); Sun, 6 May 2018 14:08:49 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:38306 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbeEFSIs (ORCPT ); Sun, 6 May 2018 14:08:48 -0400 Received: by mail-wr0-f195.google.com with SMTP id 94-v6so24404287wrf.5 for ; Sun, 06 May 2018 11:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TKjgHN8K2fcbs8x6KYPo+Lckof+FyNd6VeCZYEbrTv8=; b=t1QHvXckLyg+p5vO/0cxc6lqNbyx+oMZn9yaF5x83wwJxYRXhPtqT5fgx3GZtfb67E GbVkNXX+rN/Ho4q+39tD9VCZ+GbeeMkKeSF4q7PnzmxMYNejfO1NhpoufYGu42L8eJoV ADVlyobZh+g0nms31T+a0eZtp2HnENy5QH4nBIHMFPCkwN2PmxK7ZIZBlrlFkEwjwauW xn1ah0igiIQpwmlC4Ceww6XIqOBzzc9NISnhFjiYFVBpOuej+CDyNNlhM0bX24C5Y4v1 rQiswPSAmlF2QhVr8uO6Q6DobS/FhL785YNjz8wBd+nmYfySBBe38GZ1YhLkURk93Xw+ cVYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TKjgHN8K2fcbs8x6KYPo+Lckof+FyNd6VeCZYEbrTv8=; b=eWFPZaSVIeVwHQfhF8vFC0XBTiBLuWujkQHsQVAXpxW1DtX8LnS9Uk6oDNXAMC5bby JnSAyU6LU6w9XEY2DjFOYnWEH13OQDWsXhQ20wyehuiIqRfedkwC0z1KaFIDbNbth6I9 mxVicO+33+JTgpdiwl1bDvzShk3t6ln2P0ymT1D+TO2kgmVSNIK9blgjziOFt0D2/SWa MULSw+jtI0GnIiNR+1TC+5CGrCczJmA8DWasyAON2ZGmYNiriZADQdkRzfx7e/bKEgdg YADl8zISF0YV42Ff44oFnKsKEz1gZSBTwRkkKdzwX0B2ZCPMKEN1Hr4ZdxFcAdrwZFAb iBOw== X-Gm-Message-State: ALQs6tDyAIkBltrOZAKmQIsvive4AazraDc71UTH1xpSJOh7gBf5n9AJ esNNE+1Eb8xin9giHjh0NRPyQ9JfJg8= X-Google-Smtp-Source: AB8JxZqCOCn1SwNnVIh/sfk+eiCkDy6YoXw/WX9tcweRGhfBtKaL4V+TXa0HF7WxJF0gKt025PL3FA== X-Received: by 2002:adf:82c4:: with SMTP id 62-v6mr4724633wrc.273.1525630126430; Sun, 06 May 2018 11:08:46 -0700 (PDT) Received: from x1.local (p200300E55F2109000000000000000281.dip0.t-ipconnect.de. [2003:e5:5f21:900::281]) by smtp.googlemail.com with ESMTPSA id h81sm8290414wmd.0.2018.05.06.11.08.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 06 May 2018 11:08:45 -0700 (PDT) From: Thomas Hollstegge To: linux-media@vger.kernel.org Cc: Antti Palosaari , Mauro Carvalho Chehab , Thomas Hollstegge , =?UTF-8?q?Stefan=20Br=C3=BCns?= Subject: [PATCH v2 2/2] dvbsky: Add support for MyGica T230C v2 Date: Sun, 6 May 2018 20:08:00 +0200 Message-Id: <1525630080-19329-3-git-send-email-thomas.hollstegge@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1525630080-19329-1-git-send-email-thomas.hollstegge@gmail.com> References: <1525513831-17682-1-git-send-email-thomas.hollstegge@gmail.com> <1525630080-19329-1-git-send-email-thomas.hollstegge@gmail.com> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Support for newer revisions of the MyGica T230C, shipping with a different USB pid. Although sometimes referred to as T230C2, the device is sold under its original name T230C. Besides a slightly different PCB layout and some different minor components, it utilizes the same bridge, demodulator and tuner as the older revision. However, it requires a fixed TS clock frequency of 10 MHz to tune to some muxes. Tested with various DVB-T2 HEVC and DVB-C channels. Signed-off-by: Thomas Hollstegge Cc: Stefan Brüns --- drivers/media/usb/dvb-usb-v2/dvbsky.c | 90 +++++++++++++++++++++++++++++++++++ include/media/dvb-usb-ids.h | 1 + 2 files changed, 91 insertions(+) diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c index e28bd88..4a4c6ae 100644 --- a/drivers/media/usb/dvb-usb-v2/dvbsky.c +++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c @@ -583,6 +583,66 @@ static int dvbsky_mygica_t230c_attach(struct dvb_usb_adapter *adap) return 0; } +static int dvbsky_mygica_t230c_v2_attach(struct dvb_usb_adapter *adap) +{ + struct dvbsky_state *state = adap_to_priv(adap); + struct dvb_usb_device *d = adap_to_d(adap); + struct i2c_adapter *i2c_adapter; + struct i2c_client *client_demod, *client_tuner; + struct i2c_board_info info; + struct si2168_config si2168_config; + struct si2157_config si2157_config; + + /* attach demod */ + memset(&si2168_config, 0, sizeof(si2168_config)); + si2168_config.i2c_adapter = &i2c_adapter; + si2168_config.fe = &adap->fe[0]; + si2168_config.ts_mode = SI2168_TS_PARALLEL; + si2168_config.ts_clock_inv = 1; + si2168_config.ts_clock_mode = SI2168_TS_CLOCK_MODE_MANUAL; + si2168_config.ts_clock_freq = 10000000; + memset(&info, 0, sizeof(struct i2c_board_info)); + strlcpy(info.type, "si2168", sizeof(info.type)); + info.addr = 0x64; + info.platform_data = &si2168_config; + + request_module("si2168"); + client_demod = i2c_new_device(&d->i2c_adap, &info); + if (!client_demod || !client_demod->dev.driver) + goto fail_demod_device; + if (!try_module_get(client_demod->dev.driver->owner)) + goto fail_demod_module; + + /* attach tuner */ + memset(&si2157_config, 0, sizeof(si2157_config)); + si2157_config.fe = adap->fe[0]; + si2157_config.if_port = 0; + memset(&info, 0, sizeof(struct i2c_board_info)); + strlcpy(info.type, "si2141", sizeof(info.type)); + info.addr = 0x60; + info.platform_data = &si2157_config; + + request_module("si2157"); + client_tuner = i2c_new_device(i2c_adapter, &info); + if (!client_tuner || !client_tuner->dev.driver) + goto fail_tuner_device; + if (!try_module_get(client_tuner->dev.driver->owner)) + goto fail_tuner_module; + + state->i2c_client_demod = client_demod; + state->i2c_client_tuner = client_tuner; + return 0; + +fail_tuner_module: + i2c_unregister_device(client_tuner); +fail_tuner_device: + module_put(client_demod->dev.driver->owner); +fail_demod_module: + i2c_unregister_device(client_demod); +fail_demod_device: + return -ENODEV; +} + static int dvbsky_identify_state(struct dvb_usb_device *d, const char **name) { @@ -762,6 +822,33 @@ static struct dvb_usb_device_properties mygica_t230c_props = { } }; +static struct dvb_usb_device_properties mygica_t230c_v2_props = { + .driver_name = KBUILD_MODNAME, + .owner = THIS_MODULE, + .adapter_nr = adapter_nr, + .size_of_priv = sizeof(struct dvbsky_state), + + .generic_bulk_ctrl_endpoint = 0x01, + .generic_bulk_ctrl_endpoint_response = 0x81, + .generic_bulk_ctrl_delay = DVBSKY_MSG_DELAY, + + .i2c_algo = &dvbsky_i2c_algo, + .frontend_attach = dvbsky_mygica_t230c_v2_attach, + .init = dvbsky_init, + .get_rc_config = dvbsky_get_rc_config, + .streaming_ctrl = dvbsky_streaming_ctrl, + .identify_state = dvbsky_identify_state, + .exit = dvbsky_exit, + + .num_adapters = 1, + .adapter = { + { + .stream = DVB_USB_STREAM_BULK(0x82, 8, 4096), + } + } +}; + + static const struct usb_device_id dvbsky_id_table[] = { { DVB_USB_DEVICE(0x0572, 0x6831, &dvbsky_s960_props, "DVBSky S960/S860", RC_MAP_DVBSKY) }, @@ -797,6 +884,9 @@ static const struct usb_device_id dvbsky_id_table[] = { { DVB_USB_DEVICE(USB_VID_CONEXANT, USB_PID_MYGICA_T230C, &mygica_t230c_props, "MyGica Mini DVB-T2 USB Stick T230C", RC_MAP_TOTAL_MEDIA_IN_HAND_02) }, + { DVB_USB_DEVICE(USB_VID_CONEXANT, USB_PID_MYGICA_T230C_V2, + &mygica_t230c_v2_props, "MyGica Mini DVB-T2 USB Stick T230C v2", + RC_MAP_TOTAL_MEDIA_IN_HAND_02) }, { } }; MODULE_DEVICE_TABLE(usb, dvbsky_id_table); diff --git a/include/media/dvb-usb-ids.h b/include/media/dvb-usb-ids.h index f9e73b4..d606248 100644 --- a/include/media/dvb-usb-ids.h +++ b/include/media/dvb-usb-ids.h @@ -387,6 +387,7 @@ #define USB_PID_MYGICA_D689 0xd811 #define USB_PID_MYGICA_T230 0xc688 #define USB_PID_MYGICA_T230C 0xc689 +#define USB_PID_MYGICA_T230C_V2 0xc68a #define USB_PID_ELGATO_EYETV_DIVERSITY 0x0011 #define USB_PID_ELGATO_EYETV_DTT 0x0021 #define USB_PID_ELGATO_EYETV_DTT_2 0x003f