| Message ID | 1526488352-898-7-git-send-email-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Jacopo, Thanks for your work. On 2018-05-16 18:32:32 +0200, Jacopo Mondi wrote: > The 'data-active' property needs to be specified when using embedded > synchronization. Add it to the Gen-2 boards using composite video input. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > arch/arm/boot/dts/r8a7790-lager.dts | 1 + > arch/arm/boot/dts/r8a7791-koelsch.dts | 1 + > arch/arm/boot/dts/r8a7791-porter.dts | 1 + > arch/arm/boot/dts/r8a7793-gose.dts | 1 + > arch/arm/boot/dts/r8a7794-alt.dts | 1 + > arch/arm/boot/dts/r8a7794-silk.dts | 1 + > 6 files changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts > index b56b309..48fcb44 100644 > --- a/arch/arm/boot/dts/r8a7790-lager.dts > +++ b/arch/arm/boot/dts/r8a7790-lager.dts > @@ -893,6 +893,7 @@ > > vin1ep0: endpoint { > remote-endpoint = <&adv7180>; > + data-active = <1>; > }; > }; > }; > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts > index 9967666..fa0b25f 100644 > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > @@ -868,6 +868,7 @@ > > vin1ep: endpoint { > remote-endpoint = <&adv7180>; > + data-active = <1>; Depending on how we interpret the data-active property this can be good or bad. But if we interpret it as the polarity of the VIn_CLKENB pin this is not good as this is not connected for the adv7180 on Koelsch. I have not checked all the Gen2 schematics as I'm still not sure how to interpret the property. > }; > }; > }; > diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts > index 055a7f1..96b9605 100644 > --- a/arch/arm/boot/dts/r8a7791-porter.dts > +++ b/arch/arm/boot/dts/r8a7791-porter.dts > @@ -391,6 +391,7 @@ > > vin0ep: endpoint { > remote-endpoint = <&adv7180>; > + data-active = <1>; > }; > }; > }; > diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts > index 9d3fba2..80b4fa8 100644 > --- a/arch/arm/boot/dts/r8a7793-gose.dts > +++ b/arch/arm/boot/dts/r8a7793-gose.dts > @@ -779,6 +779,7 @@ > > vin1ep: endpoint { > remote-endpoint = <&adv7180_out>; > + data-active = <1>; > }; > }; > }; > diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts > index 4bbb9cc..00df605d 100644 > --- a/arch/arm/boot/dts/r8a7794-alt.dts > +++ b/arch/arm/boot/dts/r8a7794-alt.dts > @@ -380,6 +380,7 @@ > > vin0ep: endpoint { > remote-endpoint = <&adv7180>; > + data-active = <1>; > }; > }; > }; > diff --git a/arch/arm/boot/dts/r8a7794-silk.dts b/arch/arm/boot/dts/r8a7794-silk.dts > index c0c5d31..ed17376 100644 > --- a/arch/arm/boot/dts/r8a7794-silk.dts > +++ b/arch/arm/boot/dts/r8a7794-silk.dts > @@ -480,6 +480,7 @@ > > vin0ep: endpoint { > remote-endpoint = <&adv7180>; > + data-active = <1>; > }; > }; > }; > -- > 2.7.4 >
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts index b56b309..48fcb44 100644 --- a/arch/arm/boot/dts/r8a7790-lager.dts +++ b/arch/arm/boot/dts/r8a7790-lager.dts @@ -893,6 +893,7 @@ vin1ep0: endpoint { remote-endpoint = <&adv7180>; + data-active = <1>; }; }; }; diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts index 9967666..fa0b25f 100644 --- a/arch/arm/boot/dts/r8a7791-koelsch.dts +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts @@ -868,6 +868,7 @@ vin1ep: endpoint { remote-endpoint = <&adv7180>; + data-active = <1>; }; }; }; diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts index 055a7f1..96b9605 100644 --- a/arch/arm/boot/dts/r8a7791-porter.dts +++ b/arch/arm/boot/dts/r8a7791-porter.dts @@ -391,6 +391,7 @@ vin0ep: endpoint { remote-endpoint = <&adv7180>; + data-active = <1>; }; }; }; diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts index 9d3fba2..80b4fa8 100644 --- a/arch/arm/boot/dts/r8a7793-gose.dts +++ b/arch/arm/boot/dts/r8a7793-gose.dts @@ -779,6 +779,7 @@ vin1ep: endpoint { remote-endpoint = <&adv7180_out>; + data-active = <1>; }; }; }; diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts index 4bbb9cc..00df605d 100644 --- a/arch/arm/boot/dts/r8a7794-alt.dts +++ b/arch/arm/boot/dts/r8a7794-alt.dts @@ -380,6 +380,7 @@ vin0ep: endpoint { remote-endpoint = <&adv7180>; + data-active = <1>; }; }; }; diff --git a/arch/arm/boot/dts/r8a7794-silk.dts b/arch/arm/boot/dts/r8a7794-silk.dts index c0c5d31..ed17376 100644 --- a/arch/arm/boot/dts/r8a7794-silk.dts +++ b/arch/arm/boot/dts/r8a7794-silk.dts @@ -480,6 +480,7 @@ vin0ep: endpoint { remote-endpoint = <&adv7180>; + data-active = <1>; }; }; };
The 'data-active' property needs to be specified when using embedded synchronization. Add it to the Gen-2 boards using composite video input. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- arch/arm/boot/dts/r8a7790-lager.dts | 1 + arch/arm/boot/dts/r8a7791-koelsch.dts | 1 + arch/arm/boot/dts/r8a7791-porter.dts | 1 + arch/arm/boot/dts/r8a7793-gose.dts | 1 + arch/arm/boot/dts/r8a7794-alt.dts | 1 + arch/arm/boot/dts/r8a7794-silk.dts | 1 + 6 files changed, 6 insertions(+) -- 2.7.4