From patchwork Tue Nov 20 15:27:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 10690497 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 65F4215A7 for ; Tue, 20 Nov 2018 15:28:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 51C922AA39 for ; Tue, 20 Nov 2018 15:28:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4316E2A92F; Tue, 20 Nov 2018 15:28:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D2D912A92F for ; Tue, 20 Nov 2018 15:28:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729145AbeKUB5k (ORCPT ); Tue, 20 Nov 2018 20:57:40 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:46018 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725935AbeKUB5k (ORCPT ); Tue, 20 Nov 2018 20:57:40 -0500 Received: by mail-pf1-f195.google.com with SMTP id g62so1142833pfd.12 for ; Tue, 20 Nov 2018 07:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=WnhxHtS84l5b1ZfLCH/exQhSU2jPVHugksBd0pOpUNk=; b=k1MXoFqOlkpVS56CAGnSw/TQH2fELPdo4ztBFS5pvvk26M+iYVEHa/iDnSXTmOjBLC V5Qn5U49WaUQhBQ5BPq3TD6QH8iQXGKzqLaIUedTm+8waFypy+rLxV84Wnwrbcxc+ubh oV2DBWmXfAFWMz5qi4DSq+ca8jx+BS8L6QM8V4u4xh0KcxJhcR3NNDqO+uUmnfmQQuXv zmX9r+gBVPDufXKceK0mjgomYE/H+0ZvUs7G3kspqgzk4fnpBBbK414uNPrcKtkqK2OS 40wEuDsZEyZio0jrg6UHK/jW1tgnoMEINtNvM7ciVMRJpINrotguhHObFg05tmuOTX33 RSlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=WnhxHtS84l5b1ZfLCH/exQhSU2jPVHugksBd0pOpUNk=; b=PctJ1zBPAHPSytMNbEN3n/51PfaudjfuZMGxCO3B8kQlqae9BWusCsMPqkmCIjnCIB KWqYqZ9X5lkbMgzI7UKGuaMYsVy1HEzxlt1QOTwdcJA+6pwTYEErhFcP8ggIqCkOtBqh EJyeihSEzGnh8hdi1wWsaMt/40+9tu1krEs7Ba4BiLKYPAWKyj3997jFRf8k5ocLEbk2 k4G4xGQK1qwuy4U0ZUlMc2DlMImK27ZShD/7jTnEfHHlQzeq37fCOb8CPjxpODP6M+1R 94Acq94nwIXFTxGrJm0S1Vn9Re9g0CIiyCQp2GZ5EqMPVgQrV3abtbMYVHIEBeGeJ4JC Jf9A== X-Gm-Message-State: AA+aEWYzyh21tHBjZGINjwpMcUC6iFfqQy1zkWc/PSKfUlczST/TI/Rd Q1VYjNW4QUCy6YSGBNrcGHN3Wkfc X-Google-Smtp-Source: AFSGD/U22LAeWbyEtKN8qJ9LBN/toK1iCDH8sHLrnqStM/APq2BBxiaPO75YKCAG9RgsXMviCMaV/A== X-Received: by 2002:a63:6506:: with SMTP id z6mr2300852pgb.334.1542727679914; Tue, 20 Nov 2018 07:27:59 -0800 (PST) Received: from localhost.localdomain ([240f:34:212d:1:b17b:901d:39be:c7e2]) by smtp.gmail.com with ESMTPSA id i63-v6sm9904628pfi.66.2018.11.20.07.27.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 Nov 2018 07:27:59 -0800 (PST) From: Akinobu Mita To: linux-media@vger.kernel.org Cc: Akinobu Mita , Matt Ranostay , Sakari Ailus , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH] media: video-i2c: don't use msleep for 1ms - 20ms Date: Wed, 21 Nov 2018 00:27:40 +0900 Message-Id: <1542727660-14117-1-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Documentation/timers/timers-howto.txt says: "msleep(1~20) may not do what the caller intends, and will often sleep longer (~20 ms actual sleep for any value given in the 1~20ms range)." So replace msleep(2) by usleep_range(2000, 3000). Reported-by: Hans Verkuil Cc: Matt Ranostay Cc: Sakari Ailus Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita Acked-by: Sakari Ailus --- This fixes "[PATCH v4 6/6] media: video-i2c: support runtime PM" in the patchset "[PATCH v4 0/6] media: video-i2c: support changing frame interval and runtime PM". drivers/media/i2c/video-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c index 0c82131..77080d7 100644 --- a/drivers/media/i2c/video-i2c.c +++ b/drivers/media/i2c/video-i2c.c @@ -155,7 +155,7 @@ static int amg88xx_set_power_on(struct video_i2c_data *data) if (ret) return ret; - msleep(2); + usleep_range(2000, 3000); ret = regmap_write(data->regmap, AMG88XX_REG_RST, AMG88XX_RST_FLAG); if (ret)