From patchwork Mon Apr 15 14:13:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugen Hristev X-Patchwork-Id: 10900897 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4F5EB14DB for ; Mon, 15 Apr 2019 14:14:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 340AD2896F for ; Mon, 15 Apr 2019 14:14:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 287EC28876; Mon, 15 Apr 2019 14:14:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B62E22897B for ; Mon, 15 Apr 2019 14:14:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727579AbfDOOOK (ORCPT ); Mon, 15 Apr 2019 10:14:10 -0400 Received: from esa4.microchip.iphmx.com ([68.232.154.123]:38782 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727506AbfDOOOJ (ORCPT ); Mon, 15 Apr 2019 10:14:09 -0400 X-IronPort-AV: E=Sophos;i="5.60,353,1549954800"; d="scan'208";a="29944501" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 15 Apr 2019 07:14:03 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.76.108) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 15 Apr 2019 07:14:02 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector1-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SeWisu9ZOtbYQD09rL1XpJ8RNP1uLmqyLYVbBQSW+Sc=; b=iIapJ1AEMzMJFfBGPR+BeAdqwFjGE49Inz6md18PWQ2L2AjDZa965TT8j0nGtvKI/n8ZxC/DomP76rfAvKxVbmeELKaVXZdtADfC1YztEJ5mv/I+IQTVYLjDd/X6GepYaXpEKMSPQLEIcrsPa6/1tXP+PNyo/4nU3ccB0Pkhx3A= Received: from DM5PR11MB1242.namprd11.prod.outlook.com (10.168.108.8) by DM5PR11MB1548.namprd11.prod.outlook.com (10.172.38.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.19; Mon, 15 Apr 2019 14:13:56 +0000 Received: from DM5PR11MB1242.namprd11.prod.outlook.com ([fe80::e0e3:1d51:9e3e:6dc]) by DM5PR11MB1242.namprd11.prod.outlook.com ([fe80::e0e3:1d51:9e3e:6dc%3]) with mapi id 15.20.1792.018; Mon, 15 Apr 2019 14:13:56 +0000 From: To: , , , CC: , , , Subject: [PATCH v2 4/4] media: atmel: atmel-isc: make try_fmt error less verbose Thread-Topic: [PATCH v2 4/4] media: atmel: atmel-isc: make try_fmt error less verbose Thread-Index: AQHU85V2f59JdX2VPUWzEumzCPs+5w== Date: Mon, 15 Apr 2019 14:13:56 +0000 Message-ID: <1555337305-13767-5-git-send-email-eugen.hristev@microchip.com> References: <1555337305-13767-1-git-send-email-eugen.hristev@microchip.com> In-Reply-To: <1555337305-13767-1-git-send-email-eugen.hristev@microchip.com> Accept-Language: ro-RO, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VE1PR08CA0005.eurprd08.prod.outlook.com (2603:10a6:803:104::18) To DM5PR11MB1242.namprd11.prod.outlook.com (2603:10b6:3:14::8) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Eugen.Hristev@microchip.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-originating-ip: [94.177.32.154] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f708bb4f-8572-46d8-02c6-08d6c1ac98ba x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600140)(711020)(4605104)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:DM5PR11MB1548; x-ms-traffictypediagnostic: DM5PR11MB1548: x-microsoft-antispam-prvs: x-forefront-prvs: 000800954F x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(346002)(39860400002)(136003)(366004)(396003)(199004)(189003)(76176011)(99286004)(5660300002)(52116002)(7736002)(305945005)(486006)(54906003)(110136005)(316002)(478600001)(86362001)(11346002)(256004)(476003)(2616005)(186003)(14454004)(72206003)(71190400001)(446003)(106356001)(36756003)(105586002)(14444005)(71200400001)(26005)(6486002)(102836004)(386003)(2906002)(81156014)(4326008)(81166006)(6436002)(25786009)(68736007)(6512007)(53936002)(107886003)(6116002)(66066001)(2501003)(3846002)(2201001)(50226002)(8936002)(97736004)(6506007)(8676002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR11MB1548;H:DM5PR11MB1242.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: U7o4GK/YrNywqpG1qP+CH+neEoazy4oqPGda9AuK3Et7h7TLKtnbehf/g2oun5sD9XsFkSgil4mVi73mLG5wpfjVCsFI14PdN+wuqmprCCNU00pici/5+DCbJ66We2mGk85p4ev7x9CAzXQTzFTgHYPXVJXz1PNI+OEIxrAUFmQg8vQwDbaBTbFAxvg6twvMxDIXETgtBKU7hzfPwbbRBij2uSe2iSFg1KRcipStjcxFZVU68fdjLdlOlutpI51CF8yp9UexyipJN2RsagjtvEzPvEJeY8+qZ7bZQ55au43piwnjYMUVK0mcBfXSP3+bjhJP1skkXDA5SoRRtk62Fe3DOD1jsHqKyqEh+TvXuCj5tYuYCP/Xeq2y3YlBCXJcCGEjcilM4JGavpzrSC7PO4bnb3eabJ3wIQppdo0UAcY= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f708bb4f-8572-46d8-02c6-08d6c1ac98ba X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2019 14:13:56.4129 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1548 X-OriginatorOrg: microchip.com Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Eugen Hristev In case the sensor refuses to set the format, avoid printing the error message that no compatible format was found. This means that the try_fmt will be less verbose. The error will be printed only if really a format cannot be found. Some application try all possible formats in a row (gstreamer e.g.) which will flood the console with error messages until a working one is found. Signed-off-by: Eugen Hristev --- drivers/media/platform/atmel/atmel-isc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c index 777e27f..da3b441 100644 --- a/drivers/media/platform/atmel/atmel-isc.c +++ b/drivers/media/platform/atmel/atmel-isc.c @@ -1487,7 +1487,7 @@ static int isc_try_fmt(struct isc_device *isc, struct v4l2_format *f, ret = v4l2_subdev_call(isc->current_subdev->sd, pad, set_fmt, &pad_cfg, &format); if (ret < 0) - goto isc_try_fmt_err; + goto isc_try_fmt_subdev_err; v4l2_fill_pix_format(pixfmt, &format.format); @@ -1502,6 +1502,7 @@ static int isc_try_fmt(struct isc_device *isc, struct v4l2_format *f, isc_try_fmt_err: v4l2_err(&isc->v4l2_dev, "Could not find any possible format for a working pipeline\n"); +isc_try_fmt_subdev_err: memset(&isc->try_config, 0, sizeof(isc->try_config)); return ret;