From patchwork Sat Aug 17 06:14:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wenwen Wang X-Patchwork-Id: 11098555 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CFBFA17E2 for ; Sat, 17 Aug 2019 06:15:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BFF5528847 for ; Sat, 17 Aug 2019 06:15:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B42E128A8B; Sat, 17 Aug 2019 06:15:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 88C5828847 for ; Sat, 17 Aug 2019 06:15:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725965AbfHQGPF (ORCPT ); Sat, 17 Aug 2019 02:15:05 -0400 Received: from mail-yw1-f66.google.com ([209.85.161.66]:40525 "EHLO mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbfHQGPF (ORCPT ); Sat, 17 Aug 2019 02:15:05 -0400 Received: by mail-yw1-f66.google.com with SMTP id z64so2486655ywe.7; Fri, 16 Aug 2019 23:15:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nSWcGHQFcez4uU+PGD8SyJWHkgtSsyU9F5EbfdiRyOY=; b=GVbeND+VuCVsfCqmm1wM4PSvX7el6yjkvwS6KzIL56Xl4yqGHe+yY1n1xDAcJY5nDs EvJgTJrT3xrouThCnnY6lwbEOOtU6NnNXvO8b5Be1fBNio6+gwB0zeUgWmchalrB9TcK FUES05ADHO+2JIETLEGCso29eT2r+U/W3HSac+QjTvE6NzGhlspeXMjjFgWGVI2Yk2Fv xr8frR4XiAr/T8jNn56UOKukmFXRlQQw43iaNVcnr2QPS7av1xdOLI7Y7OCiAgdA99NM LuhKQluuD26lSal/LnNosCMk6NadrRBiYmCYh/f4ZvFAiLPm02OdBklVrCtSi9kMjkN9 9a6w== X-Gm-Message-State: APjAAAWfpjIP6wPdIyFARX2068dG0VNLaIHTHdBmh6m3GZwRBxsg2Vp7 Gth2uVBh9OsyE2jxSX0MsMg= X-Google-Smtp-Source: APXvYqyS/jAzmGnlQPDV9uzKPPB0ykdf9ZoWYve2vEeCZ+LPu5F46hL2uOA17Yg3PWXbARZodLlwHg== X-Received: by 2002:a81:6286:: with SMTP id w128mr8746846ywb.272.1566022504556; Fri, 16 Aug 2019 23:15:04 -0700 (PDT) Received: from localhost.localdomain (24-158-240-219.dhcp.smyr.ga.charter.com. [24.158.240.219]) by smtp.gmail.com with ESMTPSA id g3sm1334310ywk.15.2019.08.16.23.15.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 16 Aug 2019 23:15:03 -0700 (PDT) From: Wenwen Wang To: Wenwen Wang Cc: Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , Alexandre Courbot , Kees Cook , Thomas Gleixner , linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] media: usb: cx231xx-417: fix a memory leak bug Date: Sat, 17 Aug 2019 01:14:54 -0500 Message-Id: <1566022496-4425-1-git-send-email-wenwen@cs.uga.edu> X-Mailer: git-send-email 2.7.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In cx231xx_load_firmware(), 'p_buffer' is allocated through vmalloc() to hold the firmware. However, after the usage, it is not deallocated, leading to a memory leak bug. Signed-off-by: Wenwen Wang --- drivers/media/usb/cx231xx/cx231xx-417.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/cx231xx/cx231xx-417.c index 2475f69..5e2e1fd 100644 --- a/drivers/media/usb/cx231xx/cx231xx-417.c +++ b/drivers/media/usb/cx231xx/cx231xx-417.c @@ -1051,6 +1051,7 @@ static int cx231xx_load_firmware(struct cx231xx *dev) p_current_fw = p_fw; vfree(p_current_fw); p_current_fw = NULL; + vfree(p_buffer); uninitGPIO(dev); release_firmware(firmware); dprintk(1, "Firmware upload successful.\n");