From patchwork Thu Nov 14 10:41:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?Q2h1bmZlbmcgWXVuICjkupHmmKXls7Ap?= X-Patchwork-Id: 11243411 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F1D4317E6 for ; Thu, 14 Nov 2019 10:42:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2FB0206D9 for ; Thu, 14 Nov 2019 10:42:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Agvxk1MA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726179AbfKNKll (ORCPT ); Thu, 14 Nov 2019 05:41:41 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:14860 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725977AbfKNKlk (ORCPT ); Thu, 14 Nov 2019 05:41:40 -0500 X-UUID: cd2f0d8402b1427d9701618f20d65886-20191114 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=0tBiZpHnf425YMkNlYRFqHDCec3UUmeDOqF4HLvc6wQ=; b=Agvxk1MACNVFtcElkisR46STmWWUiFuUodj14dJ7BVL5wj9TWRPLXn2E6Ygpk5UakJ9s9KGB2iWmfZAkR15V2ZE1o6do7E9zsuh6LCGsyIBGZfARmhihVqw7ai/4q5ZUdJoIZGX0i8Y8WJvUGibGjdnkfXs5noV/LBEDLOKq+mU=; X-UUID: cd2f0d8402b1427d9701618f20d65886-20191114 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1220913259; Thu, 14 Nov 2019 18:41:34 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 14 Nov 2019 18:41:33 +0800 Received: from localhost.localdomain (10.17.3.153) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 14 Nov 2019 18:41:28 +0800 From: Chunfeng Yun To: Greg Kroah-Hartman , Felipe Balbi CC: Laurent Pinchart , Mauro Carvalho Chehab , Peter Chen , Minas Harutyunyan , Cristian Birsan , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Kevin Cernekee , Florian Fainelli , , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Bin Liu , Matthias Brugger , Stephen Boyd , Chunfeng Yun , Yoshihiro Shimoda , Colin Ian King , Biju Das , Fabrizio Castro , "Gustavo A. R. Silva" , Yangtao Li , , , , , Subject: [PATCH v3 01/13] media: uvcvideo: drop error check of debugfs_create_dir() Date: Thu, 14 Nov 2019 18:41:13 +0800 Message-ID: <1573728085-29016-1-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty MIME-Version: 1.0 X-MTK: N Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org No need check the return value of debugfs_create_dir() Signed-off-by: Chunfeng Yun --- v3: no changes v2: 1. abandon new API usb_debugfs_create_dir(), and drop error check --- drivers/media/usb/uvc/uvc_debugfs.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_debugfs.c b/drivers/media/usb/uvc/uvc_debugfs.c index d2b109959d82..2b8af4b54117 100644 --- a/drivers/media/usb/uvc/uvc_debugfs.c +++ b/drivers/media/usb/uvc/uvc_debugfs.c @@ -108,15 +108,7 @@ void uvc_debugfs_cleanup_stream(struct uvc_streaming *stream) void uvc_debugfs_init(void) { - struct dentry *dir; - - dir = debugfs_create_dir("uvcvideo", usb_debug_root); - if (IS_ERR_OR_NULL(dir)) { - uvc_printk(KERN_INFO, "Unable to create debugfs directory\n"); - return; - } - - uvc_debugfs_root_dir = dir; + uvc_debugfs_root_dir = debugfs_create_dir("uvcvideo", usb_debug_root); } void uvc_debugfs_cleanup(void)