| Message ID | 1576503511-27500-1-git-send-email-zhongjiang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static | expand |
On 12/16/19 8:38 AM, zhong jiang wrote: > Fix the following sparse warning. > > drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds' was not declared. Should it be static? > Acked-by: Andrew F. Davis <afd@ti.com> > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > drivers/dma-buf/dma-heap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c > index 4f04d10..da2090e 100644 > --- a/drivers/dma-buf/dma-heap.c > +++ b/drivers/dma-buf/dma-heap.c > @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data) > return 0; > } > > -unsigned int dma_heap_ioctl_cmds[] = { > +static unsigned int dma_heap_ioctl_cmds[] = { > DMA_HEAP_IOC_ALLOC, > }; > >
On Mon, Dec 16, 2019 at 5:43 AM zhong jiang <zhongjiang@huawei.com> wrote: > > Fix the following sparse warning. > > drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds' was not declared. Should it be static? > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > drivers/dma-buf/dma-heap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c > index 4f04d10..da2090e 100644 > --- a/drivers/dma-buf/dma-heap.c > +++ b/drivers/dma-buf/dma-heap.c > @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data) > return 0; > } > > -unsigned int dma_heap_ioctl_cmds[] = { > +static unsigned int dma_heap_ioctl_cmds[] = { > DMA_HEAP_IOC_ALLOC, > }; Acked-by: John Stultz <john.stultz@linaro.org> This patch will collide with Andrew's _IOCTL_ naming change, but its a fairly simple thing to resolve. Sumit: If you're comfortable resolving the collision, please queue with the rest of the recent changes for drm-misc-next. Otherwise, I'm happy to submit the resolution I tested with here afterwards. Let me know. thanks -john
On 2019/12/17 5:13, John Stultz wrote: > On Mon, Dec 16, 2019 at 5:43 AM zhong jiang <zhongjiang@huawei.com> wrote: >> Fix the following sparse warning. >> >> drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds' was not declared. Should it be static? >> >> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >> --- >> drivers/dma-buf/dma-heap.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c >> index 4f04d10..da2090e 100644 >> --- a/drivers/dma-buf/dma-heap.c >> +++ b/drivers/dma-buf/dma-heap.c >> @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data) >> return 0; >> } >> >> -unsigned int dma_heap_ioctl_cmds[] = { >> +static unsigned int dma_heap_ioctl_cmds[] = { >> DMA_HEAP_IOC_ALLOC, >> }; > Acked-by: John Stultz <john.stultz@linaro.org> > > This patch will collide with Andrew's _IOCTL_ naming change, but its a > fairly simple thing to resolve. > > Sumit: If you're comfortable resolving the collision, please queue > with the rest of the recent changes for drm-misc-next. > Otherwise, I'm happy to submit the resolution I tested with here > afterwards. Let me know. As it is an fairly simple patch, I hope you can resolve the issue directly. Thanks, zhong jiang > thanks > -john > > . >
Hello Zhong Jiang, On Tue, 17 Dec 2019 at 07:56, zhong jiang <zhongjiang@huawei.com> wrote: > > On 2019/12/17 5:13, John Stultz wrote: > > On Mon, Dec 16, 2019 at 5:43 AM zhong jiang <zhongjiang@huawei.com> wrote: > >> Fix the following sparse warning. Thanks for the patch; could I request you to please use scripts/get_maintainer.pl to get the cc: list for the patches? + dri-devel. > >> > >> drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds' was not declared. Should it be static? > >> > >> Signed-off-by: zhong jiang <zhongjiang@huawei.com> > >> --- > >> drivers/dma-buf/dma-heap.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c > >> index 4f04d10..da2090e 100644 > >> --- a/drivers/dma-buf/dma-heap.c > >> +++ b/drivers/dma-buf/dma-heap.c > >> @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data) > >> return 0; > >> } > >> > >> -unsigned int dma_heap_ioctl_cmds[] = { > >> +static unsigned int dma_heap_ioctl_cmds[] = { > >> DMA_HEAP_IOC_ALLOC, > >> }; > > Acked-by: John Stultz <john.stultz@linaro.org> > > > > This patch will collide with Andrew's _IOCTL_ naming change, but its a > > fairly simple thing to resolve. > > > > Sumit: If you're comfortable resolving the collision, please queue > > with the rest of the recent changes for drm-misc-next. > > Otherwise, I'm happy to submit the resolution I tested with here > > afterwards. Let me know. Of course, I am sure I can handle collisions, John, or else being a maintainer might get a tad difficult :) > As it is an fairly simple patch, I hope you can resolve the issue directly. > > Thanks, > zhong jiang > > thanks > > -john > > Best, Sumit.
diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c index 4f04d10..da2090e 100644 --- a/drivers/dma-buf/dma-heap.c +++ b/drivers/dma-buf/dma-heap.c @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data) return 0; } -unsigned int dma_heap_ioctl_cmds[] = { +static unsigned int dma_heap_ioctl_cmds[] = { DMA_HEAP_IOC_ALLOC, };
Fix the following sparse warning. drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds' was not declared. Should it be static? Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/dma-buf/dma-heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)