From patchwork Wed Jun 17 04:57:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suresh Udipi X-Patchwork-Id: 11609019 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D3D7713A0 for ; Wed, 17 Jun 2020 04:57:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCA78208E4 for ; Wed, 17 Jun 2020 04:57:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=adit-jv.com header.i=@adit-jv.com header.b="5kAE5zEe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726848AbgFQE5n (ORCPT ); Wed, 17 Jun 2020 00:57:43 -0400 Received: from ma-dnext03.denso.co.jp ([133.192.181.78]:60653 "EHLO ma-dnext03.denso.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725923AbgFQE5n (ORCPT ); Wed, 17 Jun 2020 00:57:43 -0400 Received: from grdma01h.denso.co.jp (unknown [133.192.24.24]) by ma-dnext03.denso.co.jp (Postfix) with ESMTP id DC4FD5D038B; Wed, 17 Jun 2020 13:57:40 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=adit-jv.com; s=jpadit-jvmail2011; t=1592369860; bh=+trNuZ/6D8LtwN5zjuN0TnCITVnaRRbPnaBDq3L5rDU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=5kAE5zEek0E1lY6Eqf2DFTvMxc8qwEiCJR/pixaChEZtkBkiSSew1a9bYWOdk2hWq 0lCV/CNADEkdWV1NftdEvymav0teeXIoOarjNf3Y9/Fo9unOClFRC1GmaK8UdHkN2X 53Bbfj2yf+Tq2t3fWxA0rySTXAkOXrVauKVlbjfHcHy9yTIGfLA1aR1Q8jVZB5De0H xhQSwsJZltFrG271MbXNZyE+Svcho+ppVKmeMdyGgkYh4BmzQYQcE6MRrEMKwuhLQY WNoNkamRx0KdscmCJg2D/QNyFDnu6zxh04+BvKMxTo2vlnAiqi1dXooFcfZOojCPDC oqhnGDWhMUoOw== Received: by grdma01h.denso.co.jp (Postfix, from userid 0) id D8F17C0BDAB; Wed, 17 Jun 2020 13:57:40 +0900 (JST) Received: from smtp0.denso.co.jp [133.192.24.87] by grdma01h. with ESMTP id PAA08272; Wed, 17 Jun 2020 13:57:40 +0900 Received: from ky0exch01.adit-jv.com ([10.71.113.8]) by smtp00.denso.co.jp (MOS 4.4.7-GA) with ESMTP id GBI96730; Wed, 17 Jun 2020 13:57:40 +0900 Received: from jp-u0004.adit-jv.com (10.71.112.120) by ky0exch01.adit-jv.com (10.71.113.8) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 17 Jun 2020 13:57:40 +0900 From: Suresh Udipi To: CC: , , , , , , , , , , Subject: [PATCH v7 2/2] media: rcar-csi2: Add warning for PHY speed less than minimum Date: Wed, 17 Jun 2020 13:57:23 +0900 Message-ID: <1592369843-32217-2-git-send-email-sudipi@jp.adit-jv.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1592369843-32217-1-git-send-email-sudipi@jp.adit-jv.com> References: <20200615141126.GE915368@oden.dyn.berto.se> <1592369843-32217-1-git-send-email-sudipi@jp.adit-jv.com> MIME-Version: 1.0 X-Originating-IP: [10.71.112.120] Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Add a warning message when the selected PHY speed is less than supported minimum PHY speed given in the hsfreq table[1]. For raspberry pi camera capture on Kingfisher board with resolution 640x480, the calculated PHY speed is 48 mbps which is less than the minimum PHY speed 80 Mbps from the table[1]. But in this cases capture is successful. [1] specs r19uh0105ej0200-r-car-3rd-generation.pdf [Table 25.9] Signed-off-by: Suresh Udipi Signed-off-by: Michael Rodin --- drivers/media/platform/rcar-vin/rcar-csi2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c index f18dedc..1184527 100644 --- a/drivers/media/platform/rcar-vin/rcar-csi2.c +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c @@ -433,6 +433,10 @@ static int rcsi2_set_phypll(struct rcar_csi2 *priv, unsigned int mbps) const struct rcsi2_mbps_reg *hsfreq; const struct rcsi2_mbps_reg *hsfreq_prev = NULL; + if (mbps < priv->info->hsfreqrange->mbps) + dev_warn(priv->dev, "%u Mbps less than min PHY speed %u Mbps", + mbps, priv->info->hsfreqrange->mbps); + for (hsfreq = priv->info->hsfreqrange; hsfreq->mbps != 0; hsfreq++) { if (hsfreq->mbps >= mbps) break;