| Message ID | 1592476472-26235-3-git-send-email-sudipi@jp.adit-jv.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v8,1/3] media: rcar-csi2: Correct the selection of hsfreqrange | expand |
Hi Suresh, Thanks for your work. On 2020-06-18 19:34:32 +0900, Suresh Udipi wrote: > PHTW register is selected based on default bit rate from Table[1]. > for the bit rates less than or equal to 250. Currently first > value of default bit rate which is greater than or equal to > the caculated mbps is selected.This selection can be further Missing space 'selected.This'. > improved by selecting the default bit rate which is nearest to > the calculated value. > > [1] specs r19uh0105ej0200-r-car-3rd-generation.pdf [Table 25.12] > > Fixes: 769afd212b16 ("media: rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver") Nit-pick: No need for a blank line between fixes and SoB. > > Signed-off-by: Suresh Udipi <sudipi@jp.adit-jv.com> > Signed-off-by: Michael Rodin <mrodin@de.adit-jv.com> > --- > drivers/media/platform/rcar-vin/rcar-csi2.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c > index 1184527..d7bf59f 100644 > --- a/drivers/media/platform/rcar-vin/rcar-csi2.c > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c > @@ -917,10 +917,18 @@ static int rcsi2_phtw_write_mbps(struct rcar_csi2 *priv, unsigned int mbps, > const struct rcsi2_mbps_reg *values, u16 code) > { > const struct rcsi2_mbps_reg *value; > + const struct rcsi2_mbps_reg *prev_value = NULL; > > - for (value = values; value->mbps; value++) > + for (value = values; value->mbps; value++) { > if (value->mbps >= mbps) > break; > + prev_value = value; > + } > + > + if (prev_value && > + ((mbps - prev_value->mbps) <= (value->mbps - mbps))) > + value = prev_value; > + One to many blank lines. With this and the commit message fixed, Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Nice work, thanks again for being persistent with this! > > if (!value->mbps) { > dev_err(priv->dev, "Unsupported PHY speed (%u Mbps)", mbps); > -- > 2.7.4 >
diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c index 1184527..d7bf59f 100644 --- a/drivers/media/platform/rcar-vin/rcar-csi2.c +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c @@ -917,10 +917,18 @@ static int rcsi2_phtw_write_mbps(struct rcar_csi2 *priv, unsigned int mbps, const struct rcsi2_mbps_reg *values, u16 code) { const struct rcsi2_mbps_reg *value; + const struct rcsi2_mbps_reg *prev_value = NULL; - for (value = values; value->mbps; value++) + for (value = values; value->mbps; value++) { if (value->mbps >= mbps) break; + prev_value = value; + } + + if (prev_value && + ((mbps - prev_value->mbps) <= (value->mbps - mbps))) + value = prev_value; + if (!value->mbps) { dev_err(priv->dev, "Unsupported PHY speed (%u Mbps)", mbps);
PHTW register is selected based on default bit rate from Table[1]. for the bit rates less than or equal to 250. Currently first value of default bit rate which is greater than or equal to the caculated mbps is selected.This selection can be further improved by selecting the default bit rate which is nearest to the calculated value. [1] specs r19uh0105ej0200-r-car-3rd-generation.pdf [Table 25.12] Fixes: 769afd212b16 ("media: rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver") Signed-off-by: Suresh Udipi <sudipi@jp.adit-jv.com> Signed-off-by: Michael Rodin <mrodin@de.adit-jv.com> --- drivers/media/platform/rcar-vin/rcar-csi2.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)