diff mbox series

MAINTAINERS: Fix email typo and correct name of Tianshu

Message ID 1595823137-20553-1-git-send-email-bingbu.cao@intel.com (mailing list archive)
State New, archived
Headers show
Series MAINTAINERS: Fix email typo and correct name of Tianshu | expand

Commit Message

Bingbu Cao July 27, 2020, 4:12 a.m. UTC 
Fix the typo in email address of Tianshu Qiu and correct the name.

Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
Signed-off-by: Tianshu Qiu <tian.shu.qiu@intel.com>
Reported-by: Bjorn Helgaas <helgaas@kernel.org>
---
 MAINTAINERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Qiu, Tian Shu July 27, 2020, 4:20 a.m. UTC | #1 
Reviewed-by: Tianshu Qiu <tian.shu.qiu@intel.com>


> -----Original Message-----
> From: Cao, Bingbu <bingbu.cao@intel.com>
> Sent: Monday, July 27, 2020 12:12 PM
> To: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; helgaas@kernel.org
> Cc: sakari.ailus@linux.intel.com; Qiu, Tian Shu <tian.shu.qiu@intel.com>; Cao, Bingbu <bingbu.cao@intel.com>;
> bingbu.cao@linux.intel.com
> Subject: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu
> 
> Fix the typo in email address of Tianshu Qiu and correct the name.
> 
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> Signed-off-by: Tianshu Qiu <tian.shu.qiu@intel.com>
> Reported-by: Bjorn Helgaas <helgaas@kernel.org>
> ---
>  MAINTAINERS | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5392f00cec46..638dfa99751b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8765,7 +8765,7 @@ INTEL IPU3 CSI-2 CIO2 DRIVER
>  M:	Yong Zhi <yong.zhi@intel.com>
>  M:	Sakari Ailus <sakari.ailus@linux.intel.com>
>  M:	Bingbu Cao <bingbu.cao@intel.com>
> -R:	Tian Shu Qiu <tian.shu.qiu@intel.com>
> +R:	Tianshu Qiu <tian.shu.qiu@intel.com>
>  L:	linux-media@vger.kernel.org
>  S:	Maintained
>  F:	Documentation/userspace-api/media/v4l/pixfmt-srggb10-ipu3.rst
> @@ -8774,7 +8774,7 @@ F:	drivers/media/pci/intel/ipu3/
>  INTEL IPU3 CSI-2 IMGU DRIVER
>  M:	Sakari Ailus <sakari.ailus@linux.intel.com>
>  R:	Bingbu Cao <bingbu.cao@intel.com>
> -R:	Tian Shu Qiu <tian.shu.qiu@intel.com>
> +R:	Tianshu Qiu <tian.shu.qiu@intel.com>
>  L:	linux-media@vger.kernel.org
>  S:	Maintained
>  F:	Documentation/admin-guide/media/ipu3.rst
> @@ -12609,7 +12609,7 @@ T:	git git://linuxtv.org/media_tree.git
>  F:	drivers/media/i2c/ov2685.c
> 
>  OMNIVISION OV2740 SENSOR DRIVER
> -M:	Tianshu Qiu <tian.shu.qiua@intel.com>
> +M:	Tianshu Qiu <tian.shu.qiu@intel.com>
>  R:	Shawn Tu <shawnx.tu@intel.com>
>  R:	Bingbu Cao <bingbu.cao@intel.com>
>  L:	linux-media@vger.kernel.org
> --
> 2.7.4
Bjorn Helgaas July 27, 2020, 5:31 p.m. UTC | #2 
On Mon, Jul 27, 2020 at 04:20:39AM +0000, Qiu, Tian Shu wrote:
> Reviewed-by: Tianshu Qiu <tian.shu.qiu@intel.com>

This doesn't really make sense.  The patch already contains your
Signed-off-by, which means you participated in its development (see
Documentation/process/submitting-patches.rst), and I don't think it
makes sense to review your own patch.

> > -----Original Message-----
> > From: Cao, Bingbu <bingbu.cao@intel.com>
> > Sent: Monday, July 27, 2020 12:12 PM
> > To: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; helgaas@kernel.org
> > Cc: sakari.ailus@linux.intel.com; Qiu, Tian Shu <tian.shu.qiu@intel.com>; Cao, Bingbu <bingbu.cao@intel.com>;
> > bingbu.cao@linux.intel.com
> > Subject: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu
> > 
> > Fix the typo in email address of Tianshu Qiu and correct the name.
> > 
> > Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> > Signed-off-by: Tianshu Qiu <tian.shu.qiu@intel.com>

Also, Documentation/process/submitting-patches.rst says "the last
Signed-off-by: must always be that of the developer submitting the
patch," which means these should be reversed, since Bingbu submitted
the patch.

> > Reported-by: Bjorn Helgaas <helgaas@kernel.org>

I don't care whether you include this or not, but if you do, it would
typically go first, since the report comes before the writing of the
patch.

> > ---
> >  MAINTAINERS | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5392f00cec46..638dfa99751b 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -8765,7 +8765,7 @@ INTEL IPU3 CSI-2 CIO2 DRIVER
> >  M:	Yong Zhi <yong.zhi@intel.com>
> >  M:	Sakari Ailus <sakari.ailus@linux.intel.com>
> >  M:	Bingbu Cao <bingbu.cao@intel.com>
> > -R:	Tian Shu Qiu <tian.shu.qiu@intel.com>
> > +R:	Tianshu Qiu <tian.shu.qiu@intel.com>
> >  L:	linux-media@vger.kernel.org
> >  S:	Maintained
> >  F:	Documentation/userspace-api/media/v4l/pixfmt-srggb10-ipu3.rst
> > @@ -8774,7 +8774,7 @@ F:	drivers/media/pci/intel/ipu3/
> >  INTEL IPU3 CSI-2 IMGU DRIVER
> >  M:	Sakari Ailus <sakari.ailus@linux.intel.com>
> >  R:	Bingbu Cao <bingbu.cao@intel.com>
> > -R:	Tian Shu Qiu <tian.shu.qiu@intel.com>
> > +R:	Tianshu Qiu <tian.shu.qiu@intel.com>
> >  L:	linux-media@vger.kernel.org
> >  S:	Maintained
> >  F:	Documentation/admin-guide/media/ipu3.rst
> > @@ -12609,7 +12609,7 @@ T:	git git://linuxtv.org/media_tree.git
> >  F:	drivers/media/i2c/ov2685.c
> > 
> >  OMNIVISION OV2740 SENSOR DRIVER
> > -M:	Tianshu Qiu <tian.shu.qiua@intel.com>
> > +M:	Tianshu Qiu <tian.shu.qiu@intel.com>
> >  R:	Shawn Tu <shawnx.tu@intel.com>
> >  R:	Bingbu Cao <bingbu.cao@intel.com>
> >  L:	linux-media@vger.kernel.org
> > --
> > 2.7.4
>
Qiu, Tian Shu July 28, 2020, 1:09 p.m. UTC | #3 
> -----Original Message-----
> From: Bjorn Helgaas <helgaas@kernel.org>
> Sent: Tuesday, July 28, 2020 1:31 AM
> To: Qiu, Tian Shu <tian.shu.qiu@intel.com>
> Cc: Cao, Bingbu <bingbu.cao@intel.com>; linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; sakari.ailus@linux.intel.com;
> bingbu.cao@linux.intel.com
> Subject: Re: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu
> 
> On Mon, Jul 27, 2020 at 04:20:39AM +0000, Qiu, Tian Shu wrote:
> > Reviewed-by: Tianshu Qiu <tian.shu.qiu@intel.com>
> 
> This doesn't really make sense.  The patch already contains your
> Signed-off-by, which means you participated in its development (see
> Documentation/process/submitting-patches.rst), and I don't think it
> makes sense to review your own patch.

Thanks for pointing this out. Sorry I did not pay attention to this.

> 
> > > -----Original Message-----
> > > From: Cao, Bingbu <bingbu.cao@intel.com>
> > > Sent: Monday, July 27, 2020 12:12 PM
> > > To: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; helgaas@kernel.org
> > > Cc: sakari.ailus@linux.intel.com; Qiu, Tian Shu <tian.shu.qiu@intel.com>; Cao, Bingbu <bingbu.cao@intel.com>;
> > > bingbu.cao@linux.intel.com
> > > Subject: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu
> > >
> > > Fix the typo in email address of Tianshu Qiu and correct the name.
> > >
> > > Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> > > Signed-off-by: Tianshu Qiu <tian.shu.qiu@intel.com>
> 
> Also, Documentation/process/submitting-patches.rst says "the last
> Signed-off-by: must always be that of the developer submitting the
> patch," which means these should be reversed, since Bingbu submitted
> the patch.
> 
> > > Reported-by: Bjorn Helgaas <helgaas@kernel.org>
> 
> I don't care whether you include this or not, but if you do, it would
> typically go first, since the report comes before the writing of the
> patch.
> 
> > > ---
> > >  MAINTAINERS | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 5392f00cec46..638dfa99751b 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -8765,7 +8765,7 @@ INTEL IPU3 CSI-2 CIO2 DRIVER
> > >  M:	Yong Zhi <yong.zhi@intel.com>
> > >  M:	Sakari Ailus <sakari.ailus@linux.intel.com>
> > >  M:	Bingbu Cao <bingbu.cao@intel.com>
> > > -R:	Tian Shu Qiu <tian.shu.qiu@intel.com>
> > > +R:	Tianshu Qiu <tian.shu.qiu@intel.com>
> > >  L:	linux-media@vger.kernel.org
> > >  S:	Maintained
> > >  F:	Documentation/userspace-api/media/v4l/pixfmt-srggb10-ipu3.rst
> > > @@ -8774,7 +8774,7 @@ F:	drivers/media/pci/intel/ipu3/
> > >  INTEL IPU3 CSI-2 IMGU DRIVER
> > >  M:	Sakari Ailus <sakari.ailus@linux.intel.com>
> > >  R:	Bingbu Cao <bingbu.cao@intel.com>
> > > -R:	Tian Shu Qiu <tian.shu.qiu@intel.com>
> > > +R:	Tianshu Qiu <tian.shu.qiu@intel.com>
> > >  L:	linux-media@vger.kernel.org
> > >  S:	Maintained
> > >  F:	Documentation/admin-guide/media/ipu3.rst
> > > @@ -12609,7 +12609,7 @@ T:	git git://linuxtv.org/media_tree.git
> > >  F:	drivers/media/i2c/ov2685.c
> > >
> > >  OMNIVISION OV2740 SENSOR DRIVER
> > > -M:	Tianshu Qiu <tian.shu.qiua@intel.com>
> > > +M:	Tianshu Qiu <tian.shu.qiu@intel.com>
> > >  R:	Shawn Tu <shawnx.tu@intel.com>
> > >  R:	Bingbu Cao <bingbu.cao@intel.com>
> > >  L:	linux-media@vger.kernel.org
> > > --
> > > 2.7.4
> >
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 5392f00cec46..638dfa99751b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8765,7 +8765,7 @@  INTEL IPU3 CSI-2 CIO2 DRIVER
 M:	Yong Zhi <yong.zhi@intel.com>
 M:	Sakari Ailus <sakari.ailus@linux.intel.com>
 M:	Bingbu Cao <bingbu.cao@intel.com>
-R:	Tian Shu Qiu <tian.shu.qiu@intel.com>
+R:	Tianshu Qiu <tian.shu.qiu@intel.com>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 F:	Documentation/userspace-api/media/v4l/pixfmt-srggb10-ipu3.rst
@@ -8774,7 +8774,7 @@  F:	drivers/media/pci/intel/ipu3/
 INTEL IPU3 CSI-2 IMGU DRIVER
 M:	Sakari Ailus <sakari.ailus@linux.intel.com>
 R:	Bingbu Cao <bingbu.cao@intel.com>
-R:	Tian Shu Qiu <tian.shu.qiu@intel.com>
+R:	Tianshu Qiu <tian.shu.qiu@intel.com>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 F:	Documentation/admin-guide/media/ipu3.rst
@@ -12609,7 +12609,7 @@  T:	git git://linuxtv.org/media_tree.git
 F:	drivers/media/i2c/ov2685.c
 
 OMNIVISION OV2740 SENSOR DRIVER
-M:	Tianshu Qiu <tian.shu.qiua@intel.com>
+M:	Tianshu Qiu <tian.shu.qiu@intel.com>
 R:	Shawn Tu <shawnx.tu@intel.com>
 R:	Bingbu Cao <bingbu.cao@intel.com>
 L:	linux-media@vger.kernel.org