diff mbox

CXUSB D680 DMB using unified lgs8gxx driver

Message ID 15ed362e0903170856g17e5fa47i9fb3ac927c2d25a5@mail.gmail.com (mailing list archive)
State RFC
Headers show

Commit Message

David Wong March 17, 2009, 3:56 p.m. UTC
This patch replace the use of lgs8gl5 driver by unified lgs8gxx driver, for
CXUSB D680 DMB (MagicPro ProHDTV)

David T.L. Wong

Comments

Mauro Carvalho Chehab March 27, 2009, 10:04 a.m. UTC | #1
On Tue, 17 Mar 2009 23:56:57 +0800
David Wong <davidtlwong@gmail.com> wrote:

> This patch replace the use of lgs8gl5 driver by unified lgs8gxx driver, for
> CXUSB D680 DMB (MagicPro ProHDTV)
> 
> David T.L. Wong

Patch is ok. However, as it depends on the previous one, I'll mark it as RFC. When you submit back the previous patch (plus the API patch), re-submit the other patches on this series.

Also, since those patches are dependent, please number they at the subject, as:

[PATCH 01/05] 
...
[PATCH 05/05] 

This allows us to be sure about the proper patch order to apply.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff -r 626c136ec221 linux/drivers/media/dvb/dvb-usb/cxusb.c
--- a/linux/drivers/media/dvb/dvb-usb/cxusb.c	Fri Mar 13 14:35:14 2009 -0700
+++ b/linux/drivers/media/dvb/dvb-usb/cxusb.c	Tue Mar 17 23:17:16 2009 +0800
@@ -38,7 +38,7 @@ 
 #include "mxl5005s.h"
 #include "dib7000p.h"
 #include "dib0070.h"
-#include "lgs8gl5.h"
+#include "lgs8gxx.h"
 
 /* debug */
 static int dvb_usb_cxusb_debug;
@@ -1097,8 +1097,18 @@ 
 	return -EIO;
 }
 
-static struct lgs8gl5_config lgs8gl5_cfg = {
+static struct lgs8gxx_config d680_lgs8gl5_cfg = {
+	.prod = LGS8GXX_PROD_LGS8GL5,
 	.demod_address = 0x19,
+	.serial_ts = 0,
+	.ts_clk_pol = 0,
+	.ts_clk_gated = 1,
+	.if_clk_freq = 30400, /* 30.4 MHz */
+	.if_freq = 5725, /* 5.725 MHz */
+	.if_neg_center = 0,
+	.ext_adc = 0,
+	.adc_signed = 0,
+	.if_neg_edge = 0,
 };
 
 static int cxusb_d680_dmb_frontend_attach(struct dvb_usb_adapter *adap)
@@ -1138,7 +1148,7 @@ 
 	msleep(100);
 
 	/* Attach frontend */
-	adap->fe = dvb_attach(lgs8gl5_attach, &lgs8gl5_cfg, &d->i2c_adap);
+	adap->fe = dvb_attach(lgs8gxx_attach, &d680_lgs8gl5_cfg, &d->i2c_adap);
 	if (adap->fe == NULL)
 		return -EIO;