| Message ID | 15ed362e0906101016g13b81df6h1282e3bd410928b2@mail.gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Douglas Landgraf |
| Headers | show |
Hi David, Em Thu, 11 Jun 2009 01:16:13 +0800 David Wong <davidtlwong@gmail.com> escreveu: > Use unified lgs8gxx frontend instead of reverse engineered lgs8gl5 frontend. > After this patch, lgs8gl5 frontend could be mark as deprecated. > Future development should base on unified lgs8gxx frontend. > > Signed-off-by: David T.L. Wong <davidtlwong <at> gmail.com> Your patch makes sense. Have you tested it with the Magic-Pro DMB-TH usb stick? Michael and Timothy, Can you check if the new frontend module works with the currently supported devices? Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/17/2009 03:05 AM, Mauro Carvalho Chehab wrote: > Hi David, > > Em Thu, 11 Jun 2009 01:16:13 +0800 > David Wong<davidtlwong@gmail.com> escreveu: > >> Use unified lgs8gxx frontend instead of reverse engineered lgs8gl5 frontend. >> After this patch, lgs8gl5 frontend could be mark as deprecated. >> Future development should base on unified lgs8gxx frontend. >> >> Signed-off-by: David T.L. Wong<davidtlwong<at> gmail.com> >> > Your patch makes sense. Have you tested it with the Magic-Pro DMB-TH usb stick? > > Michael and Timothy, > > Can you check if the new frontend module works with the currently supported > devices? > Dear all, It's Timothy here -- I'm the original author of the lgs8gl5 module. Sorry for the late reply, but since my office's relocation, I've been having a hard time getting good TV reception, and had not been able to exercise the patch. However, I've been in close contact with David, and did try an earlier version of his patch prior to moving, so I'm optimistic that it should work. Regards, Timothy Lee -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
changeset: 11831:2fe3ef06a8e2 tag: tip user: marvel@DHM200 date: Mon May 18 17:03:36 2009 +0800 summary: cxusb: d680 switch from lgs8gl5 to unified lgs8gxx frontend driver diff -r 32e66a2bd568 -r 2fe3ef06a8e2 linux/drivers/media/dvb/dvb-usb/cxusb.c --- a/linux/drivers/media/dvb/dvb-usb/cxusb.c Mon May 18 16:01:15 2009 +0800 +++ b/linux/drivers/media/dvb/dvb-usb/cxusb.c Mon May 18 17:03:36 2009 +0800 @@ -38,7 +38,7 @@ #include "mxl5005s.h" #include "dib7000p.h" #include "dib0070.h" -#include "lgs8gl5.h" +#include "lgs8gxx.h" /* debug */ static int dvb_usb_cxusb_debug; @@ -1097,8 +1097,18 @@ return -EIO; } -static struct lgs8gl5_config lgs8gl5_cfg = { +static struct lgs8gxx_config d680_lgs8gl5_cfg = { + .prod = LGS8GXX_PROD_LGS8GL5, .demod_address = 0x19, + .serial_ts = 0, + .ts_clk_pol = 0, + .ts_clk_gated = 1, + .if_clk_freq = 30400, /* 30.4 MHz */ + .if_freq = 5725, /* 5.725 MHz */ + .if_neg_center = 0, + .ext_adc = 0, + .adc_signed = 0, + .if_neg_edge = 0, }; static int cxusb_d680_dmb_frontend_attach(struct dvb_usb_adapter *adap) @@ -1138,7 +1148,7 @@ msleep(100); /* Attach frontend */ - adap->fe = dvb_attach(lgs8gl5_attach, &lgs8gl5_cfg, &d->i2c_adap); + adap->fe = dvb_attach(lgs8gxx_attach, &d680_lgs8gl5_cfg, &d->i2c_adap); if (adap->fe == NULL) return -EIO;
Use unified lgs8gxx frontend instead of reverse engineered lgs8gl5 frontend. After this patch, lgs8gl5 frontend could be mark as deprecated. Future development should base on unified lgs8gxx frontend. Signed-off-by: David T.L. Wong <davidtlwong <at> gmail.com>