| Message ID | 1614302920-19505-1-git-send-email-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] media: exynos4-is: add missing call to of_node_put() | expand |
On Fri, 26 Feb 2021 at 02:28, Yang Li <yang.lee@linux.alibaba.com> wrote: > > In one of the error paths of the for_each_child_of_node() loop in > fimc_md_parse_one_endpoint, add missing call to of_node_put(). > > Fix the following coccicheck warning: > ./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING: > Function "for_each_child_of_node" should have of_node_put() before > return around line 492. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> You ignored the comment for this. Anyone can run Coccinelle and it does not equal "Reported-by" credit. Reported by is for reported bugs, but I asked three times to you guys to share the reports. This is not an open way of working. This should be removed. Best regards, Krzysztof
diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c index 8e1e892..a6ee2a3 100644 --- a/drivers/media/platform/exynos4-is/media-dev.c +++ b/drivers/media/platform/exynos4-is/media-dev.c @@ -488,8 +488,10 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd, for_each_child_of_node(port, ep) { ret = fimc_md_parse_one_endpoint(fmd, ep); - if (ret < 0) + if (ret < 0) { + of_node_put(ep); return ret; + } } return 0;
In one of the error paths of the for_each_child_of_node() loop in fimc_md_parse_one_endpoint, add missing call to of_node_put(). Fix the following coccicheck warning: ./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 492. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- Changes in v2: -add braces for if drivers/media/platform/exynos4-is/media-dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)