| Message ID | 1618298581-33566-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: solo6x10: remove useless function | expand |
NACK; before removing any of these functions the fields should be documented somewhere else, so that no information is lost. On 13/Apr/2021 15:23, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c:394:19: warning: unused > function 'vop_interlaced' [-Wunused-function]. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c > index 0abcad4..8c4fae7 100644 > --- a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c > +++ b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c > @@ -391,11 +391,6 @@ static int solo_send_desc(struct solo_enc_dev *solo_enc, int skip, > } > > /* Extract values from VOP header - VE_STATUSxx */ > -static inline int vop_interlaced(const vop_header *vh) > -{ > - return (__le32_to_cpu((*vh)[0]) >> 30) & 1; > -} > - > static inline u8 vop_channel(const vop_header *vh) > { > return (__le32_to_cpu((*vh)[0]) >> 24) & 0x1F; > -- > 1.8.3.1 >
diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c index 0abcad4..8c4fae7 100644 --- a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c +++ b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c @@ -391,11 +391,6 @@ static int solo_send_desc(struct solo_enc_dev *solo_enc, int skip, } /* Extract values from VOP header - VE_STATUSxx */ -static inline int vop_interlaced(const vop_header *vh) -{ - return (__le32_to_cpu((*vh)[0]) >> 30) & 1; -} - static inline u8 vop_channel(const vop_header *vh) { return (__le32_to_cpu((*vh)[0]) >> 24) & 0x1F;
Fix the following clang warning: drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c:394:19: warning: unused function 'vop_interlaced' [-Wunused-function]. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 5 ----- 1 file changed, 5 deletions(-)